active_model_serializers 0.10.0.rc4 → 0.10.0.rc5

data/test/adapter/json_api/collection_test.rb

@@ -1,95 +1,93 @@
 require 'test_helper'
 
-module ActiveModel
-  class Serializer
-    module Adapter
-      class JsonApi
-        class CollectionTest < ActiveSupport::TestCase
-          def setup
-            @author = Author.new(id: 1, name: 'Steve K.')
-            @author.bio = nil
-            @blog = Blog.new(id: 23, name: 'AMS Blog')
-            @first_post = Post.new(id: 1, title: 'Hello!!', body: 'Hello, world!!')
-            @second_post = Post.new(id: 2, title: 'New Post', body: 'Body')
-            @first_post.comments = []
-            @second_post.comments = []
-            @first_post.blog = @blog
-            @second_post.blog = nil
-            @first_post.author = @author
-            @second_post.author = @author
-            @author.posts = [@first_post, @second_post]
+module ActiveModelSerializers
+  module Adapter
+    class JsonApi
+      class CollectionTest < ActiveSupport::TestCase
+        def setup
+          @author = Author.new(id: 1, name: 'Steve K.')
+          @author.bio = nil
+          @blog = Blog.new(id: 23, name: 'AMS Blog')
+          @first_post = Post.new(id: 1, title: 'Hello!!', body: 'Hello, world!!')
+          @second_post = Post.new(id: 2, title: 'New Post', body: 'Body')
+          @first_post.comments = []
+          @second_post.comments = []
+          @first_post.blog = @blog
+          @second_post.blog = nil
+          @first_post.author = @author
+          @second_post.author = @author
+          @author.posts = [@first_post, @second_post]
 
-            @serializer = CollectionSerializer.new([@first_post, @second_post])
-            @adapter = ActiveModel::Serializer::Adapter::JsonApi.new(@serializer)
-            ActionController::Base.cache_store.clear
-          end
+          @serializer = ActiveModel::Serializer::CollectionSerializer.new([@first_post, @second_post])
+          @adapter = ActiveModelSerializers::Adapter::JsonApi.new(@serializer)
+          ActionController::Base.cache_store.clear
+        end
 
-          def test_include_multiple_posts
-            expected = [
-              {
-                id: '1',
-                type: 'posts',
-                attributes: {
-                  title: 'Hello!!',
-                  body: 'Hello, world!!'
-                },
-                relationships: {
-                  comments: { data: [] },
-                  blog: { data: { type: 'blogs', id: '999' } },
-                  author: { data: { type: 'authors', id: '1' } }
-                }
+        def test_include_multiple_posts
+          expected = [
+            {
+              id: '1',
+              type: 'posts',
+              attributes: {
+                title: 'Hello!!',
+                body: 'Hello, world!!'
+              },
+              relationships: {
+                comments: { data: [] },
+                blog: { data: { type: 'blogs', id: '999' } },
+                author: { data: { type: 'authors', id: '1' } }
+              }
+            },
+            {
+              id: '2',
+              type: 'posts',
+              attributes: {
+                title: 'New Post',
+                body: 'Body'
               },
-              {
-                id: '2',
-                type: 'posts',
-                attributes: {
-                  title: 'New Post',
-                  body: 'Body'
-                },
-                relationships: {
-                  comments: { data: [] },
-                  blog: { data: { type: 'blogs', id: '999' } },
-                  author: { data: { type: 'authors', id: '1' } }
-                }
+              relationships: {
+                comments: { data: [] },
+                blog: { data: { type: 'blogs', id: '999' } },
+                author: { data: { type: 'authors', id: '1' } }
               }
-            ]
+            }
+          ]
 
-            assert_equal(expected, @adapter.serializable_hash[:data])
-          end
+          assert_equal(expected, @adapter.serializable_hash[:data])
+        end
 
-          def test_limiting_fields
-            actual = ActiveModel::SerializableResource.new(
-              [@first_post, @second_post], adapter: :json_api,
-                                           fields: { posts: %w(title comments blog author) })
-                     .serializable_hash
-            expected = [
-              {
-                id: '1',
-                type: 'posts',
-                attributes: {
-                  title: 'Hello!!'
-                },
-                relationships: {
-                  comments: { data: [] },
-                  blog: { data: { type: 'blogs', id: '999' } },
-                  author: { data: { type: 'authors', id: '1' } }
-                }
+        def test_limiting_fields
+          actual = ActiveModelSerializers::SerializableResource.new(
+            [@first_post, @second_post], adapter: :json_api,
+                                         fields: { posts: %w(title comments blog author) })
+                                                               .serializable_hash
+          expected = [
+            {
+              id: '1',
+              type: 'posts',
+              attributes: {
+                title: 'Hello!!'
+              },
+              relationships: {
+                comments: { data: [] },
+                blog: { data: { type: 'blogs', id: '999' } },
+                author: { data: { type: 'authors', id: '1' } }
+              }
+            },
+            {
+              id: '2',
+              type: 'posts',
+              attributes: {
+                title: 'New Post'
               },
-              {
-                id: '2',
-                type: 'posts',
-                attributes: {
-                  title: 'New Post'
-                },
-                relationships: {
-                  comments: { data: [] },
-                  blog: { data: { type: 'blogs', id: '999' } },
-                  author: { data: { type: 'authors', id: '1' } }
-                }
+              relationships: {
+                comments: { data: [] },
+                blog: { data: { type: 'blogs', id: '999' } },
+                author: { data: { type: 'authors', id: '1' } }
               }
-            ]
-            assert_equal(expected, actual[:data])
-          end
+            }
+          ]
+          assert_equal(expected, actual[:data])
         end
       end
     end

data/test/adapter/json_api/errors_test.rb

@@ -0,0 +1,78 @@
+require 'test_helper'
+
+module ActiveModelSerializers
+  module Adapter
+    class JsonApi < Base
+      class ErrorsTest < Minitest::Test
+        include ActiveModel::Serializer::Lint::Tests
+
+        def setup
+          @resource = ModelWithErrors.new
+        end
+
+        def test_active_model_with_error
+          options = {
+              serializer: ActiveModel::Serializer::ErrorSerializer,
+              adapter: :json_api
+          }
+
+          @resource.errors.add(:name, 'cannot be nil')
+
+          serializable_resource = ActiveModelSerializers::SerializableResource.new(@resource, options)
+          assert_equal serializable_resource.serializer_instance.attributes, {}
+          assert_equal serializable_resource.serializer_instance.object, @resource
+
+          expected_errors_object =
+            { :errors =>
+              [
+                {
+                  source: { pointer: '/data/attributes/name' },
+                  detail: 'cannot be nil'
+                }
+              ]
+          }
+          assert_equal serializable_resource.as_json, expected_errors_object
+        end
+
+        def test_active_model_with_multiple_errors
+          options = {
+              serializer: ActiveModel::Serializer::ErrorSerializer,
+              adapter: :json_api
+          }
+
+          @resource.errors.add(:name, 'cannot be nil')
+          @resource.errors.add(:name, 'must be longer')
+          @resource.errors.add(:id, 'must be a uuid')
+
+          serializable_resource = ActiveModelSerializers::SerializableResource.new(@resource, options)
+          assert_equal serializable_resource.serializer_instance.attributes, {}
+          assert_equal serializable_resource.serializer_instance.object, @resource
+
+          expected_errors_object =
+            { :errors =>
+              [
+                { :source => { :pointer => '/data/attributes/name' }, :detail => 'cannot be nil' },
+                { :source => { :pointer => '/data/attributes/name' }, :detail => 'must be longer' },
+                { :source => { :pointer => '/data/attributes/id' }, :detail => 'must be a uuid' }
+              ]
+          }
+          assert_equal serializable_resource.as_json, expected_errors_object
+        end
+
+        # see http://jsonapi.org/examples/
+        def test_parameter_source_type_error
+          parameter = 'auther'
+          error_source = ActiveModelSerializers::Adapter::JsonApi::Error.error_source(:parameter, parameter)
+          assert_equal({ parameter: parameter }, error_source)
+        end
+
+        def test_unknown_source_type_error
+          value = 'auther'
+          assert_raises(ActiveModelSerializers::Adapter::JsonApi::Error::UnknownSourceTypeError) do
+            ActiveModelSerializers::Adapter::JsonApi::Error.error_source(:hyper, value)
+          end
+        end
+      end
+    end
+  end
+end

data/test/adapter/json_api/fields_test.rb

@@ -1,87 +1,85 @@
 require 'test_helper'
 
-module ActiveModel
-  class Serializer
-    module Adapter
-      class JsonApi
-        class FieldsTest < ActiveSupport::TestCase
-          Post = Class.new(::Model)
-          class PostSerializer < ActiveModel::Serializer
-            type 'posts'
-            attributes :title, :body
-            belongs_to :author
-            has_many :comments
-          end
+module ActiveModelSerializers
+  module Adapter
+    class JsonApi
+      class FieldsTest < ActiveSupport::TestCase
+        Post = Class.new(::Model)
+        class PostSerializer < ActiveModel::Serializer
+          type 'posts'
+          attributes :title, :body
+          belongs_to :author
+          has_many :comments
+        end
 
-          Author = Class.new(::Model)
-          class AuthorSerializer < ActiveModel::Serializer
-            type 'authors'
-            attributes :name, :birthday
-          end
+        Author = Class.new(::Model)
+        class AuthorSerializer < ActiveModel::Serializer
+          type 'authors'
+          attributes :name, :birthday
+        end
 
-          Comment = Class.new(::Model)
-          class CommentSerializer < ActiveModel::Serializer
-            type 'comments'
-            attributes :body
-            belongs_to :author
-          end
+        Comment = Class.new(::Model)
+        class CommentSerializer < ActiveModel::Serializer
+          type 'comments'
+          attributes :body
+          belongs_to :author
+        end
 
-          def setup
-            @author = Author.new(id: 1, name: 'Lucas', birthday: '10.01.1990')
-            @comment1 = Comment.new(id: 7, body: 'cool', author: @author)
-            @comment2 = Comment.new(id: 12, body: 'awesome', author: @author)
-            @post = Post.new(id: 1337, title: 'Title 1', body: 'Body 1',
-                             author: @author, comments: [@comment1, @comment2])
-            @comment1.post = @post
-            @comment2.post = @post
-          end
+        def setup
+          @author = Author.new(id: 1, name: 'Lucas', birthday: '10.01.1990')
+          @comment1 = Comment.new(id: 7, body: 'cool', author: @author)
+          @comment2 = Comment.new(id: 12, body: 'awesome', author: @author)
+          @post = Post.new(id: 1337, title: 'Title 1', body: 'Body 1',
+                           author: @author, comments: [@comment1, @comment2])
+          @comment1.post = @post
+          @comment2.post = @post
+        end
 
-          def test_fields_attributes
-            fields = { posts: [:title] }
-            hash = serializable(@post, adapter: :json_api, fields: fields).serializable_hash
-            expected = {
-              title: 'Title 1'
-            }
+        def test_fields_attributes
+          fields = { posts: [:title] }
+          hash = serializable(@post, adapter: :json_api, fields: fields).serializable_hash
+          expected = {
+            title: 'Title 1'
+          }
 
-            assert_equal(expected, hash[:data][:attributes])
-          end
+          assert_equal(expected, hash[:data][:attributes])
+        end
 
-          def test_fields_relationships
-            fields = { posts: [:author] }
-            hash = serializable(@post, adapter: :json_api, fields: fields).serializable_hash
-            expected = {
-              author: {
-                data: {
-                  type: 'authors',
-                  id: '1'
-                }
+        def test_fields_relationships
+          fields = { posts: [:author] }
+          hash = serializable(@post, adapter: :json_api, fields: fields).serializable_hash
+          expected = {
+            author: {
+              data: {
+                type: 'authors',
+                id: '1'
               }
             }
+          }
 
-            assert_equal(expected, hash[:data][:relationships])
-          end
+          assert_equal(expected, hash[:data][:relationships])
+        end
 
-          def test_fields_included
-            fields = { posts: [:author], comments: [:body] }
-            hash = serializable(@post, adapter: :json_api, fields: fields, include: 'comments').serializable_hash
-            expected = [
-              {
-                type: 'comments',
-                id: '7',
-                attributes: {
-                  body: 'cool'
-                }
-              }, {
-                type: 'comments',
-                id: '12',
-                attributes: {
-                  body: 'awesome'
-                }
+        def test_fields_included
+          fields = { posts: [:author], comments: [:body] }
+          hash = serializable(@post, adapter: :json_api, fields: fields, include: 'comments').serializable_hash
+          expected = [
+            {
+              type: 'comments',
+              id: '7',
+              attributes: {
+                body: 'cool'
               }
-            ]
+            }, {
+              type: 'comments',
+              id: '12',
+              attributes: {
+                body: 'awesome'
+              }
+            }
+          ]
 
-            assert_equal(expected, hash[:included])
-          end
+          assert_equal(expected, hash[:included])
         end
       end
     end

data/test/adapter/json_api/has_many_embed_ids_test.rb

@@ -1,43 +1,41 @@
 require 'test_helper'
 
-module ActiveModel
-  class Serializer
-    module Adapter
-      class JsonApi
-        class HasManyEmbedIdsTest < ActiveSupport::TestCase
-          def setup
-            @author = Author.new(name: 'Steve K.')
-            @author.bio = nil
-            @author.roles = nil
-            @first_post = Post.new(id: 1, title: 'Hello!!', body: 'Hello, world!!')
-            @second_post = Post.new(id: 2, title: 'New Post', body: 'Body')
-            @author.posts = [@first_post, @second_post]
-            @first_post.author = @author
-            @second_post.author = @author
-            @first_post.comments = []
-            @second_post.comments = []
-            @blog = Blog.new(id: 23, name: 'AMS Blog')
-            @first_post.blog = @blog
-            @second_post.blog = nil
+module ActiveModelSerializers
+  module Adapter
+    class JsonApi
+      class HasManyEmbedIdsTest < ActiveSupport::TestCase
+        def setup
+          @author = Author.new(name: 'Steve K.')
+          @author.bio = nil
+          @author.roles = nil
+          @first_post = Post.new(id: 1, title: 'Hello!!', body: 'Hello, world!!')
+          @second_post = Post.new(id: 2, title: 'New Post', body: 'Body')
+          @author.posts = [@first_post, @second_post]
+          @first_post.author = @author
+          @second_post.author = @author
+          @first_post.comments = []
+          @second_post.comments = []
+          @blog = Blog.new(id: 23, name: 'AMS Blog')
+          @first_post.blog = @blog
+          @second_post.blog = nil
 
-            @serializer = AuthorSerializer.new(@author)
-            @adapter = ActiveModel::Serializer::Adapter::JsonApi.new(@serializer)
-          end
+          @serializer = AuthorSerializer.new(@author)
+          @adapter = ActiveModelSerializers::Adapter::JsonApi.new(@serializer)
+        end
 
-          def test_includes_comment_ids
-            expected = {
-              data: [
-                { type: 'posts', id: '1' },
-                { type: 'posts', id: '2' }
-              ]
-            }
+        def test_includes_comment_ids
+          expected = {
+            data: [
+              { type: 'posts', id: '1' },
+              { type: 'posts', id: '2' }
+            ]
+          }
 
-            assert_equal(expected, @adapter.serializable_hash[:data][:relationships][:posts])
-          end
+          assert_equal(expected, @adapter.serializable_hash[:data][:relationships][:posts])
+        end
 
-          def test_no_includes_linked_comments
-            assert_nil @adapter.serializable_hash[:linked]
-          end
+        def test_no_includes_linked_comments
+          assert_nil @adapter.serializable_hash[:linked]
         end
       end
     end