active_model_listener 0.2.2 → 0.2.3

data/CHANGELOG

@@ -1,3 +1,4 @@
 2009-10-26
   - you no longer have to define all 3 callback methods in callback classes
-  - callback methods are execute without listeners, to prevent recursion
+  - callback methods are execute without listeners, to prevent recursion
+  - inherited subclasses don't get two copies of the callbacks

data/VERSION

@@ -1 +1 @@
-0.2.2
+0.2.3

data/active_model_listener.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{active_model_listener}
-  s.version = "0.2.2"
+  s.version = "0.2.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jeff Dean"]

data/lib/active_model_listener.rb

@@ -4,24 +4,16 @@ require 'active_model_listener/active_model_listener'
 module WireUpModels
 
   def self.included(base)
-    base.send(:extend, ClassMethods)
-  end
-
-  module ClassMethods
-    def inherited(child)
-      super
-
-      child.after_create do |record|
-        ActiveModelListener.dispatch record, :create
-      end
+    base.after_create do |record|
+      ActiveModelListener.dispatch record, :create
+    end
 
-      child.after_update do |record|
-        ActiveModelListener.dispatch record, :update
-      end
+    base.after_update do |record|
+      ActiveModelListener.dispatch record, :update
+    end
 
-      child.after_destroy do |record|
-        ActiveModelListener.dispatch record, :destroy
-      end
+    base.after_destroy do |record|
+      ActiveModelListener.dispatch record, :destroy
     end
   end
 

data/spec/active_model_listener_spec.rb

@@ -28,6 +28,9 @@ describe ActiveModelListener do
       string :title
     end
 
+    build_model :editorials, :superclass => Article do
+    end
+
     ActiveModelListener.listeners.clear
     ActiveModelListener.listeners << FooListener
     ActiveModelListener.listeners << BarListener
@@ -70,6 +73,11 @@ describe ActiveModelListener do
       FooListener.should_receive(:after_create).once
       Article.create! :title => "foo"
     end
+
+    it "should not be run twice for inherited models" do
+      FooListener.should_receive(:after_create).once
+      Editorial.create! :title => "foo"
+    end
   end
 
   describe "after create" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: active_model_listener
 version: !ruby/object:Gem::Version 
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors: 
 - Jeff Dean