active_model-errors_details 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 73354179ee7bcde3fc9788714870cd06981c32ec
-  data.tar.gz: 21b27aa4a7b13a411c780fd2b7af3316686a5843
+  metadata.gz: 6d71b28eafed6a675b4b31f30bf4ef0a6146406c
+  data.tar.gz: 878becca5e2f6b8bbda9535439d9bfdc61774d73
 SHA512:
-  metadata.gz: 0ff23f9ae379f31dc5728421dd8caa798067b95719cda49182f1fc3a261d184d137bc13873371eb6365f3b6af285c58a51464fa31fc8a922c96754ebdf4380bd
-  data.tar.gz: 5014f82de304d637c761b7033f0d55b471743cba24e57807995193ed3a09c7040bf1346eb88d2ae40194bfd16ef6b64528cd8824bc30657338bb3875a62ee122
+  metadata.gz: d11968f0d4f0b9a51a8732fa21fc776b29b5d902af22c6605c9224a46c61f253497941e41db708c2fc762327be733210559454e3ad93bfe85a16d8a2dd1115be
+  data.tar.gz: 0a34703bcf3283612a64d1cbe3dcacfa257ce6fd1830441325593f46b4a4a406f7429c2f783c146f4faf984cb0216b64732b2feec87ad15274d687e9ffbaf699

data/README.md

@@ -1,5 +1,7 @@
 # ActiveModel::Errors#details
 
+[![Build Status](https://travis-ci.org/cowbell/active_model-errors_details.svg?branch=master)](https://travis-ci.org/cowbell/active_model-errors_details)
+
 Feature backported from Rails 5.0 to use with Rails 4.x apps.
 
 Background: https://github.com/rails/rails/pull/18322
@@ -12,9 +14,7 @@ gem install "active_model-errors_details"
 
 ## Usage
 
-To check what validator type was used on invalid attribute, you can use
-`errors.details[:attribute]`. It returns array of hashes where under `:error`
- key you will find symbol of used validator.
+To check what validator type was used on invalid attribute, you can use `errors.details[:attribute]`. It returns array of hashes where under `:error` key you will find symbol of used validator.
 
 ```ruby
 class Person < ActiveRecord::Base
@@ -27,38 +27,39 @@ person.errors.details[:name]
 # => [{error: :blank}]
 ```
 
-You can add validator type to details hash when using `errors.add` method.
+You can add validator type to details hash when using `ActiveModel::Errors.add` method.
 
 ```ruby
-class Person < ActiveRecord::Base
-  def a_method_used_for_validation_purposes
-    errors.add(:name, :invalid_characters)
+class User < ActiveRecord::Base
+  validate :adulthood
+
+  def adulthood
+    errors.add(:age, :too_young) if age < 18
   end
 end
 
-person = Person.create(name: "!@#")
-
-person.errors.details[:name]
-# => [{error: :invalid_characters}]
+user = User.new(age: 15)
+user.valid?
+user.errors.details
+# => {age: [{error: :too_young}]}
 ```
 
-To improve error details to contain not allowed characters set, you can
-pass additional options to `errors.add` method.
+To improve error details to contain additional options, you can pass them to `ActiveModel::Errors.add` method.
 
 ```ruby
-class Person < ActiveRecord::Base
-  def a_method_used_for_validation_purposes
-    errors.add(:name, :invalid_characters, not_allowed: "!@#%*()_-+=")
+class User < ActiveRecord::Base
+  validate :adulthood
+
+  def adulthood
+    errors.add(:age, :too_young, years_limit: 18) if age < 18
   end
 end
 
-person = Person.create(name: "John!")
-
-person.errors.details[:name]
-# => [{error: :invalid_characters, not_allowed: "!@#%*()_-+="}]
+user = User.new(age: 15)
+user.valid?
+user.errors.details
+# => {age: [{error: :too_young, years_limit: 18}]}
 ```
 
 All built in Rails validators populate details hash with corresponding
 validator types.
-
-[![Build Status](https://travis-ci.org/cowbell/active_model-email_confirmation.svg)](https://travis-ci.org/cowbell/active_model-email_confirmation)

data/active_model-errors_details.gemspec

@@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "activemodel", ">= 4.0", "< 5.0.0.alpha"
+  spec.add_dependency "activesupport"
 
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"

data/lib/active_model/errors_details.rb

@@ -1,5 +1,6 @@
 require "active_model/errors_details/version"
 require "active_model/errors"
+require "active_support/core_ext/object/deep_dup"
 
 module ActiveModel
   module ErrorsDetails
@@ -10,8 +11,8 @@ module ActiveModel
         alias_method :initialize_without_details, :initialize
         alias_method :initialize, :initialize_with_details
 
-        # alias_method :initialize_dup_without_details, :initialize_dup
-        # alias_method :initialize_dup, :initialize_dup_with_details
+        alias_method :initialize_dup_without_details, :initialize_dup
+        alias_method :initialize_dup, :initialize_dup_with_details
 
         alias_method :delete_without_details, :delete
         alias_method :delete, :delete_with_details
@@ -24,10 +25,10 @@ module ActiveModel
       end
     end
 
-    # def initialize_dup_with_details(other)
-    #   @details = other.details.dup
-    #   initialize_dup_without_details(other)
-    # end
+    def initialize_dup_with_details(other)
+      @details = other.details.deep_dup
+      initialize_dup_without_details(other)
+    end
 
     def details
       @details

data/lib/active_model/errors_details/version.rb

@@ -1,5 +1,5 @@
 module ActiveModel
   module ErrorsDetails
-    VERSION = "1.0.0"
+    VERSION = "1.1.0"
   end
 end

data/test/test_errors_details.rb

@@ -63,15 +63,14 @@ class TestErrorsDetails < MiniTest::Unit::TestCase
     assert_equal({name: [{error: :invalid}] }, person.errors.details)
   end
 
-  # TODO: investigate why it doesn't work
-  # def test_dup_duplicates_details
-  #   errors = ActiveModel::Errors.new(Person.new)
-  #   errors.add(:name, :invalid)
-  #   errors_dup = errors.dup
-  #   errors_dup.add(:name, :taken)
-
-  #   refute_equal errors_dup.details, errors.details
-  # end
+  def test_dup_duplicates_details
+    errors = ActiveModel::Errors.new(Person.new)
+    errors.add(:name, :invalid)
+    errors_dup = errors.dup
+    errors_dup.add(:name, :taken)
+
+    refute_equal errors_dup.details, errors.details
+  end
 
   def test_delete_removes_details_on_given_attribute
     errors = ActiveModel::Errors.new(Person.new)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_model-errors_details
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Wojciech Wnętrzak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-21 00:00:00.000000000 Z
+date: 2015-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -30,6 +30,20 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: 5.0.0.alpha
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement