active_model-better_errors 1.6.0

data/spec/lib/active_model/error_collecting/human_message_formatter_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe ActiveModel::ErrorCollecting::HumanMessageFormatter do
+  subject(:formatter) { klass.new base, error_message }
+  let(:klass)         { ActiveModel::ErrorCollecting::HumanMessageFormatter }
+  let(:base)          { User.new }
+  let(:error_message) { ActiveModel::ErrorCollecting::ErrorMessage.build base, :first_name, :invalid }
+
+  describe "#initialize" do
+    its(:base) { should be base }
+    its(:error_message) { should be error_message }
+    its(:attribute) { should be error_message.attribute }
+    its(:type) { should be error_message.type }
+    its(:message) { should be error_message.message }
+    its(:options) { should be error_message.options }
+  end
+
+  describe "#format_message" do
+    subject { formatter.format_message }
+    it { should == "is invalid" }
+  end
+end

data/spec/lib/active_model/error_collecting/human_message_reporter_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe ActiveModel::ErrorCollecting::HumanMessageReporter do
+  subject(:reporter)  { klass.new collection }
+  let(:klass)         { ActiveModel::ErrorCollecting::HumanMessageReporter }
+  let(:collection)    { ActiveModel::ErrorCollecting::ErrorCollection.new base}
+  let(:base)          { User.new }
+
+
+  describe "#initialize" do
+    its(:collection) { should be collection }
+  end
+
+  describe "#base" do
+    its(:base) { should be base }
+  end
+
+  describe "#full_message" do
+    subject { reporter.full_message attribute, message }
+    let(:attribute) { :first_name }
+    let(:message)   { "is invalid" }
+
+    it { should == "First name is invalid" }
+  end
+
+  describe "#full_messages" do
+    subject { reporter.full_messages }
+    let(:expected) {[
+        "First name is invalid",
+        "First name can't be empty",
+        "Last name is invalid"
+    ]}
+
+    before  do
+      collection[:first_name] << :invalid
+      collection[:first_name] << :empty
+      collection[:last_name] << :invalid
+    end
+
+    it { should == expected }
+  end
+
+  describe "#generate_message" do
+    subject { reporter.generate_message attribute, type, options }
+    let(:attribute) { :first_name }
+
+    context "when passing symbols as message" do
+      let(:type)      { :too_short }
+      let(:options)   { {count: 3} }
+      let(:expected)  { "is too short (minimum is 3 characters)" }
+      it { should == expected }
+    end
+
+    context "when passing strings as message" do
+      let(:type)      { "foo" }
+      let(:options)   { nil }
+      let(:expected)  { type }
+      it { should == expected }
+    end
+  end
+end

data/spec/lib/active_model/error_collecting/machine_array_reporter_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe ActiveModel::ErrorCollecting::MachineArrayReporter do
+  subject(:reporter)  { klass.new collection }
+  let(:klass)         { ActiveModel::ErrorCollecting::MachineArrayReporter }
+  let(:collection)    { ActiveModel::ErrorCollecting::ErrorCollection.new base}
+  let(:base)          { User.new }
+
+  describe "#initialize" do
+    its(:collection) { should be collection }
+  end
+
+  describe "#base" do
+    its(:base) { should be base }
+  end
+
+  describe "#to_a" do
+    subject { reporter.to_a }
+
+    before  do
+      collection[:first_name] << :invalid
+      collection[:first_name] << [ :too_short, { count: 3 } ]
+      collection[:last_name] << :invalid
+    end
+
+    let(:expected) {[{
+      attribute: 'first_name',
+      type:      :invalid
+    }, {
+      attribute: 'first_name',
+      type:      :too_short,
+      options:   { count: 3 }
+    },{
+      attribute: 'last_name',
+      type:      :invalid
+    }]}
+
+    it { should == expected }
+  end
+end

data/spec/lib/active_model/error_collecting/machine_hash_reporter_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe ActiveModel::ErrorCollecting::MachineHashReporter do
+  subject(:reporter)  { klass.new collection }
+  let(:klass)         { ActiveModel::ErrorCollecting::MachineHashReporter }
+  let(:collection)    { ActiveModel::ErrorCollecting::ErrorCollection.new base}
+  let(:base)          { User.new }
+
+  describe "#initialize" do
+    its(:collection) { should be collection }
+  end
+
+  describe "#base" do
+    its(:base) { should be base }
+  end
+
+  describe "#to_hash" do
+    subject { reporter.to_hash }
+
+    before  do
+      collection[:first_name] << :invalid
+      collection[:first_name] << [ :too_short, { count: 3 } ]
+      collection[:last_name] << :invalid
+    end
+
+    let(:expected) {{
+      first_name: [{
+        type:      :invalid
+      }, {
+        type:      :too_short,
+        options:   { count: 3 }
+      }],
+      last_name: [{
+        type:      :invalid
+      }]
+    }}
+
+    it { should == expected }
+  end
+end

data/spec/lib/active_model/error_collecting_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe ActiveModel::ErrorCollecting do
+  describe ".set_reporter" do
+    subject { ActiveModel::ErrorCollecting.reporters[name.to_s] }
+    before { ActiveModel::ErrorCollecting.set_reporter name, reporter }
+    after  { ActiveModel::ErrorCollecting.set_reporter name, nil }
+    let(:name) { :mock }
+    let(:reporter) { Class.new }
+    it { should be reporter }
+  end
+
+  describe ".reporters" do
+    subject { ActiveModel::ErrorCollecting.reporters }
+    let(:expected) {{
+      'message' => ActiveModel::ErrorCollecting::HumanMessageReporter,
+      'array'   => ActiveModel::ErrorCollecting::HumanArrayReporter,
+      'hash'    => ActiveModel::ErrorCollecting::HumanHashReporter
+    }}
+    it { should == expected }
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,15 @@
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+require 'rspec'
+require 'pry'
+
+require 'active_model'
+require 'active_model/better_errors'
+
+# Requires supporting files with custom matchers and macros, etc,
+# in ./support/ and its subdirectories.
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
+
+RSpec.configure do |config|
+
+end

data/spec/support/models.rb

@@ -0,0 +1,28 @@
+class BasicModel
+  extend  ActiveModel::Naming
+  extend  ActiveModel::Translation
+  include ActiveModel::Validations
+  include ActiveModel::Conversion
+
+  def initialize(params={})
+    params.each do |attr, value|
+      self.public_send("#{attr}=", value)
+    end
+  end
+
+  def persisted?
+    false
+  end
+end
+
+class User < BasicModel
+  attr_accessor :first_name, :last_name, :email
+
+  validates :first_name, :last_name, presence: { message: "plz...?" }
+end
+
+class Ruler < BasicModel
+  attr_accessor :length
+
+  validates_numericality_of :length, less_than_or_equal_to: 12, greater_than_or_equal_to: 4
+end

data/test/integration.rb

@@ -0,0 +1,10 @@
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+
+require 'active_model/better_errors'
+require 'minitest/unit'
+
+MiniTest::Unit::TestCase.add_setup_hook do
+  @__old_errors_class = ActiveModel::Errors
+  ActiveModel.stubs(:Errors).returns(ActiveModel::ErrorCollecting::Errors)
+end

metadata

@@ -0,0 +1,274 @@
+--- !ruby/object:Gem::Specification
+name: active_model-better_errors
+version: !ruby/object:Gem::Version
+  version: 1.6.0
+  prerelease: 
+platform: ruby
+authors:
+- Aaron Qian
+- Byron Anderson
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2013-01-22 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: activemodel
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.12.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.12.0
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rdoc
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: jeweler
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bcrypt-ruby
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.12.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.12.1
+description: ActiveModel::Errors class is not designed for API consumption. This gem
+  allows for that while keeping compatibility with existing rails API.
+email:
+- aq1018@gmail.com
+- byronanderson32@gmail.com
+executables: []
+extensions: []
+extra_rdoc_files:
+- LICENSE.txt
+- README.md
+files:
+- .document
+- .gitmodules
+- .rspec
+- .travis.yml
+- Gemfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- VERSION
+- active_model-better_errors.gemspec
+- lib/active_model/better_errors.rb
+- lib/active_model/error_collecting.rb
+- lib/active_model/error_collecting/array_reporter.rb
+- lib/active_model/error_collecting/core_ext.rb
+- lib/active_model/error_collecting/emulation.rb
+- lib/active_model/error_collecting/error_collection.rb
+- lib/active_model/error_collecting/error_message.rb
+- lib/active_model/error_collecting/error_message_set.rb
+- lib/active_model/error_collecting/errors.rb
+- lib/active_model/error_collecting/hash_reporter.rb
+- lib/active_model/error_collecting/human_array_reporter.rb
+- lib/active_model/error_collecting/human_hash_reporter.rb
+- lib/active_model/error_collecting/human_message_formatter.rb
+- lib/active_model/error_collecting/human_message_reporter.rb
+- lib/active_model/error_collecting/machine_array_reporter.rb
+- lib/active_model/error_collecting/machine_hash_reporter.rb
+- lib/active_model/error_collecting/message_reporter.rb
+- lib/active_model/error_collecting/reporter.rb
+- spec/lib/active_model/better_errors_spec.rb
+- spec/lib/active_model/error_collecting/emulation_spec.rb
+- spec/lib/active_model/error_collecting/error_collection_spec.rb
+- spec/lib/active_model/error_collecting/error_message_set_spec.rb
+- spec/lib/active_model/error_collecting/error_message_spec.rb
+- spec/lib/active_model/error_collecting/errors_spec.rb
+- spec/lib/active_model/error_collecting/human_array_reporter_spec.rb
+- spec/lib/active_model/error_collecting/human_hash_reporter_spec.rb
+- spec/lib/active_model/error_collecting/human_message_formatter_spec.rb
+- spec/lib/active_model/error_collecting/human_message_reporter_spec.rb
+- spec/lib/active_model/error_collecting/machine_array_reporter_spec.rb
+- spec/lib/active_model/error_collecting/machine_hash_reporter_spec.rb
+- spec/lib/active_model/error_collecting_spec.rb
+- spec/spec_helper.rb
+- spec/support/models.rb
+- test/integration.rb
+homepage: http://github.com/aq1018/active_model-better_errors
+licenses:
+- MIT
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
+      - 0
+      hash: 1834962608414084255
+required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 1.8.24
+signing_key: 
+specification_version: 3
+summary: API consumable error messages with ActiveModel::Errors drop-in compatibility.
+test_files: []