active_metadata 0.8.5 → 0.8.5.1

data/Rakefile

@@ -4,30 +4,11 @@ begin
 rescue LoadError
   puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
 end
-begin
-  require 'rdoc/task'
-rescue LoadError
-  require 'rdoc/rdoc'
-  require 'rake/rdoctask'
-  RDoc::Task = Rake::RDocTask
-end
-
-RDoc::Task.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'ActiveMetadata'
-  rdoc.options << '--line-numbers'
-  rdoc.rdoc_files.include('README.rdoc')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
-
-APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__)
-load 'rails/tasks/engine.rake'
-
-require 'ci/reporter/rake/rspec'
 require 'rspec/core/rake_task'
 require 'cucumber/rake/task'
-RSpec::Core::RakeTask.new(:spec)
 
+APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__)
+load 'rails/tasks/engine.rake'
 
 Bundler::GemHelper.install_tasks
 

data/lib/active_metadata/persistence/history.rb

@@ -10,6 +10,7 @@ module ActiveMetadata::Persistence::History
       return if ActiveMetadata.skip_history?
       self.changes.each do |key, value|
         # Do not go on in case if new and old values are nil
+        # https://github.com/rails/rails/issues/8874
         return if value.compact.empty?
         next if ActiveMetadata::CONFIG['history_skip_fields'].include?(key)
         ActiveMetadata::History.create! :value => value[1],:model_class => metadata_class, :model_id => metadata_id,:label => key.to_s, :created_by => current_user_id

data/lib/active_metadata/version.rb

@@ -1,3 +1,3 @@
 module ActiveMetadata
-  VERSION = "0.8.5"
+  VERSION = "0.8.5.1"
 end

data/lib/tasks/active_metadata_tasks.rake

@@ -1,30 +1,31 @@
 namespace :active_metadata do
+
   namespace :ci do
-    ENV['COVERAGE'] = 'on'
-    ENV['JCI'] = 'on'
-    ENV['RAILS_ENV'] ||= 'test'
-
-    task :migrate, :environment do
-      sh "mkdir -p spec/dummy/tmp/cache"
-      Rake::Task["app:db:create"].invoke
-      Rake::Task["app:db:migrate"].invoke
+
+    Rails.env = "test"
+
+    RSpec::Core::RakeTask.new(:spec_run) do |t|
+      t.rspec_opts = ["-fp", "--format RspecJunitFormatter", "--out spec/reports/rspec.xml"]
     end
 
-    task :rspec do
-      Rake::Task["ci:setup:rspec"].invoke
-      Rake::Task["spec"].invoke
+    Cucumber::Rake::Task.new(:cucumber_run) do |task|
+      format_output = ENV['CUCUMBER_FORMAT'] || 'progress'
+      task.cucumber_opts = ["--format #{format_output}", "--format junit", "--out features/reports", "--format html", "--out features/reports/cucumber.html"]
+      task.cucumber_opts.push("-p #{ENV['CUCUMBER_PROFILE']}") if ENV['CUCUMBER_PROFILE']
     end
 
-    task :cucumber do
-      ENV["CUCUMBER_OPTS"] = "--format junit --out features/reports --format html --out features/reports/cucumber.ht"
-      Rake::Task["app:cucumber"].invoke
+    task :rspec do :environment
+      rm_rf "spec/reports"
+      Rake::Task["app:active_metadata:ci:spec_run"].invoke
     end
-  end
-end
 
-task "active_metadata:ci" => ["app:active_metadata:ci:migrate", "app:active_metadata:ci:rspec", "app:active_metadata:ci:cucumber"]
+    task :cucumber do :environment
+      Rake::Task["app:active_metadata:ci:cucumber_run"].invoke
+    end
 
-namespace :active_metadata do
+  end
+
+  task :ci => ["active_metadata:ci:rspec", "active_metadata:ci:cucumber"]
 
   desc "Install the active_metadata gem requirements file ***TASK IS ON ALPHA STAGE***"
   task :install do

data/spec/lib/history_spec.rb

@@ -27,6 +27,17 @@ describe ActiveMetadata do
       @document.history_for(:name)[0].created_at.should be_a_kind_of Time
     end
 
+    it "should not save the history and send any notification if new value and old are both nil" do
+      # see
+      # https://github.com/rails/rails/issues/8874
+      @user = User.create!(:email => "email@email.it", :firstname => 'John', :lastname => 'smith')
+      ActiveMetadata::Watcher.create! :model_class => "Document", :label => :date, :owner_id => @user.id
+      @document.date = ""
+      @document.save
+      @document.notifier.should be_nil
+      @document.history_for(:date).should be_empty
+    end
+
     it "should verify that history return records only for the self document" do
       # fixtures
       @another_doc = Document.create :name => "Andrea"

data/spec/support/migrations.rb

@@ -1,6 +1,9 @@
+require 'rake'
+
 module TestDb
 
   def self.up
+
     ActiveRecord::Base.connection.create_table :documents, force: true do |t|
       t.string :name
       t.string :surname

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_metadata
 version: !ruby/object:Gem::Version
-  version: 0.8.5
+  version: 0.8.5.1
   prerelease: 
 platform: ruby
 authors:
@@ -10,22 +10,27 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-10 00:00:00.000000000Z
+date: 2013-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &2162999420 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - =
+    - - '='
       - !ruby/object:Gem::Version
         version: 3.2.10
   type: :runtime
   prerelease: false
-  version_requirements: *2162999420
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.2.10
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &2162998840 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +38,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2162998840
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &2162998280 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +54,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2162998280
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &2162997720 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +70,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2162997720
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: cucumber-rails
-  requirement: &2162997060 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,10 +86,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2162997060
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: ci_reporter
-  requirement: &2162996320 !ruby/object:Gem::Requirement
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -77,10 +102,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2162996320
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: paperclip
-  requirement: &2162995520 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -88,10 +118,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2162995520
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mime-types
-  requirement: &2162994320 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -99,7 +134,12 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2162994320
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: First implementation will write metadata on mongodb
 email:
 - acampolonghi@gmail.com
@@ -205,6 +245,7 @@ files:
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/dummy/script/rails
+- spec/dummy/tmp/cache/.gitkeep
 - spec/helpers/active_metadata/stream_helpers_spec.rb
 - spec/lib/active_metadata_spec.rb
 - spec/lib/attachments_spec.rb
@@ -237,7 +278,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1573769057447502802
+      hash: -2334406097981202284
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -246,10 +287,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1573769057447502802
+      hash: -2334406097981202284
 requirements: []
 rubyforge_project: active_metadata
-rubygems_version: 1.8.11
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Add metadata to fields in an active record model
@@ -299,6 +340,7 @@ test_files:
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/dummy/script/rails
+- spec/dummy/tmp/cache/.gitkeep
 - spec/helpers/active_metadata/stream_helpers_spec.rb
 - spec/lib/active_metadata_spec.rb
 - spec/lib/attachments_spec.rb