active_merchant_first_data 1.2.0 → 1.3.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MzZlZWJiMWY2MGY2YWJmZWFjM2U0MjAxMjkwNjY4MTFlM2E3MmY0Zg==
-  data.tar.gz: !binary |-
-    NTNiNmM3MzU2ZjEyZDIwYmFmM2FkZTE4NjU3NzdlZTIxNWU2MmEwOA==
+SHA1:
+  metadata.gz: 7c847bdc7d68f8782735ac29421f2ad5ded03607
+  data.tar.gz: 552bb14ccf65b5310ebaeed6909da816d532895e
 SHA512:
-  metadata.gz: !binary |-
-    OGM2ODU3Y2VjMTkyZWVhMTA3NzUxNTcwOGU0ODkxYjA2YjE0N2U0OGE2ZWVl
-    ZWQwMWZjYWZkMTY4YzczZGFmMDc1OWZkOWIwYjE1MjYwOTEzZTEwZTQ5ZTY0
-    ZTgzZDZiZmQzMDIzYWFkZWY3YWUyM2U2ZTA1YzBmZThmNWVhMjM=
-  data.tar.gz: !binary |-
-    YWY1Y2JlMDBiYmQ2NTg5OTBkZDFjZGVjYTg5MWM4M2ZlYTRmYmEzMjRjZmUy
-    ZDRjMDBjMGI4YjE2YmEzYWU5ZmZhNWZiZGRkZWY2N2MwMWVlMzhjYzRhNmE3
-    ZGU2ZmVhMjExNWYzNWZkNDE3MjcwYjRlZmRjNzg1Y2FjNmFlNTI=
+  metadata.gz: 0c22fc2e61afb361f82ea6f501931d77c07d7f0187fef26899ddacf7b22d2147145fe1a77a57b5d739bc842b727cacd130e5e4585a6488d08f04124f20f48f2b
+  data.tar.gz: aef5468d0f9087c2c6e74acb6c49e1aa7445af9ba4a86e148dc4f9de448450d0e46c4bd9a90d2055fb25d6f91bb58c8a9af091c7dbc294713e49f2a9761ca477

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.3.0
+
+*   Response as an object instead of a hash (@Sacristan, #6)
+
 ## 1.2.0
 
 *   Changed default currency from LVL to EUR

data/README.md

@@ -13,10 +13,20 @@ $ gem install active_merchant_first_data
 
 ```ruby
 require "active_merchant_first_data"
-@gateway = ActiveMerchant::Billing::FirstDataGateway.new(
-  :pem => "1234567_keystore.pem"
-  :pem_password => "5x64jq8n234c"
+
+gateway = ActiveMerchant::Billing::FirstDataGateway.new(
+  pem: "1234567_keystore.pem"
+  pem_password: "5x64jq8n234c"
 )
+
+# Authorize for 10 euros (1000 euro cents)
+response = gateway.authorize(1000, client_ip_addr: '127.0.0.1')
+
+# Use this url to enter credit card data
+gateway.redirect_url(response.authorization)
+
+# Capture the money
+gateway.capture(1000, response.authorization, client_ip_addr: '127.0.0.1')
 ```
 
 ## First Data test environment setup
@@ -24,7 +34,7 @@ require "active_merchant_first_data"
 1. Generate a new certificate
 
     ```bash
-    $ openssl req -newkey rsa:1024 -keyout spec/certs/1234567_key.pem -out spec/certs/1234567_req.pem -subj "/C=lv/O=example.com/CN=1234567" -outform PEM
+    $ openssl req -newkey rsa:2048 -keyout spec/certs/1234567_key.pem -out spec/certs/1234567_req.pem -subj "/C=lv/O=example.com/CN=1234567" -outform PEM
     Enter PEM pass phrase: 81f174259v45
     ```
 

data/lib/active_merchant/billing/first_data_gateway.rb

@@ -1,23 +1,7 @@
-require "active_merchant"
-
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class FirstDataGateway < Gateway
-      class_attribute :test_url, :live_url, :test_redirect_url, :live_redirect_url, :pem_file, :pem_password
-
-      self.test_redirect_url = 'https://secureshop-test.firstdata.lv/ecomm/ClientHandler'
-      self.live_redirect_url = 'https://secureshop.firstdata.lv/ecomm/ClientHandler'
-
-      self.test_url = 'https://secureshop-test.firstdata.lv:8443/ecomm/MerchantHandler'
-      self.live_url = 'https://secureshop.firstdata.lv:8443/ecomm/MerchantHandler'
-
-      self.homepage_url = 'http://www.firstdata.lv/'
-      self.display_name = 'First Data'
-
-      self.ssl_strict = false
-      self.default_currency = '978' # LVL (http://en.wikipedia.org/wiki/ISO_4217)
-      self.money_format = :cents
-
+      # http://en.wikipedia.org/wiki/ISO_4217
       CURRENCY_CODES = {
         'ADP' => '020', 'AED' => '784', 'AFA' => '004', 'ALL' => '008', 'AMD' => '051',
         'ANG' => '532', 'AOA' => '973', 'ARS' => '032', 'AUD' => '036', 'AWG' => '533',
@@ -56,6 +40,21 @@ module ActiveMerchant #:nodoc:
         'ZMK' => '894', 'ZWD' => '716'
       }
 
+      class_attribute :test_url, :live_url, :test_redirect_url, :live_redirect_url, :pem_file, :pem_password
+
+      self.test_redirect_url = 'https://secureshop-test.firstdata.lv/ecomm/ClientHandler'
+      self.live_redirect_url = 'https://secureshop.firstdata.lv/ecomm/ClientHandler'
+
+      self.test_url = 'https://secureshop-test.firstdata.lv:8443/ecomm/MerchantHandler'
+      self.live_url = 'https://secureshop.firstdata.lv:8443/ecomm/MerchantHandler'
+
+      self.homepage_url = 'http://www.firstdata.lv/'
+      self.display_name = 'First Data'
+
+      self.ssl_strict = false
+      self.default_currency = CURRENCY_CODES['EUR']
+      self.money_format = :cents
+
       class Error < StandardError
         attr_reader :response
 
@@ -261,7 +260,6 @@ module ActiveMerchant #:nodoc:
           :command => :p,
           :amount => 0,
           :currency => default_currency,
-          :msg_type => 'SMS',
           :msg_type => 'AUTH',
           :perspayee_gen => 1,
           :perspayee_overwrite => 1
@@ -287,7 +285,6 @@ module ActiveMerchant #:nodoc:
       end
 
       private
-
       def lookup_currency(params)
         params[:currency] = CURRENCY_CODES[params[:currency]] || params[:currency]
       end
@@ -307,7 +304,7 @@ module ActiveMerchant #:nodoc:
         # FIXME: test cases 17 and 19 return unnecessary error even when result and result_code are present
         # should be removed when this issue is fixed on gataway side
         raise Error.new(response) if !response[:error].blank? && response[:result_code].blank?
-        response
+        ActiveMerchant::Billing::FirstDataResponse.new response
       end
 
       def post_data(params)

data/lib/active_merchant/billing/first_data_response.rb

@@ -0,0 +1,148 @@
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    class FirstDataResponse < Response
+      RESPONSE_CODES = {
+        "000" => "Approved",
+        "001" => "Approved, honour with identification",
+        "002" => "Approved for partial amount",
+        "003" => "Approved for VIP",
+        "004" => "Approved, update track 3",
+        "005" => "Approved, account type specified by card issuer",
+        "006" => "Approved for partial amount, account type specified by card issuer",
+        "007" => "Approved, update ICC",
+        "100" => "Decline (general, no comments)",
+        "101" => "Decline, expired card",
+        "102" => "Decline, suspected fraud",
+        "103" => "Decline, card acceptor contact acquirer",
+        "104" => "Decline, restricted card",
+        "105" => "Decline, card acceptor call acquirer's security department",
+        "106" => "Decline, allowable PIN tries exceeded",
+        "107" => "Decline, refer to card issuer",
+        "108" => "Decline, refer to card issuer's special conditions",
+        "109" => "Decline, invalid merchant",
+        "110" => "Decline, invalid amount",
+        "111" => "Decline, invalid card number",
+        "112" => "Decline, PIN data required",
+        "113" => "Decline, unacceptable fee",
+        "114" => "Decline, no account of type requested",
+        "115" => "Decline, requested function not supported",
+        "116" => "Decline, not sufficient funds",
+        "117" => "Decline, incorrect PIN",
+        "118" => "Decline, no card record",
+        "119" => "Decline, transaction not permitted to cardholder",
+        "120" => "Decline, transaction not permitted to terminal",
+        "121" => "Decline, exceeds withdrawal amount limit",
+        "122" => "Decline, security violation",
+        "123" => "Decline, exceeds withdrawal frequency limit",
+        "124" => "Decline, violation of law",
+        "125" => "Decline, card not effective",
+        "126" => "Decline, invalid PIN block",
+        "127" => "Decline, PIN length error",
+        "128" => "Decline, PIN kay synch error",
+        "129" => "Decline, suspected counterfeit card",
+        "197" => "Declined, call AmEx",
+        "198" => "Declined, call Card Processing Centre",
+        "200" => "Pick-up (general, no comments)",
+        "201" => "Pick-up, expired card",
+        "202" => "Pick-up, suspected fraud",
+        "203" => "Pick-up, card acceptor contact card acquirer",
+        "204" => "Pick-up, restricted card",
+        "205" => "Pick-up, card acceptor call acquirer's security department",
+        "206" => "Pick-up, allowable PIN tries exceeded",
+        "207" => "Pick-up, special conditions",
+        "208" => "Pick-up, lost card",
+        "209" => "Pick-up, stolen card",
+        "210" => "Pick-up, suspected counterfeit card",
+        "300" => "Status message: file action successful",
+        "301" => "Status message: file action not supported by receiver",
+        "302" => "Status message: unable to locate record on file",
+        "303" => "Status message: duplicate record, old record replaced",
+        "304" => "Status message: file record field edit error",
+        "305" => "Status message: file locked out",
+        "306" => "Status message: file action not successful",
+        "307" => "Status message: file data format error",
+        "308" => "Status message: duplicate record, new record rejected",
+        "309" => "Status message: unknown file",
+        "400" => "Accepted (for reversal)",
+        "500" => "Status message: reconciled, in balance",
+        "501" => "Status message: reconciled, out of balance",
+        "502" => "Status message: amount not reconciled, totals provided",
+        "503" => "Status message: totals for reconciliation not available",
+        "504" => "Status message: not reconciled, totals provided",
+        "600" => "Accepted (for administrative info)",
+        "601" => "Status message: impossible to trace back original transaction",
+        "602" => "Status message: invalid transaction reference number",
+        "603" => "Status message: reference number/PAN incompatible",
+        "604" => "Status message: POS photograph is not available",
+        "605" => "Status message: requested item supplied",
+        "606" => "Status message: request cannot be fulfilled - required documentation is not available",
+        "700" => "Accepted (for fee collection)",
+        "800" => "Accepted (for network management)",
+        "900" => "Advice acknowledged, no financial liability accepted",
+        "901" => "Advice acknowledged, finansial liability accepted",
+        "902" => "Decline reason message: invalid transaction",
+        "903" => "Status message: re-enter transaction",
+        "904" => "Decline reason message: format error",
+        "905" => "Decline reason message: acqiurer not supported by switch",
+        "906" => "Decline reason message: cutover in process",
+        "907" => "Decline reason message: card issuer or switch inoperative",
+        "908" => "Decline reason message: transaction destination cannot be found for routing",
+        "909" => "Decline reason message: system malfunction",
+        "910" => "Decline reason message: card issuer signed off",
+        "911" => "Decline reason message: card issuer timed out",
+        "912" => "Decline reason message: card issuer unavailable",
+        "913" => "Decline reason message: duplicate transmission",
+        "914" => "Decline reason message: not able to trace back to original transaction",
+        "915" => "Decline reason message: reconciliation cutover or checkpoint error",
+        "916" => "Decline reason message: MAC incorrect",
+        "917" => "Decline reason message: MAC key sync error",
+        "918" => "Decline reason message: no communication keys available for use",
+        "919" => "Decline reason message: encryption key sync error",
+        "920" => "Decline reason message: security software/hardware error - try again",
+        "921" => "Decline reason message: security software/hardware error - no action",
+        "922" => "Decline reason message: message number out of sequence",
+        "923" => "Status message: request in progress",
+        "940" => "Decline, blocked by fraud filter",
+        "950" => "Decline reason message: violation of business arrangement"
+      }
+
+      attr_accessor :authorization, :error_code, :error_message, :success, :message
+
+      def initialize params, options={}
+        success = params[:result] == 'OK'
+        message = RESPONSE_CODES[params[:result_code]]
+
+        unless success
+          error_code = params[:result_code]
+          error_message = message
+        end
+
+        super success, message, params, options.merge(
+          authorization: params[:transaction_id]
+        )
+      end
+
+      def recurring?
+        recc_pmnt_id.present? && recc_pmnt_expiry.present?
+      end
+
+      [:recc_pmnt_expiry, :recc_pmnt_id, :result, :result_code, :transaction_id].each do |name|
+        define_method name do
+          params[name]
+        end
+      end
+
+      def _3d_secure
+        params[:'3dsecure']
+      end
+
+      def result_message
+        message
+      end
+
+      def [](value)
+        params[value]
+      end
+    end
+  end
+end

data/lib/active_merchant_first_data.rb

@@ -1 +1,3 @@
+require "active_merchant"
+require "active_merchant/billing/first_data_response"
 require "active_merchant/billing/first_data_gateway"

metadata

@@ -1,85 +1,85 @@
 --- !ruby/object:Gem::Specification
 name: active_merchant_first_data
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Edgars Beigarts
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-16 00:00:00.000000000 Z
+date: 2015-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 1.15.0
   name: activemerchant
-  type: :runtime
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.15.0
+  type: :runtime
   prerelease: false
-- !ruby/object:Gem::Dependency
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.15.0
+- !ruby/object:Gem::Dependency
   name: rake
-  type: :development
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+  type: :development
   prerelease: false
-- !ruby/object:Gem::Dependency
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.10'
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: rspec
-  type: :development
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.10'
+        version: '3.2'
+  type: :development
   prerelease: false
-- !ruby/object:Gem::Dependency
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '3.2'
+- !ruby/object:Gem::Dependency
   name: vcr
-  type: :development
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.11'
+  type: :development
   prerelease: false
-- !ruby/object:Gem::Dependency
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.11'
+- !ruby/object:Gem::Dependency
   name: fakeweb
-  type: :development
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+  type: :development
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
 description: First Data Latvia gateway for Active Merchant
 email:
 - edgars.beigarts@makit.lv
@@ -87,11 +87,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- lib/active_merchant/billing/first_data_gateway.rb
-- lib/active_merchant_first_data.rb
-- README.md
 - CHANGELOG.md
 - LICENSE
+- README.md
+- lib/active_merchant/billing/first_data_gateway.rb
+- lib/active_merchant/billing/first_data_response.rb
+- lib/active_merchant_first_data.rb
 homepage: https://github.com/ebeigarts/active_merchant_first_data
 licenses: []
 metadata: {}
@@ -101,17 +102,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: First Data Latvia gateway for Active Merchant