active_merchant-epsilon 0.14.0 → 0.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8fe0b19a8605e29e5c3a2a310e3b9684767a21fb2f93957342ffd41b9135657e
-  data.tar.gz: b8eb1a2b4d150c0696d26a52e58f5069a60542739bc6461d61f864ad20a470db
+  metadata.gz: 810d49880d7598676c702f65469fd1b701f67d44d35d9e42e880458bd5fa6fa2
+  data.tar.gz: d8eacea3a048ec4f854268456a29a56acf5efe0e547dfe554adb4db0627a338c
 SHA512:
-  metadata.gz: 87d7533d96fd6591a2b4ffeb78c7cfe2de4ad987e41c58be72083672f346178be6fa593e3aad6a5f3b66b0dde708e883d6d82a8c864a05006589d33a2978b41c
-  data.tar.gz: '0782a6f4c48fcc0e905a7b72205d5511bea0ffa95ca285dceee5058d97ae0d63e25fc2e2b009910b800c398b2cb07451cb525f8d0ee1f58696228c487f2f4106'
+  metadata.gz: cce905e0138f828f8d8f9db2a1f53a6228b90a4077665a462b89ad31eed9fed7bc9d897cace7653554c5bea9e6be03d4c831f66cbc840cae3fca228911f7784f
+  data.tar.gz: acd2051e4733141ab426271d7a26421b42eb961cc0cf8257373ef66d9c6547b9d3c2e45115281033ea681efa1783ca886554ca3a201dbfe2c66147897314f70f

data/.github/workflows/gem_push.yml

@@ -0,0 +1,41 @@
+name: Publish gem to rubygems.org
+
+on:
+  push:
+    tags:
+      - 'v*'
+
+permissions:
+  contents: read
+
+jobs:
+  push:
+    if: github.repository == 'pepabo/active_merchant-epsilon'
+    runs-on: ubuntu-latest
+
+    environment:
+      name: rubygems.org
+      url: https://rubygems.org/gems/active_merchant-epsilon
+
+    permissions:
+      contents: write
+      id-token: write
+
+    steps:
+      # Set up
+      - name: Harden Runner
+        uses: step-security/harden-runner@4d991eb9b905ef189e4c376166672c3f2f230481 # v2.11.0
+        with:
+          egress-policy: audit
+
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@fb404b9557c186e349162b0d8efb06e2bc36edea # v1.232.0
+        with:
+          bundler-cache: true
+          ruby-version: ruby
+
+      # Release
+      - name: Publish to RubyGems
+        uses: rubygems/release-gem@9e85cb11501bebc2ae661c1500176316d3987059 # v1

data/.github/workflows/test.yml

@@ -11,12 +11,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby-version: [2.4, 2.5, 2.6, 2.7, 3.0]
+        ruby-version: ['3.1', '3.2', '3.3', '3.4']
 
     steps:
     - uses: actions/checkout@v2
 
-    - uses: ruby/setup-ruby@v1.63.0
+    - uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby-version }}
         bundler-cache: true

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # CHANGELOG
 
+### 0.16.0
+
+- [Add `sales_limit_exceeded_flag` to `find_order` response](https://github.com/pepabo/active_merchant-epsilon/pull/133)
+
+### 0.15.0
+
+- [Support 3D Secure parameters for link type payments](https://github.com/pepabo/active_merchant-epsilon/pull/131)
+
 ### 0.14.0
 
 - [Support 3D Secure 2.0 for credit card payments](https://github.com/pepabo/active_merchant-epsilon/pull/121)

data/README.md

@@ -127,8 +127,8 @@ end
 # AND SECOND REQUEST
 
 response = gateway.authenticate(
-  order_number:         'ORDER NUMBER',
-  three_d_secure_pares: 'PAYMENT AUTHENTICATION RESPONSE',
+  order_number:          'ORDER NUMBER',
+  three_d_secure_pa_res: 'PAYMENT AUTHENTICATION RESPONSE',
 )
 
 if response.success?
@@ -199,8 +199,8 @@ end
 # AND SECOND REQUEST
 
 response = gateway.authenticate(
-  order_number:         'ORDER NUMBER',
-  three_d_secure_pares: 'PAYMENT AUTHENTICATION RESPONSE',
+  order_number:          'ORDER NUMBER',
+  three_d_secure_pa_res: 'PAYMENT AUTHENTICATION RESPONSE',
 )
 
 if response.success?

data/active_merchant-epsilon.gemspec

@@ -23,6 +23,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'dotenv'
+  spec.add_development_dependency 'minitest-mock'
   spec.add_development_dependency 'pry-byebug'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'tapp'

data/lib/active_merchant/billing/gateways/epsilon/epsilon_risk_base_auth_params.rb

@@ -0,0 +1,25 @@
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    module EpsilonRiskBaseAuthParams
+      KEYS = %i[
+        tds_flag billAddrCity billAddrCountry billAddrLine1 billAddrLine2 billAddrLine3
+        billAddrPostCode billAddrState shipAddrCity shipAddrCountry shipAddrLine1 shipAddrLine2
+        shipAddrLine3 shipAddrPostCode shipAddrState chAccAgeInd chAccChange
+        chAccChangeIndchAccDate chAccPwdChange chAccPwChangeInd nbPurchaseAccount paymentAccAge
+        paymentAccInd provisionAttemptsDay shipAddressUsage shipAddressUsageInd shipNameIndicator
+        suspiciousAccActivity txnActivityDay txnActivityYear threeDSReqAuthData threeDSReqAuthMethod
+        threeDSReqAuthTimestamp addrMatch cardholderName homePhone mobilePhone
+        workPhone challengeInd deliveryEmailAddress deliveryTimeframe giftCardAmount
+        giftCardCount preOrderDate preOrderPurchaseInd reorderItemsInd shipIndicator
+      ].freeze
+
+      THREE_D_SECURE_2_INDICATORS = [21, 22].freeze
+
+      def three_d_secure_2?(tds_flag)
+        THREE_D_SECURE_2_INDICATORS.include?(tds_flag)
+      end
+
+      module_function :three_d_secure_2?
+    end
+  end
+end

data/lib/active_merchant/billing/gateways/epsilon.rb

@@ -22,20 +22,6 @@ module ActiveMerchant #:nodoc:
         capture:                 'sales_payment.cgi',
       }.freeze
 
-      RISK_BASE_AUTH_PARAMS_KEYS = %i[
-        tds_flag billAddrCity billAddrCountry billAddrLine1 billAddrLine2 billAddrLine3
-        billAddrPostCode billAddrState shipAddrCity shipAddrCountry shipAddrLine1 shipAddrLine2
-        shipAddrLine3 shipAddrPostCode shipAddrState chAccAgeInd chAccChange
-        chAccChangeIndchAccDate chAccPwdChange chAccPwChangeInd nbPurchaseAccount paymentAccAge
-        paymentAccInd provisionAttemptsDay shipAddressUsage shipAddressUsageInd shipNameIndicator
-        suspiciousAccActivity txnActivityDay txnActivityYear threeDSReqAuthData threeDSReqAuthMethod
-        threeDSReqAuthTimestamp addrMatch cardholderName homePhone mobilePhone
-        workPhone challengeInd deliveryEmailAddress deliveryTimeframe giftCardAmount
-        giftCardCount preOrderDate preOrderPurchaseInd reorderItemsInd shipIndicator
-      ].freeze
-
-      THREE_D_SECURE_2_INDICATORS = [21, 22].freeze
-
       self.supported_cardtypes = [:visa, :master, :american_express, :discover]
 
       def purchase(amount, credit_card, detail = {})
@@ -44,7 +30,7 @@ module ActiveMerchant #:nodoc:
         params = billing_params(amount, credit_card, detail)
 
         if three_d_secure_2?(detail)
-          params.merge!(detail.slice(*RISK_BASE_AUTH_PARAMS_KEYS).compact)
+          params.merge!(detail.slice(*EpsilonRiskBaseAuthParams::KEYS).compact)
         end
 
         commit(PATHS[:purchase], params)
@@ -73,7 +59,7 @@ module ActiveMerchant #:nodoc:
         params[:kari_flag] = detail[:capture] ? 2 : 1 if detail.has_key?(:capture)
 
         if three_d_secure_2?(detail)
-          params.merge!(detail.slice(*RISK_BASE_AUTH_PARAMS_KEYS).compact)
+          params.merge!(detail.slice(*EpsilonRiskBaseAuthParams::KEYS).compact)
         end
 
         commit(PATHS[:registered_purchase], params)
@@ -203,6 +189,7 @@ module ActiveMerchant #:nodoc:
           :payment_code,
           :item_price,
           :amount,
+          :sales_limit_exceeded_flag,
         ]
 
         commit(PATHS[:find_order], params, response_keys)
@@ -263,7 +250,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def three_d_secure_2?(detail)
-        THREE_D_SECURE_2_INDICATORS.include?(detail[:tds_flag])
+        EpsilonRiskBaseAuthParams.three_d_secure_2?(detail[:tds_flag])
       end
     end
   end

data/lib/active_merchant/billing/gateways/epsilon_link_payment.rb

@@ -39,6 +39,10 @@ module ActiveMerchant #:nodoc:
         params[:memo2] = detail[:memo2] if detail.has_key?(:memo2)
         params[:user_tel] = detail[:user_tel] if detail.has_key?(:user_tel)
 
+        if three_d_secure_2?(detail)
+          params.merge!(detail.slice(*EpsilonRiskBaseAuthParams::KEYS).compact)
+        end
+
         commit('receive_order3.cgi', params, RESPONSE_KEYS)
       end
 
@@ -50,6 +54,12 @@ module ActiveMerchant #:nodoc:
 
         commit('cancel_payment.cgi', params)
       end
+
+      private
+
+      def three_d_secure_2?(detail)
+        EpsilonRiskBaseAuthParams.three_d_secure_2?(detail[:tds_flag])
+      end
     end
   end
 end

data/lib/active_merchant/billing/gateways/response_parser.rb

@@ -135,6 +135,10 @@ module ActiveMerchant #:nodoc:
         @xml.xpath(ResponseXpath::CAPTURED).to_s != '1'
       end
 
+      def sales_limit_exceeded_flag
+        @xml.xpath(ResponseXpath::SALES_LIMIT_EXCEEDED_FLAG).to_s
+      end
+
       def uri_decode(string)
         CGI.unescape(string).encode(Encoding::UTF_8, Encoding::CP932)
       end
@@ -168,6 +172,7 @@ module ActiveMerchant #:nodoc:
         AMOUNT                             = '//Epsilon_result/result[@amount]/@amount'
         REDIRECT                           = '//Epsilon_result/result[@redirect]/@redirect'
         CAPTURED                           = '//Epsilon_result/result[@kari_flag]/@kari_flag'
+        SALES_LIMIT_EXCEEDED_FLAG          = '//Epsilon_result/result[@sales_limit_exceeded_flag]/@sales_limit_exceeded_flag'
       end
 
       module ResultCode

data/lib/active_merchant/epsilon/version.rb

@@ -1,5 +1,5 @@
 module ActiveMerchant
   module Epsilon
-    VERSION = "0.14.0"
+    VERSION = "0.16.0"
   end
 end

data/lib/active_merchant/epsilon.rb

@@ -5,6 +5,7 @@ require_relative 'epsilon/version'
 require_relative 'billing/convenience_store'
 require_relative 'billing/gateways/epsilon/epsilon_mission_code'
 require_relative 'billing/gateways/epsilon/epsilon_process_code'
+require_relative 'billing/gateways/epsilon/epsilon_risk_base_auth_params'
 require_relative 'billing/gateways/epsilon/epsilon_base'
 require_relative 'billing/gateways/epsilon'
 require_relative 'billing/gateways/epsilon_convenience_store'

data/test/fixtures/vcr_cassettes/epsilon_link_type_with_3d_secure.yml

@@ -0,0 +1,48 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://secure.epsilon.jp/cgi-bin/order/receive_order3.cgi
+    body:
+      encoding: UTF-8
+      string: contract_code=[CONTRACT_CODE]&user_id=U1747274309&user_name=%E5%B1%B1%E7%94%B0+%E5%A4%AA%E9%83%8E&user_mail_add=yamada-taro%40example.com&item_code=ITEM001&item_name=Greate+Product&order_number=O29285401&st_code=10000-0000-00000-00000-00000-00000-00000&mission_code=1&item_price=10000&process_code=1&xml=1&memo1=memo1&memo2=memo2&tds_flag=21
+    headers:
+      Content-Type:
+      - application/x-www-form-urlencoded
+      Connection:
+      - close
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Thu, 15 May 2025 01:58:29 GMT
+      Content-Type:
+      - text/xml
+      Content-Length:
+      - '228'
+      Connection:
+      - close
+      Vary:
+      - Accept-Encoding
+      Strict-Transport-Security:
+      - max-age=31536000; includeSubDomains; preload
+    body:
+      encoding: ASCII-8BIT
+      string: |
+        <?xml version="1.0" encoding="UTF-8" ?>
+         <Epsilon_result>
+          <result result="1" />
+          <result redirect="https%3A%2F%2Fsecure.epsilon.jp%2Fcgi-bin%2Forder%2Fcard3.cgi%3Ftrans_code%3DeyHc6JoHNEiEce2mlXuiCg25" />
+          </Epsilon_result>
+  recorded_at: Thu, 15 May 2025 01:58:29 GMT
+recorded_with: VCR 6.3.1

data/test/fixtures/vcr_cassettes/find_order_success.yml

@@ -100,6 +100,7 @@ http_interactions:
           <result add_info="" />
           <result user_id="U1531791686" />
           <result memo2="memo2" />
+          <result sales_limit_exceeded_flag="0" />
         </Epsilon_result>
     http_version: 
   recorded_at: Tue, 17 Jul 2018 01:41:28 GMT

data/test/remote/gateways/remote_epsilon_convenience_store_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class RemoteEpsilonConvenienceStoreGatewayTest < MiniTest::Test
+class RemoteEpsilonConvenienceStoreGatewayTest < Minitest::Test
   include SamplePaymentMethods
 
   def gateway

data/test/remote/gateways/remote_epsilon_gmo_id_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class RemoteEpsilonGmoIdGatewayTest < MiniTest::Test
+class RemoteEpsilonGmoIdGatewayTest < Minitest::Test
   include SamplePaymentMethods
 
   def gateway

data/test/remote/gateways/remote_epsilon_link_payment_test.rb

@@ -1,5 +1,5 @@
 require 'test_helper'
-class RemoteEpsilonLinkPaymentTest < MiniTest::Test
+class RemoteEpsilonLinkPaymentTest < Minitest::Test
   include SamplePaymentMethods
 
   def gateway
@@ -33,6 +33,16 @@ class RemoteEpsilonLinkPaymentTest < MiniTest::Test
     end
   end
 
+  def test_epsilon_link_type_with_3d_secure
+    ActiveMerchant::Billing::Base.stub(:mode, :production) do
+      VCR.use_cassette(:epsilon_link_type_with_3d_secure) do
+        response = gateway.purchase(10000, valid_epsilon_link_type_purchase_detail_for_3d_secure, false)
+
+        pp response
+      end
+    end
+  end
+
   def test_epsilon_link_type_void_successfull
     VCR.use_cassette(:epsilon_link_type_void_successfull) do
       # あらかじめ課金済ステータスの受注がイプシロン側にないと取り消しができないため、課金済の受注をイプシロン側で作成しておいた。

data/test/remote/gateways/remote_epsilon_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class RemoteEpsilonGatewayTest < MiniTest::Test
+class RemoteEpsilonGatewayTest < Minitest::Test
   include SamplePaymentMethods
 
   def gateway
@@ -351,6 +351,7 @@ class RemoteEpsilonGatewayTest < MiniTest::Test
       assert_equal true, !response.params['last_update'].empty?
       assert_equal true, !response.params['payment_code'].empty?
       assert_equal true, !response.params['item_price'].empty?
+      assert_equal true, !response.params['sales_limit_exceeded_flag'].empty?
     end
   end
 

data/test/remote/gateways/remote_epsilon_virtual_account_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class RemoteEpsilonVirtualAccountGatewayTest < MiniTest::Test
+class RemoteEpsilonVirtualAccountGatewayTest < Minitest::Test
   include SamplePaymentMethods
 
   def gateway

data/test/test_helper.rb

@@ -1,4 +1,5 @@
 require 'minitest/autorun'
+require 'minitest/mock'
 
 require 'active_merchant'
 require 'active_merchant/epsilon'
@@ -69,7 +70,7 @@ module SamplePaymentMethods
       last_name:  'YAMADA',
       number:     '4123451111111117',
       month:      '12',
-      year:       '2023',
+      year:       Time.now.year + 1,
     )
   end
 
@@ -295,6 +296,22 @@ module SamplePaymentMethods
     }
   end
 
+  def valid_epsilon_link_type_purchase_detail_for_3d_secure
+    now = Time.now
+    {
+      user_id:      "U#{Time.now.to_i}",
+      user_name:    '山田 太郎',
+      user_email:   'yamada-taro@example.com',
+      item_code:    'ITEM001',
+      item_name:    'Greate Product',
+      order_number: "O#{now.sec}#{now.usec}",
+      st_code:      '10000-0000-00000-00000-00000-00000-00000',
+      memo1:        'memo1',
+      memo2:        'memo2',
+      tds_flag:     21
+    }
+  end
+
   def invalid_epsilon_link_type_purchase_detail
     now = Time.now
     {

data/test/unit/billing/convenience_store_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class EpsilonConvenienceStoreTest < MiniTest::Test
+class EpsilonConvenienceStoreTest < Minitest::Test
   def test_blank_parameter_generate_error
     convenience_store = ActiveMerchant::Billing::ConvenienceStore.new(code: "",
                                                                       full_name_kana: "",

data/test/unit/gateways/epsilon_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class EpsilonGatewayTest < MiniTest::Test
+class EpsilonGatewayTest < Minitest::Test
   include SamplePaymentMethods
 
   def test_set_proxy_address_and_port

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: active_merchant-epsilon
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.16.0
 platform: ruby
 authors:
 - Kenichi TAKAHASHI
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-09-21 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemerchant
@@ -66,6 +65,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest-mock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -158,6 +171,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".env.sample"
+- ".github/workflows/gem_push.yml"
 - ".github/workflows/test.yml"
 - ".gitignore"
 - CHANGELOG.md
@@ -171,6 +185,7 @@ files:
 - lib/active_merchant/billing/gateways/epsilon/epsilon_base.rb
 - lib/active_merchant/billing/gateways/epsilon/epsilon_mission_code.rb
 - lib/active_merchant/billing/gateways/epsilon/epsilon_process_code.rb
+- lib/active_merchant/billing/gateways/epsilon/epsilon_risk_base_auth_params.rb
 - lib/active_merchant/billing/gateways/epsilon_convenience_store.rb
 - lib/active_merchant/billing/gateways/epsilon_gmo_id.rb
 - lib/active_merchant/billing/gateways/epsilon_link_payment.rb
@@ -194,6 +209,7 @@ files:
 - test/fixtures/vcr_cassettes/epsilon_link_type_purchase_successful.yml
 - test/fixtures/vcr_cassettes/epsilon_link_type_void_fail.yml
 - test/fixtures/vcr_cassettes/epsilon_link_type_void_successfull.yml
+- test/fixtures/vcr_cassettes/epsilon_link_type_with_3d_secure.yml
 - test/fixtures/vcr_cassettes/find_order_failure.yml
 - test/fixtures/vcr_cassettes/find_order_success.yml
 - test/fixtures/vcr_cassettes/find_user_failure.yml
@@ -241,7 +257,6 @@ homepage: http://github.com/pepabo/active_merchant-epsilon
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -256,8 +271,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Epsilon integration for ActiveMerchant.
 test_files:
@@ -277,6 +291,7 @@ test_files:
 - test/fixtures/vcr_cassettes/epsilon_link_type_purchase_successful.yml
 - test/fixtures/vcr_cassettes/epsilon_link_type_void_fail.yml
 - test/fixtures/vcr_cassettes/epsilon_link_type_void_successfull.yml
+- test/fixtures/vcr_cassettes/epsilon_link_type_with_3d_secure.yml
 - test/fixtures/vcr_cassettes/find_order_failure.yml
 - test/fixtures/vcr_cassettes/find_order_success.yml
 - test/fixtures/vcr_cassettes/find_user_failure.yml