active_median 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 38d8e44bc15d376d41dcbd21e10e48a5d64b93894120321d1a84580458a28532
-  data.tar.gz: 2869dbc3182b206b18b0e83649ec851aed9c2b846995b462ca6166db0bfd65b2
+  metadata.gz: 2fde94235a65aa88d7417686a9ac804ca31bf48cb631ce6fa1f33f82f182f683
+  data.tar.gz: bca00d9fa0e7be65745217fc1c0934de095238302eaff1ce687fd47da73ad4aa
 SHA512:
-  metadata.gz: 5a571e7dee0f23a1a13767763ed192ca3f9b3db1e66d4fa963c609c6a9c9f613701198901ba8960aae5ceddecad6b862ef84cde3fe19b271fdb669d9dc53dba5
-  data.tar.gz: 0fe523c846b32a5ec8e3463c901a229cb7d00ba00cd86f7fd922d249d774c728324b4acd848b1ad06ec4120e748b9696dfe90f38ce4e4dcc7df62239c1406d58
+  metadata.gz: 4ff7c51cd683245dd808ee4ee314e20b100b944201c623bb2bb05ab490d5b90b5331de797062f152b77cffc1adfa94796a8f21558d3223b375fa4af050ac0a0f
+  data.tar.gz: 841082d44d97415a8a7c56893d286399c95fa8e601deafb26f60f97c1ad10c9f64c8199b1bc172557429738348ae99021eee742924d00797615beb9155f0e69f

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.5.0 (2024-10-07)
+
+- Fixed connection leasing for Active Record 7.2+
+- Dropped support for Ruby < 3.1 and Active Record < 7
+
 ## 0.4.1 (2023-09-20)
 
 - Added support for Trilogy

data/README.md

@@ -13,7 +13,7 @@ Supports:
 
 :fire: Uses native functions for blazing performance
 
-[![Build Status](https://github.com/ankane/active_median/workflows/build/badge.svg?branch=master)](https://github.com/ankane/active_median/actions)
+[![Build Status](https://github.com/ankane/active_median/actions/workflows/build.yml/badge.svg)](https://github.com/ankane/active_median/actions)
 
 ## Getting Started
 
@@ -105,6 +105,10 @@ db.load_extension("percentile.so") # or percentile.dylib
 db.enable_load_extension(0)
 ```
 
+## History
+
+View the [changelog](https://github.com/ankane/active_median/blob/master/CHANGELOG.md)
+
 ## Contributing
 
 Everyone is encouraged to help improve this project. Here are a few ways you can help:

data/lib/active_median/enumerable.rb

@@ -2,7 +2,7 @@ module Enumerable
   unless method_defined?(:median)
     def median(*args, &block)
       if !block && respond_to?(:scoping)
-        scoping { @klass.median(*args) }
+        scoping { klass.median(*args) }
       elsif !block && respond_to?(:with_scope)
         with_scope(self) { klass.median(*args) }
       else
@@ -15,7 +15,7 @@ module Enumerable
   unless method_defined?(:percentile)
     def percentile(*args, &block)
       if !block && respond_to?(:scoping)
-        scoping { @klass.percentile(*args) }
+        scoping { klass.percentile(*args) }
       elsif !block && respond_to?(:with_scope)
         with_scope(self) { klass.percentile(*args) }
       else

data/lib/active_median/model.rb

@@ -1,16 +1,20 @@
 module ActiveMedian
   module Model
     def median(column)
-      calculate_percentile(column, 0.5, "median")
+      connection_pool.with_connection do |connection|
+        calculate_percentile(column, 0.5, "median", connection)
+      end
     end
 
     def percentile(column, percentile)
-      calculate_percentile(column, percentile, "percentile")
+      connection_pool.with_connection do |connection|
+        calculate_percentile(column, percentile, "percentile", connection)
+      end
     end
 
     private
 
-    def calculate_percentile(column, percentile, operation)
+    def calculate_percentile(column, percentile, operation, connection)
       percentile = Float(percentile, exception: false)
       raise ArgumentError, "invalid percentile" if percentile.nil?
       raise ArgumentError, "percentile is not between 0 and 1" if percentile < 0 || percentile > 1
@@ -20,7 +24,7 @@ module ActiveMedian
       # matches table.column and column
       unless column.is_a?(Symbol) || column.is_a?(Arel::Nodes::SqlLiteral)
         column = column.to_s
-        unless /\A\w+(\.\w+)?\z/i.match(column)
+        unless /\A\w+(\.\w+)?\z/i.match?(column)
           raise ActiveRecord::UnknownAttributeReference, "Query method called with non-attribute argument(s): #{column.inspect}. Use Arel.sql() for known-safe values."
         end
       end
@@ -34,12 +38,12 @@ module ActiveMedian
         end
       # safety check
       # could quote, but want to keep consistent with Active Record
-      raise "Bad column alias: #{column_alias}. Please report a bug." unless column_alias =~ /\A[a-z0-9_]+\z/
+      raise "Bad column alias: #{column_alias}. Please report a bug." unless /\A[a-z0-9_]+\z/.match?(column_alias)
 
       # column resolution
       node = relation.send(:arel_columns, [column]).first
       node = Arel::Nodes::SqlLiteral.new(node) if node.is_a?(String)
-      column = relation.connection.visitor.accept(node, Arel::Collectors::SQLString.new).value
+      column = connection.visitor.accept(node, Arel::Collectors::SQLString.new).value
 
       # prevent SQL injection
       percentile = connection.quote(percentile)

data/lib/active_median/version.rb

@@ -1,3 +1,3 @@
 module ActiveMedian
-  VERSION = "0.4.1"
+  VERSION = "0.5.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_median
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Andrew Kane
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-20 00:00:00.000000000 Z
+date: 2024-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '7'
 description:
 email: andrew@ankane.org
 executables: []
@@ -51,14 +51,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3'
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.5.16
 signing_key:
 specification_version: 4
 summary: Median and percentile for Active Record, Mongoid, arrays, and hashes