active_median 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b551770177ca1b626f794e53a6076dcd2fd80f09
-  data.tar.gz: 94f4f4e96beaefbadba494726b7809a5ff65e649
+  metadata.gz: f2e6418a4cb5e878f7f36dec69fe4bb169b666c4
+  data.tar.gz: b0da140de2cdb3c84d4f0e8408dc13d4339de6b0
 SHA512:
-  metadata.gz: d8a51b06f6d07222bda15aeac042384bbf04d94cf1810f2bb85e32404c76b21b417912272653369c0a393d38b107eaa18ecec83418762f5b498303130511ba72
-  data.tar.gz: 78a344daee6bc290764695fa6a7b6504aec0f6392d2788dcb3767b28e5f61c3b6d5499782719e0c236db2435f6c6315c9831e49a18c7d8ca5ded9af5333455a0
+  metadata.gz: f29c2c2002f6438ab8f2d9ff209481f1785d5f8fba668ec2c0ed73bfe17deac908ca31823fb0b26e55cf06b1f9d5bab1d34d5f6c03dcd1f093adfb21fcfb271c
+  data.tar.gz: 0201efbeb295a121298a153e67f4985fee623529fcca873bbcfa8e70f5f551c90af7009a7489941014c9a0b2644cc746f9b0c18bc32cb71d40274fa4caef5f10

data/.travis.yml

@@ -12,11 +12,10 @@ notifications:
     on_failure: change
 gemfile:
   - Gemfile
-  - test/gemfiles/activerecord50.gemfile
+  - test/gemfiles/activerecord42.gemfile
   - test/gemfiles/activerecord41.gemfile
   - test/gemfiles/activerecord40.gemfile
   - test/gemfiles/activerecord32.gemfile
 matrix:
   allow_failures:
-    - gemfile: test/gemfiles/activerecord50.gemfile
     - gemfile: test/gemfiles/activerecord32.gemfile

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.1.4
+
+- Added `drop_function` method
+
 ## 0.1.3
 
 - Added support for ActiveRecord 5.0

data/Gemfile

@@ -1,4 +1,6 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in active_median.gemspec
 gemspec
+
+gem "activerecord", "~> 5.0.0"

data/README.md

@@ -22,10 +22,22 @@ Add this line to your application’s Gemfile:
 gem 'active_median'
 ```
 
-And add the `median` function to the database from the Rails console.
+And create a migration to add the `median` function to the database.
+
+```sh
+rails g migration create_median_function
+```
+
+with:
 
 ```ruby
-ActiveMedian.create_function
+def up
+  ActiveMedian.create_function
+end
+
+def down
+  ActiveMedian.drop_function
+end
 ```
 
 ## Contributing

data/Rakefile

@@ -1,7 +1,7 @@
 require "bundler/gem_tasks"
 require "rake/testtask"
 
-task :default => :test
+task default: :test
 Rake::TestTask.new do |t|
   t.libs << "test"
   t.pattern = "test/**/*_test.rb"

data/active_median.gemspec

@@ -1,19 +1,19 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'active_median/version'
+require "active_median/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "active_median"
   spec.version       = ActiveMedian::VERSION
   spec.authors       = ["Andrew Kane"]
   spec.email         = ["acekane1@gmail.com"]
-  spec.description   = %q{Median for ActiveRecord}
-  spec.summary       = %q{Median for ActiveRecord}
+  spec.description   = "Median for ActiveRecord"
+  spec.summary       = "Median for ActiveRecord"
   spec.homepage      = "https://github.com/ankane/active_median"
   spec.license       = "MIT"
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]

data/lib/active_median.rb

@@ -42,6 +42,14 @@ module ActiveMedian
     SQL
     true
   end
+
+  def self.drop_function
+    ActiveRecord::Base.connection.execute <<-SQL
+      DROP AGGREGATE IF EXISTS median(anyelement);
+      DROP FUNCTION IF EXISTS median(anyarray);
+    SQL
+    true
+  end
 end
 
 module ActiveRecord
@@ -54,7 +62,7 @@ end
 
 module ActiveRecord
   module Querying
-    delegate :median, :to => (Gem::Version.new(Arel::VERSION) >= Gem::Version.new("4.0.1") ? :all : :scoped)
+    delegate :median, to: (Gem::Version.new(Arel::VERSION) >= Gem::Version.new("4.0.1") ? :all : :scoped)
   end
 end
 
@@ -67,7 +75,7 @@ end
 module Arel
   module Expressions
     def median
-      Nodes::Median.new [self], Nodes::SqlLiteral.new('median_id')
+      Nodes::Median.new [self], Nodes::SqlLiteral.new("median_id")
     end
   end
 end
@@ -75,15 +83,17 @@ end
 module Arel
   module Visitors
     class ToSql
-      def visit_Arel_Nodes_Median o, a=nil
+      def visit_Arel_Nodes_Median(o, a = nil)
         if Gem::Version.new(Arel::VERSION) >= Gem::Version.new("6.0.0")
           aggregate "MEDIAN", o, a
         elsif a
-          "MEDIAN(#{o.distinct ? 'DISTINCT ' : ''}#{o.expressions.map { |x|
-          visit x, a }.join(', ')})#{o.alias ? " AS #{visit o.alias, a}" : ''}"
+          "MEDIAN(#{o.distinct ? 'DISTINCT ' : ''}#{o.expressions.map do |x|
+            visit x, a
+          end.join(', ')})#{o.alias ? " AS #{visit o.alias, a}" : ''}"
         else
-          "MEDIAN(#{o.distinct ? 'DISTINCT ' : ''}#{o.expressions.map { |x|
-          visit x }.join(', ')})#{o.alias ? " AS #{visit o.alias}" : ''}"
+          "MEDIAN(#{o.distinct ? 'DISTINCT ' : ''}#{o.expressions.map do |x|
+            visit x
+          end.join(', ')})#{o.alias ? " AS #{visit o.alias}" : ''}"
         end
       end
     end

data/lib/active_median/version.rb

@@ -1,3 +1,3 @@
 module ActiveMedian
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/test/active_median_test.rb

@@ -1,19 +1,18 @@
 require_relative "test_helper"
 
 class TestActiveMedian < Minitest::Test
-
   def setup
     ActiveMedian.create_function
     User.delete_all
   end
 
   def test_even
-    [1, 1, 2, 3, 4, 100].each {|n| User.create!(visits_count: n) }
+    [1, 1, 2, 3, 4, 100].each { |n| User.create!(visits_count: n) }
     assert_equal 2.5, User.median(:visits_count)
   end
 
   def test_odd
-    [1, 1, 2, 4, 100].each {|n| User.create!(visits_count: n) }
+    [1, 1, 2, 4, 100].each { |n| User.create!(visits_count: n) }
     assert_equal 2, User.median(:visits_count)
   end
 
@@ -22,13 +21,18 @@ class TestActiveMedian < Minitest::Test
   end
 
   def test_decimal
-    6.times {|n| User.create!(latitude: n * 0.1) }
+    6.times { |n| User.create!(latitude: n * 0.1) }
     assert_equal 0.25, User.median(:latitude)
   end
 
   def test_float
-    6.times {|n| User.create!(rating: n * 0.1) }
+    6.times { |n| User.create!(rating: n * 0.1) }
     assert_equal 0.25, User.median(:rating)
   end
 
+  def test_drop
+    ActiveMedian.drop_function
+    error = assert_raises(ActiveRecord::StatementInvalid) { User.median(:visits_count) }
+    assert_includes error.message, "PG::UndefinedFunction"
+  end
 end

data/test/gemfiles/{activerecord50.gemfile → activerecord42.gemfile}

@@ -3,4 +3,4 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in active_median.gemspec
 gemspec path: "../../"
 
-gem "activerecord", "~> 5.0.0.beta3"
+gem "activerecord", "~> 4.2.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_median
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Andrew Kane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-22 00:00:00.000000000 Z
+date: 2016-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -101,7 +101,7 @@ files:
 - test/gemfiles/activerecord32.gemfile
 - test/gemfiles/activerecord40.gemfile
 - test/gemfiles/activerecord41.gemfile
-- test/gemfiles/activerecord50.gemfile
+- test/gemfiles/activerecord42.gemfile
 - test/test_helper.rb
 homepage: https://github.com/ankane/active_median
 licenses:
@@ -123,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Median for ActiveRecord
@@ -132,6 +132,5 @@ test_files:
 - test/gemfiles/activerecord32.gemfile
 - test/gemfiles/activerecord40.gemfile
 - test/gemfiles/activerecord41.gemfile
-- test/gemfiles/activerecord50.gemfile
+- test/gemfiles/activerecord42.gemfile
 - test/test_helper.rb
-has_rdoc: