active_median 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd1078e7f04565325bc6055502adad0c3703eec5
-  data.tar.gz: 02266f10162a9dec2779790bb926adc0e95ae696
+  metadata.gz: 2b6d9c75498f9e09937bf9198f7b67249b2bf122
+  data.tar.gz: 49de0d0b1f1ba1e0509cf982ed97b3abebb19cf8
 SHA512:
-  metadata.gz: 99455884b48f4b78a35524fc95c8912a33cec9e3b92745577ce6583ba7acc70d4e70beddf2c9173dfc7756f79eb5a335a75d5ca36a54cdad23ceec44bf767157
-  data.tar.gz: 147c1b11f376a34407407ccc7b901a1533b4f8b1312f9142e51eab3e3d2b3ef4e21ab108f226772d7c22f2354242193fdd3b9ce4e308c4acd4897d1d204bc70a
+  metadata.gz: f93d25e49d3e9e1dbb2ba51cde3f54a8233ce9fae30710c30b76edc859b02b49eb9baa33034ecf6a97fd2569111903405fc63ffc323e2034965e81f29a6ad6f0
+  data.tar.gz: 589c9c118009bf1258aed61fcace805476549e9ca05504a0c4f21276d58e4cc97e960b4497ee3cd061d94d2a9f9d08029f114f698f55c7d5555fec6aae8290da

data/CHANGELOG.md

@@ -0,0 +1,8 @@
+## 0.1.1
+
+- 10x faster median
+- Added tests
+
+## 0.1.0
+
+- First release

data/Rakefile

@@ -1 +1,8 @@
 require "bundler/gem_tasks"
+require "rake/testtask"
+
+task :default => :test
+Rake::TestTask.new do |t|
+  t.libs << "test"
+  t.pattern = "test/**/*_test.rb"
+end

data/active_median.gemspec

@@ -18,6 +18,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.add_dependency "activerecord"
+
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "pg"
 end

data/lib/active_median.rb

@@ -4,50 +4,40 @@ require "active_record"
 module ActiveMedian
   def self.create_function
     # create median method
-    # http://www.postgresonline.com/journal/archives/67-Build-Median-Aggregate-Function-in-SQL.html
+    # http://wiki.postgresql.org/wiki/Aggregate_Median
     ActiveRecord::Base.connection.execute <<-SQL
-      CREATE OR REPLACE FUNCTION array_median(numeric[])
-        RETURNS numeric AS
+      CREATE OR REPLACE FUNCTION median(anyarray)
+         RETURNS float8 AS
       $$
-        SELECT CASE
-          WHEN array_upper($1, 1) = 0 THEN null
-          WHEN mod(array_upper($1, 1), 2) = 1 THEN asorted[ceiling(array_upper(asorted, 1) / 2.0)]
-          ELSE (
-            (
-              asorted[ceiling(array_upper(asorted, 1) / 2.0)] +
-              asorted[ceiling(array_upper(asorted, 1) / 2.0) + 1]
-            ) / 2.0
-          )
-          END
-        FROM (
-          SELECT ARRAY(
-            SELECT ($1)[n] FROM generate_series(1, array_upper($1, 1)) AS n
-            WHERE ($1)[n] IS NOT NULL ORDER BY ($1)[n]
-          ) AS asorted
-        ) AS foo;
+        WITH q AS
+        (
+           SELECT val
+           FROM unnest($1) val
+           WHERE VAL IS NOT NULL
+           ORDER BY 1
+        ),
+        cnt AS
+        (
+          SELECT COUNT(*) AS c FROM q
+        )
+        SELECT AVG(val)::float8
+        FROM
+        (
+          SELECT val FROM q
+          LIMIT  2 - MOD((SELECT c FROM cnt), 2)
+          OFFSET GREATEST(CEIL((SELECT c FROM cnt) / 2.0) - 1,0)
+        ) q2;
       $$
-        LANGUAGE SQL;
+      LANGUAGE sql IMMUTABLE;
 
       DROP AGGREGATE IF EXISTS median(numeric);
-      CREATE AGGREGATE median(numeric) (
-        SFUNC=array_append,
-        STYPE=numeric[],
-        FINALFUNC=array_median
-      );
-    SQL
-    ActiveRecord::Base.connection.execute <<-SQL
-      CREATE OR REPLACE FUNCTION array_median(double precision[])
-        RETURNS double precision AS
-      $$
-        SELECT array_median($1::numeric[])::double precision;
-      $$
-        LANGUAGE SQL;
-
       DROP AGGREGATE IF EXISTS median(double precision);
-      CREATE AGGREGATE median(double precision) (
+      DROP AGGREGATE IF EXISTS median(anyelement);
+      CREATE AGGREGATE median(anyelement) (
         SFUNC=array_append,
-        STYPE=double precision[],
-        FINALFUNC=array_median
+        STYPE=anyarray,
+        FINALFUNC=median,
+        INITCOND='{}'
       );
     SQL
     true

data/lib/active_median/version.rb

@@ -1,3 +1,3 @@
 module ActiveMedian
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/test/active_median_test.rb

@@ -0,0 +1,34 @@
+require "test_helper"
+
+class TestActiveMedian < Minitest::Test
+
+  def setup
+    ActiveMedian.create_function
+    User.delete_all
+  end
+
+  def test_even
+    6.times {|n| User.create!(visits_count: n) }
+    assert_equal 2.5, User.median(:visits_count)
+  end
+
+  def test_odd
+    5.times {|n| User.create!(visits_count: n) }
+    assert_equal 2, User.median(:visits_count)
+  end
+
+  def test_empty
+    assert_nil User.median(:visits_count)
+  end
+
+  def test_decimal
+    6.times {|n| User.create!(latitude: n * 0.1) }
+    assert_equal 0.25, User.median(:latitude)
+  end
+
+  def test_float
+    6.times {|n| User.create!(rating: n * 0.1) }
+    assert_equal 0.25, User.median(:rating)
+  end
+
+end

data/test/test_helper.rb

@@ -0,0 +1,15 @@
+require "bundler/setup"
+Bundler.require :default
+require "minitest/autorun"
+require "minitest/pride"
+
+ActiveRecord::Base.establish_connection adapter: "postgresql", database: "active_median_test"
+
+ActiveRecord::Migration.create_table :users, force: true do |t|
+  t.integer :visits_count
+  t.decimal :latitude
+  t.float :rating
+end
+
+class User < ActiveRecord::Base
+end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: active_median
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Andrew Kane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-13 00:00:00.000000000 Z
+date: 2014-08-13 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pg
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Median for ActiveRecord
 email:
 - acekane1@gmail.com
@@ -46,6 +74,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -53,6 +82,8 @@ files:
 - active_median.gemspec
 - lib/active_median.rb
 - lib/active_median/version.rb
+- test/active_median_test.rb
+- test/test_helper.rb
 homepage: https://github.com/ankane/active_median
 licenses:
 - MIT
@@ -73,8 +104,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Median for ActiveRecord
-test_files: []
+test_files:
+- test/active_median_test.rb
+- test/test_helper.rb
+has_rdoc: