active_mcp 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9f18994ffb431e43b365012a42a156596c09d0b1fef51352c7280363df3baddc
-  data.tar.gz: ab39f6b59b7a14510d1f3bc1c18b8f8e854de8ec6055d7592671b7fa1e586382
+  metadata.gz: f768454eb918802f12f22205183172abcddeee402f1747c0223810e0622945f5
+  data.tar.gz: 336a6e84d15e9899240ef15de5912063cfe7729848a3617cf584cf987603d4d4
 SHA512:
-  metadata.gz: b9cf091830ad128b958570361b252a396d9778d6eeaec596bbc22e88dd53bd16770726320928600c8d5e6ec7adc1adf436ab574a6355ec21a276ee15e4b6ccc1
-  data.tar.gz: e7f65722c824d17de80903e899efa552733e747b64ca5abfdc8c44dc73e37ae74d50d7481974dc543c3daed0315050a761115956233f78ccfc1fd55f7eb9a23c
+  metadata.gz: 5a9db4bc9729b90fdc34caf1aae7715c73bb9596162641d34e5ca0ca12f03cac1b1b8576def4198bdc59d1967a4184377a1ee9dbf050d73d82c69385b8a2df40
+  data.tar.gz: 7027f29f2402272a75cce1e96791e4218b006558787efdbe6aa0ddadb93bc0ff84aa82afc36523eda1b16ba5d264f6e5be8df47316adb9f1b69d3b60ab691ddf

data/README.md

@@ -1,7 +1,9 @@
-# Active Context
+# Active MCP
 
 A Ruby on Rails engine that provides [Model Context Protocol (MCP)](https://modelcontextprotocol.io/) capabilities to Rails applications. This gem allows you to easily create and expose MCP-compatible tools from your Rails application.
 
+![Active MCP](./docs/active_mcp.png)
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -54,6 +56,7 @@ end
 3. Start the MCP server:
 
 ```ruby
+# server.rb
 server = ActiveMcp::Server.new(
   name: "ActiveMcp DEMO",
   uri: 'https://your-app.example.com/mcp'
@@ -61,6 +64,19 @@ server = ActiveMcp::Server.new(
 server.start
 ```
 
+4. Set up MCP Client
+
+```json
+{
+  "mcpServers": {
+    "active-mcp-demo": {
+      "command": "/path/to/ruby",
+      "args": ["/path/to/server.rb"]
+    }
+  }
+}
+```
+
 ## Rails Generators
 
 MCP Rails provides generators to help you quickly create new MCP tools:

data/lib/active_mcp/server/protocol_handler.rb

@@ -17,9 +17,11 @@ module ActiveMcp
           request = JSON.parse(message, symbolize_names: true)
           handle_request(request)
         rescue JSON::ParserError => e
-          error_response(nil, ErrorCode::PARSE_ERROR, "Invalid JSON: #{e.message}")
+          log_error("JSON parse error", e)
+          error_response(nil, ErrorCode::PARSE_ERROR, "Invalid JSON format")
         rescue => e
-          error_response(nil, ErrorCode::INTERNAL_ERROR, e.message)
+          log_error("Internal error during message processing", e)
+          error_response(nil, ErrorCode::INTERNAL_ERROR, "An internal error occurred")
         end
 
         json_result = JSON.generate(result).force_encoding("UTF-8") if result
@@ -123,7 +125,8 @@ module ActiveMcp
 
           success_response(request[:id], result)
         rescue => e
-          error_response(request[:id], ErrorCode::INTERNAL_ERROR, e.message)
+          log_error("Error calling tool #{name}", e)
+          error_response(request[:id], ErrorCode::INTERNAL_ERROR, "An error occurred while calling the tool")
         end
       end
 
@@ -162,6 +165,18 @@ module ActiveMcp
         response[:error][:data] = data if data
         response
       end
+      
+      def log_error(message, error)
+        error_details = "#{message}: #{error.message}\n"
+        error_details += error.backtrace.join("\n") if error.backtrace
+        
+        if defined?(Rails)
+          Rails.logger.error(error_details)
+        else
+          # Fallback to standard error output if Rails is not available
+          $stderr.puts(error_details)
+        end
+      end
     end
   end
 end

data/lib/active_mcp/server/tool_manager.rb

@@ -35,7 +35,43 @@ module ActiveMcp
 
       def invoke_tool(name, arguments)
         require "net/http"
-        uri = URI.parse(@uri.to_s)
+        
+        # URIの検証
+        unless @uri.is_a?(URI) || @uri.is_a?(String)
+          log_error("Invalid URI type", StandardError.new("URI must be a String or URI object"))
+          return {
+            isError: true,
+            content: [{type: "text", text: "Invalid URI configuration"}]
+          }
+        end
+        
+        begin
+          uri = URI.parse(@uri.to_s)
+          
+          # 有効なスキームとホストの検証
+          unless uri.scheme =~ /\Ahttps?\z/ && !uri.host.nil?
+            log_error("Invalid URI", StandardError.new("URI must have a valid scheme and host"))
+            return {
+              isError: true,
+              content: [{type: "text", text: "Invalid URI configuration"}]
+            }
+          end
+          
+          # 本番環境ではHTTPSを強制
+          if defined?(Rails) && Rails.env.production? && uri.scheme != "https"
+            return {
+              isError: true,
+              content: [{type: "text", text: "HTTPS is required in production environment"}]
+            }
+          end
+        rescue URI::InvalidURIError => e
+          log_error("Invalid URI format", e)
+          return {
+            isError: true,
+            content: [{type: "text", text: "Invalid URI format"}]
+          }
+        end
+        
         request = Net::HTTP::Post.new(uri)
         request.body = JSON.generate({
           method: "tools/call",
@@ -67,9 +103,11 @@ module ActiveMcp
             }
           end
         rescue => e
+          # ログに詳細を記録
+          log_error("Error calling tool", e)
           {
             isError: true,
-            content: [{type: "text", text: "Error calling tool: #{e.message}"}]
+            content: [{type: "text", text: "Error calling tool"}]
           }
         end
       end
@@ -78,7 +116,32 @@ module ActiveMcp
         return unless @uri
 
         require "net/http"
-        uri = URI.parse(@uri.to_s)
+        
+        # URIの検証
+        unless @uri.is_a?(URI) || @uri.is_a?(String)
+          log_error("Invalid URI type", StandardError.new("URI must be a String or URI object"))
+          return
+        end
+        
+        begin
+          uri = URI.parse(@uri.to_s)
+          
+          # 有効なスキームとホストの検証
+          unless uri.scheme =~ /\Ahttps?\z/ && !uri.host.nil?
+            log_error("Invalid URI", StandardError.new("URI must have a valid scheme and host"))
+            return
+          end
+          
+          # 本番環境ではHTTPSを強制
+          if defined?(Rails) && Rails.env.production? && uri.scheme != "https"
+            log_error("HTTPS is required in production environment", StandardError.new("Non-HTTPS URI in production"))
+            return
+          end
+        rescue URI::InvalidURIError => e
+          log_error("Invalid URI format", e)
+          return
+        end
+        
         request = Net::HTTP::Post.new(uri)
         request.body = JSON.generate({
           method: "tools/list",
@@ -94,7 +157,8 @@ module ActiveMcp
 
           result = JSON.parse(response.body, symbolize_names: true)
           @tools = result[:result]
-        rescue
+        rescue => e
+          log_error("Error fetching tools", e)
           @tools = []
         end
       end
@@ -109,6 +173,18 @@ module ActiveMcp
           {content: [{type: "text", text: result.to_s}]}
         end
       end
+      
+      def log_error(message, error)
+        error_details = "#{message}: #{error.message}\n"
+        error_details += error.backtrace.join("\n") if error.backtrace
+        
+        if defined?(Rails)
+          Rails.logger.error(error_details)
+        else
+          # Fallback to standard error output if Rails is not available
+          $stderr.puts(error_details)
+        end
+      end
     end
   end
 end

data/lib/active_mcp/version.rb

@@ -1,3 +1,3 @@
 module ActiveMcp
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: active_mcp
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Your Name
 bindir: bin
 cert_chain: []
-date: 2025-04-02 00:00:00.000000000 Z
+date: 2025-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails