active_list 6.5.1 → 6.6.0

data/lib/active_list/exporters/open_document_spreadsheet_exporter.rb

@@ -2,22 +2,19 @@
 require 'zip'
 
 # Register ODS format unless is already set
-Mime::Type.register("application/vnd.oasis.opendocument.spreadsheet", :ods) unless defined? Mime::ODS
+Mime::Type.register('application/vnd.oasis.opendocument.spreadsheet', :ods) unless defined? Mime::ODS
 
 module ActiveList
-
   module Exporters
-
     class OpenDocumentSpreadsheetExporter < AbstractExporter
-
       DATE_ELEMENTS = {
-        "m" => "<number:month number:style=\"long\"/>",
-        "d" => "<number:day number:style=\"long\"/>",
-        "Y" => "<number:year/>"
+        'm' => "<number:month number:style=\"long\"/>",
+        'd' => "<number:day number:style=\"long\"/>",
+        'Y' => '<number:year/>'
       }
 
       def file_extension
-        "ods"
+        'ods'
       end
 
       def mime_type
@@ -27,56 +24,53 @@ module ActiveList
       def send_data_code
         xml_escape = "to_s.gsub('&', '&amp;').gsub('\\'', '&apos;').gsub('<', '&lt;').gsub('>', '&gt;')"
         xml_escape << ".force_encoding('US-ASCII')" if xml_escape.respond_to?(:force_encoding)
-        record = "r"
-        code  = generator.select_data_code(paginate: false)
+        record = 'r'
+        code = generator.select_data_code(paginate: false)
         code << "name = #{table.model.name}.model_name.human.gsub(/[^a-z0-9]/i, '_')\n"
-        code << "file = ActiveList.temporary_directory.join(name + rand(999_999_999).to_s(36) + '.#{self.file_extension}')\n"
+        code << "file = ActiveList.temporary_directory.join(name + rand(999_999_999).to_s(36) + '.#{file_extension}')\n"
         code << "FileUtils.mkdir_p(file.dirname)\n"
         code << "Zip::OutputStream.open(file) do |zile|\n"
         # MimeType in first place
         code << "  zile.put_next_entry('mimetype', nil, nil, Zip::Entry::STORED)\n"
-        code << "  zile << '#{self.mime_type}'\n"
+        code << "  zile << '#{mime_type}'\n"
 
         # Manifest
         code << "  zile.put_next_entry('META-INF/manifest.xml')\n"
-        code << "  zile << ('<?xml version=\"1.0\" encoding=\"UTF-8\"?><manifest:manifest xmlns:manifest=\"urn:oasis:names:tc:opendocument:xmlns:manifest:1.0\"><manifest:file-entry manifest:media-type=\"#{self.mime_type}\" manifest:full-path=\"/\"/><manifest:file-entry manifest:media-type=\"text/xml\" manifest:full-path=\"content.xml\"/></manifest:manifest>')\n"
+        code << "  zile << ('<?xml version=\"1.0\" encoding=\"UTF-8\"?><manifest:manifest xmlns:manifest=\"urn:oasis:names:tc:opendocument:xmlns:manifest:1.0\"><manifest:file-entry manifest:media-type=\"#{mime_type}\" manifest:full-path=\"/\"/><manifest:file-entry manifest:media-type=\"text/xml\" manifest:full-path=\"content.xml\"/></manifest:manifest>')\n"
         code << "  zile.put_next_entry('content.xml')\n"
 
         code << "  zile << ('<?xml version=\"1.0\" encoding=\"UTF-8\"?><office:document-content xmlns:office=\"urn:oasis:names:tc:opendocument:xmlns:office:1.0\" xmlns:style=\"urn:oasis:names:tc:opendocument:xmlns:style:1.0\" xmlns:text=\"urn:oasis:names:tc:opendocument:xmlns:text:1.0\" xmlns:table=\"urn:oasis:names:tc:opendocument:xmlns:table:1.0\" xmlns:draw=\"urn:oasis:names:tc:opendocument:xmlns:drawing:1.0\" xmlns:fo=\"urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0\" xmlns:xlink=\"http://www.w3.org/1999/xlink\" xmlns:dc=\"http://purl.org/dc/elements/1.1/\" xmlns:meta=\"urn:oasis:names:tc:opendocument:xmlns:meta:1.0\" xmlns:number=\"urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0\" xmlns:presentation=\"urn:oasis:names:tc:opendocument:xmlns:presentation:1.0\" xmlns:svg=\"urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0\" xmlns:chart=\"urn:oasis:names:tc:opendocument:xmlns:chart:1.0\" xmlns:dr3d=\"urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0\" xmlns:math=\"http://www.w3.org/1998/Math/MathML\" xmlns:form=\"urn:oasis:names:tc:opendocument:xmlns:form:1.0\" xmlns:script=\"urn:oasis:names:tc:opendocument:xmlns:script:1.0\" xmlns:ooo=\"http://openoffice.org/2004/office\" xmlns:ooow=\"http://openoffice.org/2004/writer\" xmlns:oooc=\"http://openoffice.org/2004/calc\" xmlns:dom=\"http://www.w3.org/2001/xml-events\" xmlns:xforms=\"http://www.w3.org/2002/xforms\" xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xmlns:field=\"urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:field:1.0\" office:version=\"1.1\"><office:scripts/>')\n"
         # Styles
-        code << "  zile << ('<office:automatic-styles>"+
-          "<style:style style:name=\"co1\" style:family=\"table-column\"><style:table-column-properties fo:break-before=\"auto\" style:use-optimal-column-width=\"true\"/></style:style>"+
-          "<style:style style:name=\"header\" style:family=\"table-cell\"><style:text-properties fo:font-weight=\"bold\" style:font-weight-asian=\"bold\" style:font-weight-complex=\"bold\"/></style:style>"+
-          "<number:date-style style:name=\"K4D\" number:automatic-order=\"true\"><number:text>"+::I18n.translate("date.formats.default").gsub(/\%./){|x| "</number:text>"+DATE_ELEMENTS[x[1..1]]+"<number:text>"} +"</number:text></number:date-style><style:style style:name=\"ce1\" style:family=\"table-cell\" style:data-style-name=\"K4D\"/>"+
-          "</office:automatic-styles>')\n"
+        code << "  zile << ('<office:automatic-styles>"\
+                "<style:style style:name=\"co1\" style:family=\"table-column\"><style:table-column-properties fo:break-before=\"auto\" style:use-optimal-column-width=\"true\"/></style:style>"\
+                "<style:style style:name=\"header\" style:family=\"table-cell\"><style:text-properties fo:font-weight=\"bold\" style:font-weight-asian=\"bold\" style:font-weight-complex=\"bold\"/></style:style>"\
+                "<number:date-style style:name=\"K4D\" number:automatic-order=\"true\"><number:text>" + ::I18n.translate('date.formats.default').gsub(/\%./) { |x| '</number:text>' + DATE_ELEMENTS[x[1..1]] + '<number:text>' } + "</number:text></number:date-style><style:style style:name=\"ce1\" style:family=\"table-cell\" style:data-style-name=\"K4D\"/>"\
+                                                                                                                                                                                                                                   "</office:automatic-styles>')\n"
 
         # Tables
         code << "  zile << ('<office:body><office:spreadsheet><table:table table:name=\"'+#{table.model.name}.model_name.human.#{xml_escape}+'\">')\n"
         code << "  zile << ('<table:table-column table:number-columns-repeated=\"#{table.exportable_columns.size}\"/>')\n"
-        code << "  zile << ('<table:table-header-rows><table:table-row>"+columns_headers.collect{|h| "<table:table-cell table:style-name=\"header\" office:value-type=\"string\"><text:p>'+(#{h}).#{xml_escape}+'</text:p></table:table-cell>"}.join+"</table:table-row></table:table-header-rows>')\n"
+        code << "  zile << ('<table:table-header-rows><table:table-row>" + columns_headers.collect { |h| "<table:table-cell table:style-name=\"header\" office:value-type=\"string\"><text:p>'+(#{h}).#{xml_escape}+'</text:p></table:table-cell>" }.join + "</table:table-row></table:table-header-rows>')\n"
         code << "  for #{record} in #{generator.records_variable_name}\n"
-        code << "    zile << ('<table:table-row>"+table.exportable_columns.collect do |column|
-          "<table:table-cell"+(if column.numeric? or column.datatype==:decimal
-                                 " office:value-type=\"float\" office:value=\"'+(#{column.datum_code(record)}).#{xml_escape}+'\""
-                               elsif column.datatype==:boolean
-                                 " office:value-type=\"boolean\" office:boolean-value=\"'+(#{column.datum_code(record)}).#{xml_escape}+'\""
-                               elsif column.datatype==:date
-                                 " office:value-type=\"date\" table:style-name=\"ce1\" office:date-value=\"'+(#{column.datum_code(record)}).#{xml_escape}+'\""
-                               else
-                                 " office:value-type=\"string\""
-                               end)+"><text:p>'+("+column.exporting_datum_code(record, true)+").#{xml_escape}+'</text:p></table:table-cell>"
-        end.join+"</table:table-row>')\n"
+        code << "    zile << ('<table:table-row>" + table.exportable_columns.collect do |column|
+          '<table:table-cell' + (if column.numeric? || column.datatype == :decimal
+                                   " office:value-type=\"float\" office:value=\"'+(#{column.datum_code(record)}).#{xml_escape}+'\""
+                                 elsif column.datatype == :boolean
+                                   " office:value-type=\"boolean\" office:boolean-value=\"'+(#{column.datum_code(record)}).#{xml_escape}+'\""
+                                 elsif column.datatype == :date
+                                   " office:value-type=\"date\" table:style-name=\"ce1\" office:date-value=\"'+(#{column.datum_code(record)}).#{xml_escape}+'\""
+                                 else
+                                   " office:value-type=\"string\""
+                                 end) + "><text:p>'+(" + column.exporting_datum_code(record, true) + ").#{xml_escape}+'</text:p></table:table-cell>"
+        end.join + "</table:table-row>')\n"
         code << "  end\n"
         code << "  zile << ('</table:table></office:spreadsheet></office:body></office:document-content>')\n"
         code << "end\n"
-        code << "send_file(file, stream: false, type: #{self.mime_type.to_s.inspect}, disposition: 'inline', filename: name+'.#{self.file_extension}')\n"
+        code << "send_file(file, stream: false, type: #{mime_type.to_s.inspect}, disposition: 'inline', filename: name+'.#{file_extension}')\n"
         # code << "File.delete(file)\n" # Removes tmp files before they explode the disk
         # raise code
-        return code
+        code
       end
-
     end
-
   end
-
 end

data/lib/active_list/generator.rb

@@ -1,17 +1,14 @@
-# encoding: UTF-8
 module ActiveList
-
   class Generator
-
     attr_accessor :table, :controller, :controller_method_name, :view_method_name, :records_variable_name
 
-    def initialize(*args, &block)
+    def initialize(*args, &_block)
       options = args.extract_options!
       @controller = options[:controller]
       name = args.shift || @controller.controller_name.to_sym
-      model = (options[:model]||name).to_s.classify.constantize
+      model = (options[:model] || name).to_s.classify.constantize
       @collection = !!(model.name == @controller.controller_name.to_s.classify)
-      @controller_method_name = "list#{'_'+name.to_s if name != @controller.controller_name.to_sym}"
+      @controller_method_name = "list#{'_' + name.to_s if name != @controller.controller_name.to_sym}"
       @view_method_name       = "_#{@controller.controller_name}_list_#{name}_tag"
       @records_variable_name  = "@#{name}"
       @table = ActiveList::Definition::Table.new(name, model, options)
@@ -20,7 +17,7 @@ module ActiveList
       else
         @table.load_default_columns
       end
-      @parameters = {sort: :to_s, dir: :to_s}
+      @parameters = { sort: :to_s, dir: :to_s }
       @parameters.merge!(page: :to_i, per_page: :to_i) if @table.paginate?
     end
 
@@ -37,15 +34,15 @@ module ActiveList
     end
 
     def controller_method_code
-      code  = "# encoding: utf-8\n"
-      code << "def #{self.controller_method_name}\n"
-      code << self.session_initialization_code.dig
+      code = "# encoding: utf-8\n"
+      code << "def #{controller_method_name}\n"
+      code << session_initialization_code.dig
       code << "  respond_to do |format|\n"
       code << "    format.html do\n"
       code << "      if request.xhr?\n"
-      code << self.renderer.remote_update_code.dig(4)
+      code << renderer.remote_update_code.dig(4)
       code << "      else\n"
-      code << "        render(inline: '<%=#{self.view_method_name}-%>')\n" # , layout: action_has_layout?
+      code << "        render(inline: '<%=#{view_method_name}-%>')\n" # , layout: action_has_layout?
       code << "      end\n"
       code << "    end\n"
       for format, exporter in ActiveList::Exporters.hash
@@ -55,40 +52,40 @@ module ActiveList
       end
       code << "  end\n"
       # Save preferences of user
-      if defined? User and User.instance_methods.include? :pref
-        code << "  p = current_user.pref('list.#{self.view_method_name}', YAML::dump({}))\n"
+      if defined?(User) && User.instance_methods.include?(:preference)
+        code << "  p = current_user.preference('list.#{view_method_name}', YAML::dump({}))\n"
         code << "  p.set! YAML::dump(#{var_name(:params)}.stringify_keys)\n"
       end
       code << "end\n"
       # code.split("\n").each_with_index{|l, x| puts((x+1).to_s.rjust(4)+": "+l)}
       unless ::Rails.env.production?
-        file = ::Rails.root.join("tmp", "code", "active_list", "controllers", self.controller.controller_path, self.controller_method_name + ".rb")
+        file = ::Rails.root.join('tmp', 'code', 'active_list', 'controllers', controller.controller_path, controller_method_name + '.rb')
         FileUtils.mkdir_p(file.dirname)
         File.write(file, code)
       end
-      return code
+      code
     end
 
     def view_method_code
-      code  = "# encoding: utf-8\n"
-      code << "def #{self.view_method_name}(options={}, &block)\n"
-      code << self.session_initialization_code.dig
-      code << self.renderer.build_table_code.dig
+      code = "# encoding: utf-8\n"
+      code << "def #{view_method_name}(options={}, &block)\n"
+      code << session_initialization_code.dig
+      code << renderer.build_table_code.dig
       code << "end\n"
       # code.split("\n").each_with_index{|l, x| puts((x+1).to_s.rjust(4)+": "+l)}
       unless ::Rails.env.production?
-        file = ::Rails.root.join("tmp", "code", "active_list", "views", self.controller.controller_path, self.view_method_name + ".rb")
+        file = ::Rails.root.join('tmp', 'code', 'active_list', 'views', controller.controller_path, view_method_name + '.rb')
         FileUtils.mkdir_p(file.dirname)
         File.write(file, code)
       end
-      return code
+      code
     end
 
     def session_initialization_code
-      code  = "options = {} unless options.is_a? Hash\n"
+      code = "options = {} unless options.is_a? Hash\n"
       code << "options.update(params)\n"
-      if defined? User and User.instance_methods.include? :pref
-        code << "#{var_name(:params)} = YAML::load(current_user.pref('list.#{self.view_method_name}', YAML::dump({})).value).symbolize_keys\n"
+      if defined?(User) && User.instance_methods.include?(:preference)
+        code << "#{var_name(:params)} = YAML::load(current_user.preference('list.#{view_method_name}', YAML::dump({})).value).symbolize_keys\n"
         code << "#{var_name(:params)} = {} unless #{var_name(:params)}.is_a?(Hash)\n"
       else
         code << "#{var_name(:params)} = {}\n"
@@ -97,11 +94,11 @@ module ActiveList
       code << "unless #{var_name(:params)}[:hidden_columns].is_a? Array\n"
       code << "  #{var_name(:params)}[:hidden_columns] = #{@table.hidden_columns.map(&:name).map(&:to_sym).inspect}\n"
       code << "end\n"
-      for parameter, convertor in @parameters.sort{|a,b| a[0].to_s <=> b[0].to_s}
+      for parameter, convertor in @parameters.sort { |a, b| a[0].to_s <=> b[0].to_s }
         # expr  = "options.delete('#{@table.name}_#{parameter}') || options.delete('#{parameter}') || #{var_name(:params)}[:#{parameter}]"
         # expr += " || #{@table.options[parameter]}" unless @table.options[parameter].blank?
         # code << "#{var_name(:params)}[:#{parameter}] = (#{expr}).#{convertor}\n"
-        expr  = "#{var_name(:params)}[:#{parameter}]"
+        expr = "#{var_name(:params)}[:#{parameter}]"
         expr = "(#{expr} || #{@table.options[parameter]})" unless @table.options[parameter].blank?
         code << "#{var_name(:params)}[:#{parameter}] = #{expr}.#{convertor}\n"
       end
@@ -109,16 +106,14 @@ module ActiveList
 
       # Order
       code << "#{var_name(:order)} = #{@table.options[:order] ? @table.options[:order].inspect : 'nil'}\n"
-      code << "if #{var_name(:col)} = {" + @table.sortable_columns.collect{|c| "'#{c.sort_id}' => '#{c.sort_expression}'"}.join(', ') + "}[#{var_name(:params)}[:sort]]\n"
+      code << "if #{var_name(:col)} = {" + @table.sortable_columns.collect { |c| "'#{c.sort_id}' => '#{c.sort_expression}'" }.join(', ') + "}[#{var_name(:params)}[:sort]]\n"
       code << "  #{var_name(:params)}[:dir] = 'asc' unless #{var_name(:params)}[:dir] == 'asc' or #{var_name(:params)}[:dir] == 'desc'\n"
       code << "  #{var_name(:order)} = #{var_name(:col)} + ' ' + #{var_name(:params)}[:dir]\n"
       code << "end\n"
 
-      return code
+      code
     end
-
   end
-
 end
 
-require "active_list/generator/finder"
+require 'active_list/generator/finder'

data/lib/active_list/generator/finder.rb

@@ -1,15 +1,13 @@
 module ActiveList
-
   # Manage data query
   class Generator
-
     # Generate select code for the table taking all parameters in account
     def select_data_code(options = {})
-      paginate = (options.has_key?(:paginate) ? options[:paginate] : @table.paginate?)
+      paginate = (options.key?(:paginate) ? options[:paginate] : @table.paginate?)
       # Check order
       unless @table.options.keys.include?(:order)
         columns = @table.table_columns
-        @table.options[:order] = (columns.any? ? columns.first.name.to_sym : {id: :desc})
+        @table.options[:order] = (columns.any? ? columns.first.name.to_sym : { id: :desc })
       end
 
       class_name = @table.model.name
@@ -17,17 +15,17 @@ module ActiveList
 
       # Find data
       query_code = "#{class_name}"
-      query_code << self.scope_code if self.scope_code
-      query_code << ".select(#{self.select_code})" if self.select_code
-      query_code << ".where(#{self.conditions_code})" unless @table.options[:conditions].blank?
+      query_code << scope_code if scope_code
+      query_code << ".select(#{select_code})" if select_code
+      query_code << ".where(#{conditions_code})" unless @table.options[:conditions].blank?
       query_code << ".joins(#{@table.options[:joins].inspect})" unless @table.options[:joins].blank?
-      unless self.includes_reflections.empty?
-        expr = self.includes_reflections.inspect[1..-2]
+      unless includes_reflections.empty?
+        expr = includes_reflections.inspect[1..-2]
         query_code << ".includes(#{expr})"
         query_code << ".references(#{expr})"
       end
 
-      code  = ""
+      code = ''
       code << "#{var_name(:count)} = #{query_code}.count\n"
 
       query_code << ".reorder(#{var_name(:order)})"
@@ -48,16 +46,15 @@ module ActiveList
         code << "#{var_name(:offset)} = (#{var_name(:page)} - 1) * #{var_name(:limit)}\n"
         code << "#{var_name(:last)}   = (#{var_name(:count)}.to_f / #{var_name(:limit)}).ceil.to_i\n"
         code << "#{var_name(:last)}   = 1 if #{var_name(:last)} < 1\n"
-        
 
-        code << "return #{self.view_method_name}(options.merge(page: 1)) if 1 > #{var_name(:page)}\n"
-        code << "return #{self.view_method_name}(options.merge(page: #{var_name(:last)})) if #{var_name(:page)} > #{var_name(:last)}\n"
+        code << "return #{view_method_name}(options.merge(page: 1)) if 1 > #{var_name(:page)}\n"
+        code << "return #{view_method_name}(options.merge(page: #{var_name(:last)})) if #{var_name(:page)} > #{var_name(:last)}\n"
         query_code << ".offset(#{var_name(:offset)})"
         query_code << ".limit(#{var_name(:limit)})"
       end
 
-      code << "#{self.records_variable_name} = #{query_code} || {}\n"
-      return code
+      code << "#{records_variable_name} = #{query_code} || {}\n"
+      code
     end
 
     protected
@@ -65,25 +62,21 @@ module ActiveList
     # Compute includes Hash
     def includes_reflections
       hash = []
-      for column in @table.columns
-        if column.respond_to?(:reflection)
-          hash << column.reflection.name
-        end
+      @table.columns.each do |column|
+        hash << column.reflection.name if column.respond_to?(:reflection)
       end
-      return hash
+      hash
     end
 
-
     def scope_code
       return nil unless scopes = @table.options[:scope]
       scopes = [scopes].flatten
-      code  = ""
-      for scope in scopes
+      code = ''
+      scopes.each do |scope|
         code << ".#{scope}"
       end
-      return code
+      code
     end
-    
 
     # Generate the code from a conditions option
     def conditions_code
@@ -92,44 +85,43 @@ module ActiveList
       case conditions
       when Array
         case conditions[0]
-        when String  # SQL
+        when String # SQL
           code << '[' + conditions.first.inspect
-          code << conditions[1..-1].collect{|p| ", " + sanitize_condition(p)}.join if conditions.size > 1
+          code << conditions[1..-1].collect { |p| ', ' + sanitize_condition(p) }.join if conditions.size > 1
           code << ']'
         when Symbol # Method
-          raise "What?"
-          code << conditions.first.to_s + '('
-          code << conditions[1..-1].collect{|p| sanitize_condition(p)}.join(', ') if conditions.size > 1
-          code << ')'
+          fail 'What?'
+        # code << conditions.first.to_s + '('
+        # code << conditions[1..-1].collect { |p| sanitize_condition(p) }.join(', ') if conditions.size > 1
+        # code << ')'
         else
-          raise ArgumentError.new("First element of an Array can only be String or Symbol.")
+          fail ArgumentError, 'First element of an Array can only be String or Symbol.'
         end
       when Hash # SQL
-        code << '{' + conditions.collect{|key, value| key.to_s + ': ' + sanitize_condition(value)}.join(',') + '}'
+        code << '{' + conditions.collect { |key, value| key.to_s + ': ' + sanitize_condition(value) }.join(',') + '}'
       when Symbol # Method
-        code << conditions.to_s + "(options)"
+        code << conditions.to_s + '(options)'
       when CodeString
-        code << "(" + conditions.gsub(/\s*\n\s*/, ';') + ")"
+        code << '(' + conditions.gsub(/\s*\n\s*/, ';') + ')'
       when String
         code << conditions.inspect
       else
-        raise ArgumentError.new("Unsupported type for conditions: #{conditions.inspect}")
+        fail ArgumentError, "Unsupported type for conditions: #{conditions.inspect}"
       end
-      return code
+      code
     end
 
     def select_code
-      return nil unless @table.options[:distinct] or @table.options[:select]
-      code  = ""
-      code << "DISTINCT " if @table.options[:distinct]
+      return nil unless @table.options[:distinct] || @table.options[:select]
+      code = ''
+      code << 'DISTINCT ' if @table.options[:distinct]
       code << "#{@table.model.table_name}.*"
       if @table.options[:select]
-        code << @table.options[:select].collect{|k, v| ", #{k[0].to_s+'.'+k[1].to_s} AS #{v}" }.join
+        code << @table.options[:select].collect { |k, v| ", #{k[0].to_s + '.' + k[1].to_s} AS #{v}" }.join
       end
-      return ("'" + code + "'").c
+      ("'" + code + "'").c
     end
 
-
     def sanitize_condition(value)
       # if value.is_a? Array
       #   # if value.size==1 and value[0].is_a? String
@@ -150,12 +142,5 @@ module ActiveList
         value.inspect
       end
     end
-
-
   end
-
-
 end
-
-
-

data/lib/active_list/helpers.rb

@@ -1,21 +1,20 @@
 module ActiveList
   module Helpers
-
     def recordify!(value, record_name)
       if value.is_a?(Symbol)
-        return record_name + "." + value.to_s
+        return record_name + '.' + value.to_s
       elsif value.is_a?(CodeString)
-        return "(" + value.gsub(/RECORD/, record_name) + ")"
+        return '(' + value.gsub(/RECORD/, record_name) + ')'
       else
-        raise ArgumentError, "CodeString or Symbol must be given to be recordified)"
+        fail ArgumentError, 'CodeString or Symbol must be given to be recordified)'
       end
     end
 
     def recordify(value, record_name)
       if value.is_a?(Symbol)
-        return record_name + "." + value.to_s
+        return record_name + '.' + value.to_s
       elsif value.is_a?(CodeString)
-        return "(" + value.gsub(/RECORD/, record_name) + ")"
+        return '(' + value.gsub(/RECORD/, record_name) + ')'
       else
         return value.inspect
       end
@@ -23,11 +22,10 @@ module ActiveList
 
     def urlify(value, record_name)
       if value.is_a?(CodeString)
-        return "(" + value.gsub(/RECORD/, record_name) + ")"
+        return '(' + value.gsub(/RECORD/, record_name) + ')'
       else
         return value.inspect
       end
     end
-
   end
 end