active_job_status 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5431b8cc6fed8a99592123c01fc9357cf4a46192
-  data.tar.gz: bd92db0a996e02e8ac1cabdb1af6d9e8092de953
+  metadata.gz: 84db9cd64e705477457dc8a26e5eb933feafc0db
+  data.tar.gz: f9d888e8d8bdfff969f85fa00a8c461053ee9fdd
 SHA512:
-  metadata.gz: 1e081751d977356a0315b686321c526e02ddc881b5e8624c59434a187bb40625aa452ca31188a6d7905550eadb93dd0c2f8c03d02390c3c3913f61e4da730480
-  data.tar.gz: 88df222fab4619634fe7073fc024b691c649bbd22df91c5261a9f304e3eaff9117f35ab2a05ff903e6c303a002650f5baa86884c8fd74758f51868a85daefb0f
+  metadata.gz: 071d38cda3a6c6d94ba193f2e0e838a13b989633b229fd2c0fecb11b4b04e8c260a963ee88ca747096a1f3aea286b4831b29f25886f3a2ee20b68a6efd122aa8
+  data.tar.gz: 5bc2c62021717551fa696a5bf5db14a6e1826b2617cca1d262674dddc46402b403fa9770fcde807e68e251bb783d156e5a368cbfade6f18efcfd8d667be0b64b

data/CHANGELOG.md

@@ -1,4 +1,7 @@
 # ActiveJobStatus
+## 1.2.1
+- Fixes bug with JobBatch#completed? (https://github.com/cdale77/active_job_status/pull/19)
+
 ## 1.2.0
 - Add support for Rails 5
 - Adds many small improvements (see https://github.com/cdale77/active_job_status/pull/15)
@@ -8,7 +11,7 @@
 
 ## 1.0.0
 - Move TrackableJob inside ActiveJobStatus namespace. Bump version to 1.0.0, as
-  this may be a breaking change for some users. 
+  this may be a breaking change for some users.
 
 ## 0.0.5
 - Use ActiveSupport::Cache instead of Redis, reducing dependencies. Changes

data/lib/active_job_status/job_batch.rb

@@ -34,9 +34,9 @@ module ActiveJobStatus
     end
 
     def completed?
-      @job_ids.map do |job_id|
+      !@job_ids.map do |job_id|
         job_status = ActiveJobStatus.get_status(job_id)
-        job_status == nil || job_status == :completed
+        job_status != nil && job_status != :completed
       end.any?
     end
 

data/lib/active_job_status/version.rb

@@ -1,3 +1,3 @@
 module ActiveJobStatus
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/spec/job_batch_spec.rb

@@ -57,6 +57,11 @@ describe ActiveJobStatus::JobBatch do
       update_store(id_array: total_jobs, job_status: :working)
       expect(batch.completed?).to be_falsey
     end
+    it "should be false with mixed jobs status of working and completed" do
+      update_store_mixed_status(id_array: total_jobs, 
+                                job_status_array: [:working, :completed])
+      expect(batch.completed?).to be_falsey
+    end
     it "should be true when jobs are all completed" do
       update_store(id_array: total_jobs, job_status: :completed)
       expect(batch.completed?).to be_truthy
@@ -109,6 +114,13 @@ describe ActiveJobStatus::JobBatch do
     end
   end
 
+  def update_store_mixed_status(id_array: [], job_status_array: [:queued])
+    n_element = job_status_array.count
+    id_array.each_with_index do |id, index|
+      store.write(id, job_status_array[index % n_element].to_s)
+    end
+  end
+
   def clear_store(id_array: [])
     id_array.each do |id|
       store.delete(id)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_job_status
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Brad Johnson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-04 00:00:00.000000000 Z
+date: 2016-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler