active_job_status 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0f5b9c6307f29a9c2f63d672cb9e3df1ebc8803e
-  data.tar.gz: 400d59fc1f9d4b8d850f43e3e1faf7a356784242
+  metadata.gz: 4ea8bac2bfeb93d6844f4771f4bf9706735831ce
+  data.tar.gz: 176590db71f11445b8fc2a82b9b2ff53af8fc65e
 SHA512:
-  metadata.gz: ebde3b55fb024aa7663618ae10602e174ff548edb8917aa20af92ebd933147fb9faca42612556b727aa95f050e194c0db57f6732a5d7a7124db4fa21690cd721
-  data.tar.gz: 65b0f469ebb6c015cb5f7683e28b9c55fab8cdcc2fc1ffa1f0da70e84b34e5f6315c8e04118d995267623aac38845141a949e31260b9a7e7059c23926f0fefea
+  metadata.gz: 8baecc6e6ab0a989125c51c35aa1c17fd0a4de621b1263e7b2bf8f5f8e03b5717732e3745878c72c8b1380990ab1f29e8fb0197d40e75cb5f9861c08fba2b952
+  data.tar.gz: e3a0a23cc6dd05e7c2be3175f521c4d71abe39e3f182577e55089d0801c5c61e11c9574c882e54d65f0aa8ec4727b979517a1bac5e2698ce5df7437174516273

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+# ActiveJobStatus
+
+## 0.0.4
+- Change name of JobStatus::get_status argument batch_key to be batch_id
+- Add changelog

data/README.md

@@ -50,14 +50,14 @@ exists, its jobs will be overwritten with the supplied list.
 
     my_key = "230923asdlkj230923"
     my_jobs = [my_first_job.job_id, my_second_job.job_id]
-    my_batch = ActiveJobStatus::JobBatch.new(batch_key: my_key, job_ids: my_jobs)
+    my_batch = ActiveJobStatus::JobBatch.new(batch_id: my_key, job_ids: my_jobs)
 
 Batches expire after 72 hours (259200 seconds).
 You can change that by passing the initalizer an integer value (in seconds).
 
     my_key = "230923asdlkj230923"
     my_jobs = [my_first_job.job_id, my_second_job.job_id]
-    my_batch = ActiveJobStatus::JobBatch.new(batch_key: my_key,
+    my_batch = ActiveJobStatus::JobBatch.new(batch_id: my_key,
                                              job_ids: my_jobs,
                                              expire_in: 500000)
 
@@ -73,7 +73,7 @@ And you can ask the batch if all the jobs are completed or not.
 
 You can ask the batch for other bits of information.
 
-    batch.batch_key
+    batch.batch_id
     # => "230923asdlkj230923"
     batch.job_ids
     # => ["b67af7a0-3ed2-4661-a2d5-ff6b6a254886", "6c0216b9-ea0c-4ee9-a3b2-501faa919a66"]

data/lib/active_job_status/job_batch.rb

@@ -1,22 +1,22 @@
 module ActiveJobStatus
   class JobBatch
 
-    attr_reader :batch_key
+    attr_reader :batch_id
     attr_reader :job_ids
     attr_reader :expire_in
 
-    def initialize(batch_key:, job_ids:, expire_in: 259200)
-      @batch_key = batch_key
+    def initialize(batch_id:, job_ids:, expire_in: 259200)
+      @batch_id = batch_id
       @job_ids = job_ids
       @expire_in = expire_in
-      ActiveJobStatus.redis.del(@batch_key) # delete any old batches
-      ActiveJobStatus.redis.sadd(@batch_key, @job_ids)
-      ActiveJobStatus.redis.expire(@batch_key, @expire_in)
+      ActiveJobStatus.redis.del(@batch_id) # delete any old batches
+      ActiveJobStatus.redis.sadd(@batch_id, @job_ids)
+      ActiveJobStatus.redis.expire(@batch_id, @expire_in)
     end
 
     def add_jobs(job_ids:)
       @job_ids = @job_ids + job_ids
-      ActiveJobStatus.redis.sadd(@batch_key, job_ids)
+      ActiveJobStatus.redis.sadd(@batch_id, job_ids)
     end
 
     def completed?
@@ -27,8 +27,8 @@ module ActiveJobStatus
       !job_statuses.any?
     end
 
-    def self.find(batch_key:)
-      ActiveJobStatus.redis.smembers(batch_key)
+    def self.find(batch_id:)
+      ActiveJobStatus.redis.smembers(batch_id)
     end
   end
 end

data/lib/active_job_status/version.rb

@@ -1,3 +1,3 @@
 module ActiveJobStatus
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/job_batch_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 
 describe ActiveJobStatus::JobBatch do
 
-  let!(:batch_key) { Time.now }
+  let!(:batch_id) { Time.now }
 
   let!(:redis) { ActiveJobStatus.redis }
 
@@ -15,7 +15,7 @@ describe ActiveJobStatus::JobBatch do
   let!(:addl_jobs) { [job3.job_id, job4.job_id] }
   let!(:total_jobs) { first_jobs + addl_jobs }
 
-  let!(:batch) { ActiveJobStatus::JobBatch.new(batch_key: batch_key,
+  let!(:batch) { ActiveJobStatus::JobBatch.new(batch_id: batch_id,
                                               job_ids: first_jobs) }
 
   describe "#initialize" do
@@ -24,7 +24,7 @@ describe ActiveJobStatus::JobBatch do
     end
     it "should create a redis set" do
       first_jobs.each do |job_id|
-        expect(redis.smembers(batch_key)).to include job_id
+        expect(redis.smembers(batch_id)).to include job_id
       end
     end
   end
@@ -33,7 +33,7 @@ describe ActiveJobStatus::JobBatch do
     it "should add jobs to the set" do
       batch.add_jobs(job_ids: addl_jobs)
       total_jobs.each do |job_id|
-        expect(ActiveJobStatus::JobBatch.find(batch_key: batch_key)).to \
+        expect(ActiveJobStatus::JobBatch.find(batch_id: batch_id)).to \
           include job_id
       end
     end
@@ -56,31 +56,31 @@ describe ActiveJobStatus::JobBatch do
 
   describe "::find" do
     it "should return an array of jobs when a batch exists" do
-      expect(ActiveJobStatus::JobBatch.find(batch_key: batch_key)).to \
+      expect(ActiveJobStatus::JobBatch.find(batch_id: batch_id)).to \
         be_an_instance_of Array
     end
     it "should return the correct jobs" do
-      expect(ActiveJobStatus::JobBatch.find(batch_key: batch_key)).to \
+      expect(ActiveJobStatus::JobBatch.find(batch_id: batch_id)).to \
         eq first_jobs
     end
     it "should return nil when no batch exists" do
-      expect(ActiveJobStatus::JobBatch.find(batch_key: "45")).to eq []
+      expect(ActiveJobStatus::JobBatch.find(batch_id: "45")).to eq []
     end
   end
 
   describe "expiring job" do
     it "should allow the expiration time to be set in seconds" do
-      expect(ActiveJobStatus::JobBatch.new(batch_key: "newkey",
+      expect(ActiveJobStatus::JobBatch.new(batch_id: "newkey",
                                             job_ids: first_jobs,
                                             expire_in: 200000)).to \
             be_an_instance_of ActiveJobStatus::JobBatch
     end
     it "should expire" do
-      ActiveJobStatus::JobBatch.new(batch_key: "expiry",
+      ActiveJobStatus::JobBatch.new(batch_id: "expiry",
                                     job_ids: first_jobs,
                                     expire_in: 1)
       sleep 2
-      expect(ActiveJobStatus::JobBatch.find(batch_key: "expiry")).to be_empty
+      expect(ActiveJobStatus::JobBatch.find(batch_id: "expiry")).to be_empty
 
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_job_status
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Brad Johnson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-08 00:00:00.000000000 Z
+date: 2015-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -118,6 +118,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md