active_job-performs 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 566acd14649609a2e16b658a93fe276f80609866c61fb37c11e720b581bc0f76
-  data.tar.gz: 5174b18e562c53966639bb16e3d729885d99f1ebe01163175a1513dded11cbff
+  metadata.gz: 360213ab324cae80fefcf276ecb9803ed8e4ec62166dc9eded626b67f8329b97
+  data.tar.gz: 92fa0c284711569f812da53e7acca9cbe15cea03aec0ccb9c2512465a7b93f39
 SHA512:
-  metadata.gz: f2fd767c6bd1c66d26a046e84dea4cd2ea0bfdb0ec50452699151e90fba9856b14875ab1a98371cf2727423a31871db4af432a965784a9cf61d92b58917ce0d2
-  data.tar.gz: cd9628dce5378c14ecae35da1fc83ae4487ea0ece02a5e4a78226572778ca7d370c5975e99ff880fa9bf030f026c244d1d3cf2abac838fb7d1bec373f7327cbf
+  metadata.gz: 16fd7671e6eaeba29bac333597170661ca5333c3e14e3142ba910579316641dc2e2ba31f3fdd49508e5e0263a3fc67b34032e4ef61bb1b1a8dc3679a6a9ec26b
+  data.tar.gz: 353e3cf1bc646e32883352a2f4ebb80121987e415872ce9d0e32256fcbed7f559e66576a1ee15b71e2fec3930d54f362a5b8905cd502cac7daf4df7b618191e3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    active_job-performs (0.3.2)
+    active_job-performs (0.3.3)
       activejob (>= 6.1)
 
 GEM

data/README.md

@@ -13,7 +13,7 @@ class Post < ApplicationRecord
 end
 ```
 
-Then we build a job for the instance method and define a `post.publish_later` instance method, and more:
+Here's what `performs` generates under the hood:
 
 ```ruby
 class Post < ApplicationRecord
@@ -25,12 +25,12 @@ class Post < ApplicationRecord
     def perform(post, *, **) = post.publish(*, **)
   end
 
-  # On Rails 7.1, where `ActiveJob.perform_all_later` exists, we also generate
+  # On Rails 7.1+, where `ActiveJob.perform_all_later` exists, we also generate
   # a bulk method to enqueue many jobs at once. So you can do this:
   #
   #   Post.unpublished.in_batches.each(&:publish_later_bulk)
-  def self.publish_later_bulk
-    ActiveJob.perform_all_later all.map { PublishJob.new(_1) }
+  def self.publish_later_bulk(set = all)
+    ActiveJob.perform_all_later set.map { PublishJob.new(_1) }
   end
 
   # We generate `publish_later` to wrap the job execution forwarding arguments and options.
@@ -55,7 +55,12 @@ end
 > [!TIP]
 > On that last point, `performs` does put more logic back within your Active Records, so if you need further encapsulation to prevent them growing too large, consider checking out [active_record-associated_object](https://github.com/kaspth/active_record-associated_object).
 
-### Praise from people
+### Used in production & praise from people
+
+The https://www.rubyevents.org team uses `ActiveJob::Performs` quite a bit:
+
+- [See `performs` calls in RubyEvents](https://github.com/search?q=repo%3Arubyevents%2Frubyevents+performs+language%3ARuby&type=code&l=Ruby)
+
 
 Here's what [@claudiob](https://github.com/claudiob) had to say after using `ActiveJob::Performs`:
 
@@ -85,7 +90,7 @@ class Post < ActiveRecord::Base
   extend ActiveJob::Performs # We technically auto-extend ActiveRecord::Base, but other object hierarchies need this.
 
   # `performs` builds a `Post::PublishJob` and routes configs over to it.
-  performs :publish, queue_as: :important, discard_on: SomeError do
+  performs :publish, queue_adapter: :sidekiq, queue_as: :important, discard_on: SomeError do
     retry_on TimeoutError, wait: :polynomially_longer
   end
 
@@ -104,6 +109,7 @@ class Post < ActiveRecord::Base
 
   # Individual method jobs inherit from the `Post::Job` defined above.
   class PublishJob < Job
+    self.queue_adapter = :sidekiq
     queue_as :important
     discard_on SomeError
     retry_on TimeoutError, wait: :polynomially_longer
@@ -122,8 +128,8 @@ class Post < ActiveRecord::Base
   # Or pass in a subset of posts as an argument:
   #
   #   Post.publish_later_bulk Post.unpublished
-  def self.publish_later_bulk
-    ActiveJob.perform_all_later all.map { PublishJob.new(_1) }
+  def self.publish_later_bulk(set = all)
+    ActiveJob.perform_all_later set.map { PublishJob.new(_1) }
   end
 
   # We generate `publish_later` to wrap the job execution.
@@ -137,6 +143,9 @@ class Post < ActiveRecord::Base
 end
 ```
 
+> [!NOTE]
+> We prefer & call `{name}=` setter methods, but fall back to getters. That's how we support `self.queue_adapter=`, but also `queue_as` which is not configured via `queue_as=`.
+
 We generate the `Post::Job` class above to share configuration between method level jobs. E.g. if you had a `retract` method that was setup very similar, you could do:
 
 ```ruby

data/lib/active_job/performs/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveJob
   module Performs
-    VERSION = "0.3.2"
+    VERSION = "0.3.3"
   end
 end

data/lib/active_job/performs.rb

@@ -5,18 +5,14 @@ require_relative "performs/version"
 module ActiveJob; end
 module ActiveJob::Performs
   module Waiting
-    def Proc(value)
-      value.respond_to?(:call) ? value : proc { value }
-    end unless Kernel.respond_to?(:Proc) # Optimistically assume Ruby gets this and it'll work fine.
+    attr_reader :wait, :wait_until
 
-    def wait(value = nil)
-      @wait = Proc(value) if value
-      @wait
+    def wait=(value)
+      @wait = value.respond_to?(:call) ? value : proc { value }
     end
 
-    def wait_until(value = nil)
-      @wait_until = Proc(value) if value
-      @wait_until
+    def wait_until=(value)
+      @wait_until = value.respond_to?(:call) ? value : proc { value }
     end
 
     def scoped_by_wait(record)
@@ -69,9 +65,13 @@ module ActiveJob::Performs
       name.safe_constantize || const_set(name, Class.new(yield))
     end
 
-    def apply_performs_to(job_class, **configs, &block)
-      configs.each { job_class.public_send(_1, _2) }
-      job_class.class_exec(&block) if block_given?
+    def apply_performs_to(job, **configs, &block)
+      job.class_exec(&block) if block_given?
+
+      configs.each do |name, value|
+        name = "#{name}=".then.find { job.respond_to? _1 } || name
+        job.public_send name, value
+      end
     end
 
     def performs_later_methods

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: active_job-performs
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Kasper Timm Hansen
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-16 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -24,7 +23,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '6.1'
-description:
 email:
 - hey@kaspth.com
 executables: []
@@ -47,7 +45,6 @@ metadata:
   homepage_uri: https://github.com/kaspth/active_job-performs
   source_code_uri: https://github.com/kaspth/active_job-performs
   changelog_uri: https://github.com/kaspth/active_job-performs/blob/main/CHANGELOG.md
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -62,8 +59,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.18
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: ActiveJob::Performs adds the `performs` macro to set up jobs by convention.
 test_files: []