active_interaction 5.1.0 → 5.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c740eef14e1c0bca42f4bbb5b3718c879bc3af038f40953a60a53007611916e5
-  data.tar.gz: b0a3738aa38869c7be559d72f23e958d0f9e66c0f490652bd8a92e1ef449e48e
+  metadata.gz: b90b2dc28188b224ed0aa986afb739056dbd2407061da2dfee81b825c5674ca9
+  data.tar.gz: 755707a0f9554cee89a08567245f3d78d597a8b7ae7ec671c3eb572f4dd5a881
 SHA512:
-  metadata.gz: f998483eb21ec13a43dcf3c7b6805f7865b3dd7b4d8fbc9846263338d676c41c7991a602dd3a82e13a9b93a027cbeccd5648a87fef688964124935d38d9ef6c4
-  data.tar.gz: 4669a1e76a427af4a62415f242bfdc3fa45f7a63c5a43de704b7849639841f365e83168b5c1db68ab067ca2104f8f7ec580baa487e5caa6035196607033c79f8
+  metadata.gz: d24433ef35282b38531e2e18c1e426f69f9cc71692fdb2d96e21f3c420b56a6bb42c3f473b255890b457ab3d1764d6b132ec7f30260437d732ced70b083d217a
+  data.tar.gz: dd2ce32a0c59afa9f5fe1a8134aa82e98404b1e0d5a3a3801b8dd7a726f75f28d16de46c72687c3e5f807db0576936e0a34abe3b26201dd2c58c90c798df10d5

data/CHANGELOG.md

@@ -1,3 +1,21 @@
+# [5.2.0][] (2022-10-22)
+
+## Added
+
+- Added translation for Spanish. Thanks @matiasasis!
+
+## Fixed
+
+- [#545][] - Arrays passed in are no longer modified. Thanks @jonkgrimes!
+
+## Added
+
+# [5.1.1][] (2022-09-01)
+
+## Fixed
+
+- [#539][] - Fixed a caching error in default values.
+
 # [5.1.0][] (2022-07-28)
 
 ## Added
@@ -1112,6 +1130,8 @@ Example.run
 
 - Initial release.
 
+  [5.2.0]: https://github.com/AaronLasseigne/active_interaction/compare/v5.1.1...v5.2.0
+  [5.1.1]: https://github.com/AaronLasseigne/active_interaction/compare/v5.1.0...v5.1.1
   [5.1.0]: https://github.com/AaronLasseigne/active_interaction/compare/v5.0.0...v5.1.0
   [5.0.0]: https://github.com/AaronLasseigne/active_interaction/compare/v4.1.0...v5.0.0
   [4.1.0]: https://github.com/AaronLasseigne/active_interaction/compare/v4.0.6...v4.1.0
@@ -1339,3 +1359,5 @@ Example.run
   [#503]: https://github.com/AaronLasseigne/active_interaction/issues/503
   [#536]: https://github.com/AaronLasseigne/active_interaction/issues/536
   [#537]: https://github.com/AaronLasseigne/active_interaction/issues/537
+  [#539]: https://github.com/AaronLasseigne/active_interaction/issues/539
+  [#545]: https://github.com/AaronLasseigne/active_interaction/issues/545

data/README.md

@@ -65,13 +65,13 @@ handles your verbs.
 Add it to your Gemfile:
 
 ``` rb
-gem 'active_interaction', '~> 5.1'
+gem 'active_interaction', '~> 5.2'
 ```
 
 Or install it manually:
 
 ``` sh
-$ gem install active_interaction --version '~> 5.1'
+$ gem install active_interaction --version '~> 5.2'
 ```
 
 This project uses [Semantic Versioning][]. Check out [GitHub releases][] for a

data/lib/active_interaction/filter.rb

@@ -112,24 +112,21 @@ module ActiveInteraction
     # @raise [NoDefaultError] If the default is missing.
     # @raise [InvalidDefaultError] If the default is invalid.
     def default(context = nil)
-      return @default if defined?(@default)
-
       raise NoDefaultError, name unless default?
 
       value = raw_default(context)
       raise InvalidDefaultError, "#{name}: #{value.inspect}" if value.is_a?(GroupedInput)
 
-      @default =
-        if value.nil?
-          nil
-        else
-          default = process(value, context)
-          if default.errors.any? && default.errors.first.is_a?(Filter::Error)
-            raise InvalidDefaultError, "#{name}: #{value.inspect}"
-          end
-
-          default.value
+      if value.nil?
+        nil
+      else
+        default = process(value, context)
+        if default.errors.any? && default.errors.first.is_a?(Filter::Error)
+          raise InvalidDefaultError, "#{name}: #{value.inspect}"
         end
+
+        default.value
+      end
     end
 
     # Get the description.

data/lib/active_interaction/filters/array_filter.rb

@@ -49,7 +49,7 @@ module ActiveInteraction
       children = []
 
       unless filters.empty?
-        value.map! do |item|
+        value = value.map do |item|
           result = filters[:'0'].process(item, context)
           children.push(result)
           result.value

data/lib/active_interaction/locale/es.yml

@@ -0,0 +1,23 @@
+es:
+  active_interaction:
+    errors:
+      messages:
+        invalid: es inválido
+        invalid_type: no es un %{type} válido
+        missing: es requerido
+    types:
+      array: array
+      boolean: boolean
+      date: date
+      date_time: date time
+      decimal: decimal
+      file: file
+      float: float
+      hash: hash
+      integer: integer
+      interface: interface
+      object: object
+      record: record
+      string: string
+      symbol: symbol
+      time: time

data/lib/active_interaction/version.rb

@@ -4,5 +4,5 @@ module ActiveInteraction
   # The version number.
   #
   # @return [Gem::Version]
-  VERSION = Gem::Version.new('5.1.0')
+  VERSION = Gem::Version.new('5.2.0')
 end

data/spec/active_interaction/filter_spec.rb

@@ -36,4 +36,25 @@ describe ActiveInteraction::Filter, :filter do
       end
     end
   end
+
+  describe '#default' do
+    subject(:filter) { ActiveInteraction::IntegerFilter.new(:test, default: default) }
+
+    context 'when it is a value' do
+      let(:default) { 1 }
+
+      it 'returns the default' do
+        expect(filter.default).to be 1
+      end
+    end
+
+    context 'when it is a proc' do
+      let(:default) { -> { i + 1 } }
+
+      it 'returns the default' do
+        expect(filter.default(double(i: 0))).to be 1 # rubocop:disable RSpec/VerifiedDoubles
+        expect(filter.default(double(i: 1))).to be 2 # rubocop:disable RSpec/VerifiedDoubles
+      end
+    end
+  end
 end

data/spec/active_interaction/filters/array_filter_spec.rb

@@ -74,6 +74,11 @@ describe ActiveInteraction::ArrayFilter, :filter do
       it 'returns the transformed value' do
         expect(result.value).to eql [:test]
       end
+
+      it 'does not modify the original value' do
+        expect(result.value.object_id).to_not eql value.object_id
+        expect(value).to eql ['test']
+      end
     end
 
     context 'with a nested filter' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_interaction
 version: !ruby/object:Gem::Version
-  version: 5.1.0
+  version: 5.2.0
 platform: ruby
 authors:
 - Aaron Lasseigne
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-07-28 00:00:00.000000000 Z
+date: 2022-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -242,6 +242,7 @@ files:
 - lib/active_interaction/input.rb
 - lib/active_interaction/inputs.rb
 - lib/active_interaction/locale/en.yml
+- lib/active_interaction/locale/es.yml
 - lib/active_interaction/locale/fr.yml
 - lib/active_interaction/locale/it.yml
 - lib/active_interaction/locale/ja.yml