active_interaction 4.1.0 → 5.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 557de518b6e1a33937d70d31e6c29dd6179384372e082595f8087b3efcdae784
-  data.tar.gz: 2ba312b6ddc61043acbc8bcb48dbbc4a60010be6701a5a368325d0a14fc4c557
+  metadata.gz: 1205bfc3c95589bd74fdb6395e09573c01210a95bf5d6644b70fef11cacea914
+  data.tar.gz: 2494a61529d645f6dcfaef940e4d54e404bda94eb78eabbac605dcc14221e422
 SHA512:
-  metadata.gz: 28674a0400c7bd8dafaae7430f1609fdbd3cd93e3ca5c60a07d2df2970b825a7e218d2482026f0a6365ba11fdd6518830fdfb96f496909ee7d8cb63154c5b8e7
-  data.tar.gz: e527210922d3e9af79ff3c61f2e5d1ba873fe9eb31be543ffd640d255f69de19b40d0621ff9900db19e3cf3f553c8cfbcf583954385d2c8a3db2f24a747037f7
+  metadata.gz: 6037171bd7f2ddc2af0204e2af5fdf0140725678698e7c4fa27875f16446c7c8be0b69aa83da30626bf9fe96ae00a5f76ffc92274cfd9654abad355e611df7ed
+  data.tar.gz: fac17df5266c5a72809fbc32ab3e84d840b35fe59cb2d483511b27c46beaec197b5a5e669d740ef023bf064df82a8ac8d5cbcd94bba60b3c5e0ba72969b385c2

data/CHANGELOG.md

@@ -1,3 +1,145 @@
+# [5.1.1][] (2022-09-01)
+
+## Fixed
+
+- [#539][] - Fixed a caching error in default values.
+
+# [5.1.0][] (2022-07-28)
+
+## Added
+
+- Limit dependencies to the minimum requirements.
+
+## Fixed
+
+- [#536][] - `compose` accepts `Inputs`.
+- [#537][] - Arrays with nested filters returned the wrong value.
+
+# [5.0.0][] (2022-06-24)
+
+## Changed
+
+- Drop support for JRuby.
+- Drop support for Ruby 2.5 and 2.6, adding support for 3.1
+- Drop support for Rails 5.0 and 5.1
+- `ActiveInteraction::Inputs` no longer inherits from `Hash` though it still has most of the methods
+  provided by `Hash` (methods that write were removed).
+- Removed `Filter#clean` (use `Filter#process` and call `#value` on the result)
+- The `given?` method has been moved onto `inputs`. ([how to upgrade](#given))
+- [#503][] - The record filter now treats blank strings value as `nil`. This was missed in the 4.0 update.
+- The `type_check` callback has been renamed to `filter` to better match the reality of what it does.
+  ([how to upgrade](#filter-callback))
+- `ActiveIneraction::FilterColumn` is now `ActiveInteraction::Filter::Column`
+- Errors on the array filter will now be indexed if the Rails config `index_nested_attribute_errors`
+  is `true` or the `:index_errors` option is set to `true`. The `:index_errors` option always overrides
+  the Rails config.
+- Invalid nested errors (`:invalid_nested`) are gone. Instead the nested errors will appear as they would
+  in Rails if they were a `has_many` relationship being assigned attributes through a parent.
+  ([how to upgrade](#nested-hash-errors))
+
+## Added
+
+- `Filter#process` which returns an `Input`.
+
+## Fixed
+
+- When passing an `ActiveRecord::Relation` in an array filter with no inner
+  filter, the value returned was an `ActiveRecord::Relation` instead of an
+  Array.
+
+## Upgrading
+
+### `given?`
+
+The `given?` method can now be found on `inputs`. It works the same as before.
+
+```ruby
+# 4.1
+class Example < ActiveInteraction::Base
+  string :name, default: nil
+
+  def execute
+    given?(:name)
+  end
+end
+
+# 5.0
+class Example < ActiveInteraction::Base
+  string :name, default: nil
+
+  def execute
+    inputs.given?(:name)
+  end
+end
+```
+
+### Filter Callback
+
+You'll need to rename any `:type_check` callbacks to `:filter`.
+
+```ruby
+# 4.1
+set_callback :type_check, :before, -> { puts 'before type check' }
+
+# 5.0
+set_callback :filter, :before, -> { puts 'before type check' }
+```
+
+### Nested Hash Errors
+
+Nested hash errors no longer add an error as through it happened on the hash.
+They now use the error in its original form and attach the name of the hash to
+the error. It is also not limited to returning one error.
+
+```ruby
+class HashInteraction < ActiveInteraction::Base
+  hash :mailing_lists do
+    boolean :marketing
+    boolean :product_updates
+  end
+
+  def execute
+    # ...
+  end
+end
+
+> outcome = HashInteraction.run(mailing_lists: {})
+
+# 4.1
+> outcome.errors.details
+# => {:mailing_lists=>[{:error=>:invalid_nested, :name=>"\"marketing\"", :value=>"nil"}]},
+> outcome.errors.messages
+# => {:mailing_lists=>["has an invalid nested value (\"marketing\" => nil)"]}
+> outcome.errors.full_messages
+# => ["Mailing lists has an invalid nested value (\"marketing\" => nil)"]
+
+# 5.0
+> outcome.errors.details
+# => {:"mailing_lists.marketing"=>[{:error=>:missing}], :"mailing_lists.product_updates"=>[{:error=>:missing}]}
+> outcome.errors.messages
+# => {:"mailing_lists.marketing"=>["is required"], :"mailing_lists.product_updates"=>["is required"]}
+> outcome.errors.full_messages
+# => ["Mailing lists marketing is required", "Mailing lists product updates is required"]
+```
+
+I18n can handle these values the same as nested values in Rails:
+
+```yml
+en:
+  active_interaction:
+    attributes:
+      hash_interaction/mailing_lists:
+        marketing: 'Mailing list "Marketing"'
+        product_updates: 'Mailing list "Product Updates"'
+```
+
+Using the same example from above:
+
+```ruby
+> outcome.errors.full_messages
+# => ["Mailing list \"Marketing\" is required", "Mailing list \"Product Updates\" is required"]
+```
+
 # [4.1.0][] (2021-12-30)
 
 ## Added
@@ -68,7 +210,7 @@
 
 ## Added
 
-- Implicit coercion of types are now supported in filters (e.g. to_str, to_int,
+- Implicit coercion of types are now supported in filters (e.g. `to_str`, `to_int`,
   etc).
 - The `interface` and `record` filters, when used as an inner filter for an
   `array`, will have their `from/class` option set to a singularized version of
@@ -976,6 +1118,9 @@ Example.run
 
 - Initial release.
 
+  [5.1.1]: https://github.com/AaronLasseigne/active_interaction/compare/v5.1.0...v5.1.1
+  [5.1.0]: https://github.com/AaronLasseigne/active_interaction/compare/v5.0.0...v5.1.0
+  [5.0.0]: https://github.com/AaronLasseigne/active_interaction/compare/v4.1.0...v5.0.0
   [4.1.0]: https://github.com/AaronLasseigne/active_interaction/compare/v4.0.6...v4.1.0
   [4.0.6]: https://github.com/AaronLasseigne/active_interaction/compare/v4.0.5...v4.0.6
   [4.0.5]: https://github.com/AaronLasseigne/active_interaction/compare/v4.0.4...v4.0.5
@@ -1198,3 +1343,7 @@ Example.run
   [#480]: https://github.com/AaronLasseigne/active_interaction/issues/480
   [#515]: https://github.com/AaronLasseigne/active_interaction/issues/515
   [#518]: https://github.com/AaronLasseigne/active_interaction/issues/518
+  [#503]: https://github.com/AaronLasseigne/active_interaction/issues/503
+  [#536]: https://github.com/AaronLasseigne/active_interaction/issues/536
+  [#537]: https://github.com/AaronLasseigne/active_interaction/issues/537
+  [#539]: https://github.com/AaronLasseigne/active_interaction/issues/539

data/CONTRIBUTING.md

@@ -1,13 +1,21 @@
-# Steps
+# Contributing
+
+Bug fixes and optimizations are welcome.
+For optimizations please provide some reproducable proof of the improvement.
+
+For features please open a [discussion][] and we can make sure the feature fits with the gem before working on it.
+
+## Steps
 
 1. [Fork][] the repo.
 2. Add a breaking test for your change.
 3. Make the tests pass.
 4. Push your fork.
-5. Submit a pull request.
+5. Submit a pull request against the `next` branch.
 
-# Code Style
+## Code Style
 
 Running the tests using `rake` (with no args) will also check for style issues in the code. Ideally all submissions would pass these checks. If the code style is causing issues (particularly the method or class size) we can work with you to correct it. Don't let it stop you from contributing.
 
 [fork]: https://github.com/AaronLasseigne/active_interaction/fork
+[discussion]: https://github.com/AaronLasseigne/active_interaction/discussions/categories/ideas