active_interaction 3.5.0 → 3.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c2eca96d7ec5eccc82c4321445f7c0e009a0d8e6
-  data.tar.gz: '048a0f22cd8c0e2071eb1428aff2cd9c88be0482'
+  metadata.gz: efaabefa03827c037549d3199559e79028e01014
+  data.tar.gz: c31b3dfde06e95dd679771e2719300c3ceeb155a
 SHA512:
-  metadata.gz: a67fa88d500066873e6c4626d21fd76c5cf322989fab2fb9ab52f076ce7353d2e22856c4b40b204f23570bfd2d9f218f2c5d2289c77207f43d2a5c21dd557eb7
-  data.tar.gz: 24daf7828183f8093ea7aa19709a0b49f5f8f9f263cf997dd9c5ed32ae5e45beb7267ad892efff27d5318a67c5c6e75f1f31d9048e734284aabf0da4fbdbb65a
+  metadata.gz: e89ce8aa7c3d8ffa79de7720444086a425edc0e287ac0a87d96b5b987bc5275af0c916eef480f59f66b57b0be6c29a0b2c094bb0719de5156d0acb6a7b005bd5
+  data.tar.gz: cc04bc1579b22405deba56144038f681bbb99b3db413382bc5126a703a761e711fafbc23fb32dca99271472492619dd58ffec5f1b8628e28c71b8a16ac8f4415

data/lib/active_interaction/base.rb

@@ -2,7 +2,6 @@
 # frozen_string_literal: true
 
 require 'active_support/core_ext/hash/indifferent_access'
-require 'set'
 
 module ActiveInteraction
   # @abstract Subclass and override {#execute} to implement a custom
@@ -277,9 +276,7 @@ module ActiveInteraction
       @_interaction_inputs = inputs
 
       inputs.each do |key, value|
-        raise InvalidValueError, key.inspect if InputProcessor.reserved?(key)
-
-        populate_reader(key, value)
+        populate_reader(key, value) unless InputProcessor.reserved?(key)
       end
 
       populate_filters(InputProcessor.process(inputs))

data/lib/active_interaction/errors.rb

@@ -48,13 +48,6 @@ module ActiveInteraction
   # @return [Class]
   NoDefaultError = Class.new(Error)
 
-  # Raised if a reserved name is used.
-  #
-  # @return [Class]
-  #
-  # @since 1.2.0
-  ReservedNameError = Class.new(Error)
-
   # Raised if a user-supplied value to a nested hash input is invalid.
   #
   # @return [Class]

data/lib/active_interaction/modules/input_processor.rb

@@ -14,13 +14,13 @@ module ActiveInteraction
 
       def reserved?(name)
         name.to_s.start_with?('_interaction_') ||
-          Base.instance_methods.include?(name) ||
-          Base.private_instance_methods.include?(name)
+          Base.method_defined?(name) ||
+          Base.private_method_defined?(name)
       end
 
       def process(inputs)
         inputs.stringify_keys.sort.each_with_object({}) do |(k, v), h|
-          raise ReservedNameError, k.inspect if reserved?(k)
+          next if reserved?(k)
 
           if (match = GROUPED_INPUT_PATTERN.match(k))
             assign_to_group!(h, *match.captures, v)

data/lib/active_interaction/version.rb

@@ -6,5 +6,5 @@ module ActiveInteraction
   # The version number.
   #
   # @return [Gem::Version]
-  VERSION = Gem::Version.new('3.5.0')
+  VERSION = Gem::Version.new('3.5.1')
 end

data/spec/active_interaction/base_spec.rb

@@ -35,20 +35,11 @@ describe ActiveInteraction::Base do
   subject(:interaction) { described_class.new(inputs) }
 
   describe '.new(inputs = {})' do
-    it 'does not allow :_interaction_* as an option' do
-      key = :"_interaction_#{SecureRandom.hex}"
+    it 'does not set instance vars for reserved input names' do
+      key = :execute
       inputs[key] = nil
-      expect do
-        interaction
-      end.to raise_error ActiveInteraction::InvalidValueError
-    end
 
-    it 'does not allow "_interaction_*" as an option' do
-      key = "_interaction_#{SecureRandom.hex}"
-      inputs[key] = nil
-      expect do
-        interaction
-      end.to raise_error ActiveInteraction::InvalidValueError
+      expect(interaction.instance_variable_defined?(:"@#{key}")).to be false
     end
 
     context 'with invalid inputs' do

data/spec/active_interaction/modules/input_processor_spec.rb

@@ -74,10 +74,8 @@ describe ActiveInteraction::InputProcessor do
     context 'with a reserved name' do
       before { inputs[:_interaction_key] = :value }
 
-      it 'raises an error' do
-        expect do
-          result
-        end.to raise_error ActiveInteraction::ReservedNameError
+      it 'skips the input' do
+        expect(result).to_not have_key(:_interaction_key)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_interaction
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.5.1
 platform: ruby
 authors:
 - Aaron Lasseigne
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-19 00:00:00.000000000 Z
+date: 2017-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -273,7 +273,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Manage application specific business logic.