active_interaction 1.5.0 → 1.5.1

data/lib/active_interaction.rb

@@ -51,5 +51,5 @@ I18n.load_path.unshift(*Dir[File.expand_path(
 #
 # @since 1.0.0
 #
-# @version 1.5.0
+# @version 1.5.1
 module ActiveInteraction end

data/lib/active_interaction/backports.rb

@@ -1,8 +1,7 @@
 # coding: utf-8
 
-# rubocop:disable Documentation
 module ActiveInteraction
-  class GroupedInput
+  class GroupedInput # rubocop:disable Style/Documentation
     # Required for Ruby <= 1.9.3.
     def [](name)
       send(name)
@@ -14,7 +13,7 @@ module ActiveInteraction
     end unless method_defined?(:[]=)
   end
 
-  class Errors
+  class Errors # rubocop:disable Style/Documentation
     # Required for Rails < 3.2.13.
     protected :initialize_dup
   end

data/lib/active_interaction/base.rb

@@ -240,7 +240,7 @@ module ActiveInteraction
       self.class.filters.each do |name, filter|
         begin
           public_send("#{name}=", filter.clean(inputs[name]))
-        rescue InvalidValueError, MissingValueError, InvalidNestedValueError
+        rescue Error
           # #type_check will add errors if appropriate.
         end
       end

data/lib/active_interaction/concerns/active_recordable.rb

@@ -50,9 +50,8 @@ module ActiveInteraction
     # @return [Boolean]
     #
     # @since 1.5.0
-    def has_attribute?(name) # rubocop:disable PredicateName
+    def has_attribute?(name) # rubocop:disable Style/PredicateName
       self.class.filters.key?(name.to_sym)
     end
-    # rubocop:enable PredicateName
   end
 end

data/lib/active_interaction/concerns/transactable.rb

@@ -3,10 +3,10 @@
 begin
   require 'active_record'
 rescue LoadError
-  module ActiveRecord # rubocop:disable Documentation
+  module ActiveRecord # rubocop:disable Style/Documentation
     Rollback = Class.new(ActiveInteraction::Error)
 
-    class Base # rubocop:disable Documentation
+    class Base # rubocop:disable Style/Documentation
       def self.transaction(*)
         yield
       rescue Rollback
@@ -38,7 +38,7 @@ module ActiveInteraction
       end
     end
 
-    module ClassMethods # rubocop:disable Documentation
+    module ClassMethods # rubocop:disable Style/Documentation
       # @param klass [Class]
       def inherited(klass)
         klass.transaction(transaction?, transaction_options.dup)

data/lib/active_interaction/errors.rb

@@ -67,7 +67,7 @@ module ActiveInteraction
     # @param filter_name [Symbol]
     # @param input_value [Object]
     def initialize(filter_name, input_value)
-      super()
+      super("#{filter_name}: #{input_value.inspect}")
 
       @filter_name = filter_name
       @input_value = input_value

data/lib/active_interaction/filters/array_filter.rb

@@ -48,7 +48,7 @@ module ActiveInteraction
       super do |klass, names, options|
         filter = klass.new(name.to_s.singularize.to_sym, options, &block)
 
-        validate(filter, names)
+        validate!(filter, names)
 
         filters[filter.name] = filter
       end
@@ -71,7 +71,7 @@ module ActiveInteraction
     # @param names [Array<Symbol>]
     #
     # @raise [InvalidFilterError]
-    def validate(filter, names)
+    def validate!(filter, names)
       unless filters.empty?
         fail InvalidFilterError, 'multiple filters in array block'
       end
@@ -80,11 +80,11 @@ module ActiveInteraction
         fail InvalidFilterError, 'attribute names in array block'
       end
 
-      # rubocop:disable GuardClause
       if filter.default?
         fail InvalidDefaultError, 'default values in array block'
       end
-      # rubocop:enable GuardClause
+
+      nil
     end
   end
 end

data/lib/active_interaction/filters/model_filter.rb

@@ -49,7 +49,7 @@ module ActiveInteraction
     #
     # @return [Boolean]
     def matches?(value)
-      @klass === value || # rubocop:disable CaseEquality
+      @klass === value || # rubocop:disable Style/CaseEquality
         value.is_a?(@klass)
     end
   end

data/lib/active_interaction/version.rb

@@ -5,5 +5,5 @@ module ActiveInteraction
   # The version number.
   #
   # @return [Gem::Version]
-  VERSION = Gem::Version.new('1.5.0')
+  VERSION = Gem::Version.new('1.5.1')
 end

data/spec/active_interaction/concerns/active_recordable_spec.rb

@@ -2,14 +2,14 @@
 
 require 'spec_helper'
 
-InteractionWithFilter = Class.new(TestInteraction) do
+InteractionWithFloatFilter = Class.new(TestInteraction) do
   float :thing
 end
 
 describe ActiveInteraction::ActiveRecordable do
   include_context 'interactions'
 
-  let(:described_class) { InteractionWithFilter }
+  let(:described_class) { InteractionWithFloatFilter }
 
   describe '#column_for_attribute(name)' do
     let(:column) { outcome.column_for_attribute(name) }

data/spec/active_interaction/errors_spec.rb

@@ -145,8 +145,7 @@ describe ActiveInteraction::Errors do
                 }
               }
             }
-          }
-        )
+          })
 
         other.add_sym(:attribute, :invalid_type, type: nil)
       end

data/spec/active_interaction/i18n_spec.rb

@@ -85,8 +85,7 @@ describe I18nInteraction do
             }
           },
           types: TYPES.each_with_object({}) { |e, a| a[e] = e.reverse }
-        }
-      )
+        })
 
       @locale = I18n.locale
       I18n.locale = 'hsilgne'

data/spec/active_interaction/integration/interface_interaction_spec.rb

@@ -4,9 +4,18 @@ require 'spec_helper'
 require 'json'
 require 'yaml'
 
-describe 'InterfaceInteraction' do
+InterfaceInteraction = Class.new(TestInteraction) do
+  interface :anything
+end
+
+describe InterfaceInteraction do
+  include_context 'interactions'
   it_behaves_like 'an interaction',
     :interface,
     -> { [JSON, YAML].sample },
     methods: [:dump, :load]
+
+  it 'succeeds when given nil' do
+    expect { result }.to_not raise_error
+  end
 end

data/spec/active_interaction/integration/model_interaction_spec.rb

@@ -2,6 +2,15 @@
 
 require 'spec_helper'
 
-describe 'ModelInteraction' do
+ModelInteraction = Class.new(TestInteraction) do
+  model :object
+end
+
+describe ModelInteraction do
+  include_context 'interactions'
   it_behaves_like 'an interaction', :model, -> { // }, class: Regexp
+
+  it 'succeeds when given nil' do
+    expect { result }.to_not raise_error
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_interaction
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Aaron Lasseigne
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-05 00:00:00.000000000 Z
+date: 2015-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -37,112 +37,112 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.9'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.7'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '4.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '4.5'
 - !ruby/object:Gem::Dependency
   name: guard-rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: kramdown
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.3'
+        version: '10.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.3'
+        version: '10.4'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.28'
+        version: '0.30'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.28'
+        version: '0.30'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -157,7 +157,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
-description: Manage application specific business logic.
+description: |2
+      ActiveInteraction manages application-specific business logic. It is an
+      implementation of the command pattern in Ruby.
 email:
 - aaron.lasseigne@gmail.com
 - taylor@fausak.me
@@ -166,6 +168,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - CHANGELOG.md
+- CONTRIBUTING.md
 - LICENSE.txt
 - README.md
 - lib/active_interaction.rb
@@ -250,7 +253,7 @@ files:
 - spec/support/concerns.rb
 - spec/support/filters.rb
 - spec/support/interactions.rb
-homepage: http://orgsync.github.io/active_interaction/
+homepage: http://devblog.orgsync.com/active_interaction/
 licenses:
 - MIT
 metadata: {}
@@ -270,7 +273,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Manage application specific business logic.