active_interaction 0.9.0 → 0.9.1

data/spec/active_interaction/integration/string_interaction_spec.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 require 'spec_helper'
 
 describe 'StringInteraction' do

data/spec/active_interaction/integration/symbol_interaction_spec.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 require 'spec_helper'
 
 describe 'SymbolInteraction' do

data/spec/active_interaction/integration/time_interaction_spec.rb

@@ -1,26 +1,28 @@
+# coding: utf-8
+
 require 'spec_helper'
 
-class TimeZone
+TimeZone = Class.new do
   def self.at(*args)
     TimeWithZone.at(*args)
   end
 end
 
-class TimeWithZone
+TimeWithZone = Class.new do
   def self.at(*args)
-    self.new(Time.at(*args))
+    new(Time.at(*args))
   end
 
   def initialize(time)
     @time = time
   end
 
-  def ==(time)
-    @time == time
+  def ==(other)
+    @time == other
   end
 end
 
-class TimeInteraction < ActiveInteraction::Base
+TimeInteraction = Class.new(TestInteraction) do
   time :a
 
   def execute
@@ -37,7 +39,7 @@ describe TimeInteraction do
 
     before do
       allow(Time).to receive(:zone).and_return(TimeZone)
-      options.merge!(a: a)
+      inputs.merge!(a: a)
     end
 
     it 'returns the correct value' do

data/spec/active_interaction/modules/active_model_spec.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 require 'spec_helper'
 
 describe ActiveInteraction::ActiveModel do

data/spec/active_interaction/modules/core_spec.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 require 'spec_helper'
 
 describe ActiveInteraction::Core do
@@ -31,11 +33,14 @@ describe ActiveInteraction::Core do
     end
 
     shared_examples '#run!' do
-      let(:options) { double }
+      let(:inputs) { double }
 
       it 'calls #run' do
-        expect(instance).to receive(:run).once.with(options)
-        instance.run!(options) rescue nil
+        begin
+          instance.run!(inputs)
+        rescue ActiveInteraction::InvalidInteractionError
+          expect(instance).to have_received(:run).once.with(inputs)
+        end
       end
     end
 
@@ -47,9 +52,9 @@ describe ActiveInteraction::Core do
       end
 
       it 'raises an error' do
-        expect {
+        expect do
           instance.run!
-        }.to raise_error ActiveInteraction::InvalidInteractionError
+        end.to raise_error ActiveInteraction::InvalidInteractionError
       end
     end
 
@@ -93,14 +98,14 @@ describe ActiveInteraction::Core do
       end
 
       it 'calls ActiveRecord::Base#transaction' do
-        block = Proc.new {}
+        block = proc {}
         expect(ActiveRecord::Base).to receive(:transaction).once.with(no_args)
         instance.send(:transaction, &block)
       end
 
       it 'calls ActiveRecord::Base#transaction' do
         args = [:a, :b, :c]
-        block = Proc.new {}
+        block = proc {}
         expect(ActiveRecord::Base).to receive(:transaction).once.with(*args)
         instance.send(:transaction, *args, &block)
       end

data/spec/active_interaction/modules/method_missing_spec.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 require 'spec_helper'
 
 describe ActiveInteraction::MethodMissing do
@@ -9,9 +11,9 @@ describe ActiveInteraction::MethodMissing do
       let(:slug) { :slug }
 
       it 'calls super' do
-        expect {
+        expect do
           instance.method_missing(slug)
-        }.to raise_error NameError
+        end.to raise_error NameError
       end
     end
 
@@ -24,18 +26,18 @@ describe ActiveInteraction::MethodMissing do
       end
 
       it 'yields' do
-        expect { |b|
+        expect do |b|
           instance.method_missing(slug, &b)
-        }.to yield_with_args(filter, [], {})
+        end.to yield_with_args(filter, [], {})
       end
 
       context 'with names' do
         let(:names) { [:a, :b, :c] }
 
         it 'yields' do
-          expect { |b|
+          expect do |b|
             instance.method_missing(:boolean, *names, &b)
-          }.to yield_with_args(filter, names, {})
+          end.to yield_with_args(filter, names, {})
         end
       end
 
@@ -43,9 +45,9 @@ describe ActiveInteraction::MethodMissing do
         let(:options) { { a: nil, b: false, c: true } }
 
         it 'yields' do
-          expect { |b|
+          expect do |b|
             instance.method_missing(:boolean, options, &b)
-          }.to yield_with_args(filter, [], options)
+          end.to yield_with_args(filter, [], options)
         end
       end
 
@@ -54,9 +56,9 @@ describe ActiveInteraction::MethodMissing do
         let(:options) { { a: nil, b: false, c: true } }
 
         it 'yields' do
-          expect { |b|
+          expect do |b|
             instance.method_missing(:boolean, *names, options, &b)
-          }.to yield_with_args(filter, names, options)
+          end.to yield_with_args(filter, names, options)
         end
       end
     end

data/spec/active_interaction/modules/overload_hash_spec.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 require 'spec_helper'
 
 describe ActiveInteraction::OverloadHash do
@@ -21,18 +23,18 @@ describe ActiveInteraction::OverloadHash do
 
       it 'calls method_missing' do
         hash
-        expect(subject).to have_received(:method_missing).once.
-          with(:hash, *arguments)
+        expect(subject).to have_received(:method_missing).once
+          .with(:hash, *arguments)
       end
 
       context 'with a block' do
-        let(:block) { Proc.new {} }
+        let(:block) { proc {} }
         let(:hash) { subject.hash(*arguments, &block) }
 
         it 'calls method_missing' do
           hash
-          expect(subject).to have_received(:method_missing).once.
-            with(:hash, *arguments)
+          expect(subject).to have_received(:method_missing).once
+            .with(:hash, *arguments)
         end
 
         it 'passes the block to method_missing' do

data/spec/active_interaction/modules/validation_spec.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 require 'spec_helper'
 
 describe ActiveInteraction::Validation do
@@ -16,7 +18,7 @@ describe ActiveInteraction::Validation do
     end
 
     context 'filter.cast returns a value' do
-      let(:inputs) { {name: 1} }
+      let(:inputs) { { name: 1 } }
 
       before do
         filter.stub(:cast).and_return(1)
@@ -37,7 +39,8 @@ describe ActiveInteraction::Validation do
         let(:filter) { ActiveInteraction::FloatFilter.new(:name, {}) }
 
         it 'returns an :invalid_nested error' do
-          type = I18n.translate("#{ActiveInteraction::Base.i18n_scope}.types.#{filter.class.slug.to_s}")
+          type = I18n.translate(
+            "#{ActiveInteraction::Base.i18n_scope}.types.#{filter.class.slug}")
 
           expect(result).to eq [[filter.name, :invalid, nil, type: type]]
         end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 require 'coveralls'
 Coveralls.wear!
 
@@ -10,3 +12,5 @@ RSpec.configure do |config|
   config.run_all_when_everything_filtered = true
   config.filter_run_including :focus
 end
+
+I18n.config.enforce_available_locales = true

data/spec/support/filters.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 shared_context 'filters' do
   let(:block) { nil }
   let(:name) { SecureRandom.hex.to_sym }
@@ -24,9 +26,9 @@ shared_examples_for 'a filter' do
   describe '.factory' do
     context 'with an invalid slug' do
       it 'raises an error' do
-        expect {
+        expect do
           described_class.factory(:invalid)
-        }.to raise_error ActiveInteraction::MissingFilterError
+        end.to raise_error ActiveInteraction::MissingFilterError
       end
     end
 
@@ -60,18 +62,18 @@ shared_examples_for 'a filter' do
       include_context 'required'
 
       it 'raises an error' do
-        expect {
+        expect do
           filter.cast(value)
-        }.to raise_error ActiveInteraction::MissingValueError
+        end.to raise_error ActiveInteraction::MissingValueError
       end
 
       context 'with an invalid default' do
         let(:value) { Object.new }
 
         it 'raises an error' do
-          expect {
+          expect do
             filter.cast(value)
-          }.to raise_error ActiveInteraction::InvalidValueError
+          end.to raise_error ActiveInteraction::InvalidValueError
         end
       end
     end
@@ -92,18 +94,18 @@ shared_examples_for 'a filter' do
       include_context 'required'
 
       it 'raises an error' do
-        expect {
+        expect do
           filter.clean(value)
-        }.to raise_error ActiveInteraction::MissingValueError
+        end.to raise_error ActiveInteraction::MissingValueError
       end
 
       context 'with an invalid value' do
         let(:value) { Object.new }
 
         it 'raises an error' do
-          expect {
+          expect do
             filter.clean(value)
-          }.to raise_error ActiveInteraction::InvalidValueError
+          end.to raise_error ActiveInteraction::InvalidValueError
         end
       end
     end
@@ -114,9 +116,9 @@ shared_examples_for 'a filter' do
       end
 
       it 'raises an error' do
-        expect {
+        expect do
           filter.clean(value)
-        }.to raise_error ActiveInteraction::InvalidDefaultError
+        end.to raise_error ActiveInteraction::InvalidDefaultError
       end
     end
   end
@@ -134,9 +136,9 @@ shared_examples_for 'a filter' do
       include_context 'required'
 
       it 'raises an error' do
-        expect {
+        expect do
           filter.default
-        }.to raise_error ActiveInteraction::NoDefaultError
+        end.to raise_error ActiveInteraction::NoDefaultError
       end
     end
 
@@ -146,9 +148,9 @@ shared_examples_for 'a filter' do
       end
 
       it 'raises an error' do
-        expect {
+        expect do
           filter.default
-        }.to raise_error ActiveInteraction::InvalidDefaultError
+        end.to raise_error ActiveInteraction::InvalidDefaultError
       end
     end
   end

data/spec/support/interactions.rb

@@ -1,4 +1,6 @@
-class TestInteraction < ActiveInteraction::Base
+# coding: utf-8
+
+TestInteraction = Class.new(ActiveInteraction::Base) do
   def self.name
     SecureRandom.hex
   end
@@ -8,8 +10,8 @@ class TestInteraction < ActiveInteraction::Base
 end
 
 shared_context 'interactions' do
-  let(:options) { {} }
-  let(:outcome) { described_class.run(options) }
+  let(:inputs) { {} }
+  let(:outcome) { described_class.run(inputs) }
   let(:result) { outcome.result }
 end
 
@@ -36,16 +38,16 @@ shared_examples_for 'an interaction' do |type, generator, filter_options = {}|
     end
   end
 
-  context 'without required options' do
+  context 'without required inputs' do
     it 'is invalid' do
       expect(outcome).to be_invalid
     end
   end
 
-  context 'with options[:required]' do
+  context 'with inputs[:required]' do
     let(:required) { generator.call }
 
-    before { options.merge!(required: required) }
+    before { inputs.merge!(required: required) }
 
     it 'is valid' do
       expect(outcome).to be_valid
@@ -64,7 +66,7 @@ shared_examples_for 'an interaction' do |type, generator, filter_options = {}|
     end
 
     it 'does not return nil for :default when given nil' do
-      options.merge!(default: nil)
+      inputs.merge!(default: nil)
       expect(result[:default]).to_not be_nil
     end
 
@@ -76,20 +78,20 @@ shared_examples_for 'an interaction' do |type, generator, filter_options = {}|
       expect(result[:defaults_2]).to_not be_nil
     end
 
-    context 'with options[:optional]' do
+    context 'with inputs[:optional]' do
       let(:optional) { generator.call }
 
-      before { options.merge!(optional: optional) }
+      before { inputs.merge!(optional: optional) }
 
       it 'returns the correct value for :optional' do
         expect(result[:optional]).to eq optional
       end
     end
 
-    context 'with options[:default]' do
+    context 'with inputs[:default]' do
       let(:default) { generator.call }
 
-      before { options.merge!(default: default) }
+      before { inputs.merge!(default: default) }
 
       it 'returns the correct value for :default' do
         expect(result[:default]).to eq default

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_interaction
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Aaron Lasseigne
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-02 00:00:00.000000000 Z
+date: 2013-12-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -51,28 +51,28 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -129,6 +129,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.15'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.15'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement