active_importer 0.2.0 → 0.2.1

data/lib/active_importer/base.rb

@@ -138,7 +138,9 @@ module ActiveImporter
     end
 
     def row_processed_count
-      row_index - 1
+      row_index - @header_index
+    rescue
+      0
     end
 
     def row_success_count

data/lib/active_importer/version.rb

@@ -1,3 +1,3 @@
 module ActiveImporter
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/active_importer/base_spec.rb

@@ -10,6 +10,17 @@ describe ActiveImporter::Base do
     ]
   end
 
+  let(:spreadsheet_data_with_errors) do
+    [
+      ['List of employees'],
+      ['Name', 'Birth Date', 'Department', 'Manager'],
+      ['John Doe', '2013-10-25', 'IT'],
+      ['Invalid', '2013-10-24', 'Management'],
+      ['Invalid', '2013-10-24', 'Accounting'],
+      ['Jane Doe', '2013-10-26', 'Sales'],
+    ]
+  end
+
   let(:importer) { EmployeeImporter.new('/dummy/file') }
 
   before do
@@ -36,17 +47,36 @@ describe ActiveImporter::Base do
     EmployeeImporter.import('/dummy/file')
   end
 
-  context 'when there are rows with errors' do
-    let(:spreadsheet_data) do
-      [
-        ['Name', 'Birth Date', 'Department', 'Manager'],
-        ['John Doe', '2013-10-25', 'IT'],
-        ['Invalid', '2013-10-24', 'Management'],
-        ['Invalid', '2013-10-24', 'Accounting'],
-        ['Jane Doe', '2013-10-26', 'Sales'],
-      ]
+  context do
+    let(:spreadsheet_data) { spreadsheet_data_with_errors }
+
+    before do
+      expect(EmployeeImporter).to receive(:new).once.and_return(importer)
+      EmployeeImporter.import('/dummy/file')
     end
 
+    describe '.row_processed_count' do
+      it 'reports the number of rows processed' do
+        expect(importer.row_processed_count).to eq(4)
+      end
+    end
+
+    describe '.row_success_count' do
+      it 'reports the number of rows imported successfully' do
+        expect(importer.row_success_count).to eq(2)
+      end
+    end
+
+    describe '.row_error_count' do
+      it 'reports the number of rows with errors' do
+        expect(importer.row_error_count).to eq(2)
+      end
+    end
+  end
+
+  context 'when there are rows with errors' do
+    let(:spreadsheet_data) { spreadsheet_data_with_errors }
+
     it 'does not import those rows' do
       expect { EmployeeImporter.import('/dummy/file') }.to change(Employee, :count).by(2)
     end
@@ -100,6 +130,12 @@ describe ActiveImporter::Base do
     it 'smartly skips any rows before the header' do
       expect { EmployeeImporter.import('/dummy/file') }.to change(Employee, :count).by(2)
     end
+
+    it 'reports the number of processed rows correctly' do
+      expect(EmployeeImporter).to receive(:new).once.and_return(importer)
+      EmployeeImporter.import('/dummy/file')
+      expect(importer.row_processed_count).to eq(2)
+    end
   end
 
   describe '.fetch_model' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_importer
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-11 00:00:00.000000000 Z
+date: 2013-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: roo
@@ -112,7 +112,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1076262899309802271
+      hash: -3865447106793864810
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -121,7 +121,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1076262899309802271
+      hash: -3865447106793864810
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23