active_hash_relation 0.0.3 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c46ec26a67f7a3de70d6ea616c729d074b24b3c6
-  data.tar.gz: 77fcb4801781ce42b1b131897f512a27e99c14c4
+  metadata.gz: 9e8a15147af3c9b53fa1edadbd8a6d73c1032dfa
+  data.tar.gz: caa04edc9050cd929d30ca023004c34618b6316c
 SHA512:
-  metadata.gz: fd1dd4b024765dacd505e2bf4b035ccfc5949c457404e650bbd2a0dc9cdd88bcdc1a661651a4a4d8476afb7309e5aed2920aedda563643bc37d64dbd6d358494
-  data.tar.gz: 467857eaaa1c5742190b336f36489d206a3ae59d068f4540948ad9f39a296bc479a5bed3c052e01c9495c71af687d14caf8f0d46d916c065aeed5c24790e19db
+  metadata.gz: a37b985fbebea7efd854ac282a60308b62ac67d994fdc2f204d4bfdc06c1e328b749126b4e952c40220e200718bbb53eda434d2aa734c499121ba251493f61ab
+  data.tar.gz: 2ae6c59dacc4aafe54b4eb441b38b17434a2986aa6e9fe9be7f4493ff5e4d1d7067ec45306e09d6b8f24e2e70a9f7abe5821073b94e1f8350e97122ff9aa2115

data/README.md

@@ -21,9 +21,9 @@ underneath with the same params.
 _\*Actually nothing is exposed, but a user could retrieve resources based
 on unknown attributes (attributes not returned from the API) by brute forcing
 which might or might not be a security issue. If you don't like that check
-[whitelisting](https://github.com/kollegorna/active_hash_relation#whitelisting)._
+[whitelisting](#whitelisting)._
 
-*New*! You can now do [__aggregation queries__](https://github.com/kollegorna/active_hash_relation#aggregation_queries).
+*New*! You can now do [__aggregation queries__](#aggregation-queries).
 
 ## Installation
 
@@ -149,7 +149,7 @@ called to apply the filters in resource association.
 Sometimes we need to ask the database queries that act on the collection but don't want back an array of elements but a value instead! Now you can do that on an ActiveRecord::Relation by simply calling the aggregations method inside the controller:
 
 ```ruby
-apply_filters(resource, {
+aggregations(resource, {
   aggregate: {
     integer_column: { avg: true, max: true, min: true, sum: true },
     float_column: {avg: true, max: true, min: true },
@@ -165,7 +165,7 @@ and you will get a hash (HashWithIndifferentAccess) back that holds all your agg
  "datetime_at"=>{"max"=>2015-06-11 20:59:14 UTC, "min"=>2015-06-11 20:59:12 UTC}}
 ```
 
-These attributes usually go to the "meta" section of your serializer. In that way it's easy to parse them in the front-end (for ember check [here](http://guides.emberjs.com/v1.10.0/models/handling-metadata/). Please note that you should apply the aggregations __after__ you apply the filters, if there any.
+These attributes usually go to the "meta" section of your serializer. In that way it's easy to parse them in the front-end (for ember check [here](http://guides.emberjs.com/v1.10.0/models/handling-metadata/)). Please note that you should apply the aggregations __after__ you apply the filters (if there any) but __before__ you apply pagination!
 
 
 

data/lib/active_hash_relation/aggregation.rb

@@ -46,7 +46,7 @@ module ActiveHashRelation
       meta_attributes = HashWithIndifferentAccess.new
 
       available_aggr.each do |k, v|
-        if asked_aggr[k] == true
+        if asked_aggr[k]
           meta_attributes[k] = resource.send(v,column)
           meta_attributes[k] = meta_attributes[k].to_f if meta_attributes[k].is_a? BigDecimal
         end

data/lib/active_hash_relation/column_filters.rb

@@ -56,15 +56,15 @@ module ActiveHashRelation::ColumnFilters
   private
 
   def apply_leq_geq_le_ge_filters(resource, table_name, column, param)
-    if param[:leq]
+    if !param[:leq].blank?
       resource = resource.where("#{table_name}.#{column} <= ?", param[:leq])
-    elsif param[:le]
+    elsif !param[:le].blank?
       resource = resource.where("#{table_name}.#{column} < ?", param[:le])
     end
 
-    if param[:geq]
+    if !param[:geq].blank?
       resource = resource.where("#{table_name}.#{column} >= ?", param[:geq])
-    elsif param[:ge]
+    elsif !param[:ge].blank?
       resource = resource.where("#{table_name}.#{column} > ?", param[:ge])
     end
 

data/lib/active_hash_relation/filter_applier.rb

@@ -24,7 +24,7 @@ module ActiveHashRelation
       end
       table_name = @model.table_name
       @model.columns.each do |c|
-        next if @params[c.name.to_s].nil?
+        next if @params[c.name.to_s].blank?
 
         if c.respond_to?(:primary)
           if c.primary

data/lib/active_hash_relation/version.rb

@@ -1,3 +1,3 @@
 module ActiveHashRelation
-  VERSION = "0.0.3"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_hash_relation
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 1.0.0
 platform: ruby
 authors:
 - Filippos Vasilakis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-11 00:00:00.000000000 Z
+date: 2015-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -83,7 +83,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Simple gem that allows you to run multiple ActiveRecord::Relation using hash.