active_form_objects 1.0.0.beta.2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4cc38391b46ea4d3dd453708fd14842a0848017c270003e0ffcc67088aaf4ce8
-  data.tar.gz: 91c862cc0a28c7f2be22d9af319e41eae764421cf8234badacc0dc66c708afa5
+  metadata.gz: 264e500907e70a06681bb42c4553d532b52f34b311145b993065725672ccdc54
+  data.tar.gz: ea8d279f54b93ca9f573f7350f63432f11dc26b3e4ad6eb4de7d87ce0b78cfd0
 SHA512:
-  metadata.gz: c9a52467cb2e00a176b5044869b125728b45eca076931ecbc5f049ca72eccf1b33d878516449ef29dbbcc08501add7c59ed5eeedd191faadb9d594b571b01146
-  data.tar.gz: 401e27c9bd4024c242eda7d211d2df1759cbea23a85a12c0375c59443490d4dec5edafd8159d4ea662fb8300935a2c09cf98c5f65e1ad6989eedd98220bc0632
+  metadata.gz: 92288f3451f81cadb980157da7783060aef7d071ea3d83a45646e1a02e8586ad3d58b03cc8bd49514de16e68fb7a20ca96c7b4756b2687a9ca4b7e24fad5cdf3
+  data.tar.gz: f98fa84485a428a4c1bf53ff45fd138dbaa77b8114872e77cfff480e28db4064bfbaeedd2e9d4c08086b39073733020d7fe32e3c052943503799fe8de56b0008

data/lib/dsl/polymorphs.rb

@@ -14,7 +14,7 @@ module Dsl
       # +key+:: the corresponding key in the params hash
       # +possible_types+:: A hash that follows the below format
       #
-      # polymorph(:content, :program_id, {
+      # polymorph(:content, {
       #   foo: Bar
       # })
       #

data/lib/handlers/base.rb

@@ -14,5 +14,14 @@ module Handlers
     def upper(var)
       @klass.class.class_variable_get(var)[@klass.class.name]
     end
+
+    def raise_error(string)
+      raise ActiveFormObjects::Error.new("[#{@klass.class.name}] #{string}")
+    end
+  end
+end
+
+module ActiveFormObjects
+  class Error < RuntimeError
   end
 end

data/lib/handlers/delegates.rb

@@ -29,6 +29,7 @@ module Handlers
       })
 
       @form.new(@attributes, @resource.send(@relation)).save!
+      @resource.reload
     end
   end
 end

data/lib/handlers/polymorphs.rb

@@ -28,25 +28,29 @@ module Handlers
     #
     def initialize(klass, polymorph)
       @polymorph = polymorph
+
       super(klass)
     end
 
     def handle
       @params_to_send = @params[@polymorph[:key]] || {}
-      polymorph_instance = form_class.new(@params_to_send, @resource.try(@polymorph[:key])).save!
+      form = form_class
+
+      raise_error("The form resolved with key '#{@type}' seems to be nil. Check your polymorphic relation key and the associated forms.") if form.nil?
+
+      polymorph_instance = form.new(@params_to_send, @resource.try(@polymorph[:key])).save!
+
       @params["#{@polymorph[:key]}_id"] = polymorph_instance.id
       @params["#{@polymorph[:key]}_type"] = polymorph_instance.class.name
       @params.delete(@polymorph[:key])
     end
 
     def form_class
-      @polymorph[:types][
-        @resource.try("#{@polymorph[:key]}_type") || clean_params.try(:to_sym)
-      ]
-    end
+      @type = @resource.try(@polymorph[:key]).try(:type) || @params_to_send['type']
+      raise_error("No 'type' method or 'type‘ key found in params for '#{@polymorph[:key]}' polymorphic relation") if @type.nil?
 
-    def clean_params
       @params_to_send.delete(:type)
+      @polymorph[:types][@type.try(:to_sym)]
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_form_objects
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta.2
+  version: 1.0.0
 platform: ruby
 authors:
 - Michaël Villeneuve
@@ -90,9 +90,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.7.3