active_force 0.5.0 → 0.6.0

data/lib/generators/active_force/model/templates/model.rb.erb

@@ -0,0 +1,7 @@
+require 'active_force/sobject'
+
+class <%= @class_name %> < ActiveForce::SObject
+<% attributes.each do |attribute| -%>
+  <%= attribute_line attribute %>
+<% end -%>
+end

data/spec/active_force/active_query_spec.rb

@@ -2,18 +2,15 @@ require 'spec_helper'
 require 'active_force/active_query'
 
 describe ActiveForce::ActiveQuery do
-  let(:sobject){
-    sobject = double("sobject")
-    allow(sobject).to receive(:table_name).and_return "table_name"
-    allow(sobject).to receive(:fields).and_return []
-    allow(sobject).to receive(:mappings).and_return({field: "Field__c"})
-    sobject
-  }
-
-  let(:client){
-    double("client")
-  }
-
+  let(:sobject) do
+    double("sobject", {
+      table_name: "table_name",
+      fields: [],
+      mappings: mappings
+    })
+  end
+  let(:mappings){ { field: "Field__c", other_field: "Other_Field" } }
+  let(:client){ double("client") }
   let(:active_query){ ActiveForce::ActiveQuery.new(sobject) }
 
   before do
@@ -37,6 +34,13 @@ describe ActiveForce::ActiveQuery do
     end
   end
 
+  describe "select only some field using mappings" do
+    it "should return a query only with selected field" do
+      active_query.select(:field)
+      expect(active_query.to_s).to eq("SELECT Field__c FROM table_name")
+    end
+  end
+
   describe "condition mapping" do
     it "maps conditions for a .where" do
       active_query.where(field: 123)
@@ -47,6 +51,69 @@ describe ActiveForce::ActiveQuery do
       active_query.where field: "hello"
       expect(active_query.to_s).to end_with("Field__c = 'hello'")
     end
+
+    it "puts NULL when a field is set as nil" do
+      active_query.where field: nil
+      expect(active_query.to_s).to end_with("Field__c = NULL")
+    end
+
+    describe 'bind parameters' do
+      let(:mappings) do
+        super().merge({
+          other_field: 'Other_Field__c',
+          name: 'Name'
+        })
+      end
+
+      it 'accepts bind parameters' do
+        active_query.where('Field__c = ?', 123)
+        expect(active_query.to_s).to eq("SELECT Id FROM table_name WHERE Field__c = 123")
+      end
+
+      it 'accepts nil bind parameters' do
+        active_query.where('Field__c = ?', nil)
+        expect(active_query.to_s).to eq("SELECT Id FROM table_name WHERE Field__c = NULL")
+      end
+
+      it 'accepts multiple bind parameters' do
+        active_query.where('Field__c = ? AND Other_Field__c = ? AND Name = ?', 123, 321, 'Bob')
+        expect(active_query.to_s).to eq("SELECT Id FROM table_name WHERE Field__c = 123 AND Other_Field__c = 321 AND Name = 'Bob'")
+      end
+
+      it 'complains when there given an incorrect number of bind parameters' do
+        expect{
+          active_query.where('Field__c = ? AND Other_Field__c = ? AND Name = ?', 123, 321)
+        }.to raise_error(ActiveForce::PreparedStatementInvalid, 'wrong number of bind variables (2 for 3)')
+      end
+
+      context 'named bind parameters' do
+        it 'accepts bind parameters' do
+          active_query.where('Field__c = :field', field: 123)
+          expect(active_query.to_s).to eq("SELECT Id FROM table_name WHERE Field__c = 123")
+        end
+
+        it 'accepts nil bind parameters' do
+          active_query.where('Field__c = :field', field: nil)
+          expect(active_query.to_s).to eq("SELECT Id FROM table_name WHERE Field__c = NULL")
+        end
+
+        it 'accepts multiple bind parameters' do
+          active_query.where('Field__c = :field AND Other_Field__c = :other_field AND Name = :name', field: 123, other_field: 321, name: 'Bob')
+          expect(active_query.to_s).to eq("SELECT Id FROM table_name WHERE Field__c = 123 AND Other_Field__c = 321 AND Name = 'Bob'")
+        end
+
+        it 'accepts multiple bind parameters orderless' do
+          active_query.where('Field__c = :field AND Other_Field__c = :other_field AND Name = :name', name: 'Bob', other_field: 321, field: 123)
+          expect(active_query.to_s).to eq("SELECT Id FROM table_name WHERE Field__c = 123 AND Other_Field__c = 321 AND Name = 'Bob'")
+        end
+
+        it 'complains when there given an incorrect number of bind parameters' do
+          expect{
+            active_query.where('Field__c = :field AND Other_Field__c = :other_field AND Name = :name', field: 123, other_field: 321)
+          }.to raise_error(ActiveForce::PreparedStatementInvalid, 'missing value for :name in Field__c = :field AND Other_Field__c = :other_field AND Name = :name')
+        end
+      end
+    end
   end
 
   describe "#find_by" do

data/spec/active_force/association_spec.rb

@@ -4,20 +4,15 @@ require 'active_force/association'
 describe ActiveForce::SObject do
 
   let :post do
-    post = Post.new
-    allow(post).to receive(:id).and_return "1"
-    post
+    Post.new(id: "1")
   end
 
   let :comment do
-    comment = Comment.new
-    allow(comment).to receive(:id).and_return "1"
-    allow(comment).to receive(:post_id).and_return "1"
-    comment
+    Comment.new(id: "1", post_id: "1")
   end
 
   let :client do
-    double("sfdc_client")
+    double("sfdc_client", query: [Restforce::Mash.new(id: 1)])
   end
 
   before do
@@ -34,7 +29,6 @@ describe ActiveForce::SObject do
   end
 
   describe "has_many_query" do
-
     before do
       class Post < ActiveForce::SObject
         has_many :comments
@@ -49,13 +43,46 @@ describe ActiveForce::SObject do
       expect(post.comments).to be_a ActiveForce::ActiveQuery
     end
 
+    it 'makes only one API call to fetch the associated object' do
+      expect(client).to receive(:query).once
+      post.comments.to_a
+      post.comments.to_a
+    end
+
     describe 'to_s' do
-      it "should retrun a SOQL statment" do
+      it "should return a SOQL statment" do
         soql = "SELECT Id, PostId FROM Comment__c WHERE PostId = '1'"
-       expect(post.comments.to_s).to eq soql
+        expect(post.comments.to_s).to eq soql
       end
     end
 
+    context 'when the SObject is namespaced' do
+      let(:account){ Foo::Account.new(id: '1') }
+
+      before do
+        module Foo
+          class Opportunity < ActiveForce::SObject
+            field :account_id, from: 'AccountId'
+          end
+
+          class Account < ActiveForce::SObject
+            has_many :opportunities, model: Foo::Opportunity
+          end
+        end
+      end
+
+      it 'correctly infers the foreign key and forms the correct query' do
+        soql = "SELECT Id, AccountId FROM Opportunity WHERE AccountId = '1'"
+        expect(account.opportunities.to_s).to eq soql
+      end
+
+      it 'uses an explicit foreign key if it is supplied' do
+        Foo::Opportunity.field :partner_account_id, from: 'Partner_Account_Id__c'
+        Foo::Account.has_many :opportunities, foreign_key: :partner_account_id, model: Foo::Opportunity
+        soql = "SELECT Id, AccountId, Partner_Account_Id__c FROM Opportunity WHERE Partner_Account_Id__c = '1'"
+        expect(account.opportunities.to_s).to eq soql
+      end
+    end
   end
 
   describe 'has_many(options)' do
@@ -70,8 +97,8 @@ describe ActiveForce::SObject do
     end
 
     it 'should allow to change the foreign key' do
-      Post.has_many :comments, { foreign_key: :post }
-      Comment.field :post, from: 'PostId'
+      Post.has_many :comments, { foreign_key: :poster }
+      Comment.field :poster, from: 'PostId'
       soql = "SELECT Id, PostId FROM Comment__c WHERE PostId = '1'"
       expect(post.comments.to_s).to eq soql
     end
@@ -90,13 +117,11 @@ describe ActiveForce::SObject do
   end
 
   describe "belongs_to" do
-
     before do
-      allow(client).to receive(:query).and_return [Restforce::Mash.new(id: 1)]
+      Comment.belongs_to :post
     end
 
     it "should get the resource it belongs to" do
-      Comment.belongs_to :post
       expect(comment.post).to be_instance_of(Post)
     end
 
@@ -110,5 +135,58 @@ describe ActiveForce::SObject do
       comment.post
     end
 
+    it 'makes only one API call to fetch the associated object' do
+      expect(client).to receive(:query).once
+      comment.post
+      comment.post
+    end
+
+    it 'accepts assignment of an existing object as an association' do
+      expect(client).to_not receive(:query)
+      other_post = Post.new(id: "2")
+      comment.post = other_post
+      expect(comment.post_id).to eq other_post.id
+      expect(comment.post).to eq other_post
+    end
+
+    context 'when the SObject is namespaced' do
+      let(:attachment){ Foo::Attachment.new(id: '1', lead_id: '2') }
+      before do
+        module Foo
+          class Lead < ActiveForce::SObject; end
+
+          class Attachment < ActiveForce::SObject
+            field :lead_id, from: 'Lead_Id__c'
+            belongs_to :lead, model: Foo::Lead
+          end
+        end
+      end
+
+      it 'generates the correct query' do
+        expect(client).to receive(:query).with("SELECT Id FROM Lead WHERE Id = '2' LIMIT 1")
+        attachment.lead
+      end
+
+      it 'instantiates the correct object' do
+        expect(attachment.lead).to be_instance_of(Foo::Lead)
+      end
+
+      context 'when given a foreign key' do
+        let(:attachment){ Foo::Attachment.new(id: '1', fancy_lead_id: '2') }
+        before do
+          module Foo
+            class Attachment < ActiveForce::SObject
+              field :fancy_lead_id, from: 'LeadId'
+              belongs_to :lead, model: Foo::Lead, foreign_key: :fancy_lead_id
+            end
+          end
+        end
+
+        it 'generates the correct query' do
+          expect(client).to receive(:query).with("SELECT Id FROM Lead WHERE Id = '2' LIMIT 1")
+          attachment.lead
+        end
+      end
+    end
   end
 end

data/spec/active_force/callbacks_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+require 'active_force/sobject'
+
+describe ActiveForce::SObject do
+  let(:client) { double 'Client', create!: 'id' }
+
+  before do
+    allow(ActiveForce::SObject).to receive(:sfdc_client).and_return client
+  end
+
+  describe "save" do
+
+    it 'call action callback when save a record' do
+      class Whizbanged < ActiveForce::SObject
+
+        field :updated_from
+        field :dirty_attribute
+
+        before_save :set_as_updated_from_rails
+        after_save :mark_dirty
+
+        private
+
+        def set_as_updated_from_rails
+          self.updated_from = 'Rails'
+        end
+
+        def mark_dirty
+          self.dirty_attribute = true
+        end
+
+      end
+
+      whizbanged = Whizbanged.new
+      whizbanged.save
+      expect(whizbanged.updated_from).to eq 'Rails'
+      expect(whizbanged.dirty_attribute).to eq true
+      expect(whizbanged.changed.include? 'dirty_attribute').to eq true
+      expect(whizbanged.changed.include? 'updated_from').to eq false
+    end
+  end
+end

data/spec/active_force/query_spec.rb

@@ -11,6 +11,16 @@ describe ActiveForce::Query do
   after do
   end
 
+  describe '.select' do
+    it 'use column sent on the select method' do
+      expect(@query.select('name').all.to_s).to eq "SELECT name FROM table_name"
+    end
+
+    it 'use columns sent on the select method' do
+      expect(@query.select(['id','name']).all.to_s).to eq "SELECT id, name FROM table_name"
+    end
+  end
+
   describe ".all" do
     it "table should return table name" do
       expect(@query.all.table).to eq(@query.table)

data/spec/active_force/sobject/table_name_spec.rb

@@ -25,13 +25,24 @@ describe ActiveForce::SObject do
       expect(EnforcedTableName.table_name).to eq('Forced__c')
     end
 
-    it "doesn't include a namespace" do
-      module Foo
-        class Bar < ActiveForce::SObject
+    context 'with a namespace' do
+      it "the namespace is not included" do
+        module Foo
+          class Bar < ActiveForce::SObject
+          end
         end
+
+        expect(Foo::Bar.table_name).to eq('Bar__c')
       end
 
-      expect(Foo::Bar.table_name).to eq('Bar__c')
+      it 'standard types are inferred correctly' do
+        module Foo
+          class Account < ActiveForce::SObject
+          end
+        end
+
+        expect(Foo::Account.table_name).to eq('Account')
+      end
     end
   end
 end

data/spec/active_force/sobject_spec.rb

@@ -55,16 +55,46 @@ describe ActiveForce::SObject do
         expect(Quota.mappings[:id]).to eq 'Bar_Id__c'
       end
     end
+
+    context 'as: :multi_picklist' do
+      before do
+        class IceCream < ActiveForce::SObject
+          field :flavors, as: :multi_picklist
+        end
+        sundae.flavors = %w(chocolate vanilla strawberry)
+      end
+
+      context 'on create' do
+        let(:sundae) { IceCream.new }
+        it 'formats the picklist values' do
+          expect(client).to receive(:create!).with('IceCream__c', {'Flavors__c' => 'chocolate;vanilla;strawberry'})
+          sundae.save
+        end
+      end
+
+      context 'on update' do
+        let(:sundae) { IceCream.new(id: '1') }
+        it 'formats the picklist values' do
+          expect(client).to receive(:update!).with('IceCream__c', {'Flavors__c' => 'chocolate;vanilla;strawberry', 'Id' => '1'})
+          sundae.save
+        end
+      end
+
+    end
   end
 
   describe '#update' do
 
     subject do
-      Whizbang.new
+      Whizbang.new(id: '1')
     end
 
     before do
-      expect(client).to receive(:update!).and_return('id')
+      expected_args = [
+        Whizbang.table_name,
+        {'Text_Label' => 'some text', 'Id' => '1'}
+      ]
+      expect(client).to receive(:update!).with(*expected_args).and_return('id')
     end
 
     it 'delegates to the Client with create!' do
@@ -97,7 +127,7 @@ describe ActiveForce::SObject do
   describe 'self.create' do
 
     before do
-      expect(client).to receive(:create!).and_return('id')
+      expect(client).to receive(:create!).with(Whizbang.table_name, 'Text_Label' => 'some text').and_return('id')
     end
 
     it 'should create a new instance' do
@@ -126,4 +156,43 @@ describe ActiveForce::SObject do
       Whizbang.find_by id: 123, text: "foo"
     end
   end
+
+  describe '#reload' do
+    let(:client) do
+      double("sfdc_client", query: [Restforce::Mash.new(Id: 1, Name: 'Jeff')])
+    end
+    let(:quota){ Quota.new(id: '1') }
+    let(:territory){ Territory.new(id: '1', quota_id: '1') }
+
+    before do
+      Territory.belongs_to :quota, model: Quota
+      Territory.field :quota_id, from: 'Quota_Id'
+      allow(ActiveForce::SObject).to receive(:sfdc_client).and_return client
+    end
+
+    it 'clears cached associations' do
+      soql = "SELECT Id, Bar_Id__c FROM Quota__c WHERE Id = '1' LIMIT 1"
+      expect(client).to receive(:query).twice.with soql
+      allow(Territory).to receive(:find){ territory }
+      territory.quota
+      territory.quota
+      territory.reload
+      territory.quota
+    end
+
+    it "refreshes the object's attributes" do
+      Territory.field :name, from: 'Name'
+      territory.name = 'Walter'
+      expect(territory.name).to eq 'Walter'
+      territory.reload
+      expect(territory.name).to eq 'Jeff'
+      expect(territory.changed_attributes).to be_empty
+    end
+
+    it 'returns the same object' do
+      allow(Territory).to receive(:find){ Territory.new }
+      expected = territory
+      expect(territory.reload).to eql expected
+    end
+  end
 end