active_flags 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37e82dc8c41afadca68b93d26556c7306fe4cd85ea13dc1ec0186ea616d3df7d
-  data.tar.gz: 54afcdf0ee74fce3c33b7b87fd5321f35e1e0e5d6a2c2a85945fc1a86a764585
+  metadata.gz: 04d4f132fab19c0376a2a86331ebc79c309dae8e8e6a3de21a5f73295af63646
+  data.tar.gz: b1f08e89de858e78adb8713a2fdee131801db75aeb5abc265918a0f2b5d78d07
 SHA512:
-  metadata.gz: 8576103bbda00fadd4a9e3a3c0a0c6c251008e5ba5d04500d83385dd824602a3cf2db16f8f53102d21aab958f7b5231835a2162d1a33f334fec885ad865a8ee7
-  data.tar.gz: d68b0707f7c9b53546333dcd4e25dd6bd3f8dfc478e815c0fba3cca49495414afcb57d3c9afa6f5724fac3618a0a140afc0150e86c6a579499cad84fe1df3657
+  metadata.gz: 0adf7d4c13094ba72e1b168e1398310c46c1e33346ffc9aa49e82366ed811cd18861099b7346d2bc42a3772b1577fc16b6533a3a51a6422d0308b6d99b62640c
+  data.tar.gz: 44b07703f575acebcbd4af7c17f2b5101cdc118293e6c425cfd1298b5d18f5b265c8cd84c27b191958a376917f36ed01b0ffd4bcec9abc871110c497f5d513c1

data/README.md

@@ -1,4 +1,9 @@
 # ActiveFlags
+
+[![Build Status](https://travis-ci.org/FidMe/active_flags.svg?branch=master)](https://travis-ci.org/FidMe/active_flags)
+[![Gem Version](https://badge.fury.io/rb/active_flags.svg)](https://badge.fury.io/rb/active_flags)
+
+
 Active Flags allows you to use automatic flags on models. You won't have to create useless booleans with view logic in your core tables. They should not have been there in the first place, let Active Flags handle them for you!
 
 ## Installation
@@ -49,7 +54,7 @@ And that's it!
 You can now add flags on a user like that:
 
 ```ruby
-user.flags = { visible: 'true', active: 'true' }
+user.flags = { visible: true, active: true }
 user.save!
 ```
 
@@ -65,12 +70,50 @@ end
 
 And then you can declare as much flags as you want with no restriction:
 ```ruby
-user.update!(flags: { visible: 'true', active: 'true', diet: 'vegan', power: 'super saiyan' })
+user.update!(flags: { visible: true, active: true, diet: 'vegan', power: 'super saiyan' })
 ```
 
 To access your flags, you now have 2 ways.
 Either as a hash, with the `flags` method or as an ActiveFlag::Flags collection with the `flags_as_collection` method.
 
+## Flags as scopes
+
+When you develop an app without active_flags, you will generally query the equivalent of flags as simple booleans.
+
+ActiveFlags gives you a clean and simple way to query your model based on defined flags.
+
+Any flag can be queried as a scope using the `flagged_as` method
+
+```ruby
+user = User.create!(flags: { visible: true })
+
+User.flagged_as_visible
+# #<ActiveRecord::Relation [#<User id: 1>]> 
+
+User.flagged_as_visible(false)
+# #<ActiveRecord::Relation []>
+
+User.flagged_as_intelligent
+# #<ActiveRecord::Relation []>
+
+user.update!(flags: { intelligent: true })
+User.flagged_as_intelligent
+# #<ActiveRecord::Relation [#<User id: 1>]> 
+
+user.update!(flags: { intelligent: 'a bit' })
+User.flagged_as_intelligent('a_bit')
+# #<ActiveRecord::Relation [#<User id: 1>]> 
+```
+
+To query flags the other way around you can use the `not_flagged_as` method
+
+```ruby
+User.not_flagged_as_intelligent
+# or with value
+User.not_flagged_as_intelligent('a bit')
+```
+
+
 ## Contributing
 https://github.com/FidMe/active_flags
 

data/lib/active_flags.rb

@@ -1,6 +1,7 @@
 require "active_flags/engine"
 require_relative 'active_flags/handler/flag_mapper'
 require_relative 'active_flags/handler/flag_builder'
+require_relative 'utils/value_stringifier'
 
 module ActiveFlags
   extend ActiveSupport::Concern
@@ -23,5 +24,17 @@ module ActiveFlags
         hash_of_flags.with_indifferent_access
       end
     end
+
+    def method_missing(method_name, *args)
+      super(method_name, *args) unless method_name.to_s.include?(prefix = 'flagged_as_')
+      different_from = method_name.to_s.starts_with?('not')
+      flag = method_name.to_s.gsub(different_from ? "not_#{prefix}" : prefix, '')
+      condition = { active_flags_flags: { value: stringify(args[0]) } }
+
+      joins(:flags_as_collection)
+        .where(active_flags_flags: { key: flag })
+        .send(different_from ? 'where' : 'all')
+        .send(different_from ? 'not' : 'where', condition)
+    end
   end
-end
+end

data/lib/active_flags/handler/flag_builder.rb

@@ -7,9 +7,9 @@ module ActiveFlags
       end
 
       def save
-        @resource.flags_as_collection << ActiveFlags::Flag.find_or_initialize_by(subject: @resource, key: @flag_attributes[:key]) do |flag_to_create|
-          flag_to_create.value = @flag_attributes[:value]
-        end
+        ActiveFlags::Flag.find_or_initialize_by(subject: @resource, key: @flag_attributes[:key])
+                         .update!(value: @flag_attributes[:value])
+        @resource.reload
       end
     end
   end

data/lib/active_flags/handler/flag_mappers/key_value_mapper.rb

@@ -2,7 +2,6 @@ module ActiveFlags
   module Handler
     module FlagMappers
       class KeyValueMapper
-
         def initialize(hash_to_map)
           @hash_to_map = hash_to_map
         end
@@ -19,4 +18,4 @@ module ActiveFlags
       end
     end
   end
-end
+end

data/lib/active_flags/version.rb

@@ -1,3 +1,3 @@
 module ActiveFlags
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/lib/utils/value_stringifier.rb

@@ -0,0 +1,9 @@
+def stringify(value)
+  if value.nil? || value == true
+    't'
+  elsif value == false
+    'f'
+  else
+    value
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_flags
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Nathan Huberty
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-13 00:00:00.000000000 Z
+date: 2019-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -68,6 +68,7 @@ files:
 - lib/active_flags/handler/flag_mappers/key_value_mapper.rb
 - lib/active_flags/version.rb
 - lib/tasks/active_flags_tasks.rake
+- lib/utils/value_stringifier.rb
 homepage: https://github.com/FidMe/active_flags
 licenses:
 - MIT