active_enum 1.0.0.rc6 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a6fb4a88a4e4c0b8894a94b35dee75c23f9ddbdba0db2c5078dd51049cbeb82a
-  data.tar.gz: 53e5d91603101b6c0e6590ceb58f6c214cbd221be7da6e4780825b51e71b640f
+  metadata.gz: a4dd61a23068e97e9582ac6bb9109414172733ae0c26759177ecab8082819cd6
+  data.tar.gz: bab417444c404468c0fea123e31a05ef392bf0a14b32ccefa84fa9d2f63129d1
 SHA512:
-  metadata.gz: b208b4ad29373d4f604673eef17315d5ede6265384d0cb3cadda81b674953fa35d09ac8149a2831a257d2f4e05e9931b02c01767aece9b2a7e45e4152f09e462
-  data.tar.gz: 8ef7bde84f962ac14307dccfee60849d022699c2841fabd7fe33cb5b4c284cafcff938e91497a6f44f02df27fc0cd0d7bbf707162b16663df30ad61d63688f08
+  metadata.gz: c5383983a54ff4169f5cbefe0a4907c9007144808a322e0eb31fd4e0ba52e86e2a814d7f8c6dedac24ce9127a56db556878f337ce437175cfe43f111e65bc81d
+  data.tar.gz: 9ba6f7231906b870a9f9832ab477a658a99e5df227fcde6fcff47e47ba86533bf7f182147befd6295b00de285a6248f70d53fa803cb48617cbc71eb68e767f23

data/README.rdoc

@@ -15,7 +15,7 @@ From gem version 1.0 onwards this plugin will only have Rails 4+ support. If you
 
 Put this in your Gemfile
 
-  gem 'active_enum', '~> 1.0.0.rc4'
+  gem 'active_enum', '~> 1.0.0'
 
 Then generate the config initializer file
 

data/lib/active_enum/base.rb

@@ -76,7 +76,7 @@ module ActiveEnum
       alias_method :[], :get
 
       def include?(value)
-        !get(value).nil?
+        !get_value(value, false).nil?
       end
 
       # Access any meta data defined for a given id or name. Returns a hash.
@@ -88,22 +88,22 @@ module ActiveEnum
       private
 
       # Access value row array for a given id or name value.
-      def get_value(index)
+      def get_value(index, raise_on_not_found = ActiveEnum.raise_on_not_found)
         if index.is_a?(Integer)
           store.get_by_id(index)
         else
           store.get_by_name(index)
-        end || (ActiveEnum.raise_on_not_found ? raise(ActiveEnum::NotFound, "#{self} value for '#{index}' was not found") : nil)
+        end || (raise_on_not_found ? raise(ActiveEnum::NotFound, "#{self} value for '#{index}' was not found") : nil)
       end
 
       def id_and_name_and_meta(hash)
         if hash.has_key?(:name)
-          id   = hash.delete(:id) || next_id
-          name = hash.delete(:name)
-          meta = hash
+          id   = hash.fetch(:id) { next_id }
+          name = hash.fetch(:name).freeze
+          meta = hash.except(:id, :name).freeze
           return id, name, (meta.empty? ? nil : meta)
         elsif hash.keys.first.is_a?(Integer)
-          return *Array(hash).first
+          return *Array(hash).first.tap { |arr| arr[1].freeze }
         else
           raise ActiveEnum::InvalidValue, "The value supplied, #{hash}, is not a valid format."
         end

data/lib/active_enum/extensions.rb

@@ -92,9 +92,9 @@ module ActiveEnum
             when :id
               value if enum[value]
             when :name
-              enum[value]
+              enum[value].dup
             when Symbol
-              (enum.meta(value) || {})[arg]
+              (enum.meta(value) || {})[arg].try(:dup)
             end
           end
         DEF
@@ -110,7 +110,7 @@ module ActiveEnum
         class_eval <<-DEF
           def #{attribute}=(arg)
             if arg.is_a?(Symbol)
-              super self.class.active_enum_for(:#{attribute})[arg]
+              super(self.class.active_enum_for(:#{attribute})[arg])
             else
               super
             end
@@ -127,7 +127,7 @@ module ActiveEnum
         class_eval <<-DEF
           def #{attribute}?(arg=nil)
             if arg
-              self.#{attribute}(:id) == self.class.active_enum_for(:#{attribute})[arg]
+              self.#{attribute}(:id).present? && self.#{attribute}(:id) == self.class.active_enum_for(:#{attribute})[arg]
             else
               super()
             end

data/lib/active_enum/version.rb

@@ -1,3 +1,3 @@
 module ActiveEnum
-  VERSION = '1.0.0.rc6'
+  VERSION = '1.0.0'
 end

data/spec/active_enum/extensions_spec.rb

@@ -176,6 +176,11 @@ describe ActiveEnum::Extensions do
         expect(person.sex?(:female)).to be_falsey
         expect(person.sex?(:Female)).to be_falsey
       end
+
+      it 'should return false if attribute is nil regardless of enum value' do
+        person.sex = nil
+        expect(person.sex?(:nonexistent)).to be_falsey
+      end
     end
 
     context "with value as enum name symbol" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_enum
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc6
+  version: 1.0.0
 platform: ruby
 authors:
 - Adam Meehan
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-01 00:00:00.000000000 Z
+date: 2022-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -83,11 +83,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.3.1
 signing_key:
 specification_version: 4
 summary: Define enum classes in Rails and use them to enumerate ActiveRecord attributes