active_encode 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0cc3915da436ad8220ab0a23f27280ad490dd31b1250f56957ca2667ecd6666d
-  data.tar.gz: 6a43e177fbe445be244a80ee44f503324d0e34f98fc4ac90e9b20f5110c120c4
+  metadata.gz: 165b612fc067a4f2513bb6090876f015216dcb69986416f580256b58ee5979d0
+  data.tar.gz: 8730c65eb2b3f38a22f245992c4885a494f83bcff169af6746b35f2d2d75a5bc
 SHA512:
-  metadata.gz: 7936993f21839c01bab5f3dd6cb7614bb837244c2ab9de2fa5953154d9f0a5c3460a485a2da1748f74c545b76d555c35c18decf697791002783d3607efaaed57
-  data.tar.gz: '069ba0aaec4e5e0a31661018a560cfb73d9d39092076c0f3c9fdcc7ee7afea9ad1a23b5114fca4bd1aadd16f85b7c1d0f59a8206ef89b20efc1ccf7a2bd6a93c'
+  metadata.gz: '094791342ae22c10e682762e61a8f83934a742fa326746a5733a304cf14a657dc048560e251734b06a9833d7fe7b978fed0196361e8cca199e017b195d8e239f'
+  data.tar.gz: '087bff74b89364c3e2795a104038324846d7bf10e33e3e239a901db189445273cd7dc40f252a555cdb800d9adf82457ccb055fc3d2bcf0184ff250c891b7ff02'

data/lib/active_encode/engine_adapters/elastic_transcoder_adapter.rb

@@ -140,9 +140,10 @@ module ActiveEncode
           # logger.info("Already in bucket `#{source_bucket}'")
           s3_object.key
         else
-          s3_key = File.join(SecureRandom.uuid, s3_object.key)
+          cleaned_url = ActiveEncode.sanitize_filename input_url
+          s3_key = File.join(SecureRandom.uuid, File.basename(cleaned_url))
           # logger.info("Copying to `#{source_bucket}/#{input_url}'")
-          target = Aws::S3::Object.new(bucket_name: source_bucket, key: input_url)
+          target = Aws::S3::Object.new(bucket_name: source_bucket, key: s3_key)
           target.copy_from(s3_object, multipart_copy: s3_object.size > 15_728_640) # 15.megabytes
           s3_key
         end
@@ -152,7 +153,8 @@ module ActiveEncode
         # original_input = input_url
         bucket = Aws::S3::Resource.new(client: s3client).bucket(source_bucket)
         filename = FileLocator.new(input_url).location
-        s3_key = File.join(SecureRandom.uuid, File.basename(filename))
+        cleaned_url = ActiveEncode.sanitize_filename input_url
+        s3_key = File.join(SecureRandom.uuid, File.basename(cleaned_url))
         # logger.info("Copying `#{original_input}' to `#{source_bucket}/#{input_url}'")
         obj = bucket.object(s3_key)
         obj.upload_file filename

data/lib/active_encode/engine_adapters/ffmpeg_adapter.rb

@@ -11,11 +11,14 @@ module ActiveEncode
       MEDIAINFO_PATH = ENV["MEDIAINFO_PATH"] || "mediainfo"
       FFMPEG_PATH = ENV["FFMPEG_PATH"] || "ffmpeg"
 
+      class_attribute :completeness_threshold
+
       def create(input_url, options = {})
         # Decode file uris for ffmpeg (mediainfo works either way)
         case input_url
         when /^file\:\/\/\//
           input_url = Addressable::URI.unencode(input_url)
+          input_url = ActiveEncode.sanitize_input(input_url)
         when /^s3\:\/\//
           require 'file_locator'
 
@@ -110,8 +113,8 @@ module ActiveEncode
           encode.state = :completed
         elsif cancelled? encode.id
           encode.state = :cancelled
-        elsif encode.percent_complete < 100
-          encode.errors << "Encoding has completed but the output duration is shorter than the input"
+        elsif encode.percent_complete < (completeness_threshold || 100)
+          encode.errors.prepend("Encoding has completed but the output duration is shorter than the input")
           encode.state = :failed
         end
 
@@ -170,7 +173,7 @@ module ActiveEncode
         err_path = working_path("error.log", id)
         error = File.read(err_path) if File.file? err_path
         if error.present?
-          [error]
+          ["Error encountered during encoding. Check ffmpeg log for more details.", error]
         else
           []
         end
@@ -200,7 +203,7 @@ module ActiveEncode
         Dir["#{File.absolute_path(working_path('outputs', id))}/*"].each do |file_path|
           output = ActiveEncode::Output.new
           output.url = "file://#{file_path}"
-          sanitized_filename = sanitize_base encode.input.url
+          sanitized_filename = ActiveEncode.sanitize_base encode.input.url
           output.label = file_path[/#{Regexp.quote(sanitized_filename)}\-(.*?)#{Regexp.quote(File.extname(file_path))}$/, 1]
           output.id = "#{encode.input.id}-#{output.label}"
           output.created_at = encode.created_at
@@ -219,7 +222,7 @@ module ActiveEncode
 
       def ffmpeg_command(input_url, id, opts)
         output_opt = opts[:outputs].collect do |output|
-          sanitized_filename = sanitize_base input_url
+          sanitized_filename = ActiveEncode.sanitize_base input_url
           file_name = "outputs/#{sanitized_filename}-#{output[:label]}.#{output[:extension]}"
           " #{output[:ffmpeg_opt]} #{working_path(file_name, id)}"
         end.join(" ")
@@ -227,15 +230,7 @@ module ActiveEncode
           "#{k}: #{v}\r\n"
         end.join
         header_opt = "-headers '#{header_opt}'" if header_opt.present?
-        "#{FFMPEG_PATH} #{header_opt} -y -loglevel error -progress #{working_path('progress', id)} -i \"#{input_url}\" #{output_opt}"
-      end
-
-      def sanitize_base(input_url)
-        if input_url.is_a? URI::HTTP
-          File.basename(input_url.path, File.extname(input_url.path))
-        else
-          File.basename(input_url, File.extname(input_url)).gsub(/[^0-9A-Za-z.\-]/, '_')
-        end
+        "#{FFMPEG_PATH} #{header_opt} -y -loglevel level+fatal -progress #{working_path('progress', id)} -i \"#{input_url}\" #{output_opt}"
       end
 
       def get_pid(id)

data/lib/active_encode/engine_adapters/media_convert_adapter.rb

@@ -482,6 +482,10 @@ module ActiveEncode
         end
       end
 
+      def s3client
+        Aws::S3::Client.new
+      end
+
       def s3_uri(url, options = {})
         bucket = options[:masterfile_bucket]
 
@@ -503,9 +507,10 @@ module ActiveEncode
           # logger.info("Already in bucket `#{source_bucket}'")
           s3_object.key
         else
-          s3_key = File.join(SecureRandom.uuid, s3_object.key)
+          cleaned_url = ActiveEncode.sanitize_filename input_url
+          s3_key = File.join(SecureRandom.uuid, File.basename(cleaned_url))
           # logger.info("Copying to `#{source_bucket}/#{input_url}'")
-          target = Aws::S3::Object.new(bucket_name: source_bucket, key: input_url)
+          target = Aws::S3::Object.new(bucket_name: source_bucket, key: s3_key)
           target.copy_from(s3_object, multipart_copy: s3_object.size > 15_728_640) # 15.megabytes
           s3_key
         end
@@ -515,7 +520,8 @@ module ActiveEncode
         # original_input = input_url
         bucket = Aws::S3::Resource.new(client: s3client).bucket(source_bucket)
         filename = FileLocator.new(input_url).location
-        s3_key = File.join(SecureRandom.uuid, File.basename(filename))
+        cleaned_url = ActiveEncode.sanitize_filename input_url
+        s3_key = File.join(SecureRandom.uuid, File.basename(cleaned_url))
         # logger.info("Copying `#{original_input}' to `#{source_bucket}/#{input_url}'")
         obj = bucket.object(s3_key)
         obj.upload_file filename

data/lib/active_encode/engine_adapters/pass_through_adapter.rb

@@ -55,7 +55,7 @@ module ActiveEncode
         # Copy derivatives to work directory
         options[:outputs].each do |opt|
           url = opt[:url]
-          output_path = working_path("outputs/#{sanitize_base opt[:url]}#{File.extname opt[:url]}", new_encode.id)
+          output_path = working_path("outputs/#{ActiveEncode.sanitize_base opt[:url]}#{File.extname opt[:url]}", new_encode.id)
           FileUtils.cp FileLocator.new(url).location, output_path
           filename_label_hash[output_path] = opt[:label]
         end
@@ -206,10 +206,6 @@ module ActiveEncode
         outputs
       end
 
-      def sanitize_base(input_url)
-        File.basename(input_url, File.extname(input_url)).gsub(/[^0-9A-Za-z.\-]/, '_')
-      end
-
       def working_path(path, id)
         File.join(WORK_DIR, id, path)
       end

data/lib/active_encode/filename_sanitizer.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+module ActiveEncode
+  module FilenameSanitizer
+    # ffmpeg has trouble with double quotes in file names. Escape them to get ffmpeg to find the file.
+    def sanitize_input(input_url)
+      input_url.gsub(/["]/, '\\\\\0')
+    end
+
+    def sanitize_base(input_url)
+      filepath = input_url.is_a?(URI::HTTP) ? input_url.path : input_url
+      # Replace special characters with underscores and remove excess periods.
+      # This removes the extension before processing so it is safe to delete all detected periods.
+      File.basename(filepath, File.extname(filepath)).gsub(/[^0-9A-Za-z.\-\/]/, '_').delete('.')
+    end
+
+    def sanitize_filename(input_url)
+      filepath = input_url.is_a?(URI::HTTP) ? input_url.path : input_url
+      # Replace special characters with underscores and remove excess periods.
+      File.basename(filepath).gsub(/[^0-9A-Za-z.\-\/]/, '_').gsub(/\.(?=.*\.)/, '')
+    end
+  end
+end

data/lib/active_encode/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ActiveEncode
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end

data/lib/active_encode.rb

@@ -2,3 +2,8 @@
 require 'active_encode/version'
 require 'active_encode/base'
 require 'active_encode/engine'
+require 'active_encode/filename_sanitizer'
+
+module ActiveEncode
+  extend ActiveEncode::FilenameSanitizer
+end

data/spec/fixtures/ffmpeg/incomplete-id/exit_status.code

@@ -0,0 +1 @@
+0

data/spec/fixtures/ffmpeg/incomplete-id/input_metadata

@@ -0,0 +1,102 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<MediaInfo
+    xmlns="https://mediaarea.net/mediainfo"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="https://mediaarea.net/mediainfo https://mediaarea.net/mediainfo/mediainfo_2_0.xsd"
+    version="2.0">
+<creatingLibrary version="18.05" url="https://mediaarea.net/MediaInfo">MediaInfoLib</creatingLibrary>
+<media ref="/home/pdinh/Downloads/videoshort.mp4">
+<track type="General">
+<VideoCount>1</VideoCount>
+<AudioCount>1</AudioCount>
+<FileExtension>mp4</FileExtension>
+<Format>MPEG-4</Format>
+<Format_Profile>Base Media</Format_Profile>
+<CodecID>mp42</CodecID>
+<FileSize>199160</FileSize>
+<Duration>6.315</Duration>
+<OverallBitRate_Mode>VBR</OverallBitRate_Mode>
+<OverallBitRate>252301</OverallBitRate>
+<FrameRate>23.719</FrameRate>
+<FrameCount>149</FrameCount>
+<StreamSize>5679</StreamSize>
+<HeaderSize>160</HeaderSize>
+<DataSize>193489</DataSize>
+<FooterSize>5511</FooterSize>
+<IsStreamable>No</IsStreamable>
+<Encoded_Date>UTC 2010-09-23 00:37:25</Encoded_Date>
+<Tagged_Date>UTC 2010-09-23 00:37:27</Tagged_Date>
+<File_Modified_Date>UTC 2017-12-14 19:29:35</File_Modified_Date>
+<File_Modified_Date_Local>2017-12-14 14:29:35</File_Modified_Date_Local>
+<Encoded_Application>HandBrake 0.9.4 2009112300</Encoded_Application>
+</track>
+<track type="Video">
+<StreamOrder>0</StreamOrder>
+<ID>1</ID>
+<Format>AVC</Format>
+<Format_Profile>Main</Format_Profile>
+<Format_Level>1.1</Format_Level>
+<Format_Settings_CABAC>Yes</Format_Settings_CABAC>
+<Format_Settings_RefFrames>2</Format_Settings_RefFrames>
+<CodecID>avc1</CodecID>
+<Duration>6.282</Duration>
+<BitRate>74477</BitRate>
+<Width>200</Width>
+<Height>110</Height>
+<Stored_Width>208</Stored_Width>
+<Stored_Height>112</Stored_Height>
+<Sampled_Width>200</Sampled_Width>
+<Sampled_Height>110</Sampled_Height>
+<PixelAspectRatio>1.000</PixelAspectRatio>
+<DisplayAspectRatio>1.818</DisplayAspectRatio>
+<Rotation>0.000</Rotation>
+<FrameRate_Mode>VFR</FrameRate_Mode>
+<FrameRate>23.719</FrameRate>
+<FrameRate_Minimum>12.500</FrameRate_Minimum>
+<FrameRate_Maximum>24.390</FrameRate_Maximum>
+<FrameRate_Original>24.000</FrameRate_Original>
+<FrameCount>149</FrameCount>
+<ColorSpace>YUV</ColorSpace>
+<ChromaSubsampling>4:2:0</ChromaSubsampling>
+<BitDepth>8</BitDepth>
+<ScanType>Progressive</ScanType>
+<StreamSize>58482</StreamSize>
+<Encoded_Library>x264 - core 79 r1347 5ddd61b</Encoded_Library>
+<Encoded_Library_Name>x264</Encoded_Library_Name>
+<Encoded_Library_Version>core 79 r1347 5ddd61b</Encoded_Library_Version>
+<Encoded_Library_Settings>cabac=1 / ref=2 / deblock=1:0:0 / analyse=0x1:0x111 / me=hex / subme=6 / psy=1 / psy_rd=1.0:0.0 / mixed_ref=0 / me_range=16 / chroma_me=1 / trellis=0 / 8x8dct=0 / cqm=0 / deadzone=21,11 / chroma_qp_offset=-2 / threads=3 / nr=0 / decimate=1 / mbaff=0 / constrained_intra=0 / bframes=2 / b_pyramid=0 / b_adapt=1 / b_bias=0 / direct=1 / wpredb=0 / wpredp=2 / keyint=240 / keyint_min=24 / scenecut=40 / rc_lookahead=40 / rc=crf / mbtree=1 / crf=25.5 / qcomp=0.60 / qpmin=10 / qpmax=51 / qpstep=4 / ip_ratio=1.40 / aq=1:1.00</Encoded_Library_Settings>
+<Encoded_Date>UTC 2010-09-23 00:37:25</Encoded_Date>
+<Tagged_Date>UTC 2010-09-23 00:37:27</Tagged_Date>
+<colour_range>Limited</colour_range>
+<colour_description_present>Yes</colour_description_present>
+<colour_primaries>BT.601 NTSC</colour_primaries>
+<transfer_characteristics>BT.709</transfer_characteristics>
+<matrix_coefficients>BT.601</matrix_coefficients>
+</track>
+<track type="Audio">
+<StreamOrder>1</StreamOrder>
+<ID>2</ID>
+<Format>AAC</Format>
+<Format_Profile>LC</Format_Profile>
+<CodecID>mp4a-40-2</CodecID>
+<Duration>6.315</Duration>
+<BitRate_Mode>VBR</BitRate_Mode>
+<BitRate>171030</BitRate>
+<BitRate_Maximum>201736</BitRate_Maximum>
+<Channels>1</Channels>
+<ChannelPositions>Front: C</ChannelPositions>
+<ChannelLayout>C</ChannelLayout>
+<SamplesPerFrame>1024</SamplesPerFrame>
+<SamplingRate>48000</SamplingRate>
+<SamplingCount>303120</SamplingCount>
+<FrameRate>46.875</FrameRate>
+<FrameCount>296</FrameCount>
+<Compression_Mode>Lossy</Compression_Mode>
+<StreamSize>134999</StreamSize>
+<StreamSize_Proportion>0.67784</StreamSize_Proportion>
+<Title>Stereo</Title>
+<Encoded_Date>UTC 2010-09-23 00:37:25</Encoded_Date>
+<Tagged_Date>UTC 2010-09-23 00:37:27</Tagged_Date>
+</track>
+</media>
+</MediaInfo>

data/spec/fixtures/ffmpeg/incomplete-id/output_metadata-high

@@ -0,0 +1,90 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<MediaInfo
+    xmlns="https://mediaarea.net/mediainfo"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="https://mediaarea.net/mediainfo https://mediaarea.net/mediainfo/mediainfo_2_0.xsd"
+    version="2.0">
+<creatingLibrary version="18.05" url="https://mediaarea.net/MediaInfo">MediaInfoLib</creatingLibrary>
+<media ref="spec/fixtures/ffmpeg/completed-id/low.mp4">
+<track type="General">
+<VideoCount>1</VideoCount>
+<AudioCount>1</AudioCount>
+<FileExtension>mp4</FileExtension>
+<Format>MPEG-4</Format>
+<Format_Profile>Base Media</Format_Profile>
+<CodecID>isom</CodecID>
+<FileSize>125403</FileSize>
+<Duration>6.336</Duration>
+<OverallBitRate>158337</OverallBitRate>
+<FrameRate>24.000</FrameRate>
+<FrameCount>150</FrameCount>
+<StreamSize>5648</StreamSize>
+<HeaderSize>40</HeaderSize>
+<DataSize>119763</DataSize>
+<FooterSize>5600</FooterSize>
+<IsStreamable>No</IsStreamable>
+<File_Modified_Date>UTC 2018-09-07 17:36:26</File_Modified_Date>
+<File_Modified_Date_Local>2018-09-07 13:36:26</File_Modified_Date_Local>
+<Encoded_Application>Lavf58.12.100</Encoded_Application>
+</track>
+<track type="Video">
+<StreamOrder>0</StreamOrder>
+<ID>1</ID>
+<Format>AVC</Format>
+<Format_Profile>High</Format_Profile>
+<Format_Level>1.1</Format_Level>
+<Format_Settings_CABAC>Yes</Format_Settings_CABAC>
+<Format_Settings_RefFrames>4</Format_Settings_RefFrames>
+<CodecID>avc1</CodecID>
+<Duration>6.250</Duration>
+<BitRate>79302</BitRate>
+<Width>200</Width>
+<Height>110</Height>
+<Stored_Width>208</Stored_Width>
+<Stored_Height>112</Stored_Height>
+<Sampled_Width>200</Sampled_Width>
+<Sampled_Height>110</Sampled_Height>
+<PixelAspectRatio>1.000</PixelAspectRatio>
+<DisplayAspectRatio>1.818</DisplayAspectRatio>
+<Rotation>0.000</Rotation>
+<FrameRate_Mode>CFR</FrameRate_Mode>
+<FrameRate_Mode_Original>VFR</FrameRate_Mode_Original>
+<FrameRate>24.000</FrameRate>
+<FrameCount>150</FrameCount>
+<ColorSpace>YUV</ColorSpace>
+<ChromaSubsampling>4:2:0</ChromaSubsampling>
+<BitDepth>8</BitDepth>
+<ScanType>Progressive</ScanType>
+<StreamSize>61955</StreamSize>
+<Encoded_Library>x264 - core 152 r2854 e9a5903</Encoded_Library>
+<Encoded_Library_Name>x264</Encoded_Library_Name>
+<Encoded_Library_Version>core 152 r2854 e9a5903</Encoded_Library_Version>
+<Encoded_Library_Settings>cabac=1 / ref=3 / deblock=1:0:0 / analyse=0x3:0x113 / me=hex / subme=7 / psy=1 / psy_rd=1.00:0.00 / mixed_ref=1 / me_range=16 / chroma_me=1 / trellis=1 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=1 / chroma_qp_offset=-2 / threads=3 / lookahead_threads=1 / sliced_threads=0 / nr=0 / decimate=1 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / bframes=3 / b_pyramid=2 / b_adapt=1 / b_bias=0 / direct=1 / weightb=1 / open_gop=0 / weightp=2 / keyint=250 / keyint_min=24 / scenecut=40 / intra_refresh=0 / rc_lookahead=40 / rc=crf / mbtree=1 / crf=23.0 / qcomp=0.60 / qpmin=0 / qpmax=69 / qpstep=4 / ip_ratio=1.40 / aq=1:1.00</Encoded_Library_Settings>
+</track>
+<track type="Audio">
+<StreamOrder>1</StreamOrder>
+<ID>2</ID>
+<Format>AAC</Format>
+<Format_Profile>LC</Format_Profile>
+<Format_Settings_SBR>No (Explicit)</Format_Settings_SBR>
+<CodecID>mp4a-40-2</CodecID>
+<Duration>6.336</Duration>
+<BitRate_Mode>CBR</BitRate_Mode>
+<BitRate>72000</BitRate>
+<Channels>2</Channels>
+<Channels_Original>1</Channels_Original>
+<ChannelPositions>Front: C</ChannelPositions>
+<ChannelLayout>C</ChannelLayout>
+<SamplesPerFrame>1024</SamplesPerFrame>
+<SamplingRate>48000</SamplingRate>
+<SamplingCount>304128</SamplingCount>
+<FrameRate>46.875</FrameRate>
+<FrameCount>297</FrameCount>
+<Compression_Mode>Lossy</Compression_Mode>
+<StreamSize>57800</StreamSize>
+<StreamSize_Proportion>0.46091</StreamSize_Proportion>
+<Default>Yes</Default>
+<AlternateGroup>1</AlternateGroup>
+</track>
+</media>
+</MediaInfo>

data/spec/fixtures/ffmpeg/incomplete-id/output_metadata-low

@@ -0,0 +1,90 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<MediaInfo
+    xmlns="https://mediaarea.net/mediainfo"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="https://mediaarea.net/mediainfo https://mediaarea.net/mediainfo/mediainfo_2_0.xsd"
+    version="2.0">
+<creatingLibrary version="18.05" url="https://mediaarea.net/MediaInfo">MediaInfoLib</creatingLibrary>
+<media ref="spec/fixtures/ffmpeg/completed-id/low.mp4">
+<track type="General">
+<VideoCount>1</VideoCount>
+<AudioCount>1</AudioCount>
+<FileExtension>mp4</FileExtension>
+<Format>MPEG-4</Format>
+<Format_Profile>Base Media</Format_Profile>
+<CodecID>isom</CodecID>
+<FileSize>125403</FileSize>
+<Duration>6.336</Duration>
+<OverallBitRate>158337</OverallBitRate>
+<FrameRate>24.000</FrameRate>
+<FrameCount>150</FrameCount>
+<StreamSize>5648</StreamSize>
+<HeaderSize>40</HeaderSize>
+<DataSize>119763</DataSize>
+<FooterSize>5600</FooterSize>
+<IsStreamable>No</IsStreamable>
+<File_Modified_Date>UTC 2018-09-07 17:36:26</File_Modified_Date>
+<File_Modified_Date_Local>2018-09-07 13:36:26</File_Modified_Date_Local>
+<Encoded_Application>Lavf58.12.100</Encoded_Application>
+</track>
+<track type="Video">
+<StreamOrder>0</StreamOrder>
+<ID>1</ID>
+<Format>AVC</Format>
+<Format_Profile>High</Format_Profile>
+<Format_Level>1.1</Format_Level>
+<Format_Settings_CABAC>Yes</Format_Settings_CABAC>
+<Format_Settings_RefFrames>4</Format_Settings_RefFrames>
+<CodecID>avc1</CodecID>
+<Duration>6.250</Duration>
+<BitRate>79302</BitRate>
+<Width>200</Width>
+<Height>110</Height>
+<Stored_Width>208</Stored_Width>
+<Stored_Height>112</Stored_Height>
+<Sampled_Width>200</Sampled_Width>
+<Sampled_Height>110</Sampled_Height>
+<PixelAspectRatio>1.000</PixelAspectRatio>
+<DisplayAspectRatio>1.818</DisplayAspectRatio>
+<Rotation>0.000</Rotation>
+<FrameRate_Mode>CFR</FrameRate_Mode>
+<FrameRate_Mode_Original>VFR</FrameRate_Mode_Original>
+<FrameRate>24.000</FrameRate>
+<FrameCount>150</FrameCount>
+<ColorSpace>YUV</ColorSpace>
+<ChromaSubsampling>4:2:0</ChromaSubsampling>
+<BitDepth>8</BitDepth>
+<ScanType>Progressive</ScanType>
+<StreamSize>61955</StreamSize>
+<Encoded_Library>x264 - core 152 r2854 e9a5903</Encoded_Library>
+<Encoded_Library_Name>x264</Encoded_Library_Name>
+<Encoded_Library_Version>core 152 r2854 e9a5903</Encoded_Library_Version>
+<Encoded_Library_Settings>cabac=1 / ref=3 / deblock=1:0:0 / analyse=0x3:0x113 / me=hex / subme=7 / psy=1 / psy_rd=1.00:0.00 / mixed_ref=1 / me_range=16 / chroma_me=1 / trellis=1 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=1 / chroma_qp_offset=-2 / threads=3 / lookahead_threads=1 / sliced_threads=0 / nr=0 / decimate=1 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / bframes=3 / b_pyramid=2 / b_adapt=1 / b_bias=0 / direct=1 / weightb=1 / open_gop=0 / weightp=2 / keyint=250 / keyint_min=24 / scenecut=40 / intra_refresh=0 / rc_lookahead=40 / rc=crf / mbtree=1 / crf=23.0 / qcomp=0.60 / qpmin=0 / qpmax=69 / qpstep=4 / ip_ratio=1.40 / aq=1:1.00</Encoded_Library_Settings>
+</track>
+<track type="Audio">
+<StreamOrder>1</StreamOrder>
+<ID>2</ID>
+<Format>AAC</Format>
+<Format_Profile>LC</Format_Profile>
+<Format_Settings_SBR>No (Explicit)</Format_Settings_SBR>
+<CodecID>mp4a-40-2</CodecID>
+<Duration>6.336</Duration>
+<BitRate_Mode>CBR</BitRate_Mode>
+<BitRate>72000</BitRate>
+<Channels>2</Channels>
+<Channels_Original>1</Channels_Original>
+<ChannelPositions>Front: C</ChannelPositions>
+<ChannelLayout>C</ChannelLayout>
+<SamplesPerFrame>1024</SamplesPerFrame>
+<SamplingRate>48000</SamplingRate>
+<SamplingCount>304128</SamplingCount>
+<FrameRate>46.875</FrameRate>
+<FrameCount>297</FrameCount>
+<Compression_Mode>Lossy</Compression_Mode>
+<StreamSize>57800</StreamSize>
+<StreamSize_Proportion>0.46091</StreamSize_Proportion>
+<Default>Yes</Default>
+<AlternateGroup>1</AlternateGroup>
+</track>
+</media>
+</MediaInfo>

data/spec/fixtures/ffmpeg/incomplete-id/pid

@@ -0,0 +1 @@
+99999

data/spec/fixtures/ffmpeg/incomplete-id/progress

@@ -0,0 +1,11 @@
+frame=150
+fps=0.0
+stream_0_0_q=-1.0
+bitrate= 158.9kbits/s
+total_size=125403
+out_time_ms=6000000
+out_time=00:00:06.000000
+dup_frames=1
+drop_frames=0
+speed=43.1x
+progress=end

data/spec/integration/elastic_transcoder_adapter_spec.rb

@@ -137,6 +137,54 @@ describe ActiveEncode::EngineAdapters::ElasticTranscoderAdapter do
     end
   end
 
+  describe "#copy_to_input_bucket" do
+    context "when filename has no special characters" do
+      context "non-s3 file" do
+        let(:input_url) { "spec/fixtures/fireworks.mp4" }
+        let(:source_bucket) { "bucket1" }
+
+        it "calls the #upload_to_s3 method" do
+          allow(SecureRandom).to receive(:uuid).and_return("randomstring")
+          expect(described_class.new.send(:copy_to_input_bucket, input_url, source_bucket)).to eq "randomstring/fireworks.mp4"
+        end
+      end
+      context "s3 file" do
+        let(:input_url) { "s3://bucket1/file.mp4" }
+        let(:source_bucket) { "bucket1" }
+
+        it "calls the #check_s3_bucket method" do
+          expect(described_class.new.send(:copy_to_input_bucket, input_url, source_bucket)).to eq "file.mp4"
+        end
+      end
+    end
+    context "when filename has special characters" do
+      context "non-s3 file" do
+        let(:input) { ["'file_with_single_quote'.mp4", '"file_with_double_quote".mp4', "file with space.mp4", "file.with...periods.mp4", "file.with :=+%sp3c!l-ch4cts().mp4"] }
+        let(:clean) { ["_file_with_single_quote_.mp4", "_file_with_double_quote_.mp4", "file_with_space.mp4", "filewithperiods.mp4", "filewith_____sp3c_l-ch4cts__.mp4"] }
+        let(:source_bucket) { "bucket1" }
+
+        it "calls the #upload_to_s3 method" do
+          allow(SecureRandom).to receive(:uuid).and_return("randomstring")
+          input.each_with_index do |url, index|
+            expect(described_class.new.send(:copy_to_input_bucket, "spec/fixtures/#{url}", source_bucket)).to eq "randomstring/#{clean[index]}"
+          end
+        end
+      end
+      context "s3 file" do
+        let(:input_urls) { ["s3://bucket1/'file_with_single_quote'.mp4", 's3://bucket1/"file_with_double_quote".mp4', "s3://bucket1/file with space.mp4", "s3://bucket1/file.with...periods.mp4", "s3://bucket1/file.with :=+%sp3c!l-ch4cts().mp4"] }
+        let(:clean) { ["_file_with_single_quote_.mp4", "_file_with_double_quote_.mp4", "file_with_space.mp4", "filewithperiods.mp4", "filewith_____sp3c_l-ch4cts__.mp4"] }
+        let(:source_bucket) { "bucket2" }
+
+        it "calls the #check_s3_bucket method" do
+          allow(SecureRandom).to receive(:uuid).and_return("randomstring")
+          input_urls.each_with_index do |url, index|
+            expect(described_class.new.send(:copy_to_input_bucket, url, source_bucket)).to eq "randomstring/#{clean[index]}"
+          end
+        end
+      end
+    end
+  end
+
   describe "#check_s3_bucket" do
     context "when file exists in masterfile_bucket" do
       let(:input_url) { "s3://bucket1/file.mp4" }

data/spec/integration/ffmpeg_adapter_spec.rb

@@ -38,6 +38,7 @@ describe ActiveEncode::EngineAdapters::FfmpegAdapter do
   end
   let(:completed_job) { find_encode "completed-id" }
   let(:completed_with_warnings_job) { find_encode "completed-with-warnings-id" }
+  let(:incomplete_job) { find_encode "incomplete-id" }
   let(:failed_job) { find_encode 'failed-id' }
   let(:completed_tech_metadata) do
     {
@@ -147,6 +148,114 @@ describe ActiveEncode::EngineAdapters::FfmpegAdapter do
       end
     end
 
+    context "input filename with single quotes" do
+      let(:file_with_single_quote) { "file://" + Rails.root.join('..', 'spec', 'fixtures', "'file_with_single_quote'.mp4").to_s }
+      let!(:create_single_quote_job) { ActiveEncode::Base.create(file_with_single_quote, outputs: [{ label: "low", ffmpeg_opt: "-s 640x480", extension: 'mp4' }]) }
+      let(:find_single_quote_job) { ActiveEncode::Base.find create_single_quote_job.id }
+
+      it "does not have errors" do
+        sleep 2
+        expect(find_single_quote_job.errors).to be_empty
+      end
+
+      it "has the input technical metadata in a file" do
+        expect(File.read("#{work_dir}/#{create_single_quote_job.id}/input_metadata")).not_to be_empty
+      end
+
+      it "has the pid in a file" do
+        expect(File.read("#{work_dir}/#{create_single_quote_job.id}/pid")).not_to be_empty
+      end
+
+      context 'when uri encoded' do
+        let(:file_with_single_quote) { Addressable::URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', "'file_with_single_quote'.mp4").to_s) }
+
+        it "does not have errors" do
+          sleep 2
+          expect(find_single_quote_job.errors).to be_empty
+        end
+
+        it "has the input technical metadata in a file" do
+          expect(File.read("#{work_dir}/#{create_single_quote_job.id}/input_metadata")).not_to be_empty
+        end
+
+        it "has the pid in a file" do
+          expect(File.read("#{work_dir}/#{create_single_quote_job.id}/pid")).not_to be_empty
+        end
+      end
+    end
+
+    context "input filename with double quotes" do
+      let(:file_with_double_quote) { "file://" + Rails.root.join('..', 'spec', 'fixtures', '"file_with_double_quote".mp4').to_s }
+      let!(:create_double_quote_job) { ActiveEncode::Base.create(file_with_double_quote, outputs: [{ label: "low", ffmpeg_opt: "-s 640x480", extension: 'mp4' }]) }
+      let(:find_double_quote_job) { ActiveEncode::Base.find create_double_quote_job.id }
+
+      it "does not have errors" do
+        sleep 2
+        expect(find_double_quote_job.errors).to be_empty
+      end
+
+      it "has the input technical metadata in a file" do
+        expect(File.read("#{work_dir}/#{create_double_quote_job.id}/input_metadata")).not_to be_empty
+      end
+
+      it "has the pid in a file" do
+        expect(File.read("#{work_dir}/#{create_double_quote_job.id}/pid")).not_to be_empty
+      end
+
+      context 'when uri encoded' do
+        let(:file_with_double_quote) { Addressable::URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', '"file_with_double_quote".mp4').to_s) }
+
+        it "does not have errors" do
+          sleep 2
+          expect(find_double_quote_job.errors).to be_empty
+        end
+
+        it "has the input technical metadata in a file" do
+          expect(File.read("#{work_dir}/#{create_double_quote_job.id}/input_metadata")).not_to be_empty
+        end
+
+        it "has the pid in a file" do
+          expect(File.read("#{work_dir}/#{create_double_quote_job.id}/pid")).not_to be_empty
+        end
+      end
+    end
+
+    context "input filename with other special characters" do
+      let(:file_with_special_characters) { "file://" + Rails.root.join('..', 'spec', 'fixtures', 'file.with :=+%sp3c!l-ch4cts().mp4').to_s }
+      let!(:create_special_characters_job) { ActiveEncode::Base.create(file_with_special_characters, outputs: [{ label: "low", ffmpeg_opt: "-s 640x480", extension: 'mp4' }]) }
+      let(:find_special_characters_job) { ActiveEncode::Base.find create_special_characters_job.id }
+
+      it "does not have errors" do
+        sleep 2
+        expect(find_special_characters_job.errors).to be_empty
+      end
+
+      it "has the input technical metadata in a file" do
+        expect(File.read("#{work_dir}/#{create_special_characters_job.id}/input_metadata")).not_to be_empty
+      end
+
+      it "has the pid in a file" do
+        expect(File.read("#{work_dir}/#{create_special_characters_job.id}/pid")).not_to be_empty
+      end
+
+      context 'when uri encoded' do
+        let(:file_with_special_characters) { Addressable::URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', 'file.with :=+%sp3c!l-ch4cts().mp4').to_s) }
+
+        it "does not have errors" do
+          sleep 2
+          expect(find_special_characters_job.errors).to be_empty
+        end
+
+        it "has the input technical metadata in a file" do
+          expect(File.read("#{work_dir}/#{create_special_characters_job.id}/input_metadata")).not_to be_empty
+        end
+
+        it "has the pid in a file" do
+          expect(File.read("#{work_dir}/#{create_special_characters_job.id}/pid")).not_to be_empty
+        end
+      end
+    end
+
     context 'when failed' do
       subject { created_job }
 
@@ -212,6 +321,21 @@ describe ActiveEncode::EngineAdapters::FfmpegAdapter do
         expect(File).to exist("#{work_dir}/#{subject.id}/exit_status.code")
         expect(File.read("#{work_dir}/#{subject.id}/exit_status.code").to_i).to eq(-22)
       end
+
+      context 'with less than 100 percent completeness' do
+        subject { incomplete_job }
+
+        it { is_expected.to be_failed }
+        it 'has an error' do
+          expect(incomplete_job.errors).to include "Encoding has completed but the output duration is shorter than the input"
+        end
+
+        it 'succeeds with a configured completeness threshold' do
+          allow(ActiveEncode::EngineAdapters::FfmpegAdapter).to receive(:completeness_threshold).and_return(95)
+          expect(incomplete_job).not_to be_failed
+          expect(incomplete_job.errors).to be_empty
+        end
+      end
     end
   end
 

data/spec/integration/media_convert_adapter_spec.rb

@@ -40,12 +40,15 @@ describe ActiveEncode::EngineAdapters::MediaConvertAdapter do
   let(:cloudwatch_events) { Aws::CloudWatchEvents::Client.new(stub_responses: true) }
   let(:cloudwatch_logs) { Aws::CloudWatchLogs::Client.new(stub_responses: true) }
 
+  let(:s3client) { Aws::S3::Client.new(stub_responses: true) }
+
   before do
     mediaconvert.stub_responses(:describe_endpoints, reconstitute_response("media_convert/endpoints.json"))
 
     allow(Aws::MediaConvert::Client).to receive(:new).and_return(mediaconvert)
     allow(Aws::CloudWatchEvents::Client).to receive(:new).and_return(cloudwatch_events)
     allow(Aws::CloudWatchLogs::Client).to receive(:new).and_return(cloudwatch_logs)
+    allow(Aws::S3::Client).to receive(:new).and_return(s3client)
   end
 
   let(:created_job) do
@@ -267,4 +270,52 @@ describe ActiveEncode::EngineAdapters::MediaConvertAdapter do
       completed_job
     end
   end
+
+  describe "#s3_uri" do
+    context "when filename has no special characters" do
+      context "non-s3 file" do
+        let(:input_url) { "spec/fixtures/fireworks.mp4" }
+        let(:source_bucket) { "bucket1" }
+
+        it "calls the #upload_to_s3 method" do
+          allow(SecureRandom).to receive(:uuid).and_return("randomstring")
+          expect(described_class.new.send(:s3_uri, input_url, { masterfile_bucket: source_bucket })).to eq "randomstring/fireworks.mp4"
+        end
+      end
+      context "s3 file" do
+        let(:input_url) { "s3://bucket1/file.mp4" }
+        let(:source_bucket) { "bucket1" }
+
+        it "calls the #check_s3_bucket method" do
+          expect(described_class.new.send(:s3_uri, input_url, { masterfile_bucket: source_bucket })).to eq "file.mp4"
+        end
+      end
+    end
+    context "when filename has special characters" do
+      context "non-s3 file" do
+        let(:input) { ["'file_with_single_quote'.mp4", '"file_with_double_quote".mp4', "file with space.mp4", "file.with...periods.mp4", "file.with :=+%sp3c!l-ch4cts().mp4"] }
+        let(:clean) { ["_file_with_single_quote_.mp4", "_file_with_double_quote_.mp4", "file_with_space.mp4", "filewithperiods.mp4", "filewith_____sp3c_l-ch4cts__.mp4"] }
+        let(:source_bucket) { "bucket1" }
+
+        it "calls the #upload_to_s3 method" do
+          allow(SecureRandom).to receive(:uuid).and_return("randomstring")
+          input.each_with_index do |url, index|
+            expect(described_class.new.send(:s3_uri, "spec/fixtures/#{url}", { masterfile_bucket: source_bucket })).to eq "randomstring/#{clean[index]}"
+          end
+        end
+      end
+      context "s3 file" do
+        let(:input_urls) { ["s3://bucket1/'file_with_single_quote'.mp4", 's3://bucket1/"file_with_double_quote".mp4', "s3://bucket1/file with space.mp4", "s3://bucket1/file.with...periods.mp4", "s3://bucket1/file.with :=+%sp3c!l-ch4cts().mp4"] }
+        let(:clean) { ["_file_with_single_quote_.mp4", "_file_with_double_quote_.mp4", "file_with_space.mp4", "filewithperiods.mp4", "filewith_____sp3c_l-ch4cts__.mp4"] }
+        let(:source_bucket) { "bucket2" }
+
+        it "calls the #check_s3_bucket method" do
+          allow(SecureRandom).to receive(:uuid).and_return("randomstring")
+          input_urls.each_with_index do |url, index|
+            expect(described_class.new.send(:s3_uri, url, { masterfile_bucket: source_bucket })).to eq "randomstring/#{clean[index]}"
+          end
+        end
+      end
+    end
+  end
 end

data/spec/integration/pass_through_adapter_spec.rb

@@ -137,6 +137,90 @@ describe ActiveEncode::EngineAdapters::PassThroughAdapter do
       end
     end
 
+    context "input filename with single quotes" do
+      let(:file_with_single_quote) { "file://" + Rails.root.join('..', 'spec', 'fixtures', "'file_with_single_quote'.mp4").to_s }
+      let(:file_with_single_quote_derivative) { "file://" + Rails.root.join('..', 'spec', 'fixtures', "'file_with_single_quote'.low.mp4").to_s }
+      let!(:create_single_quote_job) { ActiveEncode::Base.create(file_with_single_quote, outputs: [{ label: "low", url: file_with_single_quote_derivative }]) }
+      let(:find_single_quote_job) { ActiveEncode::Base.find create_single_quote_job.id }
+
+      it "does not have errors" do
+        expect(find_single_quote_job.errors).to be_empty
+      end
+
+      it "has the input technical metadata in a file" do
+        expect(File.read("#{work_dir}/#{create_single_quote_job.id}/input_metadata")).not_to be_empty
+      end
+
+      context 'when uri encoded' do
+        let(:file_with_single_quote) { Addressable::URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', "'file_with_single_quote'.mp4").to_s) }
+        let(:file_with_single_quote_derivative) { "file://" + Rails.root.join('..', 'spec', 'fixtures', "'file_with_single_quote'.low.mp4").to_s }
+
+        it "does not have errors" do
+          expect(find_single_quote_job.errors).to be_empty
+        end
+
+        it "has the input technical metadata in a file" do
+          expect(File.read("#{work_dir}/#{create_single_quote_job.id}/input_metadata")).not_to be_empty
+        end
+      end
+    end
+
+    context "input filename with double quotes" do
+      let(:file_with_double_quote) { "file://" + Rails.root.join('..', 'spec', 'fixtures', '"file_with_double_quote".mp4').to_s }
+      let(:file_with_double_quote_derivative) { "file://" + Rails.root.join('..', 'spec', 'fixtures', '"file_with_double_quote".mp4').to_s }
+      let!(:create_double_quote_job) { ActiveEncode::Base.create(file_with_double_quote, outputs: [{ label: "low", url: file_with_double_quote_derivative }]) }
+      let(:find_double_quote_job) { ActiveEncode::Base.find create_double_quote_job.id }
+
+      it "does not have errors" do
+        expect(find_double_quote_job.errors).to be_empty
+      end
+
+      it "has the input technical metadata in a file" do
+        expect(File.read("#{work_dir}/#{create_double_quote_job.id}/input_metadata")).not_to be_empty
+      end
+
+      context 'when uri encoded' do
+        let(:file_with_double_quote) { Addressable::URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', '"file_with_double_quote".mp4').to_s) }
+        let(:file_with_double_quote_derivative) { "file://" + Rails.root.join('..', 'spec', 'fixtures', '"file_with_double_quote".mp4').to_s }
+
+        it "does not have errors" do
+          expect(find_double_quote_job.errors).to be_empty
+        end
+
+        it "has the input technical metadata in a file" do
+          expect(File.read("#{work_dir}/#{create_double_quote_job.id}/input_metadata")).not_to be_empty
+        end
+      end
+    end
+
+    context "input filename with other special characters" do
+      let(:file_with_special_characters) { "file://" + Rails.root.join('..', 'spec', 'fixtures', 'file.with :=+%sp3c!l-ch4cts().mp4').to_s }
+      let(:file_with_special_characters_derivative) { "file://" + Rails.root.join('..', 'spec', 'fixtures', 'file.with :=+%sp3c!l-ch4cts().mp4').to_s }
+      let!(:create_special_characters_job) { ActiveEncode::Base.create(file_with_special_characters, outputs: [{ label: "low", url: file_with_special_characters_derivative }]) }
+      let(:find_special_characters_job) { ActiveEncode::Base.find create_special_characters_job.id }
+
+      it "does not have errors" do
+        expect(find_special_characters_job.errors).to be_empty
+      end
+
+      it "has the input technical metadata in a file" do
+        expect(File.read("#{work_dir}/#{create_special_characters_job.id}/input_metadata")).not_to be_empty
+      end
+
+      context 'when uri encoded' do
+        let(:file_with_special_characters) { Addressable::URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', 'file.with :=+%sp3c!l-ch4cts().mp4').to_s) }
+        let(:file_with_special_characters_derivative) { "file://" + Rails.root.join('..', 'spec', 'fixtures', 'file.with :=+%sp3c!l-ch4cts().mp4').to_s }
+
+        it "does not have errors" do
+          expect(find_special_characters_job.errors).to be_empty
+        end
+
+        it "has the input technical metadata in a file" do
+          expect(File.read("#{work_dir}/#{create_special_characters_job.id}/input_metadata")).not_to be_empty
+        end
+      end
+    end
+
     context 'when failed' do
       subject { created_job }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_encode
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Michael Klein, Chris Colvard, Phuong Dinh
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-07-13 00:00:00.000000000 Z
+date: 2022-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -285,6 +285,7 @@ files:
 - lib/active_encode/engine_adapters/test_adapter.rb
 - lib/active_encode/engine_adapters/zencoder_adapter.rb
 - lib/active_encode/errors.rb
+- lib/active_encode/filename_sanitizer.rb
 - lib/active_encode/global_id.rb
 - lib/active_encode/input.rb
 - lib/active_encode/output.rb
@@ -297,6 +298,10 @@ files:
 - lib/active_encode/version.rb
 - lib/file_locator.rb
 - spec/controllers/encode_record_controller_spec.rb
+- spec/fixtures/"file_with_double_quote".low.mp4
+- spec/fixtures/"file_with_double_quote".mp4
+- spec/fixtures/'file_with_single_quote'.low.mp4
+- spec/fixtures/'file_with_single_quote'.mp4
 - spec/fixtures/Bars_512kb.mp4
 - spec/fixtures/elastic_transcoder/input_completed.json
 - spec/fixtures/elastic_transcoder/input_generic.json
@@ -340,12 +345,23 @@ files:
 - spec/fixtures/ffmpeg/failed-id/input_metadata
 - spec/fixtures/ffmpeg/failed-id/pid
 - spec/fixtures/ffmpeg/failed-id/progress
+- spec/fixtures/ffmpeg/incomplete-id/error.log
+- spec/fixtures/ffmpeg/incomplete-id/exit_status.code
+- spec/fixtures/ffmpeg/incomplete-id/input_metadata
+- spec/fixtures/ffmpeg/incomplete-id/output_metadata-high
+- spec/fixtures/ffmpeg/incomplete-id/output_metadata-low
+- spec/fixtures/ffmpeg/incomplete-id/pid
+- spec/fixtures/ffmpeg/incomplete-id/progress
+- spec/fixtures/ffmpeg/incomplete-id/video-high.mp4
+- spec/fixtures/ffmpeg/incomplete-id/video-low.mp4
 - spec/fixtures/ffmpeg/running-id/error.log
 - spec/fixtures/ffmpeg/running-id/input_metadata
 - spec/fixtures/ffmpeg/running-id/pid
 - spec/fixtures/ffmpeg/running-id/progress
 - spec/fixtures/file with space.low.mp4
 - spec/fixtures/file with space.mp4
+- spec/fixtures/file.with :=+%sp3c!l-ch4cts().mp4
+- spec/fixtures/file.with...periods.mp4
 - spec/fixtures/fireworks.low.mp4
 - spec/fixtures/fireworks.mp4
 - spec/fixtures/matterhorn/cancelled_response.xml
@@ -435,6 +451,10 @@ specification_version: 4
 summary: Declare encode job classes that can be run by a variety of encoding services
 test_files:
 - spec/controllers/encode_record_controller_spec.rb
+- spec/fixtures/"file_with_double_quote".low.mp4
+- spec/fixtures/"file_with_double_quote".mp4
+- spec/fixtures/'file_with_single_quote'.low.mp4
+- spec/fixtures/'file_with_single_quote'.mp4
 - spec/fixtures/Bars_512kb.mp4
 - spec/fixtures/elastic_transcoder/input_completed.json
 - spec/fixtures/elastic_transcoder/input_generic.json
@@ -478,12 +498,23 @@ test_files:
 - spec/fixtures/ffmpeg/failed-id/input_metadata
 - spec/fixtures/ffmpeg/failed-id/pid
 - spec/fixtures/ffmpeg/failed-id/progress
+- spec/fixtures/ffmpeg/incomplete-id/error.log
+- spec/fixtures/ffmpeg/incomplete-id/exit_status.code
+- spec/fixtures/ffmpeg/incomplete-id/input_metadata
+- spec/fixtures/ffmpeg/incomplete-id/output_metadata-high
+- spec/fixtures/ffmpeg/incomplete-id/output_metadata-low
+- spec/fixtures/ffmpeg/incomplete-id/pid
+- spec/fixtures/ffmpeg/incomplete-id/progress
+- spec/fixtures/ffmpeg/incomplete-id/video-high.mp4
+- spec/fixtures/ffmpeg/incomplete-id/video-low.mp4
 - spec/fixtures/ffmpeg/running-id/error.log
 - spec/fixtures/ffmpeg/running-id/input_metadata
 - spec/fixtures/ffmpeg/running-id/pid
 - spec/fixtures/ffmpeg/running-id/progress
 - spec/fixtures/file with space.low.mp4
 - spec/fixtures/file with space.mp4
+- spec/fixtures/file.with :=+%sp3c!l-ch4cts().mp4
+- spec/fixtures/file.with...periods.mp4
 - spec/fixtures/fireworks.low.mp4
 - spec/fixtures/fireworks.mp4
 - spec/fixtures/matterhorn/cancelled_response.xml