active_encode 0.8.0 → 1.0.0

data/spec/fixtures/ffmpeg/completed-with-warnings-id/output_metadata-high

@@ -0,0 +1,90 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<MediaInfo
+    xmlns="https://mediaarea.net/mediainfo"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="https://mediaarea.net/mediainfo https://mediaarea.net/mediainfo/mediainfo_2_0.xsd"
+    version="2.0">
+<creatingLibrary version="18.05" url="https://mediaarea.net/MediaInfo">MediaInfoLib</creatingLibrary>
+<media ref="spec/fixtures/ffmpeg/completed-id/low.mp4">
+<track type="General">
+<VideoCount>1</VideoCount>
+<AudioCount>1</AudioCount>
+<FileExtension>mp4</FileExtension>
+<Format>MPEG-4</Format>
+<Format_Profile>Base Media</Format_Profile>
+<CodecID>isom</CodecID>
+<FileSize>125403</FileSize>
+<Duration>6.336</Duration>
+<OverallBitRate>158337</OverallBitRate>
+<FrameRate>24.000</FrameRate>
+<FrameCount>150</FrameCount>
+<StreamSize>5648</StreamSize>
+<HeaderSize>40</HeaderSize>
+<DataSize>119763</DataSize>
+<FooterSize>5600</FooterSize>
+<IsStreamable>No</IsStreamable>
+<File_Modified_Date>UTC 2018-09-07 17:36:26</File_Modified_Date>
+<File_Modified_Date_Local>2018-09-07 13:36:26</File_Modified_Date_Local>
+<Encoded_Application>Lavf58.12.100</Encoded_Application>
+</track>
+<track type="Video">
+<StreamOrder>0</StreamOrder>
+<ID>1</ID>
+<Format>AVC</Format>
+<Format_Profile>High</Format_Profile>
+<Format_Level>1.1</Format_Level>
+<Format_Settings_CABAC>Yes</Format_Settings_CABAC>
+<Format_Settings_RefFrames>4</Format_Settings_RefFrames>
+<CodecID>avc1</CodecID>
+<Duration>6.250</Duration>
+<BitRate>79302</BitRate>
+<Width>200</Width>
+<Height>110</Height>
+<Stored_Width>208</Stored_Width>
+<Stored_Height>112</Stored_Height>
+<Sampled_Width>200</Sampled_Width>
+<Sampled_Height>110</Sampled_Height>
+<PixelAspectRatio>1.000</PixelAspectRatio>
+<DisplayAspectRatio>1.818</DisplayAspectRatio>
+<Rotation>0.000</Rotation>
+<FrameRate_Mode>CFR</FrameRate_Mode>
+<FrameRate_Mode_Original>VFR</FrameRate_Mode_Original>
+<FrameRate>24.000</FrameRate>
+<FrameCount>150</FrameCount>
+<ColorSpace>YUV</ColorSpace>
+<ChromaSubsampling>4:2:0</ChromaSubsampling>
+<BitDepth>8</BitDepth>
+<ScanType>Progressive</ScanType>
+<StreamSize>61955</StreamSize>
+<Encoded_Library>x264 - core 152 r2854 e9a5903</Encoded_Library>
+<Encoded_Library_Name>x264</Encoded_Library_Name>
+<Encoded_Library_Version>core 152 r2854 e9a5903</Encoded_Library_Version>
+<Encoded_Library_Settings>cabac=1 / ref=3 / deblock=1:0:0 / analyse=0x3:0x113 / me=hex / subme=7 / psy=1 / psy_rd=1.00:0.00 / mixed_ref=1 / me_range=16 / chroma_me=1 / trellis=1 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=1 / chroma_qp_offset=-2 / threads=3 / lookahead_threads=1 / sliced_threads=0 / nr=0 / decimate=1 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / bframes=3 / b_pyramid=2 / b_adapt=1 / b_bias=0 / direct=1 / weightb=1 / open_gop=0 / weightp=2 / keyint=250 / keyint_min=24 / scenecut=40 / intra_refresh=0 / rc_lookahead=40 / rc=crf / mbtree=1 / crf=23.0 / qcomp=0.60 / qpmin=0 / qpmax=69 / qpstep=4 / ip_ratio=1.40 / aq=1:1.00</Encoded_Library_Settings>
+</track>
+<track type="Audio">
+<StreamOrder>1</StreamOrder>
+<ID>2</ID>
+<Format>AAC</Format>
+<Format_Profile>LC</Format_Profile>
+<Format_Settings_SBR>No (Explicit)</Format_Settings_SBR>
+<CodecID>mp4a-40-2</CodecID>
+<Duration>6.336</Duration>
+<BitRate_Mode>CBR</BitRate_Mode>
+<BitRate>72000</BitRate>
+<Channels>2</Channels>
+<Channels_Original>1</Channels_Original>
+<ChannelPositions>Front: C</ChannelPositions>
+<ChannelLayout>C</ChannelLayout>
+<SamplesPerFrame>1024</SamplesPerFrame>
+<SamplingRate>48000</SamplingRate>
+<SamplingCount>304128</SamplingCount>
+<FrameRate>46.875</FrameRate>
+<FrameCount>297</FrameCount>
+<Compression_Mode>Lossy</Compression_Mode>
+<StreamSize>57800</StreamSize>
+<StreamSize_Proportion>0.46091</StreamSize_Proportion>
+<Default>Yes</Default>
+<AlternateGroup>1</AlternateGroup>
+</track>
+</media>
+</MediaInfo>

data/spec/fixtures/ffmpeg/completed-with-warnings-id/output_metadata-low

@@ -0,0 +1,90 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<MediaInfo
+    xmlns="https://mediaarea.net/mediainfo"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="https://mediaarea.net/mediainfo https://mediaarea.net/mediainfo/mediainfo_2_0.xsd"
+    version="2.0">
+<creatingLibrary version="18.05" url="https://mediaarea.net/MediaInfo">MediaInfoLib</creatingLibrary>
+<media ref="spec/fixtures/ffmpeg/completed-id/low.mp4">
+<track type="General">
+<VideoCount>1</VideoCount>
+<AudioCount>1</AudioCount>
+<FileExtension>mp4</FileExtension>
+<Format>MPEG-4</Format>
+<Format_Profile>Base Media</Format_Profile>
+<CodecID>isom</CodecID>
+<FileSize>125403</FileSize>
+<Duration>6.336</Duration>
+<OverallBitRate>158337</OverallBitRate>
+<FrameRate>24.000</FrameRate>
+<FrameCount>150</FrameCount>
+<StreamSize>5648</StreamSize>
+<HeaderSize>40</HeaderSize>
+<DataSize>119763</DataSize>
+<FooterSize>5600</FooterSize>
+<IsStreamable>No</IsStreamable>
+<File_Modified_Date>UTC 2018-09-07 17:36:26</File_Modified_Date>
+<File_Modified_Date_Local>2018-09-07 13:36:26</File_Modified_Date_Local>
+<Encoded_Application>Lavf58.12.100</Encoded_Application>
+</track>
+<track type="Video">
+<StreamOrder>0</StreamOrder>
+<ID>1</ID>
+<Format>AVC</Format>
+<Format_Profile>High</Format_Profile>
+<Format_Level>1.1</Format_Level>
+<Format_Settings_CABAC>Yes</Format_Settings_CABAC>
+<Format_Settings_RefFrames>4</Format_Settings_RefFrames>
+<CodecID>avc1</CodecID>
+<Duration>6.250</Duration>
+<BitRate>79302</BitRate>
+<Width>200</Width>
+<Height>110</Height>
+<Stored_Width>208</Stored_Width>
+<Stored_Height>112</Stored_Height>
+<Sampled_Width>200</Sampled_Width>
+<Sampled_Height>110</Sampled_Height>
+<PixelAspectRatio>1.000</PixelAspectRatio>
+<DisplayAspectRatio>1.818</DisplayAspectRatio>
+<Rotation>0.000</Rotation>
+<FrameRate_Mode>CFR</FrameRate_Mode>
+<FrameRate_Mode_Original>VFR</FrameRate_Mode_Original>
+<FrameRate>24.000</FrameRate>
+<FrameCount>150</FrameCount>
+<ColorSpace>YUV</ColorSpace>
+<ChromaSubsampling>4:2:0</ChromaSubsampling>
+<BitDepth>8</BitDepth>
+<ScanType>Progressive</ScanType>
+<StreamSize>61955</StreamSize>
+<Encoded_Library>x264 - core 152 r2854 e9a5903</Encoded_Library>
+<Encoded_Library_Name>x264</Encoded_Library_Name>
+<Encoded_Library_Version>core 152 r2854 e9a5903</Encoded_Library_Version>
+<Encoded_Library_Settings>cabac=1 / ref=3 / deblock=1:0:0 / analyse=0x3:0x113 / me=hex / subme=7 / psy=1 / psy_rd=1.00:0.00 / mixed_ref=1 / me_range=16 / chroma_me=1 / trellis=1 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=1 / chroma_qp_offset=-2 / threads=3 / lookahead_threads=1 / sliced_threads=0 / nr=0 / decimate=1 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / bframes=3 / b_pyramid=2 / b_adapt=1 / b_bias=0 / direct=1 / weightb=1 / open_gop=0 / weightp=2 / keyint=250 / keyint_min=24 / scenecut=40 / intra_refresh=0 / rc_lookahead=40 / rc=crf / mbtree=1 / crf=23.0 / qcomp=0.60 / qpmin=0 / qpmax=69 / qpstep=4 / ip_ratio=1.40 / aq=1:1.00</Encoded_Library_Settings>
+</track>
+<track type="Audio">
+<StreamOrder>1</StreamOrder>
+<ID>2</ID>
+<Format>AAC</Format>
+<Format_Profile>LC</Format_Profile>
+<Format_Settings_SBR>No (Explicit)</Format_Settings_SBR>
+<CodecID>mp4a-40-2</CodecID>
+<Duration>6.336</Duration>
+<BitRate_Mode>CBR</BitRate_Mode>
+<BitRate>72000</BitRate>
+<Channels>2</Channels>
+<Channels_Original>1</Channels_Original>
+<ChannelPositions>Front: C</ChannelPositions>
+<ChannelLayout>C</ChannelLayout>
+<SamplesPerFrame>1024</SamplesPerFrame>
+<SamplingRate>48000</SamplingRate>
+<SamplingCount>304128</SamplingCount>
+<FrameRate>46.875</FrameRate>
+<FrameCount>297</FrameCount>
+<Compression_Mode>Lossy</Compression_Mode>
+<StreamSize>57800</StreamSize>
+<StreamSize_Proportion>0.46091</StreamSize_Proportion>
+<Default>Yes</Default>
+<AlternateGroup>1</AlternateGroup>
+</track>
+</media>
+</MediaInfo>

data/spec/fixtures/ffmpeg/completed-with-warnings-id/pid

@@ -0,0 +1 @@
+99999

data/spec/fixtures/ffmpeg/completed-with-warnings-id/progress

@@ -0,0 +1,11 @@
+frame=150
+fps=0.0
+stream_0_0_q=-1.0
+bitrate= 158.9kbits/s
+total_size=125403
+out_time_ms=6314667
+out_time=00:00:06.314667
+dup_frames=1
+drop_frames=0
+speed=43.1x
+progress=end

data/spec/fixtures/ffmpeg/failed-id/exit_status.code

@@ -0,0 +1 @@
+-22

data/spec/fixtures/media_convert/job_completed_empty_detail.json

@@ -0,0 +1 @@
+{"results":[],"statistics":{"records_matched":1.0,"records_scanned":13.0,"bytes_scanned":10750.0},"status":"Complete"}

data/spec/integration/ffmpeg_adapter_spec.rb

@@ -37,6 +37,7 @@ describe ActiveEncode::EngineAdapters::FfmpegAdapter do
     encode
   end
   let(:completed_job) { find_encode "completed-id" }
+  let(:completed_with_warnings_job) { find_encode "completed-with-warnings-id" }
   let(:failed_job) { find_encode 'failed-id' }
   let(:completed_tech_metadata) do
     {
@@ -129,7 +130,7 @@ describe ActiveEncode::EngineAdapters::FfmpegAdapter do
       end
 
       context 'when uri encoded' do
-        let(:file_with_space) { URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', 'file with space.mp4').to_s) }
+        let(:file_with_space) { Addressable::URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', 'file with space.mp4').to_s) }
 
         it "does not have errors" do
           sleep 2
@@ -164,6 +165,54 @@ describe ActiveEncode::EngineAdapters::FfmpegAdapter do
     it "has a progress file" do
       expect(File).to exist("#{work_dir}/#{subject.id}/progress")
     end
+
+    it "does not have an exit code file" do
+      expect(File).not_to exist("#{work_dir}/#{subject.id}/exit_status.code")
+    end
+
+    context "completed job" do
+      subject { completed_job }
+
+      it { is_expected.to be_completed }
+      it "has an exit code of 0" do
+        expect(File).to exist("#{work_dir}/#{subject.id}/exit_status.code")
+        expect(File.read("#{work_dir}/#{subject.id}/exit_status.code").to_i).to eq 0
+      end
+    end
+
+    context "completed with warnings job" do
+      subject { completed_with_warnings_job }
+
+      it { is_expected.to be_completed }
+      it "has an exit code of 0" do
+        expect(File).to exist("#{work_dir}/#{subject.id}/exit_status.code")
+        expect(File.read("#{work_dir}/#{subject.id}/exit_status.code").to_i).to eq 0
+      end
+      it "has warnings in the error log" do
+        expect(File).to exist("#{work_dir}/#{subject.id}/error.log")
+        expect(File.read("#{work_dir}/#{subject.id}/error.log")).not_to be_empty
+      end
+    end
+
+    context "cancelled job" do
+      subject { canceled_job }
+
+      it { is_expected.to be_cancelled }
+      it "has an exit code of 143" do
+        expect(File).to exist("#{work_dir}/#{subject.id}/exit_status.code")
+        expect(File.read("#{work_dir}/#{subject.id}/exit_status.code").to_i).to eq 143
+      end
+    end
+
+    context "failed job" do
+      subject { failed_job }
+
+      it { is_expected.to be_failed }
+      it "has an exit code of -22" do
+        expect(File).to exist("#{work_dir}/#{subject.id}/exit_status.code")
+        expect(File.read("#{work_dir}/#{subject.id}/exit_status.code").to_i).to eq(-22)
+      end
+    end
   end
 
   describe "#cancel!" do

data/spec/integration/matterhorn_adapter_spec.rb

@@ -102,12 +102,11 @@ describe ActiveEncode::EngineAdapters::MatterhornAdapter do
   end
 
   describe "reload" do
+    subject { running_job.reload }
     before do
       expect(Rubyhorn.client).to receive(:instance_xml).twice.with('running-id').and_return(Rubyhorn::Workflow.from_xml(File.open('spec/fixtures/matterhorn/running_response.xml')))
     end
 
-    subject { running_job.reload }
-
     it { expect(subject.output).to be_empty }
     it { expect(subject.options).to include(preset: 'full') }
     it { expect(subject.current_operations).to include("Hold for workflow selection") }

data/spec/integration/media_convert_adapter_spec.rb

@@ -87,6 +87,16 @@ describe ActiveEncode::EngineAdapters::MediaConvertAdapter do
     ActiveEncode::Base.find(job_id)
   end
 
+  let(:recent_completed_job_without_results) do
+    job_response = reconstitute_response("media_convert/job_completed.json")
+    job_response["job"]["timing"]["finish_time"] = 5.minutes.ago
+    mediaconvert.stub_responses(:get_job, job_response)
+    cloudwatch_logs.stub_responses(:start_query, reconstitute_response("media_convert/job_completed_detail_query.json"))
+    cloudwatch_logs.stub_responses(:get_query_results, reconstitute_response("media_convert/job_completed_empty_detail.json"))
+
+    ActiveEncode::Base.find(job_id)
+  end
+
   let(:failed_job) do
     mediaconvert.stub_responses(:get_job, reconstitute_response("media_convert/job_failed.json"))
 
@@ -113,6 +123,102 @@ describe ActiveEncode::EngineAdapters::MediaConvertAdapter do
 
   it_behaves_like "an ActiveEncode::EngineAdapter"
 
+  describe "output location specification" do
+    let(:operations) { mediaconvert.api_requests(exclude_presign: true) }
+    before do
+      mediaconvert.stub_responses(:create_job, reconstitute_response("media_convert/job_created.json"))
+    end
+
+    it "can use output_bucket and output_prefix" do
+      ActiveEncode::Base.create(
+        "s3://input-bucket/test_files/source_file.mp4",
+        output_prefix: "active-encode-test/output",
+        outputs: [],
+        use_original_url: true
+      )
+      create_job_operation = operations.find { |o| o[:operation_name] == :create_job }
+      expect(create_job_operation).to be_present
+
+      destination = create_job_operation.dig(:params, :settings, :output_groups, 0,
+        :output_group_settings, :hls_group_settings, :destination)
+
+      expect(destination).to eq("s3://output-bucket/active-encode-test/output")
+    end
+
+    it "can use destination arg" do
+      ActiveEncode::Base.create(
+        "s3://input-bucket/test_files/source_file.mp4",
+        destination: "s3://alternate-output-bucket/my-path/output",
+        outputs: [],
+        use_original_url: true
+      )
+      create_job_operation = operations.find { |o| o[:operation_name] == :create_job }
+      expect(create_job_operation).to be_present
+
+      destination = create_job_operation.dig(:params, :settings, :output_groups, 0,
+        :output_group_settings, :hls_group_settings, :destination)
+
+      expect(destination).to eq("s3://alternate-output-bucket/my-path/output")
+    end
+  end
+
+  describe "output_group_destination_settings" do
+    let(:operations) { mediaconvert.api_requests(exclude_presign: true) }
+    before do
+      mediaconvert.stub_responses(:create_job, reconstitute_response("media_convert/job_created.json"))
+    end
+
+    it "are sent to MediaConvert" do
+      ActiveEncode::Base.create(
+        "s3://input-bucket/test_files/source_file.mp4",
+        destination: "s3://alternate-output-bucket/my-path/output",
+        outputs: [],
+        use_original_url: true,
+        output_group_destination_settings: {
+          s3_settings: {
+            access_control: {
+              canned_acl: "PUBLIC_READ"
+            }
+          }
+        }
+      )
+
+      create_job_operation = operations.find { |o| o[:operation_name] == :create_job }
+      expect(create_job_operation).to be_present
+
+      destination_settings = create_job_operation.dig(:params, :settings, :output_groups, 0,
+        :output_group_settings, :hls_group_settings, :destination_settings)
+      expect(destination_settings).to eq({ s3_settings: { access_control: { canned_acl: "PUBLIC_READ" } } })
+    end
+  end
+
+  describe "queue" do
+    let(:operations) { mediaconvert.api_requests(exclude_presign: true) }
+
+    it "uses the default queue" do
+      mediaconvert.stub_responses(:create_job, reconstitute_response("media_convert/job_created.json"))
+      ActiveEncode::Base.create(
+        "s3://input-bucket/test_files/source_file.mp4",
+        output_prefix: "active-encode-test/output",
+        outputs: [],
+        use_original_url: true
+      )
+      expect(operations).to include(include(operation_name: :create_job, params: include(queue: 'Default')))
+    end
+
+    it "uses a specific queue" do
+      mediaconvert.stub_responses(:create_job, reconstitute_response("media_convert/job_created.json"))
+      ActiveEncode::Base.engine_adapter.queue = 'test-queue'
+      ActiveEncode::Base.create(
+        "s3://input-bucket/test_files/source_file.mp4",
+        output_prefix: "active-encode-test/output",
+        outputs: [],
+        use_original_url: true
+      )
+      expect(operations).to include(include(operation_name: :create_job, params: include(queue: 'test-queue')))
+    end
+  end
+
   describe "output" do
     it "contains all expected outputs" do
       completed_output.each do |expected_output|
@@ -122,5 +228,43 @@ describe ActiveEncode::EngineAdapters::MediaConvertAdapter do
         end
       end
     end
+
+    it "has no logging entries but finished within the last 10 minutes" do
+      expect(recent_completed_job_without_results.state).to eq(:running)
+    end
+
+    it "finished more than 10 minutes ago but has no logging entries" do
+      mediaconvert.stub_responses(:get_job, reconstitute_response("media_convert/job_completed.json"))
+      cloudwatch_logs.stub_responses(:start_query, reconstitute_response("media_convert/job_completed_detail_query.json"))
+      cloudwatch_logs.stub_responses(:get_query_results, reconstitute_response("media_convert/job_completed_empty_detail.json"))
+
+      expect { ActiveEncode::Base.find(job_id) }.to raise_error do |error|
+        expect(error).to be_a(ActiveEncode::EngineAdapters::MediaConvertAdapter::ResultsNotAvailable)
+        expect(error.encode).to be_a(ActiveEncode::Base)
+        expect(error.encode.state).to eq(:completed)
+      end
+    end
+  end
+
+  describe "direct_output_lookup" do
+    before do
+      ActiveEncode::Base.engine_adapter.direct_output_lookup = true
+    end
+
+    it "contains all expected outputs" do
+      completed_output.each do |expected_output|
+        found_output = completed_job.output.find { |output| output.id == expected_output[:id] }
+        expected_output.each_pair do |key, value|
+          expect(found_output.send(key)).to eq(value)
+        end
+      end
+    end
+
+    it "does not make cloudwatch queries" do
+      expect(cloudwatch_logs).not_to receive(:start_query)
+      expect(cloudwatch_logs).not_to receive(:get_query_results)
+
+      completed_job
+    end
   end
 end

data/spec/integration/pass_through_adapter_spec.rb

@@ -124,8 +124,8 @@ describe ActiveEncode::EngineAdapters::PassThroughAdapter do
       end
 
       context 'when uri encoded' do
-        let(:file_with_space) { URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', 'file with space.mp4').to_s) }
-        let(:file_with_space_derivative) { URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', 'file with space.low.mp4').to_s) }
+        let(:file_with_space) { Addressable::URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', 'file with space.mp4').to_s) }
+        let(:file_with_space_derivative) { Addressable::URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', 'file with space.low.mp4').to_s) }
 
         it "does not have errors" do
           expect(find_space_job.errors).to be_empty

data/spec/integration/zencoder_adapter_spec.rb

@@ -20,12 +20,12 @@ describe ActiveEncode::EngineAdapters::ZencoderAdapter do
   let(:file) { "file://#{File.absolute_path('spec/fixtures/Bars_512kb.mp4')}" }
 
   describe "#create" do
+    subject { ActiveEncode::Base.create(file) }
     before do
       allow(Zencoder::Job).to receive(:details).and_return(details_response)
       allow(Zencoder::Job).to receive(:progress).and_return(progress_response)
     end
 
-    subject { ActiveEncode::Base.create(file) }
     let(:details_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_details_create.json'))) }
     let(:progress_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_progress_create.json'))) }
     let(:create_output) { [{ id: "511404522", url: "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150610/c09b61e4d130ddf923f0653418a80b9c/399ae101c3f99b4f318635e78a4e587a.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=GY/9LMkQAiDOrMQwS5BkmOE200s%3D&Expires=1434033527", label: nil }] }
@@ -302,13 +302,13 @@ describe ActiveEncode::EngineAdapters::ZencoderAdapter do
   end
 
   describe "#cancel!" do
+    subject { encode.cancel! }
     before do
       allow(Zencoder::Job).to receive(:cancel).and_return(cancel_response)
       allow(Zencoder::Job).to receive(:details).and_return(details_response)
       allow(Zencoder::Job).to receive(:progress).and_return(progress_response)
     end
 
-    subject { encode.cancel! }
     let(:cancel_response) { Zencoder::Response.new(code: 200) } # TODO: check that this is the correct response code for a successful cancel
     let(:details_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_details_cancelled.json'))) }
     let(:progress_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_progress_cancelled.json'))) }
@@ -320,12 +320,12 @@ describe ActiveEncode::EngineAdapters::ZencoderAdapter do
   end
 
   describe "reload" do
+    subject { ActiveEncode::Base.find('166019107').reload }
     before do
       allow(Zencoder::Job).to receive(:details).and_return(details_response)
       allow(Zencoder::Job).to receive(:progress).and_return(progress_response)
     end
 
-    subject { ActiveEncode::Base.find('166019107').reload }
     let(:details_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_details_running.json'))) }
     let(:progress_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_progress_running.json'))) }
     # let(:reload_output) { [{ id: "510582971", url: "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150609/48a6907086c012f68b9ca43461280515/1726d7ec3e24f2171bd07b2abb807b6c.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=vSvlxU94wlQLEbpG3Zs8ibp4MoY%3D&Expires=1433953106", label: nil }] }

data/spec/units/core_spec.rb

@@ -128,6 +128,7 @@ describe ActiveEncode::Core do
   end
 
   describe '#new' do
+    subject { encode.options }
     before do
       class DefaultOptionsEncode < ActiveEncode::Base
         def self.default_options(_input_url)
@@ -139,7 +140,6 @@ describe ActiveEncode::Core do
       Object.send(:remove_const, :DefaultOptionsEncode)
     end
 
-    subject { encode.options }
     let(:encode_class) { DefaultOptionsEncode }
     let(:default_options) { { preset: 'video' } }
     let(:options) { { output: [{ label: 'high', ffmpeg_opt: "640x480" }] } }

data/spec/units/file_locator_spec.rb

@@ -41,7 +41,7 @@ describe FileLocator, type: :service do
   describe "Local file" do
     let(:path) { "/path/to/file.mp4" }
     let(:source) { "file://#{path}" }
-    let(:locator) { FileLocator.new(source) }
+    let(:locator) { described_class.new(source) }
 
     it "returns the correct uri" do
       expect(locator.uri).to eq Addressable::URI.parse(source)
@@ -76,7 +76,7 @@ describe FileLocator, type: :service do
     let(:bucket) { "mybucket" }
     let(:key) { "mykey.mp4" }
     let(:source) { "s3://#{bucket}/#{key}" }
-    let(:locator) { FileLocator.new(source) }
+    let(:locator) { described_class.new(source) }
 
     it "returns the correct uri" do
       expect(locator.uri).to eq Addressable::URI.parse(source)
@@ -102,7 +102,7 @@ describe FileLocator, type: :service do
   describe "Other file" do
     let(:path) { "/path/to/file.mp4" }
     let(:source) { "bogus://#{path}" }
-    let(:locator) { FileLocator.new(source) }
+    let(:locator) { described_class.new(source) }
 
     it "returns the correct uri" do
       expect(locator.uri).to eq Addressable::URI.parse(source)

data/spec/units/status_spec.rb

@@ -2,6 +2,7 @@
 require 'spec_helper'
 
 describe ActiveEncode::Status do
+  subject { encode_class.new(nil) }
   before do
     class CustomEncode < ActiveEncode::Base
     end
@@ -10,7 +11,6 @@ describe ActiveEncode::Status do
     Object.send(:remove_const, :CustomEncode)
   end
 
-  subject { encode_class.new(nil) }
   let(:encode_class) { ActiveEncode::Base }
 
   describe 'attributes' do