active_encode 0.5.0 → 0.8.1

data/spec/rails_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 require 'engine_cart'

data/spec/routing/encode_record_controller_routing_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'rails_helper'
 
 describe ActiveEncode::EncodeRecordController, type: :routing do

data/spec/spec_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'coveralls'
 Coveralls.wear!
 
@@ -5,7 +6,6 @@ require 'bundler/setup'
 Bundler.setup
 
 require 'byebug'
-require 'rspec/its'
 require 'active_encode'
 
 RSpec.configure do |_config|
@@ -13,6 +13,6 @@ end
 
 RSpec::Matchers.define :be_the_same_time_as do |expected|
   match do |actual|
-    expect(Time.parse(expected)).to eq(Time.parse(actual))
+    expect(Time.parse(expected).utc).to eq(Time.parse(actual).utc)
   end
 end

data/spec/test_app_templates/lib/generators/test_app_generator.rb

@@ -1,15 +1,16 @@
-        require 'rails/generators'
+# frozen_string_literal: true
+# frozen_string_literal: true
+require 'rails/generators'
 
-        class TestAppGenerator < Rails::Generators::Base
-          source_root "./spec/test_app_templates"
+class TestAppGenerator < Rails::Generators::Base
+  source_root "./spec/test_app_templates"
 
-          # if you need to generate any additional configuration
-          # into the test app, this generator will be run immediately
-          # after setting up the application
-
-          def install_engine
-            generate 'active_encode:install'
-            rake 'active_encode:install:migrations'
-          end
-        end
+  # if you need to generate any additional configuration
+  # into the test app, this generator will be run immediately
+  # after setting up the application
 
+  def install_engine
+    generate 'active_encode:install'
+    rake 'active_encode:install:migrations'
+  end
+end

data/spec/units/callbacks_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe ActiveEncode::Callbacks do
@@ -36,14 +37,14 @@ describe ActiveEncode::Callbacks do
   end
 
   describe 'find callback' do
-    let(:encode) { CallbackEncode.create("sample.mp4") }
     subject { CallbackEncode.find(encode.id).history }
+    let(:encode) { CallbackEncode.create("sample.mp4") }
     it { is_expected.to include("CallbackEncode ran after_find") }
   end
 
   describe 'reload callback' do
-    let(:encode) { CallbackEncode.create("sample.mp4") }
     subject { encode.reload.history }
+    let(:encode) { CallbackEncode.create("sample.mp4") }
     it { is_expected.to include("CallbackEncode ran after_reload") }
   end
 

data/spec/units/core_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe ActiveEncode::Core do
@@ -5,7 +6,7 @@ describe ActiveEncode::Core do
     class CustomEncode < ActiveEncode::Base
     end
   end
-   after do
+  after do
     Object.send(:remove_const, :CustomEncode)
   end
 
@@ -24,11 +25,11 @@ describe ActiveEncode::Core do
   end
 
   describe 'find' do
-    let(:id) { encode_class.create(nil).id }
     subject { encode_class.find(id) }
+    let(:id) { encode_class.create(nil).id }
 
     it { is_expected.to be_a encode_class }
-    its(:id) { is_expected.to eq id }
+    it { expect(subject.id).to eq id }
 
     context 'with no id' do
       let(:id) { nil }
@@ -42,13 +43,13 @@ describe ActiveEncode::Core do
       let(:encode_class) { CustomEncode }
 
       it { is_expected.to be_a encode_class }
-      its(:id) { is_expected.to eq id }
+      it { expect(subject.id).to eq id }
 
       context 'casting' do
         let(:id) { ActiveEncode::Base.create(nil).id }
 
         it { is_expected.to be_a encode_class }
-        its(:id) { is_expected.to eq id }
+        it { expect(subject.id).to eq id }
       end
     end
   end
@@ -57,44 +58,44 @@ describe ActiveEncode::Core do
     subject { encode_class.create(nil) }
 
     it { is_expected.to be_a encode_class }
-    its(:id) { is_expected.not_to be nil }
-    its(:state) { is_expected.not_to be nil }
+    it { expect(subject.id).not_to be nil }
+    it { expect(subject.state).not_to be nil }
 
     context 'with an ActiveEncode::Base subclass' do
       let(:encode_class) { CustomEncode }
 
       it { is_expected.to be_a encode_class }
-      its(:id) { is_expected.not_to be nil }
-      its(:state) { is_expected.not_to be nil }
+      it { expect(subject.id).not_to be nil }
+      it { expect(subject.state).not_to be nil }
     end
   end
 
   describe '#create!' do
-    let(:encode) { encode_class.new(nil) }
     subject { encode.create! }
+    let(:encode) { encode_class.new(nil) }
 
     it { is_expected.to equal encode }
     it { is_expected.to be_a encode_class }
-    its(:id) { is_expected.not_to be nil }
-    its(:state) { is_expected.not_to be nil }
+    it { expect(subject.id).not_to be nil }
+    it { expect(subject.state).not_to be nil }
 
     context 'with an ActiveEncode::Base subclass' do
       let(:encode_class) { CustomEncode }
 
       it { is_expected.to equal encode }
       it { is_expected.to be_a encode_class }
-      its(:id) { is_expected.not_to be nil }
-      its(:state) { is_expected.not_to be nil }
+      it { expect(subject.id).not_to be nil }
+      it { expect(subject.state).not_to be nil }
     end
   end
 
   describe '#cancel!' do
-    let(:encode) { encode_class.create(nil) }
     subject { encode.cancel! }
+    let(:encode) { encode_class.create(nil) }
 
     it { is_expected.to equal encode }
     it { is_expected.to be_a encode_class }
-    its(:id) { is_expected.not_to be nil }
+    it { expect(subject.id).not_to be nil }
     it { is_expected.to be_cancelled }
 
     context 'with an ActiveEncode::Base subclass' do
@@ -102,27 +103,27 @@ describe ActiveEncode::Core do
 
       it { is_expected.to equal encode }
       it { is_expected.to be_a encode_class }
-      its(:id) { is_expected.not_to be nil }
+      it { expect(subject.id).not_to be nil }
       it { is_expected.to be_cancelled }
     end
   end
 
   describe '#reload' do
-    let(:encode) { encode_class.create(nil) }
     subject { encode.reload }
+    let(:encode) { encode_class.create(nil) }
 
     it { is_expected.to equal encode }
     it { is_expected.to be_a encode_class }
-    its(:id) { is_expected.not_to be nil }
-    its(:state) { is_expected.not_to be nil }
+    it { expect(subject.id).not_to be nil }
+    it { expect(subject.state).not_to be nil }
 
     context 'with an ActiveEncode::Base subclass' do
       let(:encode_class) { CustomEncode }
 
       it { is_expected.to equal encode }
       it { is_expected.to be_a encode_class }
-      its(:id) { is_expected.not_to be nil }
-      its(:state) { is_expected.not_to be nil }
+      it { expect(subject.id).not_to be nil }
+      it { expect(subject.state).not_to be nil }
     end
   end
 
@@ -134,15 +135,15 @@ describe ActiveEncode::Core do
         end
       end
     end
-     after do
+    after do
       Object.send(:remove_const, :DefaultOptionsEncode)
     end
 
+    subject { encode.options }
     let(:encode_class) { DefaultOptionsEncode }
     let(:default_options) { { preset: 'video' } }
-    let(:options) { { output: [{label: 'high', ffmpeg_opt: "640x480" }] } }
+    let(:options) { { output: [{ label: 'high', ffmpeg_opt: "640x480" }] } }
     let(:encode) { encode_class.new(nil, options) }
-    subject { encode.options }
 
     it 'merges default options and options parameter' do
       expect(subject).to include default_options

data/spec/units/engine_adapter_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe ActiveEncode::EngineAdapter do

data/spec/units/file_locator_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Copyright 2011-2018, The Trustees of Indiana University and Northwestern
 #   University.  Licensed under the Apache License, Version 2.0 (the "License");
 #   you may not use this file except in compliance with the License.
@@ -11,7 +12,7 @@
 #   CONDITIONS OF ANY KIND, either express or implied. See the License for the
 #   specific language governing permissions and limitations under the License.
 # ---  END LICENSE_HEADER BLOCK  ---
-require 'aws-sdk'
+require 'aws-sdk-s3'
 require 'rails_helper'
 
 describe FileLocator, type: :service do
@@ -24,12 +25,12 @@ describe FileLocator, type: :service do
     let(:key) { "mykey.mp4" }
     let(:s3file) { FileLocator::S3File.new("s3://#{bucket}/#{key}") }
 
-    it "should be able to initialize from an S3 URI" do
+    it "is able to initialize from an S3 URI" do
       expect(s3file.bucket).to eq bucket
       expect(s3file.key).to eq key
     end
 
-    it "should return an S3 Object" do
+    it "returns an S3 Object" do
       s3_object = s3file.object
       expect(s3_object).to be_an Aws::S3::Object
       expect(s3_object.bucket_name).to eq bucket
@@ -42,30 +43,30 @@ describe FileLocator, type: :service do
     let(:source) { "file://#{path}" }
     let(:locator) { FileLocator.new(source) }
 
-    it "should return the correct uri" do
+    it "returns the correct uri" do
       expect(locator.uri).to eq Addressable::URI.parse(source)
     end
 
-    it "should return the correct location" do
+    it "returns the correct location" do
       expect(locator.location).to eq path
     end
 
-    it "should tell if file exists" do
+    it "tells if file exists" do
       allow(File).to receive(:exist?).with(path) { true }
       expect(locator.exist?).to be_truthy
     end
 
     context "return file" do
       let(:file) { double(File) }
-      before :each do
+      before do
         allow(File).to receive(:open).and_return file
       end
 
-      it "should return reader" do
+      it "returns reader" do
         expect(locator.reader).to eq file
       end
 
-      it "should return attachment" do
+      it "returns attachment" do
         expect(locator.attachment).to eq file
       end
     end
@@ -77,23 +78,23 @@ describe FileLocator, type: :service do
     let(:source) { "s3://#{bucket}/#{key}" }
     let(:locator) { FileLocator.new(source) }
 
-    it "should return the correct uri" do
+    it "returns the correct uri" do
       expect(locator.uri).to eq Addressable::URI.parse(source)
     end
 
-    it "should return the correct location" do
+    it "returns the correct location" do
       expect(locator.location).to start_with "https://#{bucket}.s3.us-stubbed-1.amazonaws.com/#{key}"
     end
 
-    it "should tell if file exists" do
+    it "tells if file exists" do
       expect(locator.exist?).to be_truthy
     end
 
-    it "should return reader" do
+    it "returns reader" do
       expect(locator.reader).to be_a StringIO
     end
 
-    it "should return attachment" do
+    it "returns attachment" do
       expect(locator.attachment).to eq Addressable::URI.parse(source)
     end
   end
@@ -103,25 +104,25 @@ describe FileLocator, type: :service do
     let(:source) { "bogus://#{path}" }
     let(:locator) { FileLocator.new(source) }
 
-    it "should return the correct uri" do
+    it "returns the correct uri" do
       expect(locator.uri).to eq Addressable::URI.parse(source)
     end
 
-    it "should return the correct location" do
+    it "returns the correct location" do
       expect(locator.location).to eq source
     end
 
-    it "should tell if file exists" do
+    it "tells if file exists" do
       expect(locator.exist?).to be_falsy
     end
 
-    it "should return reader" do
+    it "returns reader" do
       io = double(IO)
       allow(Kernel).to receive(:open).and_return io
       expect(locator.reader).to eq io
     end
 
-    it "should return attachment" do
+    it "returns attachment" do
       expect(locator.attachment).to eq locator.location
     end
   end

data/spec/units/global_id_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe ActiveEncode::GlobalID do
@@ -11,39 +12,39 @@ describe ActiveEncode::GlobalID do
   end
 
   describe '#to_global_id' do
+    subject { encode.to_global_id }
     let(:encode_class) { ActiveEncode::Base }
     let(:encode) { encode_class.create(nil) }
-    subject { encode.to_global_id }
 
     it { is_expected.to be_a GlobalID }
-    its(:model_class) { is_expected.to eq encode_class }
-    its(:model_id) { is_expected.to eq encode.id }
-    its(:app) { is_expected.to eq 'ActiveEncode' }
+    it { expect(subject.model_class).to eq encode_class }
+    it { expect(subject.model_id).to eq encode.id }
+    it { expect(subject.app).to eq 'ActiveEncode' }
 
     context 'with an ActiveEncode::Base subclass' do
       let(:encode_class) { CustomEncode }
 
       it { is_expected.to be_a GlobalID }
-      its(:model_class) { is_expected.to eq encode_class }
-      its(:model_id) { is_expected.to eq encode.id }
-      its(:app) { is_expected.to eq 'ActiveEncode' }
+      it { expect(subject.model_class).to eq encode_class }
+      it { expect(subject.model_id).to eq encode.id }
+      it { expect(subject.app).to eq 'ActiveEncode' }
     end
   end
 
   describe 'GlobalID::Locator#locate' do
+    subject { GlobalID::Locator.locate(global_id) }
     let(:encode_class) { ActiveEncode::Base }
     let(:encode) { encode_class.create(nil) }
     let(:global_id) { encode.to_global_id }
-    subject { GlobalID::Locator.locate(global_id) }
 
     it { is_expected.to be_a encode_class }
-    its(:id) { is_expected.to eq encode.id }
+    it { expect(subject.id).to eq encode.id }
 
     context 'with an ActiveEncode::Base subclass' do
       let(:encode_class) { CustomEncode }
-      
+
       it { is_expected.to be_a encode_class }
-      its(:id) { is_expected.to eq encode.id }
+      it { expect(subject.id).to eq encode.id }
     end
   end
 end

data/spec/units/input_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe ActiveEncode::Input do
@@ -6,8 +7,10 @@ describe ActiveEncode::Input do
   describe 'attributes' do
     it { is_expected.to respond_to(:id, :url) }
     it { is_expected.to respond_to(:state, :errors, :created_at, :updated_at) }
-    it { is_expected.to respond_to(:width, :height, :frame_rate, :checksum,
-                                   :audio_codec, :video_codec, :audio_bitrate, :video_bitrate) }
+    it {
+      is_expected.to respond_to(:width, :height, :frame_rate, :checksum,
+                                :audio_codec, :video_codec, :audio_bitrate, :video_bitrate)
+    }
   end
 
   describe '#valid?' do
@@ -15,8 +18,8 @@ describe ActiveEncode::Input do
       described_class.new.tap do |obj|
         obj.id = "1"
         obj.url = "file:///tmp/video.mp4"
-        obj.created_at = Time.now
-        obj.updated_at = Time.now
+        obj.created_at = Time.now.utc
+        obj.updated_at = Time.now.utc
       end
     end
 
@@ -31,7 +34,7 @@ describe ActiveEncode::Input do
       expect(valid_input.tap { |obj| obj.created_at = "today" }).not_to be_valid
       expect(valid_input.tap { |obj| obj.updated_at = nil }).not_to be_valid
       expect(valid_input.tap { |obj| obj.updated_at = "today" }).not_to be_valid
-      expect(valid_input.tap { |obj| obj.created_at = Time.now }).not_to be_valid
+      expect(valid_input.tap { |obj| obj.created_at = Time.now.utc }).not_to be_valid
     end
   end
 end