active_encode 0.4.1 → 0.8.0

data/spec/integration/matterhorn_adapter_spec.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'rubyhorn'
-require 'shared_specs/engine_adapter_specs'
+require 'active_encode/spec/shared_specs'
 
 describe ActiveEncode::EngineAdapters::MatterhornAdapter do
   before(:all) do
@@ -26,13 +27,13 @@ describe ActiveEncode::EngineAdapters::MatterhornAdapter do
   let(:created_job) { ActiveEncode::Base.create(file) }
   let(:running_job) { ActiveEncode::Base.find('running-id') }
   let(:canceled_job) { ActiveEncode::Base.find('cancelled-id') }
-  let(:cancelling_job) { ActiveEncode::Base.find('running-id')}
+  let(:cancelling_job) { ActiveEncode::Base.find('running-id') }
   let(:completed_job) { ActiveEncode::Base.find('completed-id') }
   let(:failed_job) { ActiveEncode::Base.find('failed-id') }
 
-  let(:completed_output) { [{ id: "track-7", checksum: "77de9765545ef63d2c21f7557ead6176", duration: 6337, audio_codec: "AAC", audio_bitrate: 76502.0, video_codec: "AVC", video_bitrate: 2000000.0, frame_rate: 30.0, width: 1308, height: 720, url: "file:///home/cjcolvar/Code/avalon/avalon/red5/webapps/avalon/streams/f564d9de-9c35-4b74-95f0-f3013f32cc1a/b09c765f-b64e-4725-a863-736af66b688c/videoshort.mp4", label: "quality-high" }, { id: "track-8", checksum: "10e13cf51bf8a973011eec6a17ea47ff", duration: 6337, audio_codec: "AAC", audio_bitrate: 76502.0, video_codec: "AVC", video_bitrate: 500000.0, frame_rate: 30.0, width: 654, height: 360, url: "file:///home/cjcolvar/Code/avalon/avalon/red5/webapps/avalon/streams/f564d9de-9c35-4b74-95f0-f3013f32cc1a/8d5cd8a9-ad0e-484a-96f0-05e26a84a8f0/videoshort.mp4", label: "quality-low" }, { id: "track-9", checksum: "f2b16a2606dc76cb53c7017f0e166204", duration: 6337, audio_codec: "AAC", audio_bitrate: 76502.0, video_codec: "AVC", video_bitrate: 1000000.0, frame_rate: 30.0, width: 872, height: 480, url: "file:///home/cjcolvar/Code/avalon/avalon/red5/webapps/avalon/streams/f564d9de-9c35-4b74-95f0-f3013f32cc1a/0f81d426-0e26-4496-8f58-c675c86e6f4e/videoshort.mp4", label: "quality-medium" }] }
-  let(:completed_tech_metadata) { { } }
-  let(:failed_tech_metadata) { { checksum: "7ae24368ccb7a6c6422a14ff73f33c9a", duration: 6314, audio_codec: "AAC", audio_bitrate: 171030.0, video_codec: "AVC", video_bitrate: 74477.0, frame_rate: 23.719, width: 200, height: 110 } }
+  let(:completed_output) { [{ id: "track-7", checksum: "77de9765545ef63d2c21f7557ead6176", duration: 6337, audio_codec: "AAC", audio_bitrate: 76_502.0, video_codec: "AVC", video_bitrate: 2_000_000.0, frame_rate: 30.0, width: 1308, height: 720, url: "file:///home/cjcolvar/Code/avalon/avalon/red5/webapps/avalon/streams/f564d9de-9c35-4b74-95f0-f3013f32cc1a/b09c765f-b64e-4725-a863-736af66b688c/videoshort.mp4", label: "quality-high" }, { id: "track-8", checksum: "10e13cf51bf8a973011eec6a17ea47ff", duration: 6337, audio_codec: "AAC", audio_bitrate: 76_502.0, video_codec: "AVC", video_bitrate: 500_000.0, frame_rate: 30.0, width: 654, height: 360, url: "file:///home/cjcolvar/Code/avalon/avalon/red5/webapps/avalon/streams/f564d9de-9c35-4b74-95f0-f3013f32cc1a/8d5cd8a9-ad0e-484a-96f0-05e26a84a8f0/videoshort.mp4", label: "quality-low" }, { id: "track-9", checksum: "f2b16a2606dc76cb53c7017f0e166204", duration: 6337, audio_codec: "AAC", audio_bitrate: 76_502.0, video_codec: "AVC", video_bitrate: 1_000_000.0, frame_rate: 30.0, width: 872, height: 480, url: "file:///home/cjcolvar/Code/avalon/avalon/red5/webapps/avalon/streams/f564d9de-9c35-4b74-95f0-f3013f32cc1a/0f81d426-0e26-4496-8f58-c675c86e6f4e/videoshort.mp4", label: "quality-medium" }] }
+  let(:completed_tech_metadata) { {} }
+  let(:failed_tech_metadata) { { checksum: "7ae24368ccb7a6c6422a14ff73f33c9a", duration: 6314, audio_codec: "AAC", audio_bitrate: 171_030.0, video_codec: "AVC", video_bitrate: 74_477.0, frame_rate: 23.719, width: 200, height: 110 } }
   let(:failed_errors) { "org.opencastproject.workflow.api.WorkflowOperationException: org.opencastproject.workflow.api.WorkflowOperationException: One of the encoding jobs did not complete successfully" }
 
   # Enforce generic behavior
@@ -41,62 +42,62 @@ describe ActiveEncode::EngineAdapters::MatterhornAdapter do
   describe "#create" do
     subject { created_job }
 
-    its(:output) { is_expected.to be_empty }
-    its(:options) { is_expected.to include(preset: 'full') }
+    it { expect(subject.output).to be_empty }
+    it { expect(subject.options).to include(preset: 'full') }
   end
 
   describe "#find" do
     context "a running encode" do
       subject { running_job }
 
-      its(:options) { is_expected.to include(preset: 'full') }
-      its(:output) { is_expected.to be_empty }
-      its(:current_operations) { is_expected.to include("Hold for workflow selection") }
+      it { expect(subject.options).to include(preset: 'full') }
+      it { expect(subject.output).to be_empty }
+      it { expect(subject.current_operations).to include("Hold for workflow selection") }
 
       context 'input' do
         subject { running_job.input }
 
-        its(:width) { is_expected.to be_blank }
-        its(:height) { is_expected.to be_blank }
-        its(:frame_rate) { is_expected.to be_blank }
-        its(:duration) { is_expected.to be_blank }
-        its(:file_size) { is_expected.to be_blank }
-        its(:checksum) { is_expected.to be_blank }
-        its(:audio_codec) { is_expected.to be_blank }
-        its(:video_codec) { is_expected.to be_blank }
-        its(:audio_bitrate) { is_expected.to be_blank }
-        its(:video_bitrate) { is_expected.to be_blank }
+        it { expect(subject.width).to be_blank }
+        it { expect(subject.height).to be_blank }
+        it { expect(subject.frame_rate).to be_blank }
+        it { expect(subject.duration).to be_blank }
+        it { expect(subject.file_size).to be_blank }
+        it { expect(subject.checksum).to be_blank }
+        it { expect(subject.audio_codec).to be_blank }
+        it { expect(subject.video_codec).to be_blank }
+        it { expect(subject.audio_bitrate).to be_blank }
+        it { expect(subject.video_bitrate).to be_blank }
       end
     end
     context "a cancelled encode" do
       subject { canceled_job }
 
-      its(:options) { is_expected.to include(preset: 'full') }
-      its(:current_operations) { is_expected.not_to be_empty }
-      its(:current_operations) { is_expected.to include("Tagging dublin core catalogs for publishing") }
-      its(:updated_at) { is_expected.to be > subject.created_at }
+      it { expect(subject.options).to include(preset: 'full') }
+      it { expect(subject.current_operations).not_to be_empty }
+      it { expect(subject.current_operations).to include("Tagging dublin core catalogs for publishing") }
+      it { expect(subject.updated_at).to be > subject.created_at }
     end
 
     context "a completed encode" do
       subject { completed_job }
 
-      its(:options) { is_expected.to include(preset: 'avalon') }
-      its(:current_operations) { is_expected.to include("Cleaning up") }
+      it { expect(subject.options).to include(preset: 'avalon') }
+      it { expect(subject.current_operations).to include("Cleaning up") }
     end
     context "a failed encode" do
       subject { failed_job }
 
-      its(:options) { is_expected.to include(preset: 'error') }
-      its(:current_operations) { is_expected.to include("Cleaning up after failure") }
+      it { expect(subject.options).to include(preset: 'error') }
+      it { expect(subject.current_operations).to include("Cleaning up after failure") }
     end
   end
 
   describe "#cancel!" do
-    let(:encode) { ActiveEncode::Base.create(file) }
     subject { encode.cancel! }
+    let(:encode) { ActiveEncode::Base.create(file) }
 
     it { is_expected.to be_a ActiveEncode::Base }
-    its(:id) { is_expected.to eq 'cancelled-id' }
+    it { expect(subject.id).to eq 'cancelled-id' }
     it { is_expected.to be_cancelled }
   end
 
@@ -107,24 +108,24 @@ describe ActiveEncode::EngineAdapters::MatterhornAdapter do
 
     subject { running_job.reload }
 
-    its(:output) { is_expected.to be_empty }
-    its(:options) { is_expected.to include(preset: 'full') }
-    its(:current_operations) { is_expected.to include("Hold for workflow selection") }
-    its(:percent_complete) { is_expected.to eq 0.43478260869565216 }
+    it { expect(subject.output).to be_empty }
+    it { expect(subject.options).to include(preset: 'full') }
+    it { expect(subject.current_operations).to include("Hold for workflow selection") }
+    it { expect(subject.percent_complete).to eq 0.43478260869565216 }
 
     context 'input' do
       subject { running_job.reload.input }
 
-      its(:width) { is_expected.to be_blank }
-      its(:height) { is_expected.to be_blank }
-      its(:frame_rate) { is_expected.to be_blank }
-      its(:duration) { is_expected.to be_blank }
-      its(:file_size) { is_expected.to be_blank }
-      its(:checksum) { is_expected.to be_blank }
-      its(:audio_codec) { is_expected.to be_blank }
-      its(:video_codec) { is_expected.to be_blank }
-      its(:audio_bitrate) { is_expected.to be_blank }
-      its(:video_bitrate) { is_expected.to be_blank }
+      it { expect(subject.width).to be_blank }
+      it { expect(subject.height).to be_blank }
+      it { expect(subject.frame_rate).to be_blank }
+      it { expect(subject.duration).to be_blank }
+      it { expect(subject.file_size).to be_blank }
+      it { expect(subject.checksum).to be_blank }
+      it { expect(subject.audio_codec).to be_blank }
+      it { expect(subject.video_codec).to be_blank }
+      it { expect(subject.audio_bitrate).to be_blank }
+      it { expect(subject.video_bitrate).to be_blank }
     end
   end
 end

data/spec/integration/media_convert_adapter_spec.rb

@@ -0,0 +1,126 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'aws-sdk-cloudwatchevents'
+require 'aws-sdk-cloudwatchlogs'
+require 'aws-sdk-mediaconvert'
+require 'aws-sdk-s3'
+require 'json'
+require 'active_encode/spec/shared_specs'
+require 'active_support/json'
+require 'active_support/time'
+
+def with_json_parsing
+  old_settings = { parse_json_times: ActiveSupport.parse_json_times, time_zone: Time.zone }
+  ActiveSupport.parse_json_times = true
+  Time.zone = 'America/Chicago'
+  yield
+ensure
+  ActiveSupport.parse_json_times = old_settings[:parse_json_times]
+  Time.zone = old_settings[:time_zone]
+end
+
+def reconstitute_response(fixture_path)
+  with_json_parsing do
+    HashWithIndifferentAccess.new(ActiveSupport::JSON.decode(File.read(File.join("spec/fixtures", fixture_path))))
+  end
+end
+
+describe ActiveEncode::EngineAdapters::MediaConvertAdapter do
+  around do |example|
+    # Setting this before each test works around a stubbing + memoization limitation
+    ActiveEncode::Base.engine_adapter = :media_convert
+    ActiveEncode::Base.engine_adapter.role = 'arn:aws:iam::123456789012:role/service-role/MediaConvert_Default_Role'
+    ActiveEncode::Base.engine_adapter.output_bucket = 'output-bucket'
+    example.run
+    ActiveEncode::Base.engine_adapter = :test
+  end
+
+  let(:job_id) { "1625859001514-vvqfwj" }
+  let(:mediaconvert) { Aws::MediaConvert::Client.new(stub_responses: true) }
+  let(:cloudwatch_events) { Aws::CloudWatchEvents::Client.new(stub_responses: true) }
+  let(:cloudwatch_logs) { Aws::CloudWatchLogs::Client.new(stub_responses: true) }
+
+  before do
+    mediaconvert.stub_responses(:describe_endpoints, reconstitute_response("media_convert/endpoints.json"))
+
+    allow(Aws::MediaConvert::Client).to receive(:new).and_return(mediaconvert)
+    allow(Aws::CloudWatchEvents::Client).to receive(:new).and_return(cloudwatch_events)
+    allow(Aws::CloudWatchLogs::Client).to receive(:new).and_return(cloudwatch_logs)
+  end
+
+  let(:created_job) do
+    mediaconvert.stub_responses(:create_job, reconstitute_response("media_convert/job_created.json"))
+
+    ActiveEncode::Base.create(
+      "s3://input-bucket/test_files/source_file.mp4",
+      output_prefix: "active-encode-test/output",
+      outputs: [
+        { preset: "System-Avc_16x9_1080p_29_97fps_8500kbps", modifier: "-1080" },
+        { preset: "System-Avc_16x9_720p_29_97fps_5000kbps", modifier: "-720" },
+        { preset: "System-Avc_16x9_540p_29_97fps_3500kbps", modifier: "-540" }
+      ],
+      use_original_url: true
+    )
+  end
+
+  let(:running_job) do
+    mediaconvert.stub_responses(:get_job, reconstitute_response("media_convert/job_progressing.json"))
+    ActiveEncode::Base.find(job_id)
+  end
+
+  let(:canceled_job) do
+    mediaconvert.stub_responses(:get_job, reconstitute_response("media_convert/job_canceled.json"))
+    ActiveEncode::Base.find(job_id)
+  end
+
+  let(:cancelling_job) do
+    mediaconvert.stub_responses(:cancel_job, reconstitute_response("media_convert/job_canceling.json"))
+    mediaconvert.stub_responses(:get_job, reconstitute_response("media_convert/job_canceled.json"))
+    ActiveEncode::Base.find(job_id)
+  end
+
+  let(:completed_job) do
+    mediaconvert.stub_responses(:get_job, reconstitute_response("media_convert/job_completed.json"))
+    cloudwatch_logs.stub_responses(:start_query, reconstitute_response("media_convert/job_completed_detail_query.json"))
+    cloudwatch_logs.stub_responses(:get_query_results, reconstitute_response("media_convert/job_completed_detail.json"))
+
+    ActiveEncode::Base.find(job_id)
+  end
+
+  let(:failed_job) do
+    mediaconvert.stub_responses(:get_job, reconstitute_response("media_convert/job_failed.json"))
+
+    ActiveEncode::Base.find(job_id)
+  end
+
+  let(:completed_output) do
+    [
+      { id: "1625859001514-vvqfwj-output-auto", url: "s3://output-bucket/active-encode-test/output.m3u8",
+        label: "output.m3u8", audio_codec: "AAC", duration: 888_020, video_codec: "H_264" },
+      { id: "1625859001514-vvqfwj-output-1080", url: "s3://output-bucket/active-encode-test/output-1080.m3u8",
+        label: "output-1080.m3u8", audio_bitrate: 128_000, audio_codec: "AAC", duration: 888_020,
+        video_bitrate: 8_500_000, height: 1080, width: 1920, video_codec: "H_264", frame_rate: 29.97 },
+      { id: "1625859001514-vvqfwj-output-720", url: "s3://output-bucket/active-encode-test/output-720.m3u8",
+        label: "output-720.m3u8", audio_bitrate: 96_000, audio_codec: "AAC", duration: 888_020,
+        video_bitrate: 5_000_000, height: 720, width: 1280, video_codec: "H_264", frame_rate: 29.97 },
+      { id: "1625859001514-vvqfwj-output-540", url: "s3://output-bucket/active-encode-test/output-540.m3u8",
+        label: "output-540.m3u8", audio_bitrate: 96_000, audio_codec: "AAC", duration: 888_020,
+        video_bitrate: 3_500_000, height: 540, width: 960, video_codec: "H_264", frame_rate: 29.97 }
+    ]
+  end
+  let(:completed_tech_metadata) { {} }
+  let(:failed_tech_metadata) { {} }
+
+  it_behaves_like "an ActiveEncode::EngineAdapter"
+
+  describe "output" do
+    it "contains all expected outputs" do
+      completed_output.each do |expected_output|
+        found_output = completed_job.output.find { |output| output.id == expected_output[:id] }
+        expected_output.each_pair do |key, value|
+          expect(found_output.send(key)).to eq(value)
+        end
+      end
+    end
+  end
+end

data/spec/integration/pass_through_adapter_spec.rb

@@ -0,0 +1,151 @@
+# frozen_string_literal: true
+require 'rails_helper'
+require 'active_encode/spec/shared_specs'
+
+describe ActiveEncode::EngineAdapters::PassThroughAdapter do
+  around do |example|
+    ActiveEncode::Base.engine_adapter = :pass_through
+
+    Dir.mktmpdir do |dir|
+      @dir = dir
+      example.run
+      Dir.foreach(dir) do |e|
+        next if e == "." || e == ".."
+        FileUtils.rm_rf(File.join(dir, e))
+      end
+    end
+
+    ActiveEncode::Base.engine_adapter = :test
+  end
+
+  let!(:work_dir) { stub_const "ActiveEncode::EngineAdapters::PassThroughAdapter::WORK_DIR", @dir }
+  let(:file) { "file://" + Rails.root.join('..', 'spec', 'fixtures', 'fireworks.mp4').to_s }
+  let(:low_derivative) { "file://" + Rails.root.join('..', 'spec', 'fixtures', 'fireworks.low.mp4').to_s }
+  let(:created_job) do
+    ActiveEncode::Base.create(file, outputs: [{ label: 'low', url: low_derivative }])
+  end
+  let(:running_job) do
+    created_job
+  end
+  let(:canceled_job) do
+    find_encode 'cancelled-id'
+  end
+  let(:cancelling_job) do
+    find_encode 'running-id'
+  end
+  let(:completed_job) { find_encode "completed-id" }
+  let(:failed_job) { find_encode 'failed-id' }
+  let(:completed_tech_metadata) do
+    {
+      audio_bitrate: 171_030,
+      audio_codec: 'mp4a-40-2',
+      duration: 6315.0,
+      file_size: 199_160,
+      frame_rate: 23.719,
+      height: 110.0,
+      id: "completed-id",
+      url: "/home/pdinh/Downloads/videoshort.mp4",
+      video_bitrate: 74_477,
+      video_codec: 'avc1',
+      width: 200.0
+    }
+  end
+  let(:completed_output) { [{ id: "completed-id" }] }
+  let(:failed_tech_metadata) { {} }
+
+  it_behaves_like "an ActiveEncode::EngineAdapter"
+
+  def find_encode(id)
+    # Precreate ffmpeg output directory and files
+    FileUtils.copy_entry "spec/fixtures/pass_through/#{id}", "#{work_dir}/#{id}"
+
+    # Simulate that progress is modified later than other files
+    sleep 0.1
+    FileUtils.touch Dir.glob("#{work_dir}/#{id}/*.mp4")
+    touch_fixture(id, "completed")
+    touch_fixture(id, "cancelled")
+    touch_fixture(id, "error.log")
+
+    # Stub out system calls
+    allow_any_instance_of(ActiveEncode::EngineAdapters::PassThroughAdapter).to receive(:`).and_return(1234)
+
+    ActiveEncode::Base.find(id)
+  end
+
+  def touch_fixture(id, filename)
+    FileUtils.touch("#{work_dir}/#{id}/#{filename}") if File.exist? "#{work_dir}/#{id}/#{filename}"
+  end
+
+  describe "#create" do
+    subject { created_job }
+
+    it "creates a directory whose name is the encode id" do
+      expect(File).to exist("#{work_dir}/#{subject.id}")
+    end
+
+    context "input file exists" do
+      it "has the input technical metadata in a file" do
+        expect(File.read("#{work_dir}/#{subject.id}/input_metadata")).not_to be_empty
+      end
+    end
+
+    context "input file doesn't exist" do
+      let(:missing_file) { "file:///a_bogus_file.mp4" }
+      let(:missing_job) { ActiveEncode::Base.create(missing_file, outputs: [{ label: "low", url: 'mp4' }]) }
+
+      it "returns the encode with correct error" do
+        expect(missing_job.errors).to include("#{missing_file} does not exist or is not accessible")
+        expect(missing_job.percent_complete).to be 1
+      end
+    end
+
+    context "input file is not media" do
+      let(:nonmedia_file) { "file://" + Rails.root.join('Gemfile').to_s }
+      let(:nonmedia_job) { ActiveEncode::Base.create(nonmedia_file, outputs: [{ label: "low", url: nonmedia_file }]) }
+
+      it "returns the encode with correct error" do
+        expect(nonmedia_job.errors).to include("Error inspecting input: #{nonmedia_file}")
+        expect(nonmedia_job.percent_complete).to be 1
+      end
+    end
+
+    context "input filename with spaces" do
+      let(:file_with_space) { "file://" + Rails.root.join('..', 'spec', 'fixtures', 'file with space.mp4').to_s }
+      let(:file_with_space_derivative) { "file://" + Rails.root.join('..', 'spec', 'fixtures', 'file with space.low.mp4').to_s }
+      let!(:create_space_job) { ActiveEncode::Base.create(file_with_space, outputs: [{ label: "low", url: file_with_space_derivative }]) }
+      let(:find_space_job) { ActiveEncode::Base.find create_space_job.id }
+
+      it "does not have errors" do
+        expect(find_space_job.errors).to be_empty
+      end
+
+      it "has the input technical metadata in a file" do
+        expect(File.read("#{work_dir}/#{create_space_job.id}/input_metadata")).not_to be_empty
+      end
+
+      context 'when uri encoded' do
+        let(:file_with_space) { URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', 'file with space.mp4').to_s) }
+        let(:file_with_space_derivative) { URI.encode("file://" + Rails.root.join('..', 'spec', 'fixtures', 'file with space.low.mp4').to_s) }
+
+        it "does not have errors" do
+          expect(find_space_job.errors).to be_empty
+        end
+
+        it "has the input technical metadata in a file" do
+          expect(File.read("#{work_dir}/#{create_space_job.id}/input_metadata")).not_to be_empty
+        end
+      end
+    end
+
+    context 'when failed' do
+      subject { created_job }
+
+      before do
+        allow_any_instance_of(Object).to receive(:`).and_raise Errno::ENOENT
+      end
+
+      it { is_expected.to be_failed }
+      it { expect(subject.errors).to be_present }
+    end
+  end
+end

data/spec/integration/zencoder_adapter_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'zencoder'
 require 'json'
@@ -24,66 +25,66 @@ describe ActiveEncode::EngineAdapters::ZencoderAdapter do
       allow(Zencoder::Job).to receive(:progress).and_return(progress_response)
     end
 
+    subject { ActiveEncode::Base.create(file) }
     let(:details_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_details_create.json'))) }
     let(:progress_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_progress_create.json'))) }
     let(:create_output) { [{ id: "511404522", url: "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150610/c09b61e4d130ddf923f0653418a80b9c/399ae101c3f99b4f318635e78a4e587a.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=GY/9LMkQAiDOrMQwS5BkmOE200s%3D&Expires=1434033527", label: nil }] }
 
-    subject { ActiveEncode::Base.create(file) }
     it { is_expected.to be_a ActiveEncode::Base }
-    its(:id) { is_expected.not_to be_empty }
+    it { expect(subject.id).not_to be_empty }
     it { is_expected.to be_running }
-    # its(:output) { is_expected.to eq create_output }
-    its(:current_operations) { is_expected.to be_empty }
-    its(:percent_complete) { is_expected.to eq 0 }
-    its(:errors) { is_expected.to be_empty }
-    its(:created_at) { is_expected.to eq '2015-06-10T14:38:47Z' }
-    its(:updated_at) { is_expected.to eq '2015-06-10T14:38:47Z' }
+    # it { expect(subject.output).to eq create_output }
+    it { expect(subject.current_operations).to be_empty }
+    it { expect(subject.percent_complete).to eq 0 }
+    it { expect(subject.errors).to be_empty }
+    it { expect(subject.created_at).to eq '2015-06-10T14:38:47Z' }
+    it { expect(subject.updated_at).to eq '2015-06-10T14:38:47Z' }
 
     context 'input' do
       subject { ActiveEncode::Base.create(file).input }
 
       it { is_expected.to be_a ActiveEncode::Input }
-      its(:id) { is_expected.to eq "166179248" }
-      its(:url) { is_expected.to eq "https://archive.org/download/LuckyStr1948_2/LuckyStr1948_2_512kb.mp4" }
-      its(:width) { is_expected.to be_blank }
-      its(:height) { is_expected.to be_blank }
-      its(:frame_rate) { is_expected.to be_blank }
-      its(:duration) { is_expected.to be_blank }
-      its(:file_size) { is_expected.to be_blank }
-      its(:checksum) { is_expected.to be_blank }
-      its(:audio_codec) { is_expected.to be_blank }
-      its(:video_codec) { is_expected.to be_blank }
-      its(:audio_bitrate) { is_expected.to be_blank }
-      its(:video_bitrate) { is_expected.to be_blank }
-      its(:state) { is_expected.to eq :running }
-      its(:created_at) { is_expected.to eq "2015-06-10T14:38:47Z" }
-      its(:updated_at) { is_expected.to eq "2015-06-10T14:38:00Z" }
+      it { expect(subject.id).to eq "166179248" }
+      it { expect(subject.url).to eq "https://archive.org/download/LuckyStr1948_2/LuckyStr1948_2_512kb.mp4" }
+      it { expect(subject.width).to be_blank }
+      it { expect(subject.height).to be_blank }
+      it { expect(subject.frame_rate).to be_blank }
+      it { expect(subject.duration).to be_blank }
+      it { expect(subject.file_size).to be_blank }
+      it { expect(subject.checksum).to be_blank }
+      it { expect(subject.audio_codec).to be_blank }
+      it { expect(subject.video_codec).to be_blank }
+      it { expect(subject.audio_bitrate).to be_blank }
+      it { expect(subject.video_bitrate).to be_blank }
+      it { expect(subject.state).to eq :running }
+      it { expect(subject.created_at).to eq "2015-06-10T14:38:47Z" }
+      it { expect(subject.updated_at).to eq "2015-06-10T14:38:00Z" }
     end
 
     context 'output' do
-      let(:output) { ActiveEncode::Base.find('166019107').reload.output }
       subject { output.first }
+      let(:output) { ActiveEncode::Base.find('166019107').reload.output }
 
       it 'is an array' do
         expect(output).to be_a Array
       end
       it { is_expected.to be_a ActiveEncode::Output }
-      its(:id) { is_expected.to eq "511404522" }
-      its(:url) { is_expected.to eq "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150610/c09b61e4d130ddf923f0653418a80b9c/399ae101c3f99b4f318635e78a4e587a.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=GY/9LMkQAiDOrMQwS5BkmOE200s%3D&Expires=1434033527" }
-      its(:label) { is_expected.to be_blank }
-      its(:width) { is_expected.to be_blank }
-      its(:height) { is_expected.to be_blank }
-      its(:frame_rate) { is_expected.to be_blank }
-      its(:duration) { is_expected.to be_blank }
-      its(:file_size) { is_expected.to be_blank }
-      its(:checksum) { is_expected.to be_blank }
-      its(:audio_codec) { is_expected.to be_blank }
-      its(:video_codec) { is_expected.to be_blank }
-      its(:audio_bitrate) { is_expected.to be_blank }
-      its(:video_bitrate) { is_expected.to be_blank }
-      its(:state) { is_expected.to eq :running }
-      its(:created_at) { is_expected.to eq "2015-06-10T14:38:47Z" }
-      its(:updated_at) { is_expected.to eq "2015-06-10T14:38:47Z" }
+      it { expect(subject.id).to eq "511404522" }
+      it { expect(subject.url).to eq "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150610/c09b61e4d130ddf923f0653418a80b9c/399ae101c3f99b4f318635e78a4e587a.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=GY/9LMkQAiDOrMQwS5BkmOE200s%3D&Expires=1434033527" }
+      it { expect(subject.label).to be_blank }
+      it { expect(subject.width).to be_blank }
+      it { expect(subject.height).to be_blank }
+      it { expect(subject.frame_rate).to be_blank }
+      it { expect(subject.duration).to be_blank }
+      it { expect(subject.file_size).to be_blank }
+      it { expect(subject.checksum).to be_blank }
+      it { expect(subject.audio_codec).to be_blank }
+      it { expect(subject.video_codec).to be_blank }
+      it { expect(subject.audio_bitrate).to be_blank }
+      it { expect(subject.video_bitrate).to be_blank }
+      it { expect(subject.state).to eq :running }
+      it { expect(subject.created_at).to eq "2015-06-10T14:38:47Z" }
+      it { expect(subject.updated_at).to eq "2015-06-10T14:38:47Z" }
     end
   end
 
@@ -94,208 +95,208 @@ describe ActiveEncode::EngineAdapters::ZencoderAdapter do
     end
 
     context "a running encode" do
+      subject { ActiveEncode::Base.find('166019107') }
       let(:details_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_details_running.json'))) }
       let(:progress_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_progress_running.json'))) }
       # let(:running_output) { [{ id: "510582971", url: "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150609/48a6907086c012f68b9ca43461280515/1726d7ec3e24f2171bd07b2abb807b6c.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=vSvlxU94wlQLEbpG3Zs8ibp4MoY%3D&Expires=1433953106", label: nil }] }
       # let(:running_tech_metadata) { { audio_bitrate: "52", audio_codec: "aac", audio_channels: "2", duration: "57992", mime_type: "mpeg4", video_framerate: "29.97", height: "240", video_bitrate: "535", video_codec: "h264", width: "320" } }
 
-      subject { ActiveEncode::Base.find('166019107') }
       it { is_expected.to be_a ActiveEncode::Base }
-      its(:id) { is_expected.to eq '166019107' }
+      it { expect(subject.id).to eq '166019107' }
       it { is_expected.to be_running }
-      # its(:output) { is_expected.to eq running_output }
-      its(:current_operations) { is_expected.to be_empty }
-      its(:percent_complete) { is_expected.to eq 30.0 }
-      its(:errors) { is_expected.to be_empty }
-      its(:created_at) { is_expected.to eq '2015-06-09T16:18:26Z' }
-      its(:updated_at) { is_expected.to eq '2015-06-09T16:18:28Z' }
-
-      # its(:tech_metadata) { is_expected.to eq running_tech_metadata }
+      # it { expect(subject.output).to eq running_output }
+      it { expect(subject.current_operations).to be_empty }
+      it { expect(subject.percent_complete).to eq 30.0 }
+      it { expect(subject.errors).to be_empty }
+      it { expect(subject.created_at).to eq '2015-06-09T16:18:26Z' }
+      it { expect(subject.updated_at).to eq '2015-06-09T16:18:28Z' }
+
+      # it { expect(subject.tech_metadata).to eq running_tech_metadata }
       context 'input' do
         subject { ActiveEncode::Base.find('166019107').input }
 
         it { is_expected.to be_a ActiveEncode::Input }
-        its(:id) { is_expected.to eq "165990056" }
-        its(:url) { is_expected.to eq "https://archive.org/download/LuckyStr1948_2/LuckyStr1948_2_512kb.mp4" }
-        its(:width) { is_expected.to eq 320 }
-        its(:height) { is_expected.to eq 240 }
-        its(:frame_rate) { is_expected.to eq 29.97 }
-        its(:duration) { is_expected.to eq 57992 }
-        its(:file_size) { is_expected.to be_blank }
-        its(:checksum) { is_expected.to be_blank }
-        its(:audio_codec) { is_expected.to eq "aac" }
-        its(:video_codec) { is_expected.to eq "h264" }
-        its(:audio_bitrate) { is_expected.to eq 52 }
-        its(:video_bitrate) { is_expected.to eq 535 }
-        its(:state) { is_expected.to eq :completed }
-        its(:created_at) { is_expected.to eq "2015-06-09T16:18:26Z" }
-        its(:updated_at) { is_expected.to eq "2015-06-09T16:18:32Z" }
+        it { expect(subject.id).to eq "165990056" }
+        it { expect(subject.url).to eq "https://archive.org/download/LuckyStr1948_2/LuckyStr1948_2_512kb.mp4" }
+        it { expect(subject.width).to eq 320 }
+        it { expect(subject.height).to eq 240 }
+        it { expect(subject.frame_rate).to eq 29.97 }
+        it { expect(subject.duration).to eq 57_992 }
+        it { expect(subject.file_size).to be_blank }
+        it { expect(subject.checksum).to be_blank }
+        it { expect(subject.audio_codec).to eq "aac" }
+        it { expect(subject.video_codec).to eq "h264" }
+        it { expect(subject.audio_bitrate).to eq 52 }
+        it { expect(subject.video_bitrate).to eq 535 }
+        it { expect(subject.state).to eq :completed }
+        it { expect(subject.created_at).to eq "2015-06-09T16:18:26Z" }
+        it { expect(subject.updated_at).to eq "2015-06-09T16:18:32Z" }
       end
 
       context 'output' do
-        let(:output) { ActiveEncode::Base.find('166019107').output }
         subject { output.first }
+        let(:output) { ActiveEncode::Base.find('166019107').output }
 
         it 'is an array' do
           expect(output).to be_a Array
         end
         it { is_expected.to be_a ActiveEncode::Output }
-        its(:id) { is_expected.to eq "510582971" }
-        its(:url) { is_expected.to eq "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150609/48a6907086c012f68b9ca43461280515/1726d7ec3e24f2171bd07b2abb807b6c.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=vSvlxU94wlQLEbpG3Zs8ibp4MoY%3D&Expires=1433953106" }
-        its(:label) { is_expected.to be_blank }
-        its(:width) { is_expected.to be_blank }
-        its(:height) { is_expected.to be_blank }
-        its(:frame_rate) { is_expected.to be_blank }
-        its(:duration) { is_expected.to be_blank }
-        its(:file_size) { is_expected.to be_blank }
-        its(:checksum) { is_expected.to be_blank }
-        its(:audio_codec) { is_expected.to be_blank }
-        its(:video_codec) { is_expected.to be_blank }
-        its(:audio_bitrate) { is_expected.to be_blank }
-        its(:video_bitrate) { is_expected.to be_blank }
-        its(:state) { is_expected.to eq :running }
-        its(:created_at) { is_expected.to eq "2015-06-09T16:18:26Z" }
-        its(:updated_at) { is_expected.to eq "2015-06-09T16:18:32Z" }
+        it { expect(subject.id).to eq "510582971" }
+        it { expect(subject.url).to eq "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150609/48a6907086c012f68b9ca43461280515/1726d7ec3e24f2171bd07b2abb807b6c.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=vSvlxU94wlQLEbpG3Zs8ibp4MoY%3D&Expires=1433953106" }
+        it { expect(subject.label).to be_blank }
+        it { expect(subject.width).to be_blank }
+        it { expect(subject.height).to be_blank }
+        it { expect(subject.frame_rate).to be_blank }
+        it { expect(subject.duration).to be_blank }
+        it { expect(subject.file_size).to be_blank }
+        it { expect(subject.checksum).to be_blank }
+        it { expect(subject.audio_codec).to be_blank }
+        it { expect(subject.video_codec).to be_blank }
+        it { expect(subject.audio_bitrate).to be_blank }
+        it { expect(subject.video_bitrate).to be_blank }
+        it { expect(subject.state).to eq :running }
+        it { expect(subject.created_at).to eq "2015-06-09T16:18:26Z" }
+        it { expect(subject.updated_at).to eq "2015-06-09T16:18:32Z" }
       end
     end
 
     context "a cancelled encode" do
+      subject { ActiveEncode::Base.find('165866551') }
       let(:details_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_details_cancelled.json'))) }
       let(:progress_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_progress_cancelled.json'))) }
 
-      subject { ActiveEncode::Base.find('165866551') }
       it { is_expected.to be_a ActiveEncode::Base }
-      its(:id) { is_expected.to eq '165866551' }
+      it { expect(subject.id).to eq '165866551' }
       it { is_expected.to be_cancelled }
-      its(:current_operations) { is_expected.to be_empty }
-      its(:percent_complete) { is_expected.to eq 0 }
-      its(:errors) { is_expected.to be_empty }
-      its(:created_at) { is_expected.to eq '2015-06-08T20:43:23Z' }
-      its(:updated_at) { is_expected.to eq '2015-06-08T20:43:26Z' }
+      it { expect(subject.current_operations).to be_empty }
+      it { expect(subject.percent_complete).to eq 0 }
+      it { expect(subject.errors).to be_empty }
+      it { expect(subject.created_at).to eq '2015-06-08T20:43:23Z' }
+      it { expect(subject.updated_at).to eq '2015-06-08T20:43:26Z' }
 
       context 'input' do
         subject { ActiveEncode::Base.find('165866551').input }
 
         it { is_expected.to be_a ActiveEncode::Input }
-        its(:id) { is_expected.to eq "165837500" }
-        its(:url) { is_expected.to eq "https://archive.org/download/LuckyStr1948_2/LuckyStr1948_2_512kb.mp4" }
-        its(:width) { is_expected.to be_blank }
-        its(:height) { is_expected.to be_blank }
-        its(:frame_rate) { is_expected.to be_blank }
-        its(:duration) { is_expected.to be_blank }
-        its(:file_size) { is_expected.to be_blank }
-        its(:checksum) { is_expected.to be_blank }
-        its(:audio_codec) { is_expected.to be_blank }
-        its(:video_codec) { is_expected.to be_blank }
-        its(:audio_bitrate) { is_expected.to be_blank }
-        its(:video_bitrate) { is_expected.to be_blank }
-        its(:state) { is_expected.to eq :cancelled }
-        its(:created_at) { is_expected.to eq "2015-06-08T20:43:23Z" }
-        its(:updated_at) { is_expected.to eq "2015-06-08T20:43:26Z" }
+        it { expect(subject.id).to eq "165837500" }
+        it { expect(subject.url).to eq "https://archive.org/download/LuckyStr1948_2/LuckyStr1948_2_512kb.mp4" }
+        it { expect(subject.width).to be_blank }
+        it { expect(subject.height).to be_blank }
+        it { expect(subject.frame_rate).to be_blank }
+        it { expect(subject.duration).to be_blank }
+        it { expect(subject.file_size).to be_blank }
+        it { expect(subject.checksum).to be_blank }
+        it { expect(subject.audio_codec).to be_blank }
+        it { expect(subject.video_codec).to be_blank }
+        it { expect(subject.audio_bitrate).to be_blank }
+        it { expect(subject.video_bitrate).to be_blank }
+        it { expect(subject.state).to eq :cancelled }
+        it { expect(subject.created_at).to eq "2015-06-08T20:43:23Z" }
+        it { expect(subject.updated_at).to eq "2015-06-08T20:43:26Z" }
       end
     end
 
     context "a completed encode" do
+      subject { ActiveEncode::Base.find('165839139') }
       let(:details_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_details_completed.json'))) }
       let(:progress_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_progress_completed.json'))) }
       let(:completed_output) { { id: "509856876", audio_bitrate: "53", audio_codec: "aac", audio_channels: "2", duration: "5000", mime_type: "mpeg4", video_framerate: "29.97", height: "240", video_bitrate: "549", video_codec: "h264", width: "320", url: "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150608/ebbe865f8ef1b960d7c2bb0663b88a12/0f1948dcb2fd701fba30ff21908fe460.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=1LgIyl/el9E7zeyPxzd/%2BNwez6Y%3D&Expires=1433873646", label: nil } }
       # let(:completed_tech_metadata) { { audio_bitrate: "52", audio_codec: "aac", audio_channels: "2", duration: "57992", mime_type: "mpeg4", video_framerate: "29.97", height: "240", video_bitrate: "535", video_codec: "h264", width: "320" } }
 
-      subject { ActiveEncode::Base.find('165839139') }
       it { is_expected.to be_a ActiveEncode::Base }
-      its(:id) { is_expected.to eq '165839139' }
+      it { expect(subject.id).to eq '165839139' }
       it { is_expected.to be_completed }
-      # its(:output) { is_expected.to include completed_output }
-      its(:current_operations) { is_expected.to be_empty }
-      its(:percent_complete) { is_expected.to eq 100 }
-      its(:errors) { is_expected.to be_empty }
-      its(:created_at) { is_expected.to eq '2015-06-08T18:13:53Z' }
-      its(:updated_at) { is_expected.to eq '2015-06-08T18:14:06Z' }
+      # it { expect(subject.output).to include completed_output }
+      it { expect(subject.current_operations).to be_empty }
+      it { expect(subject.percent_complete).to eq 100 }
+      it { expect(subject.errors).to be_empty }
+      it { expect(subject.created_at).to eq '2015-06-08T18:13:53Z' }
+      it { expect(subject.updated_at).to eq '2015-06-08T18:14:06Z' }
 
       context 'input' do
         subject { ActiveEncode::Base.find('165839139').input }
 
         it { is_expected.to be_a ActiveEncode::Input }
-        its(:id) { is_expected.to eq "165810088" }
-        its(:url) { is_expected.to eq "https://archive.org/download/LuckyStr1948_2/LuckyStr1948_2_512kb.mp4" }
-        its(:width) { is_expected.to eq 320 }
-        its(:height) { is_expected.to eq 240 }
-        its(:frame_rate) { is_expected.to eq 29.97 }
-        its(:duration) { is_expected.to eq 57992 }
-        its(:file_size) { is_expected.to be_blank }
-        its(:checksum) { is_expected.to be_blank }
-        its(:audio_codec) { is_expected.to eq "aac" }
-        its(:video_codec) { is_expected.to eq "h264" }
-        its(:audio_bitrate) { is_expected.to eq 52 }
-        its(:video_bitrate) { is_expected.to eq 535 }
-        its(:state) { is_expected.to eq :completed }
-        its(:created_at) { is_expected.to eq "2015-06-08T18:13:53Z" }
-        its(:updated_at) { is_expected.to eq "2015-06-08T18:14:06Z" }
+        it { expect(subject.id).to eq "165810088" }
+        it { expect(subject.url).to eq "https://archive.org/download/LuckyStr1948_2/LuckyStr1948_2_512kb.mp4" }
+        it { expect(subject.width).to eq 320 }
+        it { expect(subject.height).to eq 240 }
+        it { expect(subject.frame_rate).to eq 29.97 }
+        it { expect(subject.duration).to eq 57_992 }
+        it { expect(subject.file_size).to be_blank }
+        it { expect(subject.checksum).to be_blank }
+        it { expect(subject.audio_codec).to eq "aac" }
+        it { expect(subject.video_codec).to eq "h264" }
+        it { expect(subject.audio_bitrate).to eq 52 }
+        it { expect(subject.video_bitrate).to eq 535 }
+        it { expect(subject.state).to eq :completed }
+        it { expect(subject.created_at).to eq "2015-06-08T18:13:53Z" }
+        it { expect(subject.updated_at).to eq "2015-06-08T18:14:06Z" }
       end
 
       context 'output' do
-        let(:output) { ActiveEncode::Base.find('166019107').reload.output }
         subject { output.first }
+        let(:output) { ActiveEncode::Base.find('166019107').reload.output }
 
         it 'is an array' do
           expect(output).to be_a Array
         end
         it { is_expected.to be_a ActiveEncode::Output }
-        its(:id) { is_expected.to eq "509856876" }
-        its(:url) { is_expected.to eq "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150608/ebbe865f8ef1b960d7c2bb0663b88a12/0f1948dcb2fd701fba30ff21908fe460.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=1LgIyl/el9E7zeyPxzd/%2BNwez6Y%3D&Expires=1433873646" }
-        its(:label) { is_expected.to be_blank }
-        its(:width) { is_expected.to eq 320 }
-        its(:height) { is_expected.to eq 240 }
-        its(:frame_rate) { is_expected.to eq 29.97 }
-        its(:duration) { is_expected.to eq 5000 }
-        its(:file_size) { is_expected.to be_blank }
-        its(:checksum) { is_expected.to be_blank }
-        its(:audio_codec) { is_expected.to eq "aac" }
-        its(:video_codec) { is_expected.to eq "h264" }
-        its(:audio_bitrate) { is_expected.to eq 53 }
-        its(:video_bitrate) { is_expected.to eq 549 }
-        its(:state) { is_expected.to eq :completed }
-        its(:created_at) { is_expected.to eq "2015-06-08T18:13:53Z" }
-        its(:updated_at) { is_expected.to eq "2015-06-08T18:14:06Z" }
+        it { expect(subject.id).to eq "509856876" }
+        it { expect(subject.url).to eq "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150608/ebbe865f8ef1b960d7c2bb0663b88a12/0f1948dcb2fd701fba30ff21908fe460.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=1LgIyl/el9E7zeyPxzd/%2BNwez6Y%3D&Expires=1433873646" }
+        it { expect(subject.label).to be_blank }
+        it { expect(subject.width).to eq 320 }
+        it { expect(subject.height).to eq 240 }
+        it { expect(subject.frame_rate).to eq 29.97 }
+        it { expect(subject.duration).to eq 5000 }
+        it { expect(subject.file_size).to be_blank }
+        it { expect(subject.checksum).to be_blank }
+        it { expect(subject.audio_codec).to eq "aac" }
+        it { expect(subject.video_codec).to eq "h264" }
+        it { expect(subject.audio_bitrate).to eq 53 }
+        it { expect(subject.video_bitrate).to eq 549 }
+        it { expect(subject.state).to eq :completed }
+        it { expect(subject.created_at).to eq "2015-06-08T18:13:53Z" }
+        it { expect(subject.updated_at).to eq "2015-06-08T18:14:06Z" }
       end
     end
 
     context "a failed encode" do
+      subject { ActiveEncode::Base.find('166079902') }
       let(:details_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_details_failed.json'))) }
       let(:progress_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_progress_failed.json'))) }
       let(:failed_tech_metadata) { { mime_type: "video/mp4", checksum: "7ae24368ccb7a6c6422a14ff73f33c9a", duration: "6314", audio_codec: "AAC", audio_channels: "2", audio_bitrate: "171030.0", video_codec: "AVC", video_bitrate: "74477.0", video_framerate: "23.719", width: "200", height: "110" } }
       let(:failed_errors) { "The file is an XML file, and doesn't contain audio or video tracks." }
 
-      subject { ActiveEncode::Base.find('166079902') }
       it { is_expected.to be_a ActiveEncode::Base }
-      its(:id) { is_expected.to eq '166079902' }
+      it { expect(subject.id).to eq '166079902' }
       it { is_expected.to be_failed }
-      its(:current_operations) { is_expected.to be_empty }
-      its(:percent_complete) { is_expected.to eq 0 }
-      its(:errors) { is_expected.to be_empty }
-      its(:created_at) { is_expected.to eq '2015-06-09T20:52:57Z' }
-      its(:updated_at) { is_expected.to eq '2015-06-09T20:53:00Z' }
+      it { expect(subject.current_operations).to be_empty }
+      it { expect(subject.percent_complete).to eq 0 }
+      it { expect(subject.errors).to be_empty }
+      it { expect(subject.created_at).to eq '2015-06-09T20:52:57Z' }
+      it { expect(subject.updated_at).to eq '2015-06-09T20:53:00Z' }
 
       context 'input' do
         subject { ActiveEncode::Base.find('165866551').input }
 
         it { is_expected.to be_a ActiveEncode::Input }
-        its(:id) { is_expected.to eq "166050851" }
-        its(:url) { is_expected.to eq "s3://zencoder-customer-ingest/uploads/2015-06-09/240330/187007/682c2d90-0eea-11e5-84c9-f158f44c3d50.xml" }
-        its(:errors) { is_expected.to include failed_errors }
-        its(:width) { is_expected.to be_blank }
-        its(:height) { is_expected.to be_blank }
-        its(:frame_rate) { is_expected.to be_blank }
-        its(:duration) { is_expected.to be_blank }
-        its(:file_size) { is_expected.to be_blank }
-        its(:checksum) { is_expected.to be_blank }
-        its(:audio_codec) { is_expected.to be_blank }
-        its(:video_codec) { is_expected.to be_blank }
-        its(:audio_bitrate) { is_expected.to be_blank }
-        its(:video_bitrate) { is_expected.to be_blank }
-        its(:state) { is_expected.to eq :failed }
-        its(:created_at) { is_expected.to eq "2015-06-09T20:52:57Z" }
-        its(:updated_at) { is_expected.to eq "2015-06-09T20:53:00Z" }
+        it { expect(subject.id).to eq "166050851" }
+        it { expect(subject.url).to eq "s3://zencoder-customer-ingest/uploads/2015-06-09/240330/187007/682c2d90-0eea-11e5-84c9-f158f44c3d50.xml" }
+        it { expect(subject.errors).to include failed_errors }
+        it { expect(subject.width).to be_blank }
+        it { expect(subject.height).to be_blank }
+        it { expect(subject.frame_rate).to be_blank }
+        it { expect(subject.duration).to be_blank }
+        it { expect(subject.file_size).to be_blank }
+        it { expect(subject.checksum).to be_blank }
+        it { expect(subject.audio_codec).to be_blank }
+        it { expect(subject.video_codec).to be_blank }
+        it { expect(subject.audio_bitrate).to be_blank }
+        it { expect(subject.video_bitrate).to be_blank }
+        it { expect(subject.state).to eq :failed }
+        it { expect(subject.created_at).to eq "2015-06-09T20:52:57Z" }
+        it { expect(subject.updated_at).to eq "2015-06-09T20:53:00Z" }
       end
     end
   end
@@ -307,14 +308,14 @@ describe ActiveEncode::EngineAdapters::ZencoderAdapter do
       allow(Zencoder::Job).to receive(:progress).and_return(progress_response)
     end
 
+    subject { encode.cancel! }
     let(:cancel_response) { Zencoder::Response.new(code: 200) } # TODO: check that this is the correct response code for a successful cancel
     let(:details_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_details_cancelled.json'))) }
     let(:progress_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_progress_cancelled.json'))) }
 
     let(:encode) { ActiveEncode::Base.create(file) }
-    subject { encode.cancel! }
     it { is_expected.to be_a ActiveEncode::Base }
-    its(:id) { is_expected.to eq '165866551' }
+    it { expect(subject.id).to eq '165866551' }
     it { is_expected.to be_cancelled }
   end
 
@@ -324,67 +325,67 @@ describe ActiveEncode::EngineAdapters::ZencoderAdapter do
       allow(Zencoder::Job).to receive(:progress).and_return(progress_response)
     end
 
+    subject { ActiveEncode::Base.find('166019107').reload }
     let(:details_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_details_running.json'))) }
     let(:progress_response) { Zencoder::Response.new(body: JSON.parse(File.read('spec/fixtures/zencoder/job_progress_running.json'))) }
     # let(:reload_output) { [{ id: "510582971", url: "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150609/48a6907086c012f68b9ca43461280515/1726d7ec3e24f2171bd07b2abb807b6c.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=vSvlxU94wlQLEbpG3Zs8ibp4MoY%3D&Expires=1433953106", label: nil }] }
     # let(:reload_tech_metadata) { { audio_bitrate: "52", audio_codec: "aac", audio_channels: "2", duration: "57992", mime_type: "mpeg4", video_framerate: "29.97", height: "240", video_bitrate: "535", video_codec: "h264", width: "320" } }
 
-    subject { ActiveEncode::Base.find('166019107').reload }
     it { is_expected.to be_a ActiveEncode::Base }
-    its(:id) { is_expected.to eq '166019107' }
+    it { expect(subject.id).to eq '166019107' }
     it { is_expected.to be_running }
-    # its(:output) { is_expected.to eq reload_output }
-    its(:current_operations) { is_expected.to be_empty }
-    its(:percent_complete) { is_expected.to eq 30.0 }
-    its(:errors) { is_expected.to be_empty }
-    its(:created_at) { is_expected.to eq '2015-06-09T16:18:26Z' }
-    its(:updated_at) { is_expected.to eq '2015-06-09T16:18:28Z' }
+    # it { expect(subject.output).to eq reload_output }
+    it { expect(subject.current_operations).to be_empty }
+    it { expect(subject.percent_complete).to eq 30.0 }
+    it { expect(subject.errors).to be_empty }
+    it { expect(subject.created_at).to eq '2015-06-09T16:18:26Z' }
+    it { expect(subject.updated_at).to eq '2015-06-09T16:18:28Z' }
 
     context 'input' do
       subject { ActiveEncode::Base.find('166019107').reload.input }
 
       it { is_expected.to be_a ActiveEncode::Input }
-      its(:id) { is_expected.to eq "165990056" }
-      its(:url) { is_expected.to eq "https://archive.org/download/LuckyStr1948_2/LuckyStr1948_2_512kb.mp4" }
-      its(:width) { is_expected.to eq 320 }
-      its(:height) { is_expected.to eq 240 }
-      its(:frame_rate) { is_expected.to eq 29.97 }
-      its(:duration) { is_expected.to eq 57992 }
-      its(:file_size) { is_expected.to be_blank }
-      its(:checksum) { is_expected.to be_blank }
-      its(:audio_codec) { is_expected.to eq "aac" }
-      its(:video_codec) { is_expected.to eq "h264" }
-      its(:audio_bitrate) { is_expected.to eq 52 }
-      its(:video_bitrate) { is_expected.to eq 535 }
-      its(:state) { is_expected.to eq :completed }
-      its(:created_at) { is_expected.to eq "2015-06-09T16:18:26Z" }
-      its(:updated_at) { is_expected.to eq "2015-06-09T16:18:32Z" }
+      it { expect(subject.id).to eq "165990056" }
+      it { expect(subject.url).to eq "https://archive.org/download/LuckyStr1948_2/LuckyStr1948_2_512kb.mp4" }
+      it { expect(subject.width).to eq 320 }
+      it { expect(subject.height).to eq 240 }
+      it { expect(subject.frame_rate).to eq 29.97 }
+      it { expect(subject.duration).to eq 57_992 }
+      it { expect(subject.file_size).to be_blank }
+      it { expect(subject.checksum).to be_blank }
+      it { expect(subject.audio_codec).to eq "aac" }
+      it { expect(subject.video_codec).to eq "h264" }
+      it { expect(subject.audio_bitrate).to eq 52 }
+      it { expect(subject.video_bitrate).to eq 535 }
+      it { expect(subject.state).to eq :completed }
+      it { expect(subject.created_at).to eq "2015-06-09T16:18:26Z" }
+      it { expect(subject.updated_at).to eq "2015-06-09T16:18:32Z" }
     end
 
     context 'output' do
-      let(:output) { ActiveEncode::Base.find('166019107').reload.output }
       subject { output.first }
+      let(:output) { ActiveEncode::Base.find('166019107').reload.output }
 
       it 'is an array' do
         expect(output).to be_a Array
       end
       it { is_expected.to be_a ActiveEncode::Output }
-      its(:id) { is_expected.to eq "510582971" }
-      its(:url) { is_expected.to eq "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150609/48a6907086c012f68b9ca43461280515/1726d7ec3e24f2171bd07b2abb807b6c.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=vSvlxU94wlQLEbpG3Zs8ibp4MoY%3D&Expires=1433953106" }
-      its(:label) { is_expected.to be_blank }
-      its(:width) { is_expected.to be_blank }
-      its(:height) { is_expected.to be_blank }
-      its(:frame_rate) { is_expected.to be_blank }
-      its(:duration) { is_expected.to be_blank }
-      its(:file_size) { is_expected.to be_blank }
-      its(:checksum) { is_expected.to be_blank }
-      its(:audio_codec) { is_expected.to be_blank }
-      its(:video_codec) { is_expected.to be_blank }
-      its(:audio_bitrate) { is_expected.to be_blank }
-      its(:video_bitrate) { is_expected.to be_blank }
-      its(:state) { is_expected.to eq :running }
-      its(:created_at) { is_expected.to eq "2015-06-09T16:18:26Z" }
-      its(:updated_at) { is_expected.to eq "2015-06-09T16:18:32Z" }
+      it { expect(subject.id).to eq "510582971" }
+      it { expect(subject.url).to eq "https://zencoder-temp-storage-us-east-1.s3.amazonaws.com/o/20150609/48a6907086c012f68b9ca43461280515/1726d7ec3e24f2171bd07b2abb807b6c.mp4?AWSAccessKeyId=AKIAI456JQ76GBU7FECA&Signature=vSvlxU94wlQLEbpG3Zs8ibp4MoY%3D&Expires=1433953106" }
+      it { expect(subject.label).to be_blank }
+      it { expect(subject.width).to be_blank }
+      it { expect(subject.height).to be_blank }
+      it { expect(subject.frame_rate).to be_blank }
+      it { expect(subject.duration).to be_blank }
+      it { expect(subject.file_size).to be_blank }
+      it { expect(subject.checksum).to be_blank }
+      it { expect(subject.audio_codec).to be_blank }
+      it { expect(subject.video_codec).to be_blank }
+      it { expect(subject.audio_bitrate).to be_blank }
+      it { expect(subject.video_bitrate).to be_blank }
+      it { expect(subject.state).to eq :running }
+      it { expect(subject.created_at).to eq "2015-06-09T16:18:26Z" }
+      it { expect(subject.updated_at).to eq "2015-06-09T16:18:32Z" }
     end
   end
 end