active_encode 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 03c144b848e422a6f99d8f102dc0fce7efe3a8aa
-  data.tar.gz: 7b4617a90685806b2d0fc7434955828bb7ebf0cd
+  metadata.gz: b4cc9a23af554f70fe254b6c08dd9422e0799c5e
+  data.tar.gz: 7c4ba992d65bd57c36767cbcd386b35a645a0b8c
 SHA512:
-  metadata.gz: d3a4a5d7f9b0edc0ea63022fe360c99e70953dc4adfd6cf6419e10c4940db68767a7a5715d5f075da27c4ad1630a6dfbf6fb3054f6c1c6a8d5f9194e7a3bd381
-  data.tar.gz: e2661ed0ebdd2e3b1eb16e85d63c5e812494fa2c538c944286629fe43b33c145a7d0de825e96b800e754c5d02216e247492e44c857a24c6686f7c62023a70cb3
+  metadata.gz: 07f0ac6c7f1f0bd3a794ca21ae31ecacd311dbd2cba15b6e878706fe6c7a11b4c481fd538391d8564b28f4de37bc5d4ff91dd14125f64b642f2b4e166b721d9d
+  data.tar.gz: 5fd817093bab2eb625ac4098f256fb4597ac316b8d747fb003e64f7aeafc6faa2f79d74c50c5692bcb611339dc9d605b646286bd3c8bb6fbbe465d9124b850dd

data/.rubocop.yml

@@ -29,9 +29,6 @@ Metrics/CyclomaticComplexity:
   Exclude:
     - 'lib/active_encode/engine_adapters/*'
 
-Style/FileName:
-  Exclude:
-
 Style/IndentationConsistency:
   EnforcedStyle: rails
 
@@ -43,6 +40,10 @@ Style/CollectionMethods:
     detect: 'find'
     find_all: 'select'
 
+Style/FileName: # https://github.com/bbatsov/rubocop/issues/2973
+  Exclude:
+    - 'Gemfile'
+
 Style/WordArray:
   Enabled: false
 

data/Gemfile

@@ -3,10 +3,10 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in hydra-transcoder.gemspec
 gemspec
 
+gem 'aws-sdk'
 gem 'byebug'
 gem 'rubocop', require: false
 gem 'rubocop-rspec', require: false
 gem 'rubyhorn', git: "https://github.com/avalonmediasystem/rubyhorn.git"
-gem 'zencoder'
 gem 'shingoncoder'
-gem 'aws-sdk'
+gem 'zencoder'

data/active_encode.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'active_encode/version'
@@ -8,8 +9,8 @@ Gem::Specification.new do |spec|
   spec.version       = ActiveEncode::VERSION
   spec.authors       = ["Michael Klein, Chris Colvard"]
   spec.email         = ["mbklein@gmail.com, chris.colvard@gmail.com"]
-  spec.summary       = %q{Declare encode job classes that can be run by a variety of encoding services}
-  spec.description   = %q{This gem serves as the basis for the interface between a Ruby (Rails) application and a provider of transcoding services such as Opencast Matterhorn, Zencoder, and Amazon Elastic Transcoder.}
+  spec.summary       = 'Declare encode job classes that can be run by a variety of encoding services'
+  spec.description   = 'This gem serves as the basis for the interface between a Ruby (Rails) application and a provider of transcoding services such as Opencast Matterhorn, Zencoder, and Amazon Elastic Transcoder.'
   spec.homepage      = ""
   spec.license       = "MIT"
 

data/lib/active_encode/base.rb

@@ -13,4 +13,6 @@ module ActiveEncode #:nodoc:
     include EngineAdapter
     include Callbacks
   end
+
+  class NotFound < RuntimeError; end
 end

data/lib/active_encode/core.rb

@@ -30,6 +30,7 @@ module ActiveEncode
       end
 
       def find(id)
+        raise ArgumentError, 'id cannot be nil' unless id
         engine_adapter.find(id, cast: self)
       end
 

data/lib/active_encode/engine_adapter.rb

@@ -38,7 +38,7 @@ module ActiveEncode
           end
         end
 
-        ENGINE_ADAPTER_METHODS = [:create, :find, :list, :cancel, :purge, :remove_output].freeze
+        ENGINE_ADAPTER_METHODS = %i[create find list cancel purge remove_output].freeze
 
         def engine_adapter?(object)
           ENGINE_ADAPTER_METHODS.all? { |meth| object.respond_to?(meth) }

data/lib/active_encode/engine_adapters/elastic_transcoder_adapter.rb

@@ -127,7 +127,7 @@ module ActiveEncode
         end
 
         def convert_tech_metadata(props)
-          return {} if props.nil? || props.empty?
+          return {} if props.blank?
           metadata_fields = {
             file_size: { key: :file_size, method: :itself },
             duration_millis: { key: :duration, method: :to_s },

data/lib/active_encode/engine_adapters/matterhorn_adapter.rb

@@ -291,7 +291,7 @@ module ActiveEncode
 
     class MatterhornRtmpUrl
       class_attribute :members
-      self.members = [:application, :prefix, :media_id, :stream_id, :filename, :extension]
+      self.members = %i[application prefix media_id stream_id filename extension]
       attr_accessor(*members)
       REGEX = %r{^
   /(?<application>.+)        # application (avalon)

data/lib/active_encode/engine_adapters/zencoder_adapter.rb

@@ -103,8 +103,8 @@ module ActiveEncode
         def convert_errors(job_details)
           errors = []
           input_error = job_details.body["job"]["input_media_file"]["error_message"]
-          errors << input_error unless input_error.blank?
-          job_details.body["job"]["output_media_files"].each { |o| errors << o["error_message"] unless o["error_message"].blank? }
+          errors << input_error if input_error.present?
+          job_details.body["job"]["output_media_files"].each { |o| errors << o["error_message"] if o["error_message"].present? }
           errors
         end
 

data/lib/active_encode/version.rb

@@ -1,3 +1,3 @@
 module ActiveEncode
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.1'.freeze
 end

data/spec/units/core_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe ActiveEncode::Core do
+  describe 'find' do
+    it "raises NotFound when no id is supplied" do
+      expect { ActiveEncode::Base.find(nil) }.to raise_error(ArgumentError)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_encode
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Michael Klein, Chris Colvard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-21 00:00:00.000000000 Z
+date: 2017-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -169,6 +169,7 @@ files:
 - spec/integration/zencoder_adapter_spec.rb
 - spec/spec_helper.rb
 - spec/units/callbacks_spec.rb
+- spec/units/core_spec.rb
 - spec/units/engine_adapter_spec.rb
 - spec/units/status_spec.rb
 homepage: ''
@@ -236,5 +237,6 @@ test_files:
 - spec/integration/zencoder_adapter_spec.rb
 - spec/spec_helper.rb
 - spec/units/callbacks_spec.rb
+- spec/units/core_spec.rb
 - spec/units/engine_adapter_spec.rb
 - spec/units/status_spec.rb