active_delegate 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0ff0702750360bd4c01ebc4075853ce241921ec038c864e6c3536934adfbcba
-  data.tar.gz: 3e18f2b5f05f886b1d5a25e7e2b46cc5fb511ccd90edbff242b543891512359c
+  metadata.gz: f0d5996473a59885a272818e9654d9163978b34d0a280f068078811ab6faa6b9
+  data.tar.gz: cc625328747d9108c7c42a85714a3be6829f8dd0be44736be2c1d6484f41d9c2
 SHA512:
-  metadata.gz: 81f7b9b0b20bca2831c30c1e90ed4789cfcac4501b37816eb4ff6879a78da79875d67f7a9fd90a71c4d5a977a6eec4cfe376424c10e7c04cd4d4b283dca2ddaa
-  data.tar.gz: b6bef5e43efab6fa63b8f3f95952fc2e1f3df0cdd2f4af7cefdad6e73e18edddb2b8ebd13d78130bce3b3dfb443e086f23445b48a72fb9c4eb71c9d56e2734dc
+  metadata.gz: 3aaa1cd551c0d1758441b5365532bf57de54c8ab0d0bd369be80f3c540a6744cbba758a41f52c430905252d2ef25731709ad19126eb7d78758aa53b50f34d0cd
+  data.tar.gz: f73de9365f2ac2201555b3e19be8ddb3817a4db18dffab719d2a0f29b747c518e2e38bd2a0952772a3e7895cb40ea301656e50a07d73d6f8d545de56c4e48e7c

data/lib/active_delegate/association/methods.rb

@@ -27,11 +27,11 @@ module ActiveDelegate
       end
 
       def prefixed
-        prefixes.map { |s| :"#{s}#{attribute}" }
+        prefixes.map { |s| :"#{s}#{association_name}" }
       end
 
       def suffixed
-        suffixes.map { |s| :"#{attribute}#{s}" }
+        suffixes.map { |s| :"#{association_name}#{s}" }
       end
     end
   end

data/lib/active_delegate/attribute/methods.rb

@@ -6,7 +6,9 @@ module ActiveDelegate
     class Methods
       attr_reader :attribute_name, :association_instance
 
-      def initialize(attribute_name, association_class)
+      def initialize(attribute_name, association_class, writer:, dirty:)
+        @define_writer        = writer
+        @define_dirty         = dirty
         @attribute_name       = attribute_name
         @association_instance = association_class.new
       end
@@ -26,7 +28,10 @@ module ActiveDelegate
       private
 
       def accessor_suffixes
-        ['', '=', '?']
+        suffixes = ['', '?']
+        suffixes << '=' if @define_writer
+
+        suffixes
       end
 
       def dirty_module
@@ -36,6 +41,8 @@ module ActiveDelegate
       end
 
       def dirty_suffixes
+        return [] unless @define_dirty
+
         @dirty_suffixes ||= begin
           suffixes = dirty_module.attribute_method_matchers.map(&:suffix)
           suffixes.select { |m| m.starts_with?('_') }

data/lib/active_delegate/attribute/object.rb

@@ -16,19 +16,27 @@ module ActiveDelegate
       end
 
       def define?
-        options[:define] || in_option?(:define)
+        dirty? && (in_option?(:define) || options[:define])
       end
 
       def localize?
-        options[:localized] || in_option?(:localized)
+        in_option?(:localized) || options[:localized]
+      end
+
+      def writer?
+        in_option?(:writer) || options[:writer]
+      end
+
+      def dirty?
+        writer? && (in_option?(:dirty) || options[:dirty])
       end
 
       def finder?
-        options[:finder] || in_option?(:finder)
+        in_option?(:finder) || options[:finder]
       end
 
       def scope?
-        options[:scope] || in_option?(:scope)
+        in_option?(:scope) || options[:scope]
       end
 
       def prefix
@@ -69,10 +77,13 @@ module ActiveDelegate
 
       def aliases
         return {} unless aliased?
+
         Hash[delegatable_methods.map { |m| generate_alias(m) }]
       end
 
       def localized
+        return [] unless localize?
+
         @localized ||= Localize.new(unprefixed, association_class).attributes
       end
 
@@ -86,7 +97,11 @@ module ActiveDelegate
 
       def delegatable_methods
         @delegatable_methods ||= [unprefixed, *localized].flat_map do |method_name|
-          Methods.new(method_name, association_class).delegatable
+          methods = Methods.new(
+            method_name, association_class, writer: writer?, dirty: dirty?
+          )
+
+          methods.delegatable
         end
       end
 
@@ -97,7 +112,7 @@ module ActiveDelegate
       end
 
       def remove_prefix(attr_name)
-        attr_name.to_s.sub("#{prefix}_", '').to_sym
+        prefix.present? ? attr_name.to_s.sub("#{prefix}_", '').to_sym : attr_name
       end
 
       def generate_alias(method_name)

data/lib/active_delegate/attributes.rb

@@ -11,6 +11,8 @@ module ActiveDelegate
       {
         except:    [],
         only:      [],
+        writer:    true,
+        dirty:     true,
         localized: false,
         define:    true,
         finder:    false,
@@ -22,7 +24,7 @@ module ActiveDelegate
     end
 
     def attribute_options
-      keys = %i[cast_type default define alias localized finder scope]
+      keys = %i[cast_type default define alias writer dirty localized finder scope]
       options.select { |k, _v| k.in? keys }.merge(prefix: delegation_prefix)
     end
 
@@ -31,7 +33,11 @@ module ActiveDelegate
     end
 
     def excluded_attributes
-      excluded  = %i[id created_at updated_at]
+      excluded  = %i[created_at updated_at]
+      excluded << association_reflection.active_record_primary_key.to_sym
+
+      for_key   = association_reflection.foreign_key
+      excluded << for_key.to_sym if for_key.present?
 
       sti_col   = association_class.inheritance_column
       excluded << sti_col.to_sym if sti_col.present?
@@ -88,10 +94,17 @@ module ActiveDelegate
         default:     attribute.default
       }
 
+      redefine_reader(method_name, attr_options)
+      redefine_writer(method_name, attr_options) if attribute.writer?
+    end
+
+    def redefine_reader(method_name, attr_options)
       model.send(:redefine_method, method_name) do |*args|
         ActiveDelegate::Attribute::Accessor.new(self, attr_options).read(*args)
       end
+    end
 
+    def redefine_writer(method_name, attr_options)
       model.send(:redefine_method, :"#{method_name}=") do |value|
         ActiveDelegate::Attribute::Accessor.new(self, attr_options).write(value)
       end

data/lib/active_delegate/delegator.rb

@@ -45,6 +45,7 @@ module ActiveDelegate
     def association_reflection
       reflection = model.reflect_on_association(association_name)
       return reflection unless reflection.nil?
+
       raise "#{model.name} don't have the association #{association_name}"
     end
 

data/lib/active_delegate/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveDelegate
-  VERSION = '1.0.2'
+  VERSION = '1.0.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_delegate
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Jonian Guveli
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-11 00:00:00.000000000 Z
+date: 2019-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -108,8 +108,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: Delegate ActiveRecord model attributes and associations