active_data 1.0.0 → 1.1.0

data/spec/shared/nested_attribute_examples.rb

@@ -0,0 +1,332 @@
+require 'spec_helper'
+
+shared_examples 'nested attributes' do
+  before do
+    stub_model :project do
+      include ActiveData::Model::Primary
+      include ActiveData::Model::Lifecycle
+
+      primary :slug, String
+      attribute :title, String
+    end
+
+    stub_model :profile do
+      include ActiveData::Model::Primary
+      include ActiveData::Model::Lifecycle
+
+      primary :identifier
+      attribute :first_name, String
+    end
+  end
+
+  context 'embeds_one' do
+    let(:user) { User.new }
+
+    specify { expect { user.profile_attributes = {} }.to change { user.profile }.to(an_instance_of(Profile)) }
+    specify { expect { user.profile_attributes = {first_name: 'User'} }.to change { user.profile.try(:first_name) }.to('User') }
+    specify { expect { user.profile_attributes = {identifier: 42, first_name: 'User'} }.to raise_error ActiveData::ObjectNotFound }
+
+    context ':reject_if' do
+      context do
+        before { User.accepts_nested_attributes_for :profile, reject_if: :all_blank }
+        specify { expect { user.profile_attributes = {first_name: ''} }.not_to change { user.profile } }
+      end
+
+      context do
+        before { User.accepts_nested_attributes_for :profile, reject_if: ->(attributes) { attributes['first_name'].blank? } }
+        specify { expect { user.profile_attributes = {first_name: ''} }.not_to change { user.profile } }
+      end
+    end
+
+    context 'existing' do
+      let(:profile) { Profile.new(first_name: 'User') }
+      let(:user) { User.new profile: profile }
+
+      specify { expect { user.profile_attributes = {identifier: 42, first_name: 'User'} }.to raise_error ActiveData::ObjectNotFound }
+      specify { expect { user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1'} }.to change { user.profile.first_name }.to('User 1') }
+      specify { expect { user.profile_attributes = {first_name: 'User 1'} }.to change { user.profile.first_name }.to('User 1') }
+      specify { expect { user.profile_attributes = {first_name: 'User 1', _destroy: '1'} }.not_to change { user.profile.first_name } }
+      specify do
+        expect do
+          user.profile_attributes = {first_name: 'User 1', _destroy: '1'}
+          user.save { true }
+        end.not_to change { user.profile.first_name }
+      end
+      specify { expect { user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'} }.to change { user.profile.first_name }.to('User 1') }
+      specify do
+        expect do
+          user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'}
+          user.save { true }
+        end.to change { user.profile.first_name }.to('User 1')
+      end
+
+      context ':allow_destroy' do
+        before { User.accepts_nested_attributes_for :profile, allow_destroy: true }
+
+        specify { expect { user.profile_attributes = {first_name: 'User 1', _destroy: '1'} }.not_to change { user.profile.first_name } }
+        specify do
+          expect do
+            user.profile_attributes = {first_name: 'User 1', _destroy: '1'}
+            user.save { true }
+          end.not_to change { user.profile.first_name }
+        end
+        specify { expect { user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'} }.to change { user.profile.first_name }.to('User 1') }
+        specify do
+          expect do
+            user.profile_attributes = {identifier: profile.identifier.to_s, first_name: 'User 1', _destroy: '1'}
+            user.save { true }
+          end.to change { user.profile }.to(nil)
+        end
+      end
+
+      context ':update_only' do
+        before { User.accepts_nested_attributes_for :profile, update_only: true }
+
+        specify do
+          expect { user.profile_attributes = {identifier: 42, first_name: 'User 1'} }
+            .to change { user.profile.first_name }.to('User 1')
+        end
+      end
+    end
+
+    context 'not primary' do
+      before do
+        stub_model :profile do
+          include ActiveData::Model::Lifecycle
+
+          attribute :identifier, Integer
+          attribute :first_name, String
+        end
+      end
+
+      specify { expect { user.profile_attributes = {} }.to change { user.profile }.to(an_instance_of(Profile)) }
+      specify { expect { user.profile_attributes = {first_name: 'User'} }.to change { user.profile.try(:first_name) }.to('User') }
+
+      context do
+        let(:profile) { Profile.new(first_name: 'User') }
+        let(:user) { User.new profile: profile }
+
+        specify do
+          expect { user.profile_attributes = {identifier: 42, first_name: 'User 1'} }
+            .to change { user.profile.first_name }.to('User 1')
+        end
+      end
+    end
+
+    context 'generated method overwrites' do
+      before do
+        User.class_eval <<-RUBY, __FILE__, __LINE__ + 1
+          def profile_attributes=(args)
+            args.reverse_merge!(first_name: 'Default Profile Name')
+            super
+          end
+        RUBY
+      end
+
+      it 'allows generated method overwritting' do
+        expect { user.profile_attributes = {} }
+          .to change { user.profile.try(:first_name) }.to('Default Profile Name')
+      end
+    end
+  end
+
+  context 'embeds_many' do
+    let(:user) { User.new }
+
+    specify { expect { user.projects_attributes = {} }.not_to change { user.projects } }
+    specify do
+      expect { user.projects_attributes = [{title: 'Project 1'}, {title: 'Project 2'}] }
+        .to change { user.projects.map(&:title) }.to(['Project 1', 'Project 2'])
+    end
+    specify do
+      expect { user.projects_attributes = {1 => {title: 'Project 1'}, 2 => {title: 'Project 2'}} }
+        .to change { user.projects.map(&:title) }.to(['Project 1', 'Project 2'])
+    end
+    specify do
+      expect { user.projects_attributes = [{slug: 42, title: 'Project 1'}, {title: 'Project 2'}] }
+        .to change { user.projects.map(&:title) }.to(['Project 1', 'Project 2'])
+    end
+    specify do
+      expect { user.projects_attributes = [{title: ''}, {title: 'Project 2'}] }
+        .to change { user.projects.map(&:title) }.to(['', 'Project 2'])
+    end
+
+    context ':limit' do
+      before { User.accepts_nested_attributes_for :projects, limit: 1 }
+
+      specify do
+        expect { user.projects_attributes = [{title: 'Project 1'}] }
+          .to change { user.projects.map(&:title) }.to(['Project 1'])
+      end
+      specify do
+        expect { user.projects_attributes = [{title: 'Project 1'}, {title: 'Project 2'}] }
+          .to raise_error ActiveData::TooManyObjects
+      end
+    end
+
+    context ':reject_if' do
+      context do
+        before { User.accepts_nested_attributes_for :projects, reject_if: :all_blank }
+        specify do
+          expect { user.projects_attributes = [{title: ''}, {title: 'Project 2'}] }
+            .to change { user.projects.map(&:title) }.to(['Project 2'])
+        end
+      end
+
+      context do
+        before { User.accepts_nested_attributes_for :projects, reject_if: ->(attributes) { attributes['title'].blank? } }
+        specify do
+          expect { user.projects_attributes = [{title: ''}, {title: 'Project 2'}] }
+            .to change { user.projects.map(&:title) }.to(['Project 2'])
+        end
+      end
+
+      context do
+        before { User.accepts_nested_attributes_for :projects, reject_if: ->(attributes) { attributes['foobar'].blank? } }
+        specify do
+          expect { user.projects_attributes = [{title: ''}, {title: 'Project 2'}] }
+            .not_to change { user.projects }
+        end
+      end
+    end
+
+    context 'existing' do
+      let(:projects) { Array.new(2) { |i| Project.new(title: "Project #{i.next}").tap { |pr| pr.slug = 42 + i } } }
+      let(:user) { User.new projects: projects }
+
+      specify do
+        expect do
+          user.projects_attributes = [
+            {slug: projects.first.slug.to_i, title: 'Project 3'},
+            {title: 'Project 4'}
+          ]
+        end
+          .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2', 'Project 4'])
+      end
+      specify do
+        expect do
+          user.projects_attributes = [
+            {slug: projects.first.slug.to_i, title: 'Project 3'},
+            {slug: 33, title: 'Project 4'}
+          ]
+        end
+          .to change { user.projects.map(&:slug) }.to(%w[42 43 33])
+      end
+      specify do
+        expect do
+          user.projects_attributes = [
+            {slug: projects.first.slug.to_i, title: 'Project 3'},
+            {slug: 33, title: 'Project 4', _destroy: 1}
+          ]
+        end
+          .not_to change { user.projects.map(&:slug) }
+      end
+      specify do
+        expect do
+          user.projects_attributes = {
+            1 => {slug: projects.first.slug.to_i, title: 'Project 3'},
+            2 => {title: 'Project 4'}
+          }
+        end
+          .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2', 'Project 4'])
+      end
+      specify do
+        expect do
+          user.projects_attributes = [
+            {slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1'},
+            {title: 'Project 4', _destroy: '1'}
+          ]
+        end
+          .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2'])
+      end
+      specify do
+        expect do
+          user.projects_attributes = [
+            {slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1'},
+            {title: 'Project 4', _destroy: '1'}
+          ]
+          user.save { true }
+        end
+          .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2'])
+      end
+
+      context ':allow_destroy' do
+        before { User.accepts_nested_attributes_for :projects, allow_destroy: true }
+
+        specify do
+          expect do
+            user.projects_attributes = [
+              {slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1'},
+              {title: 'Project 4', _destroy: '1'}
+            ]
+          end
+            .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2'])
+        end
+        specify do
+          expect do
+            user.projects_attributes = [
+              {slug: projects.first.slug.to_i, title: 'Project 3', _destroy: '1'},
+              {title: 'Project 4', _destroy: '1'}
+            ]
+            user.save { true }
+          end
+            .to change { user.projects.map(&:title) }.to(['Project 2'])
+        end
+      end
+
+      context ':update_only' do
+        before { User.accepts_nested_attributes_for :projects, update_only: true }
+
+        specify do
+          expect do
+            user.projects_attributes = [
+              {slug: projects.first.slug.to_i, title: 'Project 3'},
+              {title: 'Project 4'}
+            ]
+          end
+            .to change { user.projects.map(&:title) }.to(['Project 3', 'Project 2'])
+        end
+
+        specify do
+          expect do
+            user.projects_attributes = [
+              {slug: projects.last.slug.to_i, title: 'Project 3'},
+              {slug: projects.first.slug.to_i.pred, title: 'Project 0'}
+            ]
+          end
+            .to change { user.projects.map(&:title) }.to(['Project 1', 'Project 3'])
+        end
+      end
+    end
+
+    context 'primary absence causes exception' do
+      before do
+        stub_model :project do
+          include ActiveData::Model::Primary
+          include ActiveData::Model::Lifecycle
+
+          attribute :slug, String
+          attribute :title, String
+        end
+      end
+
+      specify { expect { user.projects_attributes = {} }.to raise_error ActiveData::UndefinedPrimaryAttribute }
+    end
+
+    context 'generated method overwrites' do
+      before do
+        User.class_eval <<-RUBY, __FILE__, __LINE__ + 1
+          def projects_attributes=(args)
+            args << {title: 'Default Project'}
+            super
+          end
+        RUBY
+      end
+
+      it 'allows generated method overwritting' do
+        expect { user.projects_attributes = [] }
+          .to change { user.projects.map(&:title) }.to(['Default Project'])
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'bundler'
+require 'pry'
 Bundler.require
 
 require 'rspec/its'
@@ -6,6 +7,7 @@ require 'active_record'
 require 'database_cleaner'
 
 require 'support/model_helpers'
+require 'support/muffle_helper'
 
 ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
 ActiveRecord::Base.logger = Logger.new('/dev/null')
@@ -29,6 +31,7 @@ RSpec.configure do |config|
   config.filter_run focus: true
 
   config.include ModelHelpers
+  config.include MuffleHelpers
 
   config.before(:suite) do
     DatabaseCleaner.clean_with :truncation

data/spec/support/model_helpers.rb

@@ -1,9 +1,9 @@
 module ModelHelpers
-  def stub_model name = nil, superclass = nil, &block
+  def stub_model(name = nil, superclass = nil, &block)
     stub_class(name, superclass) { include ActiveData::Model }.tap { |klass| klass.class_eval(&block) if block }
   end
 
-  def stub_class name = nil, superclass = nil, &block
+  def stub_class(name = nil, superclass = nil, &block)
     klass = superclass ? Class.new(superclass, &block) : Class.new(&block)
     name.present? ? stub_const(name.to_s.camelize, klass) : klass
   end

data/spec/support/muffle_helper.rb

@@ -0,0 +1,7 @@
+module MuffleHelpers
+  def muffle(*exceptions)
+    yield
+  rescue *exceptions.flatten
+    nil
+  end
+end

metadata

@@ -1,17 +1,31 @@
 --- !ruby/object:Gem::Specification
 name: active_data
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - pyromaniac
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-03 00:00:00.000000000 Z
+date: 2018-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -25,7 +39,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: appraisal
+  name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -39,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-its
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: database_cleaner
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,19 +109,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: uuidtools
   requirement: !ruby/object:Gem::Requirement
@@ -123,7 +137,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,7 +151,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '4.0'
 - !ruby/object:Gem::Dependency
-  name: activemodel
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -171,11 +185,15 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".rvmrc"
 - ".travis.yml"
 - Appraisals
+- CHANGELOG.md
 - Gemfile
 - Guardfile
 - LICENSE
@@ -186,9 +204,11 @@ files:
 - gemfiles/rails.4.1.gemfile
 - gemfiles/rails.4.2.gemfile
 - gemfiles/rails.5.0.gemfile
+- gemfiles/rails.5.1.gemfile
 - lib/active_data.rb
 - lib/active_data/active_record/associations.rb
 - lib/active_data/active_record/nested_attributes.rb
+- lib/active_data/base.rb
 - lib/active_data/config.rb
 - lib/active_data/errors.rb
 - lib/active_data/extensions.rb
@@ -197,18 +217,24 @@ files:
 - lib/active_data/model/associations/base.rb
 - lib/active_data/model/associations/collection/embedded.rb
 - lib/active_data/model/associations/collection/proxy.rb
-- lib/active_data/model/associations/collection/referenced.rb
+- lib/active_data/model/associations/embeds_any.rb
 - lib/active_data/model/associations/embeds_many.rb
 - lib/active_data/model/associations/embeds_one.rb
 - lib/active_data/model/associations/nested_attributes.rb
+- lib/active_data/model/associations/persistence_adapters/active_record.rb
+- lib/active_data/model/associations/persistence_adapters/active_record/referenced_proxy.rb
+- lib/active_data/model/associations/persistence_adapters/base.rb
+- lib/active_data/model/associations/references_any.rb
 - lib/active_data/model/associations/references_many.rb
 - lib/active_data/model/associations/references_one.rb
 - lib/active_data/model/associations/reflections/base.rb
+- lib/active_data/model/associations/reflections/embeds_any.rb
 - lib/active_data/model/associations/reflections/embeds_many.rb
 - lib/active_data/model/associations/reflections/embeds_one.rb
-- lib/active_data/model/associations/reflections/reference_reflection.rb
+- lib/active_data/model/associations/reflections/references_any.rb
 - lib/active_data/model/associations/reflections/references_many.rb
 - lib/active_data/model/associations/reflections/references_one.rb
+- lib/active_data/model/associations/reflections/singular.rb
 - lib/active_data/model/associations/validations.rb
 - lib/active_data/model/attributes.rb
 - lib/active_data/model/attributes/attribute.rb
@@ -234,11 +260,13 @@ files:
 - lib/active_data/model/localization.rb
 - lib/active_data/model/persistence.rb
 - lib/active_data/model/primary.rb
+- lib/active_data/model/representation.rb
 - lib/active_data/model/scopes.rb
 - lib/active_data/model/validations.rb
 - lib/active_data/model/validations/associated.rb
 - lib/active_data/model/validations/nested.rb
 - lib/active_data/railtie.rb
+- lib/active_data/undefined_class.rb
 - lib/active_data/version.rb
 - spec/lib/active_data/active_record/associations_spec.rb
 - spec/lib/active_data/active_record/nested_attributes_spec.rb
@@ -246,6 +274,7 @@ files:
 - spec/lib/active_data/model/associations/embeds_many_spec.rb
 - spec/lib/active_data/model/associations/embeds_one_spec.rb
 - spec/lib/active_data/model/associations/nested_attributes_spec.rb
+- spec/lib/active_data/model/associations/persistence_adapters/active_record_spec.rb
 - spec/lib/active_data/model/associations/references_many_spec.rb
 - spec/lib/active_data/model/associations/references_one_spec.rb
 - spec/lib/active_data/model/associations/reflections/embeds_many_spec.rb
@@ -271,9 +300,9 @@ files:
 - spec/lib/active_data/model/conventions_spec.rb
 - spec/lib/active_data/model/dirty_spec.rb
 - spec/lib/active_data/model/lifecycle_spec.rb
-- spec/lib/active_data/model/nested_attributes.rb
 - spec/lib/active_data/model/persistence_spec.rb
 - spec/lib/active_data/model/primary_spec.rb
+- spec/lib/active_data/model/representation_spec.rb
 - spec/lib/active_data/model/scopes_spec.rb
 - spec/lib/active_data/model/typecasting_spec.rb
 - spec/lib/active_data/model/validations/associated_spec.rb
@@ -281,8 +310,10 @@ files:
 - spec/lib/active_data/model/validations_spec.rb
 - spec/lib/active_data/model_spec.rb
 - spec/lib/active_data_spec.rb
+- spec/shared/nested_attribute_examples.rb
 - spec/spec_helper.rb
 - spec/support/model_helpers.rb
+- spec/support/muffle_helper.rb
 homepage: ''
 licenses: []
 metadata: {}
@@ -302,7 +333,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Working with hashes in AR style
@@ -313,6 +344,7 @@ test_files:
 - spec/lib/active_data/model/associations/embeds_many_spec.rb
 - spec/lib/active_data/model/associations/embeds_one_spec.rb
 - spec/lib/active_data/model/associations/nested_attributes_spec.rb
+- spec/lib/active_data/model/associations/persistence_adapters/active_record_spec.rb
 - spec/lib/active_data/model/associations/references_many_spec.rb
 - spec/lib/active_data/model/associations/references_one_spec.rb
 - spec/lib/active_data/model/associations/reflections/embeds_many_spec.rb
@@ -338,9 +370,9 @@ test_files:
 - spec/lib/active_data/model/conventions_spec.rb
 - spec/lib/active_data/model/dirty_spec.rb
 - spec/lib/active_data/model/lifecycle_spec.rb
-- spec/lib/active_data/model/nested_attributes.rb
 - spec/lib/active_data/model/persistence_spec.rb
 - spec/lib/active_data/model/primary_spec.rb
+- spec/lib/active_data/model/representation_spec.rb
 - spec/lib/active_data/model/scopes_spec.rb
 - spec/lib/active_data/model/typecasting_spec.rb
 - spec/lib/active_data/model/validations/associated_spec.rb
@@ -348,5 +380,7 @@ test_files:
 - spec/lib/active_data/model/validations_spec.rb
 - spec/lib/active_data/model_spec.rb
 - spec/lib/active_data_spec.rb
+- spec/shared/nested_attribute_examples.rb
 - spec/spec_helper.rb
 - spec/support/model_helpers.rb
+- spec/support/muffle_helper.rb

data/lib/active_data/model/associations/collection/referenced.rb

@@ -1,26 +0,0 @@
-module ActiveData
-  module Model
-    module Associations
-      module Collection
-        class Referenced < Proxy
-          METHODS_EXCLUDED_FROM_DELEGATION = %w[build create create!].map(&:to_sym).freeze
-          delegate :scope, to: :@association
-
-          def method_missing(method, *args, &block)
-            delegate_to_scope?(method) ? scope.send(method, *args, &block) : super
-          end
-
-          def respond_to_missing?(method, include_private = false)
-            delegate_to_scope?(method) || super
-          end
-
-        private
-
-          def delegate_to_scope?(method)
-            METHODS_EXCLUDED_FROM_DELEGATION.exclude?(method) && scope.respond_to?(method)
-          end
-        end
-      end
-    end
-  end
-end