active_currency 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb620b38733eb426ea053d9e540fcd1d94ddbf636f93b377e9295b8bd6ca0d41
-  data.tar.gz: c6f2aa32d2ddee861583986f013c0864d7f9846691b05daecf391cc9eb89a225
+  metadata.gz: deaf57273ac8a06081edea671655192a53a560f5b4d2573818e1b3998d892f94
+  data.tar.gz: 78a851b36ae4a92fda99e8dd768685b0e5627069e75bbc07b349154823549c61
 SHA512:
-  metadata.gz: 2c10136f43d38a1c998a302261d6c388cf9a491f46de97cf723ed13c112287e1a4c1af59e152d112489c914f16beb95d6208d5e54f62b06787242c8cb74b3c96
-  data.tar.gz: 744a5f9343e62b907eb5dc05a740728a41963949b60ca762d99e78ba340d832e0124f2f9ed9165d52528d1af329c75e7a87c8564c65ea991f4822e899d41592f
+  metadata.gz: 502199ad5fa78e5b7710ef17e82de1e1f9e3ff68758a9193321c15524c636b2bec34c7f9839079122693f9c3044821aec37e862745279dbe34d9c2e45e97dfeb
+  data.tar.gz: 1f733721568ddacbc5a99335b761dee893191415a147c6639c0996f6d95a3df6fb373eebae298260906ddf704dbe9b3be0120857d845b9aa88ef0719ae06ca0e

data/README.md

@@ -14,12 +14,13 @@ provides the following advantages:
   any given time.
 - Does not need to call an API to get the rates when starting or restarting
   your web server.
+- Does not depend on the file system to store cached rates.
 - Choose how often you want to update the currency rates (daily for example).
 - Your users do not suffer the cost of making calls to the bank rates API.
 - Your app does not go down when the bank rates API does.
 
-To fetch the rates, it uses the [eu_central_bank] gem and uses your application
-cache when getting the current rate in order to save on database queries.
+To fetch the *current* rate it uses your application cache instead of making
+a call to the database.
 
 ## Usage
 
@@ -66,6 +67,23 @@ end
 Then call `bin/rake db:migrate` to create the table that holds
 the currency rates and fill it for the first time.
 
+## Fetching rates
+
+By defaut it uses the [eu_central_bank] to update the currency rates.
+
+If you prefer another API, you can provide any Money-compatible bank when
+calling `ActiveCurrency::AddRates`. For example with the
+[money-open-exchange-rates] gem:
+
+```rb
+require 'money/bank/open_exchange_rates_bank'
+
+bank = Money::Bank::OpenExchangeRatesBank.new(Money::RatesStore::Memory.new)
+bank.app_id = '…'
+
+ActiveCurrency::AddRates.call(%w[EUR USD], bank: bank)
+```
+
 ## Tests
 
 In your app test suite you may not want to have to fill your database to be
@@ -93,13 +111,13 @@ Please file issues and pull requests
 Install:
 
 ```sh
-BUNDLE_GEMFILE=Gemfile-rails5.2 bundle install
+BUNDLE_GEMFILE=Gemfile-rails6.0 bundle install
 ```
 
 Launch specs and linters:
 
 ```sh
-BUNDLE_GEMFILE=Gemfile-rails5.2 bin/rake
+BUNDLE_GEMFILE=Gemfile-rails6.0 bin/rake
 ```
 
 ## Release
@@ -109,13 +127,16 @@ Update `CHANGELOG.md`, update version in `lib/active_currency/version.rb`.
 Then:
 
 ```sh
-BUNDLE_GEMFILE=Gemfile-rails3.2 bundle install
-BUNDLE_GEMFILE=Gemfile-rails4.2 bundle install
-BUNDLE_GEMFILE=Gemfile-rails5.2 bundle install
-BUNDLE_GEMFILE=Gemfile-rails6.0 bundle install
+gem install bundler:1.17.2
+BUNDLE_GEMFILE=Gemfile-rails3.2 bundle update active_currency
+BUNDLE_GEMFILE=Gemfile-rails4.2 bundle update active_currency
+
+gem install bundler:2.1.2
+BUNDLE_GEMFILE=Gemfile-rails5.2 bundle update active_currency
+BUNDLE_GEMFILE=Gemfile-rails6.0 bundle update active_currency
 
 git add CHANGELOG.md lib/active_currency/version.rb Gemfile-rails*.lock
-git commit -m 'New version'
+git commit -m v`ruby -r./lib/active_currency/version <<< 'puts ActiveCurrency::VERSION'`
 bin/rake release
 ```
 
@@ -125,3 +146,4 @@ The gem is available as open source under the terms of the
 [MIT License](http://opensource.org/licenses/MIT).
 
 [eu_central_bank]: https://github.com/RubyMoney/eu_central_bank
+[money-open-exchange-rates]: https://github.com/spk/money-open-exchange-rates

data/lib/active_currency/add_rates.rb

@@ -3,51 +3,57 @@
 module ActiveCurrency
   # Store the latest currency rates.
   class AddRates
-    def initialize(currencies)
+    def initialize(currencies, bank: EuCentralBank.new)
       @currencies = currencies
+      @bank = bank
     end
 
     def call
+      bank.update_rates
+
       other_currencies.each do |to|
-        store_rate(from, to)
+        store_rate(to)
       end
     end
 
-    def self.call(currencies)
-      new(currencies).call
+    def self.call(currencies, *options)
+      new(currencies, *options).call
     end
 
     private
 
+    attr_accessor :bank
+
     def currencies
       @currencies.map(&:to_s).map(&:upcase)
     end
 
     def other_currencies
-      currencies - [from]
+      currencies.drop(1)
     end
 
     def from
-      'EUR'
+      @from ||= currencies.first
     end
 
     def store
       @store ||= ActiveCurrency::RateStore.new
     end
 
-    def bank
-      @bank ||= EuCentralBank.new.tap(&:update_rates)
+    def store_rate(to)
+      rate, inverse = get_rates(to)
+
+      store.add_rate(from, to, rate)
+      store.add_rate(to, from, inverse)
     end
 
-    def store_rate(from, to)
+    def get_rates(to)
       rate = bank.get_rate(from, to)
+      raise "Unknown rate between #{from} and #{to}" if rate.nil? || rate.zero?
 
-      if rate.nil? || rate.zero?
-        raise "Bank rate must be set but bank returned #{rate.inpsect}"
-      end
+      inverse = bank.get_rate(to, from) || 1.fdiv(rate)
 
-      store.add_rate(from, to, rate)
-      store.add_rate(to, from, 1.fdiv(rate))
+      [rate, inverse]
     end
   end
 end

data/lib/active_currency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveCurrency
-  VERSION = '1.0.2'
+  VERSION = '1.1.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_currency
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Sunny Ripert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-05 00:00:00.000000000 Z
+date: 2019-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -56,16 +56,16 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.6
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement