active_currency 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c07e2a76dae93079049c2140345f1e38a64d81ac
-  data.tar.gz: 179ad081203f6de02d2b44a74f1449d9eead1d52
+  metadata.gz: e714ea208f9bd8ebded58b96bde8497a9f9c47c2
+  data.tar.gz: fdd79e4b7ed274966cc932f7f4ba8536040ba02c
 SHA512:
-  metadata.gz: e31ee097e49beaaad38f1c714d1893ca80a6b09b8ef1211bc37545d0470a000470b99e1b3583ee62f4be269e9e23d4eb7413a9ca8d2e31cc0d5c8d44e41ff9cf
-  data.tar.gz: 1258f0d28a6be18644b1d19452ede084f439257b50b35bab6138bef3c9b0fc5bfa9b8019c9ee53b85f83bf34c46a204be315f36b63209576558dfb05f2d7e5ac
+  metadata.gz: ef833fcd22cf76b2511ff68a4930d1026e3687c129674abb6f96a79b2fdd64899f5c962d9fe582c911f10835c6d40363199a3876e0669e48d17c69982a734864
+  data.tar.gz: f2d8a04600e685729c538a47323c43504a7ad939ade1b425c1e940e5acdd9d09d9ad639dbbfa0b7dcd16e3a71945a0799314f1e02cdc6c4ed9951cfba6b74a4f

data/README.md

@@ -1,5 +1,7 @@
 # ActiveCurrency
 
+[![CircleCI](https://circleci.com/gh/sunny/active_currency.svg?style=svg)](https://circleci.com/gh/sunny/active_currency)
+
 Rails plugin to retrieve and store the currency rates daily to integrate
 with the `money-rails` gem.
 
@@ -15,10 +17,9 @@ provides the following advantages:
 - Choose how often you want to check for a currency (daily for example).
 - Your users do not suffer the cost of making calls to the bank rates API.
 - Your app does not go down when the bank rates API does.
-- When fetching the current rate, it uses your application cache in order not
-  to have to do a database query.
 
-To fetch the rates, it uses the [eu_central_bank] gem.
+To fetch the rates, it uses the [eu_central_bank] gem and uses your application
+cache when getting the current rate in order to save on database queries.
 
 ## Usage
 
@@ -29,13 +30,13 @@ like `sidekiq-scheduler` or `whenever`) with the currencies you want to store:
 ActiveCurrency::AddRates.call(%w[EUR USD])
 ```
 
-You can then exchange money by using the Money gem:
+You can then exchange money by using the Money gem helpers:
 
 ```rb
 10.to_money('EUR').exchange_to('USD').cents
 ```
 
-Or look up the currency rate:
+If you need to look up the previous currency rates:
 
 ```rb
 ActiveCurrency::Rate.value_for('EUR', 'USD', 1.month.ago)
@@ -69,13 +70,13 @@ the currency rates and fill it for the first time.
 In your app test suite you may not want to have to fill your database to be
 able to exchange currencies.
 
-For that, you should use a fake rate store in `config/initializers/money.rb`:
+For that, you can use a fake rate store in your `rails_helper.rb`:
 
 ```rb
-if Rails.env.test?
+MoneyRails.configure do |config|
   rate_store = Money::RatesStore::Memory.new.tap do |store|
-    store.add_rate('USD', 'EUR', 0.5)
-    store.add_rate('EUR', 'USD', 1.5)
+    store.add_rate('USD', 'EUR', 1.5)
+    store.add_rate('EUR', 'USD', 1.4)
   end
   config.default_bank = Money::Bank::VariableExchange.new(rate_store)
 end
@@ -86,10 +87,18 @@ end
 Please file issues and pull requests
 [on GitHub](https://github.com/sunny/active_currency).
 
-In developemnt, launch specs and code linter by calling:
+## Development
+
+Install:
+
+```sh
+BUNDLE_GEMFILE=Gemfile-rails4.2 bundle install
+```
+
+Launch specs and linters:
 
 ```sh
-BUNDLE_GEMFILE=Gemfile-rails3.2 bundle exec rspec && bundle exec rake
+BUNDLE_GEMFILE=Gemfile-rails4.2 bundle exec rake
 ```
 
 ## License

data/app/models/active_currency/rate.rb

@@ -2,12 +2,13 @@
 
 module ActiveCurrency
   class Rate < ActiveRecord::Base
-    validates :from,
-              :to,
-              presence: true
+    validates :from, presence: true
+    validates :to, presence: true
     validates :value, numericality: { greater_than: 0 }
 
-    scope :before, ->(date) { where(arel_table[:created_at].lt(date)) }
+    scope :before, ->(date) {
+      where(arel_table[:created_at].lt(date))
+    }
 
     def self.value_for(from, to, date = nil)
       scope = date ? before(date) : all_scope

data/db/migrate/20180911202100_create_active_currency_rates.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'active_currency/migration'
+
 class CreateActiveCurrencyRates < ActiveCurrency::Migration
   def change
     create_table :active_currency_rates do |t|
@@ -9,6 +11,8 @@ class CreateActiveCurrencyRates < ActiveCurrency::Migration
       t.datetime :created_at
     end
 
-    add_index :active_currency_rates, %i[from to created_at]
+    add_index :active_currency_rates,
+              %i[from to created_at],
+              name: 'index_active_currency_rates'
   end
 end

data/lib/active_currency.rb

@@ -3,7 +3,6 @@
 require 'money-rails'
 require 'eu_central_bank'
 
-require 'active_currency/migration'
 require 'active_currency/engine'
 require 'active_currency/database_store'
 require 'active_currency/cacheable_store'

data/lib/active_currency/add_rates.rb

@@ -8,16 +8,8 @@ module ActiveCurrency
     end
 
     def call
-      bank = EuCentralBank.new
-      bank.update_rates
-
-      from = 'EUR'
-      currencies.map(&:to_s).each do |to|
-        next if to == from
-
-        rate = bank.get_rate(from, to)
-        store.add_rate(from, to, rate)
-        store.add_rate(to, from, 1 / rate)
+      other_currencies.each do |to|
+        store_rate(from, to)
       end
     end
 
@@ -31,8 +23,31 @@ module ActiveCurrency
       @currencies.map(&:to_s).map(&:upcase)
     end
 
+    def other_currencies
+      currencies - [from]
+    end
+
+    def from
+      'EUR'
+    end
+
     def store
       @store ||= ActiveCurrency::RateStore.new
     end
+
+    def bank
+      @bank ||= EuCentralBank.new.tap(&:update_rates)
+    end
+
+    def store_rate(from, to)
+      rate = bank.get_rate(from, to)
+
+      if rate.nil? || rate.zero?
+        raise "Bank rate must be set but bank returned #{rate.inpsect}"
+      end
+
+      store.add_rate(from, to, rate)
+      store.add_rate(to, from, 1.fdiv(rate))
+    end
   end
 end

data/lib/active_currency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveCurrency
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_currency
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Sunny Ripert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-02 00:00:00.000000000 Z
+date: 2019-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -54,6 +54,20 @@ dependencies:
         version: 1.3.1
 - !ruby/object:Gem::Dependency
   name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.6
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.6
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="