active_currency 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 56f6adecbe4588cdec72671119078133df0cb4bc
-  data.tar.gz: 03425c4a136c196d0776d8160e8a7b9c0c4c66e6
+  metadata.gz: b1fe215e9c8bb75f210ec88c1e3e301f0c86fda7
+  data.tar.gz: 29a6441e018cdf3b224be0a5d5369d2069cc26fd
 SHA512:
-  metadata.gz: fde85398d3c49aa68f1ed012025f443bc47a43ef5ed513670c4ce679ba4eec9c1aa460e256d1ac4125b69fb6fe8f5412536601828f5257bbc1b897933ecc7688
-  data.tar.gz: 566f5c432f78da8151db7d5ed9ed81e83c1e6cdba28999f42a15eed930fc750f21606d9b77a8e8982b54f81ec7369cc7ff91c54c3709cc7375ce706933f8fc64
+  metadata.gz: 728585d0085673bd3de09001cf83fcaab57cf03003e16c5b31a42e51a8a99fcb498f51aa25250c2a3eabf1ea335620d0d3e23cd177ad7abd3f91a970b635c278
+  data.tar.gz: 0b7de9fea58eb52cbb375346ab47f08b4251c33d42a853dce72a27505c64bcab68afcb472a0f5aeaeffc2a6d7b3bd6d6c818fd837c590e9780b9852da66c17eb

data/README.md

@@ -23,10 +23,10 @@ To fetch the rates, it uses the [eu_central_bank] gem.
 ## Usage
 
 Store the current rate regularly by calling in a scheduled job (using something
-like `sidekiq-scheduler` or `whenever`):
+like `sidekiq-scheduler` or `whenever`) with the currencies you want to store:
 
 ```rb
-ActiveCurrency::AddRates.new(%w[EUR USD]).call
+ActiveCurrency::AddRates.call(%w[EUR USD])
 ```
 
 You can then exchange money by using the Money gem:
@@ -57,8 +57,7 @@ And in `config/initializers/money.rb`:
 
 ```rb
 MoneyRails.configure do |config|
-  config.default_bank =
-    Money::Bank::VariableExchange.new(ActiveCurrency::RateStore.new)
+  config.default_bank = ActiveCurrency::Bank.new
 end
 ```
 
@@ -70,11 +69,11 @@ the currency rates and fill it for the first time.
 In your app test suite you may not want to have to fill your database to be
 able to exchange currencies.
 
-For that, you can in `config/initializers/money.rb`:
+For that, you should use a fake rate store in `config/initializers/money.rb`:
 
 ```rb
 if Rails.env.test?
-  rate_store = ActiveCurrency::MemoryRateStore.new.tap do |store|
+  rate_store = Money::RatesStore::Memory.new.tap do |store|
     store.add_rate('USD', 'EUR', 0.5)
     store.add_rate('EUR', 'USD', 1.5)
   end

data/lib/active_currency.rb

@@ -8,8 +8,8 @@ require 'active_currency/engine'
 require 'active_currency/database_store'
 require 'active_currency/cacheable_store'
 require 'active_currency/rate_store'
-require 'active_currency/memory_rate_store'
 require 'active_currency/add_rates'
+require 'active_currency/bank'
 
 module ActiveCurrency
 end

data/lib/active_currency/add_rates.rb

@@ -21,6 +21,10 @@ module ActiveCurrency
       end
     end
 
+    def self.call(currencies)
+      new(currencies).call
+    end
+
     private
 
     def currencies

data/lib/active_currency/bank.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module ActiveCurrency
+  class Bank < Money::Bank::VariableExchange
+    def initialize(rate_store = ActiveCurrency::RateStore.new)
+      super(rate_store)
+    end
+  end
+end

data/lib/active_currency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveCurrency
-  VERSION = '0.4.0'
+  VERSION = '0.5.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_currency
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Sunny Ripert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-26 00:00:00.000000000 Z
+date: 2018-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -133,13 +133,12 @@ files:
 - README.md
 - app/models/active_currency/rate.rb
 - db/migrate/20180911202100_create_active_currency_rates.rb
-- db/migrate/20180914064834_add_rates.rb
 - lib/active_currency.rb
 - lib/active_currency/add_rates.rb
+- lib/active_currency/bank.rb
 - lib/active_currency/cacheable_store.rb
 - lib/active_currency/database_store.rb
 - lib/active_currency/engine.rb
-- lib/active_currency/memory_rate_store.rb
 - lib/active_currency/migration.rb
 - lib/active_currency/rate_store.rb
 - lib/active_currency/version.rb

data/db/migrate/20180914064834_add_rates.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-class AddRates < ActiveCurrency::Migration
-  def up
-    ActiveCurrency::AddRates.new.call
-  end
-end

data/lib/active_currency/memory_rate_store.rb

@@ -1,20 +0,0 @@
-# frozen_string_literal: true
-
-module ActiveCurrency
-  class MemoryRateStore < Money::RatesStore::Memory
-    def initialize(**)
-      @currencies = Set.new
-      super
-    end
-
-    def currencies
-      @currencies.to_a
-    end
-
-    def add_rate(from, to, value)
-      @currencies << from
-      @currencies << to
-      super
-    end
-  end
-end