active_currency 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '079217f3be4857bdc2856432a807341a94eea305'
-  data.tar.gz: defcb92fec6e6124a0a5566c9f9c9040b7efe31a
+  metadata.gz: 75b316711129b3a675bad41c3531bd43f3921323
+  data.tar.gz: 00e65292dbe3783ab0d760c54fc4932a8bde18a2
 SHA512:
-  metadata.gz: bddbb54d3fbbae7b918bcb2eb90e024e7413f5656fe887f46ee3577a3af2089d1a1993575aa126bf78f62ec504f36c78ccad684c6899b0a15dedc1c3ffa8d73a
-  data.tar.gz: a0776af8effc2d92c9ff6df9a2e9679bf9cea1ae671002987202abe638c5a1b499a6d7817a6dcea534d16b33b2322efb8d0c1143559585f1c5c7e5964dae0309
+  metadata.gz: '043295dcad9a8bc822bc29a30cc9cdc1348fc3f1fb9a21b244a55bccb7b2efda4ec66c18ab5afeeb10dec13f70e29f6f1347095e4fb9c1e6133c996ec615fb8e'
+  data.tar.gz: d74ea8f17afe55780d610918895efe3c8b59d6abab49c75c16b292f7635f9cab2d5bc8e369ece2c53f35c2537e201468d33e46f864bb61e525147b53f6bff41d

data/README.md

@@ -18,6 +18,8 @@ provides the following advantages:
 - When fetching the current rate, it uses your application cache in order not
   to have to do a database query.
 
+To fetch the rates, it uses the [eu_central_bank] gem.
+
 ## Usage
 
 Store the current rate regularly by calling in a scheduled job (using something
@@ -36,10 +38,10 @@ You can then exchange money by using the Money gem:
 Or look up the currency rate:
 
 ```rb
-ActiveCurrency::Rate.current_value_for('EUR', 'USD', 10.days.ago)
+ActiveCurrency::Rate.value_for('EUR', 'USD', 1.month.ago)
 # => 1.151
 ActiveCurrency::Rate.where(from: 'EUR', to: 'USD').pluck(:value)
-# => [1.162, 1.162, 1.161, 1.61, 1.63, …]
+# => [1.162, 1.162, 1.161, 1.161, 1.163, …]
 ```
 
 ## Installation
@@ -48,8 +50,7 @@ Add these lines to your application's `Gemfile`:
 
 ```rb
 # Store and retrieve the currency from the database.
-gem 'active_currency',
-    git: 'git@github.com:sunny/active_currency.git'
+gem 'active_currency'
 ```
 
 And in `config/initializers/money.rb`:
@@ -64,6 +65,23 @@ end
 Then call `bundle exec rake db:migrate` to create the table that holds
 the currency rates and fill it for the first time.
 
+## Tests
+
+In your app test suite you may not want to have to fill your database to be
+able to exchange currencies.
+
+For that, you can in `config/initializers/money.rb`:
+
+```rb
+if Rails.env.test?
+  rate_store = ActiveCurrency::MemoryRateStore.new.tap do |store|
+    store.add_rate('USD', 'EUR', 0.5)
+    store.add_rate('EUR', 'USD', 1.5)
+  end
+  config.default_bank = Money::Bank::VariableExchange.new(rate_store)
+end
+```
+
 ## Contributing
 
 Please file issues and pull requests
@@ -72,10 +90,12 @@ Please file issues and pull requests
 In developemnt, launch specs and code linter by calling:
 
 ```sh
-bundle exec rake
+BUNDLE_GEMFILE=Gemfile-rails3.2 bundle exec rspec && bundle exec rake
 ```
 
 ## License
 
 The gem is available as open source under the terms of the
 [MIT License](http://opensource.org/licenses/MIT).
+
+[eu_central_bank]: https://github.com/RubyMoney/eu_central_bank

data/app/models/active_currency/rate.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module ActiveCurrency
-  class Rate < ApplicationRecord
+  class Rate < ActiveRecord::Base
     validates :from,
               :to,
               inclusion: { in: ->(_v) { Money.default_bank.store.currencies } },
@@ -10,8 +10,8 @@ module ActiveCurrency
 
     scope :before, ->(date) { where(arel_table[:created_at].lt(date)) }
 
-    def self.current_value_for(from, to, date = nil)
-      scope = date ? before(date) : all
+    def self.value_for(from, to, date = nil)
+      scope = date ? before(date) : all_scope
 
       scope
         .where(from: from, to: to)
@@ -19,5 +19,15 @@ module ActiveCurrency
         .last
         &.value
     end
+
+    # DEPRECATED
+    def self.current_value_for(from, to, date = nil)
+      value_for(from, to, date)
+    end
+
+    # Scope retrocompatibility for Rails 3.2.
+    def self.all_scope
+      respond_to?(:scoped) ? scoped : all
+    end
   end
 end

data/db/migrate/20180911202100_create_active_currency_rates.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class CreateActiveCurrencyRates < ActiveRecord::Migration[5.0]
+class CreateActiveCurrencyRates < ActiveCurrency::Migration
   def change
     create_table :active_currency_rates do |t|
       t.string :from

data/db/migrate/20180914064834_add_rates.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class AddRates < ActiveRecord::Migration[5.0]
+class AddRates < ActiveCurrency::Migration
   def up
     ActiveCurrency::AddRates.new.call
   end

data/lib/active_currency/database_store.rb

@@ -5,7 +5,7 @@ module ActiveCurrency
   # value.
   class DatabaseStore
     def get_rate(from, to, date = nil)
-      ActiveCurrency::Rate.current_value_for(from, to, date)
+      ActiveCurrency::Rate.value_for(from, to, date)
     end
 
     def add_rate(from, to, rate, date = nil)

data/lib/active_currency/memory_rate_store.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module ActiveCurrency
+  class MemoryRateStore < Money::RatesStore::Memory
+    def initialize(**)
+      @currencies = Set.new
+      super
+    end
+
+    def currencies
+      @currencies.to_a
+    end
+
+    def add_rate(from, to, value)
+      @currencies << from
+      @currencies << to
+      super
+    end
+  end
+end

data/lib/active_currency/migration.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+module ActiveCurrency
+  # Helps support previous version of Rails in migrations.
+  if Rails.version > '4.1'
+    class Migration < ActiveRecord::Migration[4.2]; end
+  else
+    class Migration < ActiveRecord::Migration; end
+  end
+end

data/lib/active_currency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveCurrency
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/lib/active_currency.rb

@@ -3,10 +3,12 @@
 require 'money-rails'
 require 'eu_central_bank'
 
+require 'active_currency/migration'
 require 'active_currency/engine'
 require 'active_currency/database_store'
 require 'active_currency/cacheable_store'
 require 'active_currency/rate_store'
+require 'active_currency/memory_rate_store'
 require 'active_currency/add_rates'
 
 module ActiveCurrency

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: active_currency
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Sunny Ripert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-14 00:00:00.000000000 Z
+date: 2018-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: money-rails
   requirement: !ruby/object:Gem::Requirement
@@ -131,8 +131,6 @@ extra_rdoc_files: []
 files:
 - MIT-LICENSE
 - README.md
-- Rakefile
-- app/models/active_currency/application_record.rb
 - app/models/active_currency/rate.rb
 - db/migrate/20180911202100_create_active_currency_rates.rb
 - db/migrate/20180914064834_add_rates.rb
@@ -141,6 +139,8 @@ files:
 - lib/active_currency/cacheable_store.rb
 - lib/active_currency/database_store.rb
 - lib/active_currency/engine.rb
+- lib/active_currency/memory_rate_store.rb
+- lib/active_currency/migration.rb
 - lib/active_currency/rate_store.rb
 - lib/active_currency/version.rb
 homepage: https://github.com/sunny/active_currency
@@ -163,7 +163,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: Rails plugin to store your currency regularly

data/Rakefile

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-begin
-  require 'bundler/setup'
-rescue LoadError
-  puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
-end
-
-require 'rdoc/task'
-
-RDoc::Task.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'ActiveCurrency'
-  rdoc.options << '--line-numbers'
-  rdoc.rdoc_files.include('README.md')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
-
-APP_RAKEFILE = File.expand_path('spec/dummy/Rakefile', __dir__)
-load 'rails/tasks/engine.rake'
-
-load 'rails/tasks/statistics.rake'
-
-require 'bundler/gem_tasks'
-
-begin
-  require 'rspec/core/rake_task'
-  RSpec::Core::RakeTask.new(:spec)
-rescue LoadError
-  puts 'RSpec load error'
-end
-
-require 'rubocop/rake_task'
-
-RuboCop::RakeTask.new
-
-task default: %i[spec rubocop]

data/app/models/active_currency/application_record.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-module ActiveCurrency
-  class ApplicationRecord < ActiveRecord::Base
-    self.abstract_class = true
-  end
-end