active_cmis 0.1.2 → 0.1.3

data/VERSION

@@ -1 +1 @@
-0.1.2
+0.1.3

data/lib/active_cmis/active_cmis.rb

@@ -1,8 +1,8 @@
 module ActiveCMIS
-  # Default logger: Outputs to STDOUT and has level set to DEBUG
+  # Default logger: no output
   # @return [Logger]
   def self.default_logger
-    @default_logger ||= Logger.new(STDOUT)
+    @default_logger ||= Logger.new(nil)
   end
 
   # Will search for a given configuration in a file, and return the equivalent Repository
@@ -41,7 +41,11 @@ module ActiveCMIS
       config = config[config_name]
       if config.is_a? Hash
         if config.has_key? "log_file"
-          logger = Logger.new(config["trace_file"])
+          trace_file = config["trace_file"]
+          if trace_file == "-"
+            trace_file = STDOUT
+          end
+          logger = Logger.new(trace_file)
         else
           logger = default_logger
         end

data/lib/active_cmis/internal/utils.rb

@@ -38,7 +38,11 @@ module ActiveCMIS
 
       # Returns id if id is already an object, object_by_id if id is a string, nil otherwise
       # @private
-      def self.string_or_id_to_object(id)
+      def self.string_or_id_to_object(repository, id)
+        # FIXME: only used in lib/activecmis/relationship.rb, the repository parameter
+        # would be unnecessary if included.
+        # Should this be a generic method, or should this be moved to the Relationship class?
+        # Or should I start including this module in every place that needs it?
         case id
         when String; repository.object_by_id(id)
         when ::ActiveCMIS::Object; id

data/lib/active_cmis/property_definition.rb

@@ -53,7 +53,7 @@ module ActiveCMIS
 
       if required && updatability == "readonly"
         logger.warn "The server behaved strange: attribute #{self.inspect} required but readonly, will set required to false"
-        required = false
+        @required = false
       end
 
       @property_type = case property_type.downcase

data/lib/active_cmis/relationship.rb

@@ -2,13 +2,13 @@ module ActiveCMIS
   class Relationship < ::ActiveCMIS::Object
     # @return [Object]
     def source
-      Internal::Utils.string_or_id_to_object(attribute("cmis:sourceId"))
+      Internal::Utils.string_or_id_to_object(repository, attribute("cmis:sourceId"))
     end
     cache :source
 
     # @return [Object]
     def target
-      Internal::Utils.string_or_id_to_object(attribute("cmis:targetId"))
+      Internal::Utils.string_or_id_to_object(repository, attribute("cmis:targetId"))
     end
     cache :target
 
@@ -25,10 +25,12 @@ module ActiveCMIS
       super
       # Potentially necessary if repositories support it
       # Probably not though
-      if source = updates["cmis:sourceId"]
+
+      # Note: we use remove_instance_variable because of the way I implemented the caching
+      if updates["cmis:sourceId"] && instance_variable_defined?("@source")
         remove_instance_variable "@source"
       end
-      if updates["cmis:targetId"]
+      if updates["cmis:targetId"] && instance_variable_defined?("@target")
         remove_instance_variable "@target"
       end
     end

data/lib/active_cmis/rendition.rb

@@ -46,12 +46,12 @@ module ActiveCMIS
         response = repository.conn.get_response(@url)
         status = response.code.to_i
         if 200 <= status && status < 300
-          data = response.body 
+          data = response.body
         else
           raise HTTPError.new("Problem downloading rendition: status: #{status}, message: #{response.body}")
         end
         content_type = response.content_type
-        content_lenth = response.content_length || response.body.length # In case content encoding is chunked? ??
+        content_length = response.content_length || response.body.length # In case content encoding is chunked? ??
       else
         data = @data
         content_type = @format

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: active_cmis
 version: !ruby/object:Gem::Version 
-  version: 0.1.2
+  prerelease: false
+  segments: 
+  - 0
+  - 1
+  - 3
+  version: 0.1.3
 platform: ruby
 authors: 
 - Joeri Samson
@@ -9,19 +14,23 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-12 00:00:00 +02:00
+date: 2010-10-20 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: nokogiri
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 1
+        - 4
+        - 1
         version: 1.4.1
-    version: 
+  type: :runtime
+  version_requirements: *id001
 description: A CMIS library implementing both reading and updating capabilities through the AtomPub/REST binding to CMIS.
 email: joeri@xaop.com
 executables: []
@@ -75,18 +84,22 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 1
+      - 8
+      - 6
       version: 1.8.6
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: A library to interact with CMIS repositories through the AtomPub/REST binding