active_campaign 0.1.13 → 0.1.14

data/spec/cassettes/ActiveCampaign_Client_Lists/_list_add/add_a_list.yml

@@ -0,0 +1,48 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: "<API_ENDPOINT>?api_action=list_add&api_key=<API_KEY>&api_output=json"
+    body:
+      encoding: UTF-8
+      string: carboncopy=mikael%40zoolutions.se&get_unsubscribe_reason=1&name=Swedish+Players&p_use_captcha=0&private=0&require_name=1&send_last_broadcast=1&sender_addr1=%25C3%2596sterv%25C3%25A5ngsplan%252015&sender_city=Landskrona&sender_country=Sweden&sender_name=Zoolutions%2520AB&sender_zip=26144&stringid=swedish-players&subscription_notify=mikael%40zoolutions.se&to_name=Recipient&unsubscription_notify=mikael%40zoolutions.se
+    headers:
+      User-Agent:
+      - ActiveCampaign Ruby Gem 0.1.13
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      X-Powered-By:
+      - PHP/5.3.3
+      Set-Cookie:
+      - PHPSESSID=5b0o8l8b4jqn8sr51ahnngdbi2; path=/
+      - em_acp_globalauth_cookie=c6ead9798fb11b728939168ee2d579611; path=/; domain=zoolutions.api-us1.com;
+        secure
+      - em_acp_globalauth_cookie=deleted; expires=Wed, 12-Aug-2015 08:19:05 GMT; path=/;
+        domain=zoolutions.api-us1.com
+      Expires:
+      - Thu, 19 Nov 1981 08:52:00 GMT
+      Pragma:
+      - no-cache
+      Content-Type:
+      - application/json; charset=utf-8
+      Cache-Control:
+      - no-store, max-age=0, must-revalidate
+      Transfer-Encoding:
+      - chunked
+      Date:
+      - Thu, 11 Aug 2016 08:19:06 GMT
+      Server:
+      - lighttpd/1.4.37
+    body:
+      encoding: UTF-8
+      string: '{"id":11,"result_code":1,"result_message":"List added","result_output":"json"}'
+    http_version: 
+  recorded_at: Thu, 11 Aug 2016 08:19:06 GMT
+recorded_with: VCR 3.0.3

data/spec/cassettes/ActiveCampaign_Client_Lists/_list_list/can_find_a_list_of_lists.yml

@@ -0,0 +1,106 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: "<API_ENDPOINT>/?api_action=list_list&api_key=<API_KEY>&api_output=json&ids=all"
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - ActiveCampaign Ruby Gem 0.1.13
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 302
+      message: Found
+    headers:
+      X-Powered-By:
+      - PHP/5.3.3
+      Set-Cookie:
+      - PHPSESSID=8ev4eknm8r6s20s6obihjcbac3; path=/
+      - em_acp_globalauth_cookie=deleted; expires=Wed, 12-Aug-2015 07:54:06 GMT; path=/;
+        domain=zoolutions.api-us1.com
+      Expires:
+      - Thu, 19 Nov 1981 08:52:00 GMT
+      Cache-Control:
+      - no-store, no-cache, must-revalidate, post-check=0, pre-check=0
+      Pragma:
+      - no-cache
+      Location:
+      - http://zoolutions.activehosted.com
+      Vary:
+      - Accept-Encoding
+      Content-Type:
+      - text/html
+      Transfer-Encoding:
+      - chunked
+      Date:
+      - Thu, 11 Aug 2016 07:54:07 GMT
+      Server:
+      - lighttpd/1.4.37
+    body:
+      encoding: ASCII-8BIT
+      string: ''
+    http_version: 
+  recorded_at: Thu, 11 Aug 2016 07:54:07 GMT
+- request:
+    method: get
+    uri: "<API_ENDPOINT>?api_action=list_list&api_key=<API_KEY>&api_output=json&ids=all"
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - ActiveCampaign Ruby Gem 0.1.13
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      X-Powered-By:
+      - PHP/5.3.3
+      Set-Cookie:
+      - PHPSESSID=mtidul4kr8djuf59uecffi0tg0; path=/
+      - em_acp_globalauth_cookie=c6ead9798fb11b728939168ee2d579611; path=/; domain=zoolutions.api-us1.com;
+        secure
+      - em_acp_globalauth_cookie=deleted; expires=Wed, 12-Aug-2015 08:19:06 GMT; path=/;
+        domain=zoolutions.api-us1.com
+      Expires:
+      - Thu, 19 Nov 1981 08:52:00 GMT
+      Pragma:
+      - no-cache
+      Content-Type:
+      - application/json; charset=utf-8
+      Cache-Control:
+      - no-store, max-age=0, must-revalidate
+      Transfer-Encoding:
+      - chunked
+      Date:
+      - Thu, 11 Aug 2016 08:19:07 GMT
+      Server:
+      - lighttpd/1.4.37
+    body:
+      encoding: UTF-8
+      string: '{"0":{"id":"1","name":"Swedish Players","cdate":"2016-08-11 10:02:18","private":"0","userid":"1","subscriber_count":1},"1":{"id":"2","name":"Swedish
+        Players","cdate":"2016-08-11 10:04:00","private":"1","userid":"1","subscriber_count":0},"2":{"id":"3","name":"Swedish
+        Players","cdate":"2016-08-11 10:08:42","private":"1","userid":"1","subscriber_count":0},"3":{"id":"4","name":"Swedish
+        Players","cdate":"2016-08-11 10:08:58","private":"1","userid":"1","subscriber_count":0},"4":{"id":"5","name":"Swedish
+        Players","cdate":"2016-08-11 10:13:21","private":"1","userid":"1","subscriber_count":0},"5":{"id":"6","name":"Swedish
+        Players","cdate":"2016-08-11 10:14:51","private":"1","userid":"1","subscriber_count":0},"6":{"id":"7","name":"Swedish
+        Players","cdate":"2016-08-11 10:15:32","private":"1","userid":"1","subscriber_count":1},"7":{"id":"8","name":"Swedish
+        Players","cdate":"2016-08-11 10:17:26","private":"1","userid":"1","subscriber_count":0},"8":{"id":"9","name":"Swedish
+        Players","cdate":"2016-08-11 10:17:58","private":"1","userid":"1","subscriber_count":0},"9":{"id":"10","name":"Swedish
+        Players","cdate":"2016-08-11 10:18:21","private":"1","userid":"1","subscriber_count":0},"10":{"id":"11","name":"Swedish
+        Players","cdate":"2016-08-11 10:19:06","private":"1","userid":"1","subscriber_count":0},"result_code":1,"result_message":"Success:
+        Something is returned","result_output":"json"}'
+    http_version: 
+  recorded_at: Thu, 11 Aug 2016 08:19:07 GMT
+recorded_with: VCR 3.0.3

data/spec/cassettes/ActiveCampaign_Client_Lists/_list_view/can_find_lists_by_id.yml

@@ -0,0 +1,102 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: "<API_ENDPOINT>/?api_action=list_view&api_key=<API_KEY>&api_output=json&id=1"
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - ActiveCampaign Ruby Gem 0.1.13
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 302
+      message: Found
+    headers:
+      X-Powered-By:
+      - PHP/5.3.3
+      Set-Cookie:
+      - PHPSESSID=n4r7a65tfahaitchoc2opqo3j3; path=/
+      - em_acp_globalauth_cookie=deleted; expires=Wed, 12-Aug-2015 07:54:07 GMT; path=/;
+        domain=zoolutions.api-us1.com
+      Expires:
+      - Thu, 19 Nov 1981 08:52:00 GMT
+      Cache-Control:
+      - no-store, no-cache, must-revalidate, post-check=0, pre-check=0
+      Pragma:
+      - no-cache
+      Location:
+      - http://zoolutions.activehosted.com
+      Vary:
+      - Accept-Encoding
+      Content-Type:
+      - text/html
+      Transfer-Encoding:
+      - chunked
+      Date:
+      - Thu, 11 Aug 2016 07:54:08 GMT
+      Server:
+      - lighttpd/1.4.37
+    body:
+      encoding: ASCII-8BIT
+      string: ''
+    http_version: 
+  recorded_at: Thu, 11 Aug 2016 07:54:08 GMT
+- request:
+    method: get
+    uri: "<API_ENDPOINT>?api_action=list_view&api_key=<API_KEY>&api_output=json&id=1"
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - ActiveCampaign Ruby Gem 0.1.13
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      X-Powered-By:
+      - PHP/5.3.3
+      Set-Cookie:
+      - PHPSESSID=kkjvn5o5597m11scubeb74igg4; path=/
+      - em_acp_globalauth_cookie=c6ead9798fb11b728939168ee2d579611; path=/; domain=zoolutions.api-us1.com;
+        secure
+      - em_acp_globalauth_cookie=deleted; expires=Wed, 12-Aug-2015 08:19:03 GMT; path=/;
+        domain=zoolutions.api-us1.com
+      Expires:
+      - Thu, 19 Nov 1981 08:52:00 GMT
+      Pragma:
+      - no-cache
+      Content-Type:
+      - application/json; charset=utf-8
+      Cache-Control:
+      - no-store, max-age=0, must-revalidate
+      Transfer-Encoding:
+      - chunked
+      Date:
+      - Thu, 11 Aug 2016 08:19:04 GMT
+      Server:
+      - lighttpd/1.4.37
+    body:
+      encoding: UTF-8
+      string: '{"id":"1","stringid":"swedish-players","userid":"1","name":"Swedish
+        Players","cdate":"2016-08-11 10:02:18","p_use_tracking":"1","p_use_analytics_read":"0","p_use_analytics_link":"0","p_use_twitter":"0","p_use_facebook":"0","p_embed_image":"1","p_use_captcha":"1","send_last_broadcast":"0","private":"0","analytics_domains":null,"analytics_source":"","analytics_ua":"","twitter_token":"","twitter_token_secret":"","facebook_session":"","carboncopy":"mikael@zoolutions.se","subscription_notify":"mikael@zoolutions.se","unsubscription_notify":"mikael@zoolutions.se","require_name":"0","get_unsubscribe_reason":"0","to_name":"Subscriber","optinoptout":"1","sender_name":"Zoolutions%20AB","sender_addr1":"%C3%96sterv%C3%A5ngsplan%2015","sender_addr2":"","sender_city":"Landskrona","sender_state":"","sender_zip":"26144","sender_country":"SE","sender_phone":"","sender_url":"","sender_reminder":"","fulladdress":"Zoolutions%20AB,
+        %C3%96sterv%C3%A5ngsplan%2015, Landskrona 26144, Sweden","optinmessageid":"0","optoutconf":"0","deletestamp":null,"listid":"1","p_admin":"1","p_list_add":"1","p_list_edit":"1","p_list_delete":"1","p_list_sync":"1","p_list_filter":"1","p_message_add":"1","p_message_edit":"1","p_message_delete":"1","p_message_send":"1","p_subscriber_add":"1","p_subscriber_edit":"1","p_subscriber_delete":"1","p_subscriber_import":"1","p_subscriber_approve":"1","luserid":"1","subscribers":"1","subscribers_active":"1","fields":[],"groups":{"3":{"id":"3","title":"Admin","descript":"This
+        is a group for admin users (people that can manage content)","unsubscribelink":"0","optinconfirm":"0","p_admin":"1","pg_list_add":"1","pg_list_edit":"1","pg_list_delete":"1","pg_list_headers":"1","pg_list_emailaccount":"1","pg_list_bounce":"1","pg_message_add":"1","pg_message_edit":"1","pg_message_delete":"1","pg_message_send":"1","pg_subscriber_add":"1","pg_subscriber_edit":"1","pg_subscriber_delete":"1","pg_subscriber_import":"1","pg_subscriber_approve":"1","pg_subscriber_export":"1","pg_subscriber_sync":"1","pg_subscriber_filters":"1","pg_subscriber_actions":"0","pg_subscriber_fields":"1","pg_user_add":"1","pg_user_edit":"1","pg_user_delete":"1","pg_group_add":"1","pg_group_edit":"1","pg_group_delete":"1","pg_template_add":"1","pg_template_edit":"1","pg_template_delete":"1","pg_personalization_add":"1","pg_personalization_edit":"1","pg_personalization_delete":"1","pg_form_edit":"1","pg_reports_campaign":"1","pg_reports_list":"1","pg_reports_user":"1","pg_reports_trend":"1","pg_startup_reports":"1","pg_startup_gettingstarted":"1","sdate":"2016-08-10
+        20:15:54","req_approval":"0","req_approval_1st":"2","req_approval_notify":"","socialdata":"0","listid":"1","groupid":"3","p_list_add":"0","p_list_edit":"0","p_list_delete":"0","p_list_sync":"1","p_list_filter":"1","p_message_add":"1","p_message_edit":"1","p_message_delete":"1","p_message_send":"1","p_subscriber_add":"1","p_subscriber_edit":"1","p_subscriber_delete":"1","p_subscriber_import":"1","p_subscriber_approve":"1"},"1":{"id":"1","title":"Visitor","descript":"This
+        is a group for site visitors (people that are not logged in)","unsubscribelink":"0","optinconfirm":"0","p_admin":"0","pg_list_add":"0","pg_list_edit":"0","pg_list_delete":"0","pg_list_headers":"0","pg_list_emailaccount":"0","pg_list_bounce":"0","pg_message_add":"0","pg_message_edit":"0","pg_message_delete":"0","pg_message_send":"0","pg_subscriber_add":"0","pg_subscriber_edit":"0","pg_subscriber_delete":"0","pg_subscriber_import":"0","pg_subscriber_approve":"0","pg_subscriber_export":"0","pg_subscriber_sync":"0","pg_subscriber_filters":"0","pg_subscriber_actions":"0","pg_subscriber_fields":"0","pg_user_add":"0","pg_user_edit":"0","pg_user_delete":"0","pg_group_add":"0","pg_group_edit":"0","pg_group_delete":"0","pg_template_add":"0","pg_template_edit":"0","pg_template_delete":"0","pg_personalization_add":"0","pg_personalization_edit":"0","pg_personalization_delete":"0","pg_form_edit":"0","pg_reports_campaign":"0","pg_reports_list":"0","pg_reports_user":"0","pg_reports_trend":"0","pg_startup_reports":"0","pg_startup_gettingstarted":"0","sdate":"2016-08-10
+        20:15:54","req_approval":"0","req_approval_1st":"2","req_approval_notify":"","socialdata":"0","listid":"1","groupid":"1","p_list_add":"0","p_list_edit":"0","p_list_delete":"0","p_list_sync":"0","p_list_filter":"0","p_message_add":"0","p_message_edit":"0","p_message_delete":"0","p_message_send":"0","p_subscriber_add":"0","p_subscriber_edit":"0","p_subscriber_delete":"0","p_subscriber_import":"0","p_subscriber_approve":"0"}},"groupsCnt":2,"bounces":[{"id":"1","userid":"1","type":"pipe","email":"bounce-289042@s11.avl3.acemsrvc.com","host":null,"port":"110","user":null,"pass":null,"method":"","limit_hard":"1","limit_soft":"3","emails_per_batch":"120"}],"analytics_domains_list":[],"facebook_oauth_logout_url":"","facebook_oauth_login_url":"https:\/\/www.facebook.com\/v2.6\/dialog\/oauth?client_id=118506481555093&redirect_uri=https%3A%2F%2Fzoolutions.api-us1.com%2Fadmin%2Fmain.php%3Faction%3Dlist%26formid%3D1&scope=publish_actions,manage_pages","facebook_oauth_me":null,"result_code":1,"result_message":"Success:
+        Something is returned","result_output":"json"}'
+    http_version: 
+  recorded_at: Thu, 11 Aug 2016 08:19:05 GMT
+recorded_with: VCR 3.0.3

data/spec/lib/active_campaign/client/contacts_spec.rb

@@ -11,7 +11,7 @@ describe ActiveCampaign::Client::Contacts, :vcr do
       'email' => 'mhenrixon@me.com',
       'first_name' => 'Mikael',
       'last_name' => 'Henriksson',
-      'p' => { 1 => 1 },
+      'p' => { 1 => 7 },
       'status' => { 1 => 1 },
       'instantresponders' => { 1 => 1 },
       'ip4' => '127.0.0.1'
@@ -23,18 +23,28 @@ describe ActiveCampaign::Client::Contacts, :vcr do
       subject(:response) { @client.contact_sync params }
 
       it 'returns 1 for result_code' do
-        expect(response.result_code).to eq 1
+        expect(response['result_code']).to eq 1
+      end
+    end
+  end
+
+  describe '.contact_add' do
+    context 'when successful' do
+      subject(:response) { @client.contact_add params }
+
+      it 'returns 1 for result_code' do
+        expect(response['result_code']).to eq 1
       end
     end
   end
 
   describe '.contact_view' do
-    let(:subscriber_id) { @client.contact_sync(params).subscriber_id }
+    let(:subscriber_id) { @client.contact_sync(params)['subscriber_id'] }
 
     it 'can find contact by id' do
       contact = @client.contact_view id: subscriber_id
-      expect(contact.first_name).to eq 'Mikael'
-      expect(contact.last_name).to eq 'Henriksson'
+      expect(contact['first_name']).to eq 'Mikael'
+      expect(contact['last_name']).to eq 'Henriksson'
     end
   end
 end

data/spec/lib/active_campaign/client/lists_spec.rb

@@ -4,35 +4,43 @@ require 'spec_helper'
 describe ActiveCampaign::Client::Lists, :vcr do
   initialize_new_client
 
-  # it "add a list", :vcr do
-  #   params = {
-  #     "id"        => 1,
-  #     "email"     => 'mhenrixon@me.com',
-  #     "name"=> 'Mikael',
-  #     "last_name" => 'Henriksson',
-  #     "p[1]"      => 1,
-  #     "status[1]" => 1,
-  #     "instantresponders[1]" => 1,
-  #     "field[%BALANCE%,0]"   => 100,
-  #     "ip4"       => '127.0.0.1',
-  #     "status[2]" => 2,
-  #     "listid"    => 1
-  #   }.stringify_keys
+  describe '.list_add' do
+    it 'add a list' do
+      params = {
+        'name' => 'Swedish Players',
+        'stringid' => 'swedish-players',
+        'subscription_notify' => 'mikael@zoolutions.se',
+        'unsubscription_notify' => 'mikael@zoolutions.se',
+        'to_name' => 'Recipient',
+        'carboncopy' => 'mikael@zoolutions.se',
+        'sender_name' => 'Zoolutions%20AB',
+        'sender_addr1' => '%C3%96sterv%C3%A5ngsplan%2015',
+        'sender_city' => 'Landskrona',
+        'sender_zip' => '26144',
+        'sender_country' => 'Sweden',
+        'p_use_captcha' => 0,
+        'get_unsubscribe_reason' => 1,
+        'send_last_broadcast' => 1,
+        'require_name' => 1,
+        'private' => 0
+      }
 
-  #   list = ActiveCampaign.list_add params
-  # end
+      list = @client.list_add params
+      expect(list['id']).to be_a(Integer)
+    end
+  end
 
   describe '.list_view' do
     it 'can find lists by id' do
       list = @client.list_view id: 1
-      expect(list.name).to eq 'players_sv'
+      expect(list['name']).to eq 'Swedish Players'
     end
   end
 
   describe '.list_list' do
     it 'can find a list of lists' do
       lists = @client.list_list 'ids' => 'all'
-      expect(lists.results[0].name).to eq 'players_sv'
+      expect(lists['results'][0]['name']).to eq 'Swedish Players'
     end
   end
 end

data/spec/lib/active_campaign/client_spec.rb

@@ -2,6 +2,5 @@ require 'spec_helper'
 
 module ActiveCampaign
   describe Client do
-
   end
 end

data/spec/lib/active_campaign_spec.rb

@@ -50,11 +50,11 @@ describe ActiveCampaign do
 
   describe '.configure' do
     ActiveCampaign.config.to_h.keys.each do |key|
-      it "sets the #{key.to_s.gsub('_', ' ')}" do
+      it "sets the #{key.to_s.tr('_', ' ')}" do
         ActiveCampaign.configure do |config|
           config.send("#{key}=", key)
         end
-        expect(ActiveCampaign.configuration[key]).to eq key
+        expect(ActiveCampaign.config.send(key)).to eq key
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,8 +1,13 @@
-require_relative 'support/coverage'
+require 'simplecov'
 
 require 'pry'
 require 'rspec'
 require 'active_campaign'
+require_relative 'support/webmock'
+require_relative 'support/vcr'
+
+TEST_API_ENDPOINT ||= 'https://zoolutions.api-us1.com/admin/api.php'.freeze
+TEST_API_KEY ||= '1b85f597c38b74fc842a04efe00f10d547a839487dcb05e2c639e92c450d53a366d96f84'.freeze
 
 RSpec.configure do |config|
   config.filter_run focus: true
@@ -13,29 +18,22 @@ RSpec.configure do |config|
   end
 
   config.before(:suite) do
-    HTTPI.log = false
+    HTTPI.log       = false
+    HTTPI.logger    = nil
     HTTPI.log_level = :fatal
   end
 end
 
-def test_api_endpoint
-  ENV.fetch 'ACTIVE_CAMPAIGN_API_ENDPOINT'
-end
-
-def test_api_key
-  ENV.fetch 'ACTIVE_CAMPAIGN_API_KEY'
-end
-
-def initialize_new_client
+def initialize_new_client # rubocop:disable MethodLength
   before do
     @client = ActiveCampaign::Client.new(
-      api_endpoint: test_api_endpoint,
-      api_key: test_api_key,
+      api_endpoint: TEST_API_ENDPOINT,
+      api_key: TEST_API_KEY,
       api_output: 'json',
       debug: false,
       log_level: :fatal,
       log: false,
-      mash: true
+      mash: false
     )
   end
 end

data/spec/support/coverage.rb

@@ -1,9 +1,13 @@
-require 'simplecov'
+require 'simplecov-json'
 require 'coveralls'
 Coveralls.wear!
 
 require 'codeclimate-test-reporter'
-formatters =  [SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter]
+formatters = [
+  SimpleCov::Formatter::HTMLFormatter,
+  SimpleCov::Formatter::JSONFormatter,
+  Coveralls::SimpleCov::Formatter
+]
 
 if ENV['CODECLIMATE_REPO_TOKEN']
   formatters << CodeClimate::TestReporter::Formatter