active_call 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e129c0113e02eef8e739a830213f343eddb585c6798f4237f127256b1a5ac419
-  data.tar.gz: 550cdfc7e5285f9dc353003eb570fc89ae1d36d54025af035ab2a4751b61658a
+  metadata.gz: 31e782b9a67b967ad37abe80818b43aa445517aa99a4830e2ec158c67404922e
+  data.tar.gz: 587d98f44af3c0a36198ffb76367bf30f0b8eb22b342d0d3d361c452452faf7a
 SHA512:
-  metadata.gz: 91d837ea7bead55372e4eaf777f84f35ac4ad3a9183633e9bc9042d14cdf26ae02c425a30391ff4dc85116d66d38edb62202fa114c5657c9c5bee60fa02bde83
-  data.tar.gz: 4025432ebc6ef1dbf2cbe5129b4e235808ab91ded26d192c04b7253bca008423e6d054808e3f774421e86bc42465e005ee0e4bfd26241ab19e685fc6ffc219d2
+  metadata.gz: 4354d1137d8dfc1dae8570ccc6fb1324f2999d9b099c3f2a0e1da1fe4b93aa99b39692029d6169263736772e8eadce59376f0cd25d9812da38080f7309d06502
+  data.tar.gz: a2875e4fd4b26027584f4c830befb94ea9dc799fbc70aacbe791d44a39fa679ff56817a22c25fa5816bb715a1d6555f9717332026410a6e1af3c66f7ae1282da

data/.rubocop.yml

@@ -18,10 +18,17 @@ AllCops:
 Layout/LineEndStringConcatenationIndentation:
   EnforcedStyle: indented
 
+Layout/LineLength:
+  AllowedPatterns:
+    - '#'
+
 Lint/MissingSuper:
   AllowedParentClasses:
     - ActiveCall::Base
 
+Metrics/AbcSize:
+  Enabled: false
+
 Metrics/BlockLength:
   Exclude:
     - spec/*/**.rb

data/CHANGELOG.md

@@ -1,8 +1,14 @@
-## [Unreleased]
+## [0.3.0] - 2025-03-31
+
+- Added `validate on: :request` which runs after `before_call` and before invoking `call`'.
+
+## [0.2.1] - 2025-03-25
+
+- Gemspec `changelog_uri` fixed.
 
 ## [0.2.0] - 2025-03-20
 
-- Added method `.call!` with a bang, which will raise an `ActiveCall::ValidationError` exception when validation fails and an `ActiveCall::RequestError` exception when errors were added to the service object in the `after_call` callback.
+- Added method `.call!` with a bang, which will raise an `ActiveCall::ValidationError` exception when validation fails and an `ActiveCall::RequestError` exception when errors were added to the service object in the `validate on: :response` block.
 - Use new method `success?` instead of `valid?`.
 - Method `valid?` will return `true` if the service object passed validation and was able to make the `call` method.
 - Use `validate, on: :response` to validate the response object.

data/README.md

@@ -1,5 +1,7 @@
 # Active Call
 
+[![Gem Version](https://badge.fury.io/rb/active_call.svg?icon=si%3Arubygems)](https://badge.fury.io/rb/active_call)
+
 Active Call provides a standardized way to create service objects.
 
 ## Installation
@@ -28,17 +30,19 @@ Each service object must define only one public method named `call`.
 
 1. **Before** invoking `call`.
 
-  - Validate the request with `validates`.
+  - Validate the service with `validates`.
 
   - Use the `before_call` hook to set up anything **after validation** passes.
 
+  - Validate the request with `validate on: :request`.
+
 2. **During** `call` invocation.
 
   - A `response` attribute gets set with the result of the `call` method.
 
 3. **After** invoking `call`.
 
-  - Validate the response with `validate, on: :response`.
+  - Validate the response with `validate on: :response`.
 
   - Use the `after_call` hook to set up anything **after response validation** passes.
 
@@ -49,16 +53,20 @@ Define a service object with optional validations and callbacks.
 ```ruby
 require 'active_call'
 
-class YourGemName::SomeResource::CreateService < ActiveCall::Base
-  attr_reader :message
+class YourGem::SomeResource::CreateService < ActiveCall::Base
+  attr_reader :message, :another_service
 
   validates :message, presence: true
 
+  validate on: :request do
+    errors.merge!(another_service.errors) unless another_service.success?
+  end
+
   validate on: :response do
     errors.add(:message, :invalid, message: 'cannot be baz') if response[:foo] == 'baz'
   end
 
-  before_call :strip_message
+  before_call :call_another_service, :strip_message
 
   after_call :log_response
 
@@ -72,6 +80,10 @@ class YourGemName::SomeResource::CreateService < ActiveCall::Base
 
   private
 
+  def call_another_service
+    @another_service = YourGem::SomeResource::GetService.call(id: '1')
+  end
+
   def strip_message
     @message.strip!
   end
@@ -82,12 +94,12 @@ class YourGemName::SomeResource::CreateService < ActiveCall::Base
 end
 ```
 
-### Using `.call`
+### Using `call`
 
 You will get an **errors** object when validation fails.
 
 ```ruby
-service = YourGemName::SomeResource::CreateService.call(message: '')
+service = YourGem::SomeResource::CreateService.call(message: '')
 service.success? # => false
 service.errors # => #<ActiveModel::Errors [#<ActiveModel::Error attribute=message, type=blank, options={}>]>
 service.errors.full_messages # => ["Message can't be blank"]
@@ -97,7 +109,7 @@ service.response # => nil
 A **response** object on a successful `call` invocation.
 
 ```ruby
-service = YourGemName::SomeResource::CreateService.call(message: ' bar ')
+service = YourGem::SomeResource::CreateService.call(message: ' bar ')
 service.success? # => true
 service.response # => {:foo=>"bar"}
 ```
@@ -105,20 +117,20 @@ service.response # => {:foo=>"bar"}
 And an **errors** object if you added errors during the `validate, on: :response` validation.
 
 ```ruby
-service = YourGemName::SomeResource::CreateService.call(message: 'baz')
+service = YourGem::SomeResource::CreateService.call(message: 'baz')
 service.success? # => false
 service.errors # => #<ActiveModel::Errors [#<ActiveModel::Error attribute=message, type=invalid, options={:message=>"cannot be baz"}>]>
 service.errors.full_messages # => ["Message cannot be baz"]
 service.response # => {:foo=>"baz"}
 ```
 
-### Using `.call!`
+### Using `call!`
 
 An `ActiveCall::ValidationError` **exception** gets raised when validation fails.
 
 ```ruby
 begin
-  service = YourGemName::SomeResource::CreateService.call!(message: '')
+  service = YourGem::SomeResource::CreateService.call!(message: '')
 rescue ActiveCall::ValidationError => exception
   exception.errors # => #<ActiveModel::Errors [#<ActiveModel::Error attribute=message, type=blank, options={}>]>
   exception.errors.full_messages # => ["Message can't be blank"]
@@ -128,7 +140,7 @@ end
 A **response** object on a successful `call` invocation.
 
 ```ruby
-service = YourGemName::SomeResource::CreateService.call!(message: ' bar ')
+service = YourGem::SomeResource::CreateService.call!(message: ' bar ')
 service.success? # => true
 service.response # => {:foo=>"bar"}
 ```
@@ -137,7 +149,7 @@ And an `ActiveCall::RequestError` **exception** gets raised if you added errors
 
 ```ruby
 begin
-  service = YourGemName::SomeResource::CreateService.call!(message: 'baz')
+  service = YourGem::SomeResource::CreateService.call!(message: 'baz')
 rescue ActiveCall::RequestError => exception
   exception.errors # => #<ActiveModel::Errors [#<ActiveModel::Error attribute=message, type=invalid, options={:message=>"cannot be baz"}>]>
   exception.errors.full_messages # => ["Message cannot be baz"]
@@ -150,17 +162,17 @@ end
 If you have secrets, use a **configuration** block.
 
 ```ruby
-class YourGemName::BaseService < ActiveCall::Base
+class YourGem::BaseService < ActiveCall::Base
   self.abstract_class = true
 
   config_accessor :api_key, default: ENV['API_KEY'], instance_writer: false
 end
 ```
 
-Then in your application code you can overwite the configuration defaults.
+Then in your application code you can override the configuration defaults.
 
 ```ruby
-YourGemName::BaseService.configure do |config|
+YourGem::BaseService.configure do |config|
   config.api_key = Rails.application.credentials.api_key || ENV['API_KEY']
 end
 ```
@@ -170,7 +182,7 @@ And implement a service object like so.
 ```ruby
 require 'net/http'
 
-class YourGemName::SomeResource::CreateService < YourGemName::BaseService
+class YourGem::SomeResource::CreateService < YourGem::BaseService
   def call
     Net::HTTP.get_response(URI("http://example.com/api?#{URI.encode_www_form(api_key: api_key)}"))
   end
@@ -199,9 +211,14 @@ spec.add_dependency 'active_call'
 
 Now start adding your service objects in the `lib` directory and make sure they inherit from `ActiveCall::Base`.
 
+## Active Call Extensions
+
+- [Active Call - API](https://rubygems.org/gems/active_call-api)
+
 ## Gems Using Active Call
 
-- [Zoho Sign](https://github.com/kobusjoubert/zoho_sign)
+- [Active Call - nCino KYC DocFox](https://rubygems.org/gems/active_call-doc_fox)
+- [Active Call - Zoho Sign](https://rubygems.org/gems/active_call-zoho_sign)
 
 ## Development
 

data/lib/active_call/base.rb

@@ -14,13 +14,13 @@ class ActiveCall::Base
     # Abstract classes are not meant to be instantiated directly, but rather inherited from.
     # The `call` method doesn't need to be implemented in abstract classes.
     #
-    # Example:
+    # ==== Examples
     #
-    #   class YourGemName::BaseService < ActiveCall::Base
+    #   class YourGem::BaseService < ActiveCall::Base
     #     self.abstract_class = true
     #   end
     #
-    #   class YourGemName::SomeResource::CreateService < YourGemName::BaseService
+    #   class YourGem::SomeResource::CreateService < YourGem::BaseService
     #     def call
     #       # Implementation specific to this service.
     #     end
@@ -32,32 +32,97 @@ class ActiveCall::Base
       @abstract_class == true
     end
 
-    # TODO: Refactor `call` and `call!`. The only differences are the two lines raising exceptions.
+    # TODO: Refactor `call` and `call!`. The only differences are the lines raising exceptions.
+
+    # Using `call`
+    #
+    # ==== Examples
+    #
+    # You will get an `errors` object when validation fails.
+    #
+    #   service = YourGem::SomeResource::CreateService.call(message: '')
+    #   service.success? # => false
+    #   service.errors # => #<ActiveModel::Errors [#<ActiveModel::Error attribute=message, type=blank, options={}>]>
+    #   service.errors.full_messages # => ["Message can't be blank"]
+    #   service.response # => nil
+    #
+    # A `response` object on a successful `call` invocation.
+    #
+    #   service = YourGem::SomeResource::CreateService.call(message: ' bar ')
+    #   service.success? # => true
+    #   service.response # => {:foo=>"bar"}
+    #
+    # And an `errors` object if you added errors during the `validate, on: :response` validation.
+    #
+    #   service = YourGem::SomeResource::CreateService.call(message: 'baz')
+    #   service.success? # => false
+    #   service.errors # => #<ActiveModel::Errors [#<ActiveModel::Error attribute=message, type=invalid, options={:message=>"cannot be baz"}>]>
+    #   service.errors.full_messages # => ["Message cannot be baz"]
+    #   service.response # => {:foo=>"baz"}
+    #
     def call(...)
       service_object = new(...)
       service_object.instance_variable_set(:@bang, false)
-      return service_object if service_object.invalid?(except_on: :response)
+      return service_object if service_object.invalid?(except_on: [:request, :response])
 
       service_object.run_callbacks(:call) do
         next if service_object.is_a?(Enumerable)
 
+        service_object.validate(:request)
+        return service_object unless service_object.success?
+
         service_object.instance_variable_set(:@response, service_object.call)
         service_object.validate(:response)
-
         return service_object unless service_object.success?
       end
 
       service_object
     end
 
+    # Using `call!`
+    #
+    # ==== Examples
+    #
+    # An `ActiveCall::ValidationError` exception gets raised when validation fails.
+    #
+    #   begin
+    #     service = YourGem::SomeResource::CreateService.call!(message: '')
+    #   rescue ActiveCall::ValidationError => exception
+    #     exception.errors # => #<ActiveModel::Errors [#<ActiveModel::Error attribute=message, type=blank, options={}>]>
+    #     exception.errors.full_messages # => ["Message can't be blank"]
+    #   end
+    #
+    # A `response` object on a successful `call` invocation.
+    #
+    #   service = YourGem::SomeResource::CreateService.call!(message: ' bar ')
+    #   service.success? # => true
+    #   service.response # => {:foo=>"bar"}
+    #
+    # And an `ActiveCall::RequestError` exception gets raised if you added errors during the `validate, on: :response`
+    # validation.
+    #
+    #   begin
+    #     service = YourGem::SomeResource::CreateService.call!(message: 'baz')
+    #   rescue ActiveCall::RequestError => exception
+    #     exception.errors # => #<ActiveModel::Errors [#<ActiveModel::Error attribute=message, type=invalid, options={:message=>"cannot be baz"}>]>
+    #     exception.errors.full_messages # => ["Message cannot be baz"]
+    #     exception.response # => {:foo=>"baz"}
+    #   end
+    #
     def call!(...)
       service_object = new(...)
       service_object.instance_variable_set(:@bang, true)
-      raise ActiveCall::ValidationError, service_object.errors if service_object.invalid?(except_on: :response)
+
+      if service_object.invalid?(except_on: [:request, :response])
+        raise ActiveCall::ValidationError, service_object.errors
+      end
 
       service_object.run_callbacks(:call) do
         next if service_object.is_a?(Enumerable)
 
+        service_object.validate(:request)
+        raise ActiveCall::RequestError.new(nil, service_object.errors) unless service_object.success?
+
         service_object.instance_variable_set(:@response, service_object.call)
         service_object.validate(:response)
 

data/lib/active_call/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveCall
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_call
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Kobus Joubert
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-03-20 00:00:00.000000000 Z
+date: 2025-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -66,7 +66,7 @@ metadata:
   rubygems_mfa_required: 'true'
   homepage_uri: https://github.com/kobusjoubert/active_call
   source_code_uri: https://github.com/kobusjoubert/active_call
-  changelog_uri: https://github.com/kobusjoubert/active_call/CHANGELOG.md
+  changelog_uri: https://github.com/kobusjoubert/active_call/blob/main/CHANGELOG.md
 post_install_message:
 rdoc_options: []
 require_paths: