active_call-zoho_sign 0.1.2 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e6bfddd2811ee821c10b0f03e640a1d5bd61fce4a1f55e710d94284c4428013
-  data.tar.gz: 31222714f42fa31b5a8c90c59b1eae1e7f3e10103b3aac99e6ee3899d445c3ed
+  metadata.gz: 9f5b979aa0e18b49ea40fa109aba4afd213e5c1935cde79c60b14b5ae700420a
+  data.tar.gz: 5c06f8ad0695d64905affc7c84432e39977d1531ac3e1aa94fcd9761c7fd2537
 SHA512:
-  metadata.gz: f0da06b096bad4445ba1985194968119a4c320d961fd9d70dce91efa80206677b0cbd718608e9acfc03f15114de2255509d2d8b7f5863095aecff511566193d5
-  data.tar.gz: 46054e1c662f60ce7fe651dfc41bdbe3dc50f4009d94e2871c91230c8ac493e5600e63cae1b038332444759258a064aa3210336d8777485295a9da49acb17a2f
+  metadata.gz: f928364c2384f5b4437c1712d9d09185d1b187e7c1f52d2a04f29c4478b37e09172a5c3231b4bb79d071818a90a3bf909a7fbcde785619490c04b7ad6498611f
+  data.tar.gz: 0d57d5710f292b8659b90c82a95cb6ac40c34feae262726e945aef322522fb59dcf45a8fb9a050d44a612aea88359e62eb028e7184f8f9fd4287a9de8b581958

data/.rubocop.yml

@@ -19,6 +19,9 @@ Layout/HashAlignment:
   EnforcedHashRocketStyle: table
   EnforcedColonStyle: table
 
+Layout/LineLength:
+  AllowedPatterns: ['initialize']
+
 Lint/MissingSuper:
   Enabled: false
 
@@ -35,6 +38,7 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Exclude:
     - lib/zoho_sign/document/list_service.rb
+    - lib/zoho_sign/template/list_service.rb
 
 Metrics/MethodLength:
   Enabled: false
@@ -43,6 +47,10 @@ Metrics/PerceivedComplexity:
   Exclude:
     - lib/zoho_sign/document/list_service.rb
 
+Naming/FileName:
+  Exclude:
+    - lib/active_call-zoho_sign.rb
+
 Naming/MemoizedInstanceVariableName:
   EnforcedStyleForLeadingUnderscores: required
 

data/CHANGELOG.md

@@ -1,4 +1,11 @@
-## [Unreleased]
+## [0.1.4] - 2025-03-31
+
+- Sign a document embedded link fix.
+
+## [0.1.3] - 2025-03-25
+
+- RubyGem badge
+- Bug fix on method `forbidden?`
 
 ## [0.1.2] - 2025-03-25
 

data/README.md

@@ -1,5 +1,7 @@
 # Active Call - Zoho Sign
 
+[![Gem Version](https://badge.fury.io/rb/active_call-zoho_sign.svg?icon=si%3Arubygems)](https://badge.fury.io/rb/active_call-zoho_sign)
+
 Zoho Sign exposes the [Zoho Sign API](https://www.zoho.com/sign/api) endpoints through service objects.
 
 ## Installation
@@ -281,6 +283,15 @@ service = ZohoSign::Document::UpdateService.call(
 service = ZohoSign::Document::DeleteService.call(id: '')
 ```
 
+#### Sign a document.
+
+A unique signing URL will be generated, which will be valid for two minutes. If the signing page is not open by then, a new link needs to be generated and it is a one-time usable URL.
+
+```ruby
+service = ZohoSign::Document::Action::EmbedToken::GetService.call(request_id: '', action_id: '', host: '')
+service.sign_url
+```
+
 ### Folders
 
 TODO: ...

data/lib/active_call-zoho_sign.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require_relative 'zoho_sign'

data/lib/zoho_sign/base_service.rb

@@ -78,7 +78,7 @@ class ZohoSign::BaseService < ActiveCall::Base
   end
 
   def forbidden?
-    response.status == 403
+    return true if response.status == 403
     return false unless response.status == 400 && response.body.key?('code')
 
     # 4003: Access to view the document is denied.
@@ -93,7 +93,7 @@ class ZohoSign::BaseService < ActiveCall::Base
 
     # 4066: Invalid Request ID.
     # 20405: Invalid Template ID.
-    return true if [4066, 20405].include?(response.body['code'])
+    return true if [4_066, 20_405].include?(response.body['code'])
 
     false
   end

data/lib/zoho_sign/document/action/embed_token/get_service.rb

@@ -1,25 +1,28 @@
 # frozen_string_literal: true
 
 class ZohoSign::Document::Action::EmbedToken::GetService < ZohoSign::BaseService
-  attr_reader :id, :request_id, :host
+  attr_reader :request_id, :action_id, :host
+
+  validates :request_id, :action_id, :host, presence: true
 
   after_call :set_facade
 
   delegate_missing_to :@facade
 
-  validates :id, :request_id, :host, presence: true
-
-  def initialize(id:, request_id:, host:)
-    @id         = id
+  def initialize(request_id:, action_id:, host:)
     @request_id = request_id
+    @action_id  = action_id
     @host       = host
   end
 
-  # Get a document.
+  # Get a signing URL.
+  #
+  # A unique signing URL will be generated, which will be valid for two minutes. If the signing page is not open by
+  # then, a new link needs to be generated and it is a one-time usable URL.
   #
   # ==== Examples
   #
-  #   service = ZohoSign::Document::Action::EmbedToken::GetService.call(id: '', request_id: '', host: '')
+  #   service = ZohoSign::Document::Action::EmbedToken::GetService.call(request_id: '', action_id: '', host: '')
   #
   #   service.success? # => true
   #   service.errors # => #<ActiveModel::Errors []>
@@ -29,12 +32,12 @@ class ZohoSign::Document::Action::EmbedToken::GetService < ZohoSign::BaseService
   #   service.response.body # => {}
   #
   #   service.facade # => #<ZohoSign::Document::Action::EmbedToken::Facade ...>
-  #   service.facade.request_name
-  #   service.request_name
+  #   service.facade.sign_url
+  #   service.sign_url
   #
-  # POST /api/v1/requests/:request_id/actions/:id/embedtoken
+  # POST /api/v1/requests/:request_id/actions/:action_id/embedtoken
   def call
-    connection.post("/api/v1/requests/#{request_id}/actions/#{id}/embedtoken", **params)
+    connection.post("/api/v1/requests/#{request_id}/actions/#{action_id}/embedtoken", **params)
   end
 
   private
@@ -46,6 +49,6 @@ class ZohoSign::Document::Action::EmbedToken::GetService < ZohoSign::BaseService
   end
 
   def set_facade
-    @facade = ZohoSign::Document::Action::EmbedToken.new(response.body)
+    @facade = ZohoSign::Document::Action::EmbedToken::Facade.new(response.body)
   end
 end

data/lib/zoho_sign/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ZohoSign
-  VERSION = '0.1.2'
+  VERSION = '0.1.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: active_call-zoho_sign
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.4
 platform: ruby
 authors:
 - Kobus Joubert
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-03-25 00:00:00.000000000 Z
+date: 2025-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_call