active_attr 0.14.0 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27d7a6a18d57befed3918f2bfff542bd99d9ef58fa7cfe68b028b6165cc2e001
-  data.tar.gz: 050735d5e29e679f140f9521452dd75266116efd94c9b72a6215f4bb52834aff
+  metadata.gz: e652baf798884f7fdb18b8d87e67d651263e66bed733d8bd1f4e790d8420f464
+  data.tar.gz: 62c19ff44b88e6f456f15c78eda8f4ad5f67bcd931d15a3d356f4db995afd467
 SHA512:
-  metadata.gz: '0648dc4bb4168744604929bdc7f32d3e5ba2a5ffea45e3e7c4c27f6cfa3ce2f7aafe220b09f0cb239363bf4197ae7bfde959c52173fed65d5fbfd2f4cdd7efcc'
-  data.tar.gz: 92d9884debc077a14e90627eeef4fed79fb927467d1934cc7739198541f27b9da380cfcf2de3518c5c111113a6fbc9dbd1a83b3af413d421252a2829da5f4de5
+  metadata.gz: 9d9568e271cf14d699024f8f464898acb2f6b62dba6e3226f5c3c6183bd4aed19199cfbd969840422fbd4a638fd27dc08b5f7cd7d80e10dee4b85aca2f48aec7
+  data.tar.gz: 1d637b5566727fd7ee4476fd487e81ec3a0fa05dc53cd170a64e36a0fe1c7ed12ded40463f235d218c019aa9c60a8bee09e4eb1090e72f4b2fd3d08b17fa8f61

data/.travis.yml

@@ -1,4 +1,5 @@
 language: ruby
+dist: trusty # for Ruby 1.9
 sudo: false
 rvm:
   - 1.9.2

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# ActiveAttr 0.15.0 (June 12, 2019) #
+
+* Add missing ActiveSupport require for Attributes
+* Change numeric typecasters to cast nil and empty strings to nil
+
 # ActiveAttr 0.14.0 (June 10, 2019) #
 
 * Drop support for Ruby versions below 1.9.2

data/README.md

@@ -3,11 +3,11 @@
 [![Build History][travis badge]][travis]
 [![Code Climate][codeclimate badge]][codeclimate]
 
-ActiveAttr is a set of modules that makes it easy to create plain old ruby
+ActiveAttr is a set of modules that makes it easy to create plain old Ruby
 models with functionality found in ORMs, like ActiveRecord, without
 reinventing the wheel. Think of ActiveAttr as the stuff ActiveModel left out.
 
-ActiveAttr is distributed as a rubygem [on rubygems.org][rubygems].
+ActiveAttr is distributed as a Ruby gem [on rubygems.org][rubygems].
 
 [![ActiveAttr Railscast][railscast poster]][railscast]
 

data/active_attr.gemspec

@@ -4,7 +4,7 @@ require File.expand_path("../lib/active_attr/version", __FILE__)
 Gem::Specification.new do |gem|
   gem.authors       = ["Chris Griego", "Ben Poweski"]
   gem.email         = ["cgriego@gmail.com", "bpoweski@gmail.com"]
-  gem.description   = %q{Create plain old ruby models without reinventing the wheel.}
+  gem.description   = %q{Create plain old Ruby models without reinventing the wheel.}
   gem.summary       = %q{What ActiveModel left out}
   gem.homepage      = "https://github.com/cgriego/active_attr"
   gem.license       = "MIT"

data/lib/active_attr/attributes.rb

@@ -3,6 +3,7 @@ require "active_attr/dangerous_attribute_error"
 require "active_attr/unknown_attribute_error"
 require "active_model"
 require "active_support/concern"
+require "active_support/core_ext/class/attribute"
 require "active_support/hash_with_indifferent_access"
 
 begin

data/lib/active_attr/typecasting/big_decimal_typecaster.rb

@@ -1,6 +1,7 @@
 require "bigdecimal"
 require "bigdecimal/util"
 require "active_support/core_ext/big_decimal/conversions"
+require "active_support/core_ext/object/blank"
 
 module ActiveAttr
   module Typecasting
@@ -29,6 +30,8 @@ module ActiveAttr
           value
         elsif value.is_a? Rational
           value.to_f.to_d
+        elsif value.blank?
+          nil
         elsif value.respond_to? :to_d
           value.to_d
         else

data/lib/active_attr/typecasting/float_typecaster.rb

@@ -1,3 +1,5 @@
+require "active_support/core_ext/object/blank"
+
 module ActiveAttr
   module Typecasting
     # Typecasts an Object to a Float
@@ -20,7 +22,7 @@ module ActiveAttr
       #
       # @since 0.5.0
       def call(value)
-        value.to_f if value.respond_to? :to_f
+        value.to_f if value.present? && value.respond_to?(:to_f)
       end
     end
   end

data/lib/active_attr/typecasting/integer_typecaster.rb

@@ -1,3 +1,5 @@
+require "active_support/core_ext/object/blank"
+
 module ActiveAttr
   module Typecasting
     # Typecasts an Object to an Integer
@@ -21,7 +23,7 @@ module ActiveAttr
       #
       # @since 0.5.0
       def call(value)
-        value.to_i if value.respond_to? :to_i
+        value.to_i if value.present? && value.respond_to?(:to_i)
       rescue FloatDomainError
       end
     end

data/lib/active_attr/version.rb

@@ -1,5 +1,5 @@
 module ActiveAttr
   # Complete version string
   # @since 0.1.0
-  VERSION = "0.14.0"
+  VERSION = "0.15.0"
 end

data/spec/unit/active_attr/typecasting/big_decimal_typecaster_spec.rb

@@ -12,15 +12,19 @@ module ActiveAttr
           typecaster.call(value).should equal value
         end
 
-        it "casts nil to a zero BigDecimal" do
-          typecaster.call(nil).should eql BigDecimal("0.0")
+        it "casts nil to nil" do
+          typecaster.call(nil).should eql nil
         end
 
         it "casts a numeric String to a BigDecimal" do
           typecaster.call("2").should eql BigDecimal("2.0")
         end
 
-        it "casts a alpha String to a zero BigDecimal" do
+        it "casts an empty String to nil" do
+          typecaster.call("").should eql nil
+        end
+
+        it "casts an alpha String to a zero BigDecimal" do
           typecaster.call("bob").should eql BigDecimal("0.0")
         end
 

data/spec/unit/active_attr/typecasting/float_typecaster_spec.rb

@@ -12,14 +12,22 @@ module ActiveAttr
           typecaster.call(value).should equal value
         end
 
-        it "casts nil to 0.0" do
-          typecaster.call(nil).should eql 0.0
+        it "casts nil to nil" do
+          typecaster.call(nil).should eql nil
         end
 
         it "returns the float version of a String" do
           typecaster.call("2").should eql 2.0
         end
 
+        it "casts an empty String to nil" do
+          typecaster.call("").should eql nil
+        end
+
+        it "casts an alpha String to a zero Float" do
+          typecaster.call("bob").should eql 0.0
+        end
+
         it "returns nil for an object that does not respond to #to_f" do
           typecaster.call(Object.new).should be_nil
         end

data/spec/unit/active_attr/typecasting/integer_typecaster_spec.rb

@@ -12,14 +12,22 @@ module ActiveAttr
           typecaster.call(value).should equal value
         end
 
-        it "casts nil to 0" do
-          typecaster.call(nil).should eql 0
+        it "casts nil to nil" do
+          typecaster.call(nil).should eql nil
         end
 
         it "returns the integer version of a String" do
           typecaster.call("2").should eql 2
         end
 
+        it "casts an empty String to nil" do
+          typecaster.call("").should eql nil
+        end
+
+        it "casts an alpha String to a zero Integer" do
+          typecaster.call("bob").should eql 0
+        end
+
         it "returns nil for an object that does not respond to #to_i" do
           typecaster.call(Object.new).should be_nil
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_attr
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.0
 platform: ruby
 authors:
 - Chris Griego
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-10 00:00:00.000000000 Z
+date: 2019-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -161,7 +161,7 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
-description: Create plain old ruby models without reinventing the wheel.
+description: Create plain old Ruby models without reinventing the wheel.
 email:
 - cgriego@gmail.com
 - bpoweski@gmail.com
@@ -282,8 +282,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.9
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: What ActiveModel left out