active_attr 0.13.1 → 0.14.0

data/spec/functional/active_attr/model_spec.rb

@@ -120,5 +120,52 @@ module ActiveAttr
         end.end_date.should == Date.today
       end
     end
+
+    context "when define validation callbacks" do
+      let :model_class do
+        Class.new do
+          include Model
+
+          attribute :name
+          attribute :status
+
+          validates :name, :presence => true, :length => {:maximum => 6}
+
+          before_validation :remove_whitespaces
+          after_validation :set_status
+
+          def self.name
+            "Person"
+          end
+
+          private
+
+          def remove_whitespaces
+            name.strip!
+          end
+
+          def set_status
+            self.status = errors.empty?
+          end
+        end
+      end
+
+      it "can call before_validation" do
+        person = model_class.new(:name => "  bob  ")
+
+        expect(person.valid?).to be(true)
+        expect(person.name).to eq("bob")
+      end
+
+      it "can call after_validation" do
+        person = model_class.new(:name => "")
+        expect(person.valid?).to be(false)
+        expect(person.status).to be(false)
+
+        person = model_class.new(:name => "alice")
+        expect(person.valid?).to be(true)
+        expect(person.status).to be(true)
+      end
+    end
   end
 end

data/spec/unit/active_attr/attribute_defaults_spec.rb

@@ -4,14 +4,18 @@ require "active_attr/attribute_defaults"
 module ActiveAttr
   describe AttributeDefaults do
     subject(:model) { model_class.new }
+    let(:non_duplicable) { double("non-duplicable", :duplicable? => false) }
 
     let :model_class do
+      non_duplicable_default = non_duplicable
+
       Class.new do
         include InitializationVerifier
         include AttributeDefaults
         attribute :first_name, :default => "John"
         attribute :age, :default => nil
         attribute :created_at, :default => lambda { Time.now }
+        attribute :non_duplicable, :default => non_duplicable_default
       end
     end
 
@@ -32,6 +36,10 @@ module ActiveAttr
       it "includes declared dynamic attribute defaults" do
         attribute_defaults["created_at"].should be_a_kind_of Time
       end
+
+      it "includes non-duplicable attribute defaults" do
+        attribute_defaults["non_duplicable"].should == non_duplicable
+      end
     end
 
     describe "#initialize" do

data/spec/unit/active_attr/attributes_spec.rb

@@ -9,6 +9,7 @@ module ActiveAttr
     let :model_class do
       Class.new do
         include Attributes
+
         attribute :first_name
         attribute :last_name
         attribute :amount
@@ -133,6 +134,11 @@ module ActiveAttr
         model.should_receive(:attribute=).with("first_name", "Ben")
         model.first_name = "Ben"
       end
+
+      it "returns the new attribute definition" do
+        result = attributeless.attribute! :first_name
+        result.should == AttributeDefinition.new(:first_name)
+      end
     end
 
     describe ".attributes" do
@@ -151,6 +157,38 @@ module ActiveAttr
       end
     end
 
+    describe "#{described_class}.filter_attributes" do
+      after { described_class.send(:remove_instance_variable, "@filter_attributes") }
+
+      it "defaults to an empty array" do
+        described_class.filter_attributes.should == []
+      end
+
+      it "can be mutated" do
+        described_class.filter_attributes << :password
+        described_class.filter_attributes.should == [:password]
+      end
+
+      it "can be assigned" do
+        described_class.filter_attributes += [:password]
+        described_class.filter_attributes.should == [:password]
+      end
+
+      it "initiailizes new classes using the module config" do
+        described_class.filter_attributes += [:password]
+        model_class.filter_attributes.should == [:password]
+      end
+
+      it "subclasses should inherit from the parent class" do
+        model_class.filter_attributes = [:password]
+        Class.new(model_class).filter_attributes.should == [:password]
+      end
+
+      it "cannot be overridden on instances" do
+        model_class.new.should_not respond_to(:filter_attributes=)
+      end
+    end
+
     describe ".inspect" do
       it "renders the class name" do
         model_class.inspect.should match(/^Foo\(.*\)$/)
@@ -214,6 +252,59 @@ module ActiveAttr
         model.inspect.should == %{#<Foo amount: nil, first_name: "Ben", last_name: "#{last_name}">}
       end
 
+      context "filtering attributes with a Symbol" do
+        before { model_class.filter_attributes = [:amount] }
+
+        it "does not filter an attribute with a nil value" do
+          model.inspect.should == %{#<Foo amount: nil, first_name: "Ben", last_name: "#{last_name}">}
+        end
+
+        it "filters filtered attributes that have a value" do
+          model.amount = 100
+          model.inspect.should == %{#<Foo amount: [FILTERED], first_name: "Ben", last_name: "#{last_name}">}
+        end
+      end
+
+      context "filtering attributes with a String" do
+        before { model_class.filter_attributes = ["amount"] }
+
+        it "does not filter an attribute with a nil value" do
+          model.inspect.should == %{#<Foo amount: nil, first_name: "Ben", last_name: "#{last_name}">}
+        end
+
+        it "filters filtered attributes that have a value" do
+          model.amount = 100
+          model.inspect.should == %{#<Foo amount: [FILTERED], first_name: "Ben", last_name: "#{last_name}">}
+        end
+      end
+
+      context "filtering attributes with a partial attribute name" do
+        before { model_class.filter_attributes = [:name] }
+
+        it "filters filtered attributes that have a value and whose attribute contains the filtered attribute name" do
+          model.inspect.should == %{#<Foo amount: nil, first_name: [FILTERED], last_name: [FILTERED]>}
+        end
+      end
+
+      context "filtering attributes with a Regexp" do
+        before { model_class.filter_attributes = [/name/i] }
+
+        it "filters filtered attributes that have a value and whose attribute matches the Regexp" do
+          model.inspect.should == %{#<Foo amount: nil, first_name: [FILTERED], last_name: [FILTERED]>}
+        end
+      end
+
+      context "filtering attributes with a Proc with 2 arguments" do
+        before do
+          model.amount = 100
+          model_class.filter_attributes = [->(key, value) { value.reverse! if key =~ /name/ }]
+        end
+
+        it "filters filtered attributes that have a value by mutating the attributes" do
+          model.inspect.should == %{#<Foo amount: 100, first_name: "neB", last_name: "iksewoP">}
+        end
+      end
+
       it "doesn't format the inspection string for attributes if the model does not have any" do
         attributeless.new.inspect.should == %{#<Foo>}
       end

data/spec/unit/active_attr/typecasting/big_decimal_typecaster_spec.rb

@@ -24,6 +24,10 @@ module ActiveAttr
           typecaster.call("bob").should eql BigDecimal("0.0")
         end
 
+        it "casts an alpha string coercable object to a zero BigDecimal" do
+          typecaster.call(double(to_s: "bob")).should eql BigDecimal("0.0")
+        end
+
         it "casts a Rational to a BigDecimal" do
           typecaster.call(Rational(1, 2)).should eql BigDecimal("0.5")
         end

data/spec/unit/active_attr/typecasting/boolean_typecaster_spec.rb

@@ -16,8 +16,8 @@ module ActiveAttr
           typecaster.call(false).should equal false
         end
 
-        it "casts nil to false" do
-          typecaster.call(nil).should equal false
+        it "casts nil to nil" do
+          typecaster.call(nil).should equal nil
         end
 
         it "casts an Object to true" do
@@ -26,7 +26,7 @@ module ActiveAttr
 
         context "when the value is a String" do
           it "casts an empty String to false" do
-            typecaster.call("").should equal false
+            typecaster.call("").should equal nil
           end
 
           it "casts a non-empty String to true" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active_attr
 version: !ruby/object:Gem::Version
-  version: 0.13.1
+  version: 0.14.0
 platform: ruby
 authors:
 - Chris Griego
@@ -9,8 +9,28 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-25 00:00:00.000000000 Z
+date: 2019-06-10 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: actionpack
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.2
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.2
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
@@ -66,12 +86,9 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
@@ -79,9 +96,6 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2.2'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
@@ -157,7 +171,6 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
-- ".ruby-version"
 - ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md
@@ -252,7 +265,8 @@ files:
 homepage: https://github.com/cgriego/active_attr
 licenses:
 - MIT
-metadata: {}
+metadata:
+  changelog_uri: https://github.com/cgriego/active_attr/blob/master/CHANGELOG.md
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -261,7 +275,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -269,7 +283,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.7.9
 signing_key: 
 specification_version: 4
 summary: What ActiveModel left out

data/.ruby-version

@@ -1 +0,0 @@
-2.4.1