active_attr 0.1.0 → 0.2.0

data/spec/active_attr/matchers/have_attribute_matcher_spec.rb

@@ -0,0 +1,103 @@
+require "spec_helper"
+require "active_attr/attributes"
+require "active_attr/matchers/have_attribute_matcher"
+
+module ActiveAttr
+  describe Matchers do
+    let(:dsl) { Object.new.extend described_class }
+    subject { dsl }
+
+    it { should respond_to(:have_attribute).with(1).argument }
+
+    describe "#have_attribute" do
+      subject { dsl.have_attribute(:name) }
+
+      it "builds a HaveAttributeMatcher with the given attribute name" do
+        should be_a_kind_of Matchers::HaveAttributeMatcher
+      end
+
+      it "uses the given attribute name to construct the matcher" do
+        subject.attribute_name.should == :name
+      end
+    end
+  end
+
+  module Matchers
+    describe HaveAttributeMatcher do
+      let :model_class do
+        Class.new do
+          include Attributes
+          attribute :name
+
+          def self.to_s
+            "Person"
+          end
+        end
+      end
+
+      subject { positive_matcher }
+      let(:positive_matcher) { described_class.new(:name) }
+      let(:negative_matcher) { described_class.new(:age) }
+
+      it { described_class.should respond_to(:new).with(1).argument }
+
+      describe "#attribute_name" do
+        it "returns the value used to initialize the matcher" do
+          subject.attribute_name.should == :name
+        end
+
+        it "converts the value used to initialize the matcher to a symbol" do
+          described_class.new('name').attribute_name.should == :name
+        end
+      end
+
+      describe "#description" do
+        it "returns a description appropriate to the expectation" do
+          subject.description.should == "have attribute named name"
+        end
+      end
+
+      describe "#failure_message" do
+        it "returns a failure message appropriate to the expectation and subject" do
+          negative_matcher.tap do |matcher|
+            matcher.matches? model_class
+          end.failure_message.should == "Expected Person to have attribute named age"
+        end
+      end
+
+      describe "#initialize" do
+        it "raises a TypeError when the attribute name does not respond to #to_sym" do
+          expect { described_class.new(Object.new) }.to raise_error(TypeError, "can't convert Object into Symbol")
+        end
+      end
+
+      describe "#matches?" do
+        let(:model_instance) { model_class.new }
+
+        it "is true with an instance of a model class that has the attribute" do
+          positive_matcher.matches?(model_instance).should be_true
+        end
+
+        it "is true with a model class that has the attribute" do
+          positive_matcher.matches?(model_class).should be_true
+        end
+
+        it "is false with an instance of a model class that does not have the attribute" do
+          negative_matcher.matches?(model_instance).should be_false
+        end
+
+        it "is false with a model class that does not have the attribute" do
+          negative_matcher.matches?(model_class).should be_false
+        end
+      end
+
+      describe "#negative_failure_message" do
+        it "returns a failure message appropriate to the expectation and subject" do
+          positive_matcher.tap do |matcher|
+            matcher.matches? model_class
+          end.negative_failure_message.should == "Expected Person to not have attribute named name"
+        end
+      end
+    end
+  end
+end

data/spec/active_attr/strict_mass_assignment_spec.rb

@@ -0,0 +1,38 @@
+require "spec_helper"
+require "active_attr/strict_mass_assignment"
+
+module ActiveAttr
+  describe StrictMassAssignment, :mass_assignment do
+    subject do
+      model_class.class_eval do
+        include StrictMassAssignment
+      end
+    end
+
+    shared_examples "strict mass assignment method", :strict_mass_assignment_method => true do
+      include_examples "mass assignment method"
+
+      it "raises when assigning an unknown attribute" do
+        expect do
+          mass_assign_attributes(:middle_initial => "J")
+        end.to raise_error UnknownAttributesError, "unknown attribute(s): middle_initial"
+      end
+
+      it "raises when trying to assign a private attribute" do
+        expect do
+          mass_assign_attributes(:middle_name => "J")
+        end.to raise_error UnknownAttributesError, "unknown attribute(s): middle_name"
+      end
+
+      it "raises when assigning multiple unknown attributes with a message referencing both in alphabetical order" do
+        expect do
+          mass_assign_attributes(:middle_name => "J", :middle_initial => "J")
+        end.to raise_error UnknownAttributesError, "unknown attribute(s): middle_initial, middle_name"
+      end
+    end
+
+    describe "#assign_attributes", :assign_attributes, :strict_mass_assignment_method
+    describe "#attributes=", :attributes=, :strict_mass_assignment_method
+    describe "#initialize", :initialize, :strict_mass_assignment_method
+  end
+end

data/spec/active_attr/unknown_attributes_error_spec.rb

@@ -0,0 +1,9 @@
+require "spec_helper"
+require "active_attr/unknown_attributes_error"
+
+module ActiveAttr
+  describe UnknownAttributesError do
+    it { should be_a_kind_of NoMethodError }
+    it { should be_a_kind_of Error }
+  end
+end

data/spec/active_attr/version_spec.rb

@@ -0,0 +1,35 @@
+require "spec_helper"
+require "active_attr/version"
+
+module ActiveAttr
+  describe "ActiveAttr::VERSION" do
+    subject { VERSION }
+
+    it { should be_a_kind_of String }
+
+    describe "is compliant with Semantic Versioning <http://semver.org/>" do
+      let(:gem_version) { Gem::Version.new VERSION }
+      subject { gem_version }
+
+      it { subject.should have(3).segments }
+
+      describe "major version" do
+        subject { gem_version.segments[0] }
+
+        it { should be_a_kind_of Fixnum }
+      end
+
+      describe "minor version" do
+        subject { gem_version.segments[1] }
+
+        it { should be_a_kind_of Fixnum }
+      end
+
+      describe "patch version" do
+        subject { gem_version.segments[2] }
+
+        it { subject.to_s.should =~ /\d+([A-Za-z][0-9A-Za-z-]*)?/ }
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -7,4 +7,5 @@ Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |file| require file }
 
 RSpec.configure do |config|
   config.mock_framework = :rspec
+  config.treat_symbols_as_metadata_keys_with_true_values = true # default in RSpec 3
 end

data/spec/support/active_model_lint.rb

@@ -8,7 +8,7 @@ shared_examples_for "ActiveModel" do
   before { @model = subject }
 
   ActiveModel::Lint::Tests.public_instance_methods.map(&:to_s).grep(/^test/).each do |test|
-    example test.gsub('_',' ') do
+    example test.gsub("_", " ") do
       send test
     end
   end

data/spec/support/mass_assignment_shared_examples.rb

@@ -0,0 +1,95 @@
+shared_examples "mass assignment class", :mass_assignment => true do
+  let :model_class do
+    Class.new do
+      attr_accessor :first_name, :last_name, :middle_name
+      private :middle_name=
+
+      def name=(name)
+        self.last_name, self.first_name = name.split(nil, 2).reverse
+      end
+    end
+  end
+
+  let(:person) { subject.new }
+  let(:first_name) { "Chris" }
+  let(:last_name) { "Griego" }
+
+  def should_assign_names_to(person)
+    person.first_name.should == first_name
+    person.last_name.should == last_name
+  end
+end
+
+shared_examples "mass assignment method" do
+  it "does not raise when assigning nil attributes" do
+    expect { mass_assign_attributes nil }.not_to raise_error
+  end
+
+  it "assigns all valid attributes when passed as a hash with string keys" do
+    should_assign_names_to mass_assign_attributes('first_name' => first_name, 'last_name' => last_name)
+  end
+
+  it "assigns all valid attributes when passed as a hash with symbol keys" do
+    should_assign_names_to mass_assign_attributes(:first_name => first_name, :last_name => last_name)
+  end
+
+  it "uses any available writer methods" do
+    should_assign_names_to mass_assign_attributes(:name => "#{first_name} #{last_name}")
+  end
+end
+
+shared_examples "#assign_attribures", :assign_attributes => true do
+  def mass_assign_attributes(attributes)
+    person.assign_attributes attributes
+    person
+  end
+
+  it "raises ArgumentError when called with three arguments" do
+    expect { subject.new.assign_attributes({}, {}, nil) }.to raise_error ArgumentError
+  end
+
+  it "does not raise when called with two arguments" do
+    expect { subject.new.assign_attributes({}, {}) }.not_to raise_error
+  end
+
+  it "does not raise when called with a single argument" do
+    expect { subject.new.assign_attributes({}) }.not_to raise_error
+  end
+
+  it "raises ArgumentError when called with no arguments" do
+    expect { subject.new.assign_attributes }.to raise_error ArgumentError
+  end
+end
+
+shared_examples "#attributes=", :attributes= => true do
+  def mass_assign_attributes(attributes)
+    person.attributes = attributes
+    person
+  end
+
+  it "raises ArgumentError when called with two arguments" do
+    expect { person.send(:attributes=, {}, {}) }.to raise_error ArgumentError
+  end
+end
+
+shared_examples "#initialize", :initialize => true do
+  def mass_assign_attributes(attributes)
+    subject.new(attributes)
+  end
+
+  it "raises ArgumentError when called with three arguments" do
+    expect { subject.new({}, {}, nil) }.to raise_error ArgumentError
+  end
+
+  it "does not raise when called with two arguments" do
+    expect { subject.new({}, {}) }.not_to raise_error
+  end
+
+  it "does not raise when called with a single argument" do
+    expect { subject.new({}) }.not_to raise_error
+  end
+
+  it "does not raise when called with no arguments" do
+    expect { subject.new }.not_to raise_error
+  end
+end

metadata

@@ -1,20 +1,21 @@
 --- !ruby/object:Gem::Specification
 name: active_attr
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
 - Chris Griego
+- Ben Poweski
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-09-30 00:00:00.000000000 -05:00
+date: 2011-10-03 00:00:00.000000000 -05:00
 default_executable: 
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &70301304935460 !ruby/object:Gem::Requirement
+  requirement: &70212822508240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -22,10 +23,10 @@ dependencies:
         version: '3.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70301304935460
+  version_requirements: *70212822508240
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70301304934380 !ruby/object:Gem::Requirement
+  requirement: &70212822507140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -33,10 +34,10 @@ dependencies:
         version: '3.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70301304934380
+  version_requirements: *70212822507140
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70301304933700 !ruby/object:Gem::Requirement
+  requirement: &70212822506320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -44,10 +45,10 @@ dependencies:
         version: '1.0'
   type: :development
   prerelease: false
-  version_requirements: *70301304933700
+  version_requirements: *70212822506320
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70301304932520 !ruby/object:Gem::Requirement
+  requirement: &70212822505480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -55,10 +56,10 @@ dependencies:
         version: 0.9.0
   type: :development
   prerelease: false
-  version_requirements: *70301304932520
+  version_requirements: *70212822505480
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70301304931300 !ruby/object:Gem::Requirement
+  requirement: &70212822504100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -66,14 +67,16 @@ dependencies:
         version: '2.6'
   type: :development
   prerelease: false
-  version_requirements: *70301304931300
+  version_requirements: *70212822504100
 description: Create plain old ruby models without reinventing the wheel.
 email:
 - cgriego@gmail.com
+- bpoweski@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- .document
 - .gitignore
 - .rspec
 - .rvmrc
@@ -86,11 +89,29 @@ files:
 - Rakefile
 - active_attr.gemspec
 - lib/active_attr.rb
+- lib/active_attr/attribute_definition.rb
+- lib/active_attr/attributes.rb
+- lib/active_attr/basic_model.rb
+- lib/active_attr/error.rb
 - lib/active_attr/mass_assignment.rb
+- lib/active_attr/matchers.rb
+- lib/active_attr/matchers/have_attribute_matcher.rb
+- lib/active_attr/rspec.rb
+- lib/active_attr/strict_mass_assignment.rb
+- lib/active_attr/unknown_attributes_error.rb
 - lib/active_attr/version.rb
+- spec/active_attr/attribute_definition_spec.rb
+- spec/active_attr/attributes_spec.rb
+- spec/active_attr/basic_model_spec.rb
+- spec/active_attr/error_spec.rb
 - spec/active_attr/mass_assignment_spec.rb
+- spec/active_attr/matchers/have_attribute_matcher_spec.rb
+- spec/active_attr/strict_mass_assignment_spec.rb
+- spec/active_attr/unknown_attributes_error_spec.rb
+- spec/active_attr/version_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_model_lint.rb
+- spec/support/mass_assignment_shared_examples.rb
 has_rdoc: true
 homepage: https://github.com/cgriego/active_attr
 licenses: []
@@ -106,7 +127,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2511944466975604265
+      hash: 4452087611638543141
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -115,7 +136,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2511944466975604265
+      hash: 4452087611638543141
 requirements: []
 rubyforge_project: active_attr
 rubygems_version: 1.5.2
@@ -123,6 +144,15 @@ signing_key:
 specification_version: 3
 summary: What ActiveModel left out
 test_files:
+- spec/active_attr/attribute_definition_spec.rb
+- spec/active_attr/attributes_spec.rb
+- spec/active_attr/basic_model_spec.rb
+- spec/active_attr/error_spec.rb
 - spec/active_attr/mass_assignment_spec.rb
+- spec/active_attr/matchers/have_attribute_matcher_spec.rb
+- spec/active_attr/strict_mass_assignment_spec.rb
+- spec/active_attr/unknown_attributes_error_spec.rb
+- spec/active_attr/version_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_model_lint.rb
+- spec/support/mass_assignment_shared_examples.rb