active_admin_role 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 50b0ce4d721281f6862803084c1bc877d0e16194
-  data.tar.gz: 3a68d53325063176c30fe76ac76eec1e33dc81e5
+SHA256:
+  metadata.gz: 3ea9f11c0722efc41a64baff3ca74086dd34d878a482cc00a95ebe3d40e3523a
+  data.tar.gz: dbb330580027c71ba91d1b0f6a50d2adf69f79280f9b2ee77a61f64b4426f0aa
 SHA512:
-  metadata.gz: b95f322b9997282163ab7ea8e5ae97ceec3337317c6b862624c9477e563c8c346e3c135a7cba49d88edc4f5a2426a0e25a19169a64c86b0cd92604f650c5c9db
-  data.tar.gz: 16a35e6b5be3ee64c92bbc9ea8c95d0e6bb2c9ed1e6bbf3e24071b639b99cef6e52856703d176bfaba853f8b3197a4ace434d307541265656f28f7dbe069bb9b
+  metadata.gz: 12f29a42a12e324e635e99c804cdc51f3f877e36592a34e64d82251ba2a69c82250805a4ae2194910d87fcd725e9a2d07093651adfec3bfff0896262bec795c9
+  data.tar.gz: efa55e48d456fecd90b82139b1d13ef7de91413f7087c543a3f40a42a4139d8e2c1829a31382e9a7b590b7b1f2752cec783156a34eadc3d0946335df2a6eb83e

data/.gitignore

@@ -9,4 +9,5 @@
 /spec/reports/
 /tmp/
 /gemfiles/*.gemfile.lock
+/gemfiles/.bundle/*
 /gemfiles/vendor/

data/.rubocop.yml

@@ -1,17 +1,20 @@
-inherit_from:
-  - .ruby-style.yml
+inherit_from: .rubocop_todo.yml
+
+inherit_gem:
+  onkcop:
+    - "config/rubocop.yml"
+    # uncomment if use rails cops
+    # - "config/rails.yml"
+    # uncomment if use rspec cops
+    # - "config/rspec.yml"
 
 AllCops:
+  TargetRubyVersion: 2.2
+  # uncomment if use rails cops
+  # TargetRailsVersion: 5.1
   Exclude:
-    - "bin/*"
-    - "vendor/**/*"
-    - "gemfiles/**/*"
     - "spec/rails/**/*"
-    - "lib/generators/active_admin_role/templates/**/*"
-    - Gemfile
-    - Rakefile
-  DisplayCopNames: true
-  TargetRubyVersion: 2.1
-
-Metrics/LineLength:
-  Enabled: false
+    - "vendor/bundle/**/*"
+    - "gemfiles/vendor/**/*"
+    - "gemfiles/.bundle/**/*"
+    - "tmp/**/*"

data/.rubocop_todo.yml

@@ -0,0 +1,23 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-04-08 11:32:33 +0900 using RuboCop version 0.53.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Configuration parameters: CheckForMethodsWithNoSideEffects.
+Lint/Void:
+  Exclude:
+    - 'spec/features/integration_spec.rb'
+
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 28
+
+# Offense count: 2
+Naming/MemoizedInstanceVariableName:
+  Exclude:
+    - 'app/models/active_admin/manageable_resource.rb'
+    - 'app/models/concerns/active_admin_role/role_based_authorizable.rb'

data/.travis.yml

@@ -1,5 +1,14 @@
-sudo: false
 language: ruby
+before_install:
+  - gem update --system
+  - gem install bundler
+gemfiles:
+  - gemfiles/5.0.gemfile
+  - gemfiles/5.1.gemfile
+  - gemfiles/5.2.gemfile
 rvm:
-  - 2.0.0
-before_install: gem install bundler -v 1.12.1
+  - 2.3.7
+  - 2.4.4
+  - 2.5.1
+script:
+  - bundle exec rspec

data/Appraisals

@@ -1,12 +1,11 @@
-appraise 'rails42' do
-  gem 'rails',       '~> 4.2.0'
-  gem 'devise',      '~> 4.2.0'
-  gem 'activeadmin', '1.0.0.pre4'
+appraise "5.0" do
+  gem "rails", "~> 5.0.0"
 end
 
-appraise 'rails50' do
-  gem 'rails',       '~> 5.0.0'
-  gem 'devise',      '~> 4.2.0'
-  gem 'inherited_resources', github: 'activeadmin/inherited_resources'
-  gem 'activeadmin',         github: 'activeadmin/activeadmin'
+appraise "5.1" do
+  gem "rails", "~> 5.1.0"
+end
+
+appraise "5.2" do
+  gem "rails", "~> 5.2.0.rc2"
 end

data/Gemfile

@@ -1,23 +1,26 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
+
+git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
 
 gemspec
 
-gem "rails",       "~> 4.2.0"
-gem "activeadmin", "1.0.0.pre4"
-gem "devise",      "~> 4.2.0"
-gem "pry"
 gem "appraisal"
+gem "devise"
+gem "jquery-ui-rails", "~> 4.2.1"
+gem "rails", ">= 5.0.0"
+
+group :development, :test do
+  gem "sqlite3", platforms: :mri
+end
 
 group :development do
-  gem "rake",    "~> 10.0"
-  gem "rubocop", "~> 0.40.0"
+  gem "onkcop", require: false
 end
 
 group :test do
   gem "capybara"
-  gem "rspec-rails"
   gem "database_cleaner"
-  gem "shoulda-matchers"
-  gem "sqlite3", platforms: :mri
   gem "poltergeist"
+  gem "rspec-rails"
+  gem "shoulda-matchers"
 end

data/README.md

@@ -14,10 +14,14 @@ And run `bundle`
 
 ## Dependencies
 
-- rails (>= 4.2)
-- activeadmin (>= 1.0.0.pre4)
+- rails (>= 5.0.0)
+- activeadmin (>= 1.2.0)
 - cancancan (>= 1.15.0)
 
+## Sample application
+
+https://github.com/yhirano55-playground/active_admin_role_sample
+
 ## Usage
 
 1. Run this command after `rails generate active_admin:install`:
@@ -31,8 +35,8 @@ $ bin/rails generate active_admin_role:install
   create  db/migrate/20161128090643_create_active_admin_permissions.rb
   create  app/models/ability.rb
     gsub  config/initializers/active_admin.rb
-  create  app/admin/permission.rb
-  insert  app/admin/admin_user.rb
+  create  app/admin/permissions.rb
+  insert  app/admin/admin_users.rb
 
 $ bin/rails db:migrate
 ```

data/Rakefile

@@ -1,7 +1,36 @@
-require 'bundler'
-require 'rake'
+require "bundler"
+require "rake"
 
 Bundler.setup
 Bundler::GemHelper.install_tasks
 
-FileList['tasks/**/*.rake'].each { |task| import task }
+require "rspec/core/rake_task"
+RSpec::Core::RakeTask.new(:spec)
+task default: :spec
+
+desc "Creates a test rails app for the specs to run against"
+task :setup do
+  require "rails/version"
+  system "bundle exec rails --version"
+  system <<-COMMAND
+  bundle exec rails new tmp/rails-#{Rails::VERSION::STRING} \
+    -m spec/support/rails_template.rb \
+    --skip-spring \
+    --skip-listen \
+    --skip-turbolinks \
+    --skip-bootsnap \
+    --skip-test \
+    --skip-git \
+    --skip-yarn \
+    --skip-puma \
+    --skip-action-mailer \
+    --skip-action-cable
+  COMMAND
+end
+
+namespace :tmp do
+  task :clear do
+    require "fileutils"
+    FileUtils.rm_r("tmp")
+  end
+end

data/active_admin_role.gemspec

@@ -11,11 +11,12 @@ Gem::Specification.new do |gem|
   gem.homepage      = "https://github.com/yhirano55/active_admin_role"
   gem.license       = "MIT"
 
-  gem.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  gem.files         = `git ls-files -z`.split("\x0").reject {|f| f.match(%r{^(test|spec|features)/}) }
   gem.require_paths = ["lib"]
 
-  gem.required_ruby_version = ">= 2.1.0"
+  gem.required_ruby_version = ">= 2.2.2"
 
-  gem.add_dependency "activeadmin", ">= 1.0.0.pre4"
+  gem.add_dependency "activeadmin", ">= 1.2.0"
   gem.add_dependency "cancancan",   ">= 1.15.0"
+  gem.add_dependency "railties",    ">= 5.0.0"
 end

data/app/models/active_admin/manageable_resource.rb

@@ -0,0 +1,51 @@
+require "set"
+
+module ActiveAdmin
+  class ManageableResource
+    class << self
+      def call
+        new.call
+      end
+    end
+
+    def call
+      namespace = ::ActiveAdmin.application.default_namespace
+      ::ActiveAdmin.application.namespaces[namespace].resources.inject([]) do |result, resource|
+        class_name = resource.controller.resource_class.to_s
+        name       = resource.resource_name.name
+        actions    = collect_defined_actions(resource)
+
+        result += eval_actions(actions).map do |action|
+          { class_name: class_name, name: name, action: action }
+        end
+
+        result
+      end
+    end
+
+    private
+
+      def collect_defined_actions(resource)
+        if resource.respond_to?(:defined_actions)
+          defined_actions    = resource.defined_actions
+          member_actions     = resource.member_actions.map(&:name)
+          collection_actions = resource.collection_actions.map(&:name)
+          batch_actions      = resource.batch_actions_enabled? ? [:batch_action] : []
+
+          defined_actions | member_actions | member_actions | collection_actions | batch_actions
+        else
+          resource.page_actions.map(&:name) | [:index]
+        end
+      end
+
+      def eval_actions(actions)
+        actions.inject(Set.new) do |result, action|
+          result << (actions_dictionary[action] || action).to_s
+        end
+      end
+
+      def actions_dictionary
+        @_actions_dictionary ||= ::ActiveAdmin::BaseController::Authorization::ACTIONS_DICTIONARY.dup
+      end
+  end
+end

data/app/models/active_admin/managed_resource.rb

@@ -1,16 +1,13 @@
 module ActiveAdmin
   class ManagedResource < ActiveRecord::Base
-    self.table_name = :active_admin_managed_resources
+    self.table_name = "active_admin_managed_resources"
 
     has_many :permissions, dependent: :destroy
-
-    with_options presence: true do
-      validates :class_name
-      validates :action
-    end
+    validates :class_name, presence: true
+    validates :action, presence: true
 
     def const
-      @_const ||= class_name.try(:safe_constantize)
+      @const ||= class_name.try(:safe_constantize)
     end
 
     def active?
@@ -23,41 +20,7 @@ module ActiveAdmin
 
     class << self
       def reload
-        ActiveRecord::Base.transaction do
-          clear_cache
-          update_managed_resources
-          cleanup_managed_resources
-          update_permissions
-        end
-      end
-
-      private
-
-      def update_managed_resources
-        manageable_resources.each(&method(:find_or_create_by!))
-      end
-
-      def cleanup_managed_resources
-        (persisted_resources - manageable_resources).each do |condition|
-          where(condition).destroy_all
-        end
-      end
-
-      def update_permissions
-        ::ActiveAdmin::Permission.clear_cache
-        ::ActiveAdmin::Permission.update_all_from_managed_resources(all)
-      end
-
-      def persisted_resources
-        all.map(&:attributes).map { |attribute| attribute.slice(*%w(class_name action name)).symbolize_keys }
-      end
-
-      def manageable_resources
-        @_manageable_resources ||= ::ActiveAdminRole::ManageableResource.new.call
-      end
-
-      def clear_cache
-        @_manageable_resources = nil
+        ActiveAdmin::PermissionReloader.reload
       end
     end
   end

data/app/models/active_admin/permission.rb

@@ -1,26 +1,21 @@
 module ActiveAdmin
   class Permission < ActiveRecord::Base
     self.table_name = :active_admin_permissions
-
     role_based_authorizable
 
     enum state: { cannot: 0, can: 1 }
 
     belongs_to :managed_resource
-
     delegate :class_name, :action, :name, :const, :active?, :for_active_admin_page?, to: :managed_resource
-    delegate :clear_cache, to: :class
 
-    after_update :clear_cache
+    validates :role, presence: true
+    validates :state, presence: true
+    validates :managed_resource_id, uniqueness: { scope: :role }
 
-    with_options presence: true do
-      validates :managed_resource_id
-      validates :role
-      validates :state
+    after_update do
+      self.class.clear_cache
     end
 
-    validates :managed_resource_id, uniqueness: { scope: [:role] }
-
     def to_condition
       [].tap do |cond|
         cond << state
@@ -31,8 +26,8 @@ module ActiveAdmin
     end
 
     class << self
-      def update_all_from_managed_resources(managed_resources)
-        managed_resources.each do |managed_resource|
+      def update_all_from_managed_resources
+        ::ActiveAdmin::ManagedResource.all.find_each do |managed_resource|
           manageable_roles.values.each do |value_of_role|
             find_or_create_by!(managed_resource_id: managed_resource.id, role: value_of_role) do |permission|
               permission.state = default_state
@@ -42,18 +37,18 @@ module ActiveAdmin
       end
 
       def indexed_cache
-        @_indexed_cache ||= eager_load(:managed_resource).all.group_by(&:role)
+        @indexed_cache ||= eager_load(:managed_resource).all.group_by(&:role)
       end
 
       def clear_cache
-        @_indexed_cache = nil
+        @indexed_cache = nil
       end
 
       private
 
-      def default_state
-        @_default_state ||= ::ActiveAdminRole.config.default_state
-      end
+        def default_state
+          @default_state ||= ::ActiveAdminRole.config.default_state
+        end
     end
   end
 end

data/app/models/active_admin/permission_reloader.rb

@@ -0,0 +1,47 @@
+module ActiveAdmin
+  module PermissionReloader
+    class << self
+      def reload
+        ActiveRecord::Base.transaction do
+          clear_cache
+          update_managed_resources
+          cleanup_managed_resources
+          update_permissions
+        end
+      end
+
+      private
+
+        def clear_cache
+          @manageable_resources = nil
+        end
+
+        def update_managed_resources
+          manageable_resources.each do |manageable_resource|
+            ::ActiveAdmin::ManagedResource.find_or_create_by!(manageable_resource)
+          end
+        end
+
+        def cleanup_managed_resources
+          (persisted_resources - manageable_resources).each do |condition|
+            ::ActiveAdmin::ManagedResource.where(condition).destroy_all
+          end
+        end
+
+        def update_permissions
+          ::ActiveAdmin::Permission.clear_cache
+          ::ActiveAdmin::Permission.update_all_from_managed_resources
+        end
+
+        def persisted_resources
+          ::ActiveAdmin::ManagedResource.all.map(&:attributes).map do |attribute|
+            attribute.slice("class_name", "action", "name").symbolize_keys
+          end
+        end
+
+        def manageable_resources
+          @manageable_resources ||= ::ActiveAdmin::ManageableResource.call
+        end
+    end
+  end
+end