active-record-without-callbacks 0.0.2 → 0.0.3

data/VERSION

@@ -1 +1 @@
-0.0.2
+0.0.3

data/active-record-without-callbacks.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "active-record-without-callbacks"
-  s.version = "0.0.2"
+  s.version = "0.0.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Kasper Johansen"]
-  s.date = "2013-04-05"
+  s.date = "2013-04-08"
   s.description = "A method that allows you to run code without callbacks for a specific active-record model."
   s.email = "kj@gfish.com"
   s.extra_rdoc_files = [

data/lib/active-record-without-callbacks.rb

@@ -1,39 +1,74 @@
+#This class can disable all callbacks for a model, run a block and then re-enable all callbacks.
 class ActiveRecordWithoutCallbacks
   TRUE_BLOCK = proc{ true }
   
-  def self.wo_callbacks(klass)
-    #List of various possible callbacks.
-    takes = [:_create_callbacks, :_find_callbacks, :_initialize_callbacks, :_destroy_callbacks, :_commit_callbacks, :_rollback_callbacks, :_save_callbacks, :_touch_callbacks, :_update_callbacks, :_validate_callbacks, :_validation_callbacks, ]
+  def self.wo_callbacks(args)
+    klass = args[:class]
+    @debug = args[:debug]
+    
+    #Callback-types that we will clear or recompile.
+    callbacks = [:create, :find, :initialize, :destroy, :commit, :rollback, :save, :touch, :update, :validate, :validation]
+    callback_types = [:before, :after]
+    previous_values = []
     
-    #Array containing previous values.
-    saved = []
+    #List of various possible callbacks.
+    takes = [:_create_callbacks, :_find_callbacks, :_initialize_callbacks, :_destroy_callbacks, :_commit_callbacks, :_rollback_callbacks, :_save_callbacks, :_touch_callbacks, :_update_callbacks, :_validate_callbacks, :_validation_callbacks]
     
+    #Run inside exclusive, so we are sure no other thread suffers from the horrible hack, that we are about to do.
     Thread.exclusive do
-      takes.each do |take|
+      callbacks.each do |callback|
+        puts "Disabling callbacks for '#{callback}'." if @debug
+        
+        #Method-name for callbacks to reset.
+        callbacks_method_name = "_#{callback}_callbacks"
+        
         #Store previous value for restoring later.
-        saved << {
-          :take => take,
-          :value => klass.__send__(take)
+        previous_values << {
+          :callbacks_method_name => callbacks_method_name,
+          :value => klass.__send__(callbacks_method_name).clone
         }
         
         #Clear all callbacks.
-        klass.__send__("#{take}=", [])
+        puts "Clearing callbacks in '#{callbacks_method_name}'." if @debug
+        klass.__send__(callbacks_method_name).clear
         
         #Test that callbacks really was cleared.
-        raise "Expected '#{take}' to be empty but it wasnt: #{klass.__send__(take)}" unless klass.__send__(take).empty?
+        puts "Checking if everything is okay for '#{callback}'." if @debug
+        raise "Expected '#{callbacks_method_name}' to be empty but it wasnt: #{klass.__send__(callbacks_method_name)}" unless klass.__send__(callbacks_method_name).empty?
+        
+        #Trick ActiveRecord to recompile callbacks.
+        callback_types.each do |callback_type|
+          method_name = "#{callback_type}_#{callback}"
+          
+          if klass.respond_to?(method_name)
+            klass.__send__(method_name, &TRUE_BLOCK)
+          end
+        end
       end
       
-      klass.after_save(&TRUE_BLOCK)
-      
       begin
+        #Run the given block, now that all callbacks are disabled.
+        puts "Yielding block." if @debug
         return yield
       ensure
+        puts "Restoring callbacks." if @debug
+        
         #Restore previous callbacks.
-        saved.each do |save|
-          klass.__send__("#{save[:take]}=", save[:value])
+        previous_values.each do |previous_value|
+          method_name = "#{previous_value[:callbacks_method_name]}="
+          klass.__send__(method_name, previous_value[:value])
         end
         
-        klass.after_save(&TRUE_BLOCK)
+        #Trick ActiveRecord to recompile old callbacks.
+        callbacks.each do |callback|
+          callback_types.each do |callback_type|
+            method_name = "#{callback_type}_#{callback}"
+            
+            if klass.respond_to?(method_name)
+              klass.__send__(method_name, &TRUE_BLOCK)
+            end
+          end
+        end
       end
     end
   end

data/spec/active-record-without-callbacks_spec.rb

@@ -2,6 +2,36 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 describe "ActiveRecordWithoutCallbacks" do
   it "doesnt fail" do
-    #no tests
+    #The following code tests disabled callbacks.
+    
+    #Deal.after_create do
+    #  raise "Create WTF!?"
+    #end
+    
+    #Deal.after_save do
+    #  raise "Save WTF!?"
+    #end
+    
+    Deal.before_create do
+      raise "Before create!"
+    end
+    
+    Deal.after_create do
+      raise "After create!"
+    end
+    
+    ActiveRecordWithoutCallbacks.wo_callbacks(Deal) do
+      deal = Deal.new(:legacy_id => 999999)
+      
+      #puts deal.methods.sort
+      
+      deal.save! :validate => false
+      puts "Deal created as expected"
+    end
+    
+    deal = Deal.new(:legacy_id => 999999999)
+    
+    deal.save! :validate => false
+    puts "Second deal creation did not fail."
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active-record-without-callbacks
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-05 00:00:00.000000000 Z
+date: 2013-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -111,7 +111,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1341027000292272561
+      hash: 1788919925078652095
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: