active-fedora 9.10.4 → 9.11.0

data/spec/unit/ordered_spec.rb

@@ -0,0 +1,369 @@
+require 'spec_helper'
+
+describe ActiveFedora::Orders do
+  subject { Image.new }
+  before do
+    class Member < ActiveFedora::Base
+    end
+    class BadClass < ActiveFedora::Base
+    end
+    class Image < ActiveFedora::Base
+      ordered_aggregation :members, through: :list_source
+    end
+  end
+  after do
+    Object.send(:remove_const, :Image)
+    Object.send(:remove_const, :Member)
+    Object.send(:remove_const, :BadClass)
+  end
+  describe "<<" do
+    it "does not accept base objects" do
+      member = Member.new
+      expect { subject.ordered_member_proxies << member }.to raise_error ActiveFedora::AssociationTypeMismatch
+      expect(subject).not_to be_changed
+      expect(subject.list_source).not_to be_changed
+    end
+  end
+
+  describe "ordered_by" do
+    let(:image) { Image.new }
+
+    context "an element aggregated by one record" do
+      it "can find the record that contains it" do
+        m = Member.create
+        image.ordered_members << m
+        image.save
+
+        expect(m.ordered_by.to_a).to eq [image]
+      end
+    end
+
+    context "a new element" do
+      it "returns an empty array" do
+        m = Member.new
+        expect(m.ordered_by.to_a).to eq []
+      end
+    end
+
+    context "an element aggregated by multiple records" do
+      let(:image2) { Image.new }
+      it "can find all of the records that contain it" do
+        m = Member.create
+        image.ordered_members << m
+        image2.ordered_members << m
+        image.save
+        image2.save
+        expect(m.ordered_by).to contain_exactly(image2, image)
+      end
+    end
+  end
+
+  it "can load from solr" do
+    member = Member.new
+    subject.ordered_members << member
+    subject.save!
+    solr_doc = ActiveFedora::SolrService.query("id:#{subject.id}").first
+
+    expect { ActiveFedora::Base.load_instance_from_solr(subject.id, solr_doc) }.not_to raise_error
+  end
+
+  describe "#ordered_members" do
+    describe "<<" do
+      it "appends" do
+        member = Member.new
+        subject.save!
+        expect(subject.ordered_members << member).to eq [member]
+        expect(subject.ordered_members).to eq [member]
+        expect(subject.members).to eq [member]
+        expect(subject.ordered_member_proxies.to_a.length).to eq 1
+        subject.save!
+        expect(subject.head).not_to be_blank
+        expect(subject.reload.head).not_to be_blank
+      end
+      it "maintains member associations" do
+        member = Member.create
+        subject.ordered_members << member
+        subject.save
+        subject.reload
+        expect(subject.members).to eq [member]
+      end
+    end
+    describe "#=" do
+      it "sets ordered members" do
+        member = Member.new
+        member_2 = Member.new
+        subject.ordered_members << member
+        expect(subject.ordered_members).to eq [member]
+        subject.ordered_members = [member_2, member_2]
+        expect(subject.ordered_members).to eq [member_2, member_2]
+        # Removing from ordering is not the same as removing from aggregation.
+        expect(subject.members).to eq [member, member_2]
+      end
+    end
+    describe "+=" do
+      it "appends ordered members" do
+        member = Member.new
+        member_2 = Member.new
+        subject.ordered_members << member
+        expect(subject.ordered_members += [member, member_2]).to eq [member, member, member_2]
+        expect(subject.ordered_members).to eq [member, member, member_2]
+        expect(subject.ordered_member_proxies.map(&:target)).to eq [member, member, member_2]
+      end
+    end
+    describe "#delete_at" do
+      it "deletes that position" do
+        member = Member.new
+        member_2 = Member.new
+        subject.ordered_members += [member, member_2]
+
+        expect(subject.ordered_members.delete_at(0)).to eq member
+        expect(subject.ordered_members).to eq [member_2]
+      end
+    end
+
+    describe "#delete" do
+      let(:member) { Member.create }
+      let(:member_2) { Member.create }
+      before do
+        subject.ordered_members += [member, member_2, member]
+        subject.save!
+      end
+
+      context "with an object found in the list" do
+        it "deletes all occurences of the object" do
+          expect(subject.ordered_members.delete(member)).to eq member
+          expect(subject.ordered_members.to_a).to eq [member_2]
+        end
+      end
+
+      context "with an object not found in the list" do
+        it "returns nil" do
+          expect(subject.ordered_members.delete(Member.create)).to be_nil
+          expect(subject.ordered_members.to_a).to eq [member, member_2, member]
+        end
+      end
+    end
+
+    describe "#insert_at" do
+      it "adds at a given position" do
+        member = Member.new
+        member_2 = Member.new
+        subject.ordered_members += [member, member_2]
+
+        subject.ordered_members.insert_at(0, member_2)
+        expect(subject.ordered_members).to eq [member_2, member, member_2]
+      end
+      it "adds a proxy_in statement" do
+        member = Member.new
+        member_2 = Member.new
+        subject.ordered_members += [member, member_2]
+
+        subject.ordered_members.insert_at(0, member_2)
+        expect(subject.ordered_member_proxies.map(&:proxy_in).uniq).to eq [subject]
+      end
+    end
+    describe "lazy loading" do
+      it "does not instantiate every record on append" do
+        member = Member.new
+        member_2 = Member.new
+        subject.ordered_members += [member, member_2]
+        subject.save
+        allow(ActiveFedora::Base).to receive(:find).and_call_original
+
+        reloaded = subject.class.find(subject.id)
+        reloaded.ordered_members << member
+
+        expect(ActiveFedora::Base).not_to have_received(:find).with(member_2.id)
+      end
+      it "does not instantiate every record on #insert_at" do
+        member = Member.new
+        member_2 = Member.new
+        subject.ordered_members += [member, member_2]
+        subject.save
+        allow(ActiveFedora::Base).to receive(:find).and_call_original
+
+        reloaded = subject.class.find(subject.id)
+        reloaded.ordered_members.insert_at(0, member)
+
+        expect(ActiveFedora::Base).not_to have_received(:find).with(member_2.id)
+      end
+    end
+  end
+  describe "append_target" do
+    it "doesn't add all members" do
+      member = Member.new
+      subject.members << member
+      expect(subject.ordered_members).to eq []
+    end
+    it "can handle adding many objects" do
+      member = Member.new
+      60.times do
+        subject.ordered_member_proxies.append_target member
+      end
+      expect(subject.ordered_member_proxies.to_a.length).to eq 60
+    end
+    it "can't add items not accepted by indirect container" do
+      bad_class = BadClass.new
+      expect { subject.ordered_member_proxies.append_target bad_class }.to raise_error ActiveFedora::AssociationTypeMismatch
+    end
+    it "adds a member if it doesn't exist in members" do
+      member = Member.new
+      subject.ordered_member_proxies.append_target member
+      expect(subject.members).to eq [member]
+      expect(subject.ordered_members).to eq [member]
+    end
+    it "doesn't add a member twice" do
+      member = Member.new
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.append_target member
+      expect(subject.members).to eq [member]
+      expect(subject.ordered_members).to eq [member, member]
+    end
+    it "survives persistence" do
+      member = Member.new
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.append_target member
+      subject.save
+      subject.reload
+      expect(subject.ordered_members).to eq [member, member]
+      expect(subject.list_source.resource.query([nil, ::RDF::Vocab::ORE.proxyIn, subject.resource.rdf_subject]).to_a.length).to eq 2
+      expect(subject.head_ids).to eq subject.list_source.head_id
+      expect(subject.tail_ids).to eq subject.list_source.tail_id
+    end
+    it "can add already persisted items" do
+      member = Member.create
+      subject.ordered_member_proxies.append_target member
+      subject.save
+      subject.reload
+      expect(subject.ordered_members).to eq [member]
+    end
+    it "can append to a pre-persisted item" do
+      member = Member.new
+      subject.ordered_member_proxies.append_target member
+      subject.save
+      subject.reload
+      member_2 = Member.new
+      subject.ordered_member_proxies.append_target member_2
+      subject.save
+      subject.reload
+      expect(subject.ordered_members).to eq [member, member_2]
+    end
+  end
+  describe "insert_target_at" do
+    it "can add between items" do
+      member = Member.new
+      member2 = Member.new
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.insert_target_at(1, member2)
+      expect(subject.ordered_members).to eq [member, member2, member]
+      subject.save
+      subject.reload
+      expect(subject.ordered_members).to eq [member, member2, member]
+      subject.ordered_member_proxies.insert_target_at(2, member2)
+      subject.save
+      subject.reload
+      expect(subject.ordered_members).to eq [member, member2, member2, member]
+    end
+  end
+  describe "insert_target_id_at" do
+    it "can add between items" do
+      member = Member.create
+      member2 = Member.create
+      subject.ordered_members += [member, member2]
+
+      allow(ActiveFedora::Base).to receive(:find).and_call_original
+      subject.ordered_member_proxies.insert_target_id_at(1, member2.id)
+      expect(ActiveFedora::Base).not_to have_received(:find).with(member2.id)
+      expect(subject.ordered_members).to eq [member, member2, member2]
+      expect(ActiveFedora::Base).to have_received(:find).with(member2.id)
+    end
+    context "when given a nil id" do
+      it "raises an ArgumentError" do
+        expect { subject.ordered_member_proxies.insert_target_id_at(0, nil) }.to raise_error ArgumentError, "ID can not be nil"
+      end
+    end
+    context "when given an ID not in members" do
+      it "raises an ArgumentError" do
+        expect { subject.ordered_member_proxies.insert_target_id_at(0, "test") }.to raise_error "test is not a part of members"
+      end
+    end
+  end
+  describe "-=" do
+    it "can remove proxies" do
+      member = Member.new
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies -= [subject.ordered_member_proxies.last]
+      expect(subject.ordered_members).to eq []
+      expect(subject.list_source.resource.statements.to_a.length).to eq 1
+    end
+    it "can remove proxies in the middle" do
+      member = Member.new
+      member_2 = Member.new
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.append_target member_2
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies -= [subject.ordered_member_proxies[1]]
+      expect(subject.ordered_members).to eq [member, member]
+    end
+    it "can remove proxies post-create" do
+      member = Member.new
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.append_target member
+      subject.save
+      subject.reload
+      subject.ordered_member_proxies -= [subject.ordered_member_proxies[1]]
+      expect(subject.ordered_members).to eq [member, member]
+      subject.save
+      subject.reload
+      expect(subject.ordered_members).to eq [member, member]
+      # THIS NEEDS TO PASS - can't delete fragment URI resources via sparql
+      # update?
+      # Blocked by https://jira.duraspace.org/browse/FCREPO-1764
+      # expect(subject.list_source.resource.subjects.to_a.length).to eq 5
+    end
+  end
+  describe ".delete_at" do
+    it "can remove in the middle" do
+      member = Member.new
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.delete_at(1)
+      expect(subject.ordered_members).to eq [member, member]
+    end
+    it "returns the node" do
+      member = Member.new
+      subject.ordered_members << member
+      subject.ordered_members << member
+      second_node = subject.ordered_member_proxies[1]
+      expect(subject.ordered_member_proxies.delete_at(1)).to eq second_node
+    end
+    context "when the node doesn't exist" do
+      it "returns nil" do
+        expect(subject.ordered_member_proxies.delete_at(0)).to eq nil
+      end
+    end
+    it "doesn't do anything if passed a bad value" do
+      member = Member.new
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.delete_at(3)
+      subject.ordered_member_proxies.delete_at(nil)
+      expect(subject.ordered_members).to eq [member, member, member]
+    end
+    it "can persist a deletion" do
+      member = Member.new
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.append_target member
+      subject.ordered_member_proxies.append_target member
+      expect(subject.ordered_members).to eq [member, member, member]
+      subject.ordered_member_proxies.delete_at(1)
+      subject.save
+      subject.reload
+      expect(subject.ordered_members).to eq [member, member]
+    end
+  end
+end

data/spec/unit/orders/list_node_spec.rb

@@ -0,0 +1,151 @@
+require 'spec_helper'
+
+RSpec.describe ActiveFedora::Orders::ListNode do
+  subject { described_class.new(node_cache, rdf_subject, graph) }
+  let(:node_cache) { {} }
+  let(:rdf_subject) { RDF::URI("#bla") }
+  let(:graph) { RDF::Graph.new }
+
+  describe "#target" do
+    context "when a target is set" do
+      it "returns it" do
+        member = instance_double("member")
+        subject.target = member
+        expect(subject.target).to eq member
+      end
+    end
+    context "when no target is set" do
+      context "and it's not in the graph" do
+        it "returns nil" do
+          expect(subject.target).to eq nil
+        end
+      end
+      context "and it's set in the graph" do
+        before do
+          class Member < ActiveFedora::Base
+          end
+        end
+        after do
+          Object.send(:remove_const, :Member)
+        end
+        it "returns it" do
+          member = Member.create
+          graph << [rdf_subject, RDF::Vocab::ORE.proxyFor, member.resource.rdf_subject]
+          expect(subject.target).to eq member
+        end
+        context "and it doesn't exist" do
+          it "returns an AT::Resource" do
+            member = Member.new("testing")
+            graph << [rdf_subject, RDF::Vocab::ORE.proxyFor, member.resource.rdf_subject]
+            expect(subject.target.rdf_subject).to eq member.uri
+          end
+        end
+      end
+    end
+  end
+
+  describe "#target_uri" do
+    context "with a null target_id" do
+      it "returns nil" do
+        expect(subject.target_uri).to eq nil
+      end
+    end
+    context "with a target" do
+      before do
+        class Member < ActiveFedora::Base
+        end
+      end
+      after do
+        Object.send(:remove_const, :Member)
+      end
+      it "returns a built URI" do
+        m = Member.new
+        allow(m).to receive(:id).and_return("test")
+        subject.target = m
+
+        expect(subject.target_uri).to eq ActiveFedora::Base.translate_id_to_uri.call("test")
+      end
+    end
+  end
+
+  describe "#target_id" do
+    context "when a target is set" do
+      it "returns its id" do
+        member = instance_double("member", id: "member1")
+        subject.target = member
+        expect(subject.target_id).to eq "member1"
+      end
+    end
+    context "when a target is from the graph" do
+      before do
+        class Member < ActiveFedora::Base
+        end
+      end
+      after do
+        Object.send(:remove_const, :Member)
+      end
+      context "and it's cached but missing" do
+        it "works" do
+          member = Member.create
+          graph << [rdf_subject, RDF::Vocab::ORE.proxyFor, member.resource.rdf_subject]
+          allow(ActiveFedora::Base).to receive(:from_uri).and_return(ActiveTriples::Resource.new(member.resource.rdf_subject))
+          subject.target
+
+          expect(subject.target_id).to eq member.id
+        end
+      end
+      it "doesn't re-ify the target" do
+        member = Member.create
+        graph << [rdf_subject, RDF::Vocab::ORE.proxyFor, member.resource.rdf_subject]
+        allow(ActiveFedora::Base).to receive(:from_uri).and_call_original
+
+        expect(subject.target_id).to eq member.id
+        expect(ActiveFedora::Base).not_to have_received(:from_uri)
+      end
+    end
+  end
+  describe "#proxy_in_id" do
+    context "when a target is set" do
+      it "returns its id" do
+        member = instance_double("member", id: "member1")
+        subject.proxy_in = member
+        expect(subject.proxy_in_id).to eq "member1"
+      end
+    end
+    context "when a proxy_in is from the graph" do
+      before do
+        class Member < ActiveFedora::Base
+        end
+      end
+      after do
+        Object.send(:remove_const, :Member)
+      end
+      context "and it's cached but missing" do
+        it "works" do
+          member = Member.create
+          graph << [rdf_subject, RDF::Vocab::ORE.proxyIn, member.resource.rdf_subject]
+          allow(ActiveFedora::Base).to receive(:from_uri).and_return(ActiveTriples::Resource.new(member.resource.rdf_subject))
+          subject.target
+
+          expect(subject.proxy_in_id).to eq member.id
+        end
+      end
+      it "doesn't re-ify the target" do
+        member = Member.create
+        graph << [rdf_subject, RDF::Vocab::ORE.proxyIn, member.resource.rdf_subject]
+        allow(ActiveFedora::Base).to receive(:from_uri).and_call_original
+
+        expect(subject.proxy_in_id).to eq member.id
+        expect(ActiveFedora::Base).not_to have_received(:from_uri)
+      end
+    end
+  end
+
+  describe "#to_graph" do
+    context "with no data" do
+      it "returns an empty graph" do
+        expect(subject.to_graph.statements.to_a.length).to eq 0
+      end
+    end
+  end
+end