active-fedora 11.1.0 → 11.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d30a0af700ab6f5855f2ac0dae9bd20aace608b3
-  data.tar.gz: f2e755860c2c67c4559c339c1468fa0a23b6038f
+  metadata.gz: 9323b783c7ef9187a43d0231994ad3ce39d8c2ca
+  data.tar.gz: 7acee3df7da38562ff9133fdfacbc0e29d055c7c
 SHA512:
-  metadata.gz: 61d91bdf7413839f75fa6be613786888dd74fd0a19253cc911886fbf6877d6b2d1903cb924c6312d0e92c5cc7d719f7394e5d5ab1c6d9d960a40b15c7d885125
-  data.tar.gz: f11e71036ebc0316ebc79bef415d98e0f0fa09036f3ce7438cf6839baf3cca87a168f1ec53e83366913e24d33d246d3d394647ac21a9c5480a1f92610a67a030
+  metadata.gz: eb08a929267e83e8258c572f9928a0da09fe847059e1423ac6236d6ae83ce7dee222f618ff73a225951d5d9644ee144917d925a184c64c1ce142d58989100474
+  data.tar.gz: 6e7f1404c76486f90c76b2d6993df02b11e6147cc4864c891f9f9c3982efe0b7a188926774f719262523b860c65be27a3ccaa7529b49d8862ce1487beb9e51e1

data/.rubocop.yml

@@ -36,6 +36,7 @@ Metrics/BlockNesting:
 Metrics/CyclomaticComplexity:
   Exclude:
     - 'lib/active_fedora.rb'
+    - 'lib/active_fedora/core.rb'
     - 'lib/active_fedora/reflection.rb'
     - 'lib/active_fedora/relation/finder_methods.rb'
     - 'lib/active_fedora/query_result_builder.rb'

data/History.txt

@@ -1,3 +1,9 @@
+v11.1.1
+2017-01-13: Don't modify passed in attributes [Justin Coyne]
+
+2017-01-13: When rails initializes, set the log if it previously was a
+NullLogger [Justin Coyne]
+
 v11.1.0
 2017-01-12: Casting an RDF::URI to a RDF::URI is unnecessary [Justin Coyne]
 

data/lib/active_fedora/core.rb

@@ -30,6 +30,7 @@ module ActiveFedora
     # the given namespace.
     def initialize(attributes = nil, &_block)
       init_internals
+      attributes = attributes.dup if attributes # can't dup nil in Ruby 2.3
       id = attributes && (attributes.delete(:id) || attributes.delete('id'))
       @ldp_source = build_ldp_resource(id)
       raise IllegalOperation, "Attempting to recreate existing ldp_source: `#{ldp_source.subject}'" unless ldp_source.new?

data/lib/active_fedora/railtie.rb

@@ -9,7 +9,7 @@ module ActiveFedora
 
     initializer "active_fedora.logger" do
       ActiveSupport.on_load(:active_fedora) do
-        self.logger ||= ::Rails.logger
+        self.logger = ::Rails.logger if logger.is_a? NullLogger
         Solrizer.logger ||= logger
       end
     end

data/lib/active_fedora/version.rb

@@ -1,3 +1,3 @@
 module ActiveFedora
-  VERSION = "11.1.0".freeze
+  VERSION = "11.1.1".freeze
 end

data/spec/unit/core_spec.rb

@@ -23,11 +23,23 @@ describe ActiveFedora::Base do
     expect(book.has_model).to eq ['Book']
   end
 
-  describe "initialize with a block" do
-    subject(:book) { Book.new { |b| b.title = "The Sun also Rises" } }
+  describe "initialize" do
+    context "with a block" do
+      subject(:book) { Book.new { |b| b.title = "The Sun also Rises" } }
 
-    it "has set the title" do
-      expect(book.title).to eq "The Sun also Rises"
+      it "has set the title" do
+        expect(book.title).to eq "The Sun also Rises"
+      end
+    end
+
+    context "with an identifier" do
+      subject(:book) { Book.new(attributes) }
+      let(:attributes) { { id: '1234' } }
+
+      it "sets the id and doesn't modify the passed hash" do
+        expect(book.id).to eq '1234'
+        expect(attributes[:id]).to eq '1234'
+      end
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: active-fedora
 version: !ruby/object:Gem::Version
-  version: 11.1.0
+  version: 11.1.1
 platform: ruby
 authors:
 - Matt Zumwalt
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-13 00:00:00.000000000 Z
+date: 2017-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rsolr