actionview 8.1.3.1 → 8.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8aa4ee01b0e607eb916b6fa44ce85dca111d21a89b35d8dcafe7238473dddcc5
-  data.tar.gz: 3c036732a3611891ba8ac32fb6bf68ccaf7c19c6aaf15f9bc90819744e2aa162
+  metadata.gz: bdc26346ea4cdff80ced71eaf5b63f7ab95815f92d4944ca5b554f5dc2092c98
+  data.tar.gz: 148985bc4e994851ecef0b9a3cb80fd3e7701b4da44739952797a137863e7148
 SHA512:
-  metadata.gz: 157d017bf8051b485efcad2d94c0968e2086db22fdf87ba50764ef45c69265c053fdb441d8f9566c0b089069aa9cb38bc71cb6a54bfdd8ed2d5bf46136957fe2
-  data.tar.gz: 7a2f125325d636972ded20d7e04d86a25738363db40f1c38c894aa76d8351b209ba8bbeec3ef25c35c93b37121bbd89b194bcc271ee80829d2563ccf5d3b15e0
+  metadata.gz: 15f9fac8e9a8deea4e2ee57df40cd968a36c483e4701a3983e0bb078a2bfcbc5b561d20b5c40fb9cc70977489730f2f77fa377d8332df146d74030feb07ff5ac
+  data.tar.gz: b40f142e9d6f4597f42f66d2fcb2395e882f2eabcab216ef53c013f0c245e2c6b9e9d8fb5efae7b89b9efd20a1cef6e0611b9574c79035959e14247c99ef0240

data/CHANGELOG.md

@@ -1,3 +1,49 @@
+## Rails 8.1.4 (September 24, 2026) ##
+
+*   Fix non-ASCII strict locals defaults rendering as mojibake.
+
+    When a template declared a non-ASCII default in its `locals:` magic comment
+    and its body was ASCII-only, the handler returned ASCII-8BIT code and the
+    compiled method definition was retagged with it, corrupting the default.
+
+    *Carlos Daniel Pohlod*
+
+*   Fix the `:ruby` render tracker not being registered for ERB templates when
+    `eager_load` is enabled.
+
+    *Gabriel Quaresma*
+
+*   Fix `Encoding::CompatibilityError` when digesting templates with non-ASCII
+    content via `DependencyTracker::RubyTracker`.
+
+    File-backed templates are loaded as ASCII-8BIT. `RubyTracker` now passes
+    `template.encode!` to the handler (matching `Template#compiled_source`) so
+    handlers such as Haml/Temple can concatenate static UTF-8 strings without
+    raising. Fixes #58203.
+
+    *Edil Talantbek uulu*
+
+*   Fix `week_field` to not emit invalid  week strings at ISO year boundaries.
+
+    *Kenta Ishizaki*
+
+*   Fix `ActionView::TestCase#render` to reset `rendered`.
+    The behavior was changed when memoization was added in #51093. Now it once again conforms to the documentation.
+
+    *Jeroen Versteeg*
+
+*   Fix `FormBuilder#to_partial_path` returning `nil` for subclasses whose
+    name does not end in `Builder`.
+
+    *Kenta Ishizaki*
+
+*   Fix `collection_radio_buttons` and `collection_check_boxes` generating
+    a label `for` attribute that does not match the input `id` when a
+    collection value is `nil`.
+
+    *Kenta Ishizaki*
+
+
 ## Rails 8.1.3.1 (July 29, 2026) ##
 
 *   No changes.

data/lib/action_view/dependency_tracker/ruby_tracker.rb

@@ -28,7 +28,7 @@ module ActionView
         def render_dependencies
           return [] unless template.source.include?("render")
 
-          compiled_source = template.handler.call(template, template.source)
+          compiled_source = template.handler.call(template, template.encode!)
 
           @parser_class.new(@name, compiled_source).render_calls.filter_map do |render_call|
             render_call.gsub(%r|/_|, "/")

data/lib/action_view/gem_version.rb

@@ -9,8 +9,8 @@ module ActionView
   module VERSION
     MAJOR = 8
     MINOR = 1
-    TINY  = 3
-    PRE   = "1"
+    TINY  = 4
+    PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/action_view/helpers/form_helper.rb

@@ -1706,7 +1706,7 @@ module ActionView
       end
 
       def self._to_partial_path
-        @_to_partial_path ||= name.demodulize.underscore.sub!(/_builder$/, "")
+        @_to_partial_path ||= name.demodulize.underscore.sub(/_builder$/, "")
       end
 
       def to_partial_path

data/lib/action_view/helpers/form_options_helper.rb

@@ -383,6 +383,11 @@ module ActionView
       #
       #   select_tag 'person', options_from_collection_for_select(@people, 'id', 'name')
       #
+      # The +value_method+ and +text_method+ can be a method name to call on each member of the +collection+,
+      # or a Proc that will be called for each member of the +collection+:
+      #
+      #   options_from_collection_for_select(@people, Proc.new { |person| person.id }, Proc.new { |person| person.name })
+      #
       # If +selected+ is specified as a value or array of values, the element(s) returning a match on +value_method+
       # will be selected option tag(s).
       #
@@ -415,14 +420,14 @@ module ActionView
       #
       # Parameters:
       # * +collection+ - An array of objects representing the <tt><optgroup></tt> tags.
-      # * +group_method+ - The name of a method which, when called on a member of +collection+, returns an
+      # * +group_method+ - The name of a method which, when called on a member of +collection+, or a Proc, which when called with a member of +collection+, returns an
       #   array of child objects representing the <tt><option></tt> tags.
-      # * +group_label_method+ - The name of a method which, when called on a member of +collection+, returns a
+      # * +group_label_method+ - The name of a method which, when called on a member of +collection+, or a Proc, which when called with a member of +collection+, returns a
       #   string to be used as the +label+ attribute for its <tt><optgroup></tt> tag.
       # * +option_key_method+ - The name of a method which, when called on a child object of a member of
-      #   +collection+, returns a value to be used as the +value+ attribute for its <tt><option></tt> tag.
+      #   +collection+, or a Proc, which when called with a child object of a member of +collection+, returns a value to be used as the +value+ attribute for its <tt><option></tt> tag.
       # * +option_value_method+ - The name of a method which, when called on a child object of a member of
-      #   +collection+, returns a value to be used as the contents of its <tt><option></tt> tag.
+      #   +collection+, or a Proc, which when called with a child object of a member of +collection+, returns a value to be used as the contents of its <tt><option></tt> tag.
       # * +selected_key+ - A value equal to the +value+ attribute for one of the <tt><option></tt> tags,
       #   which will have the +selected+ attribute set. Corresponds to the return value of one of the calls
       #   to +option_key_method+. If +nil+, no selection is made. Can also be a hash if disabled values are

data/lib/action_view/helpers/tags/collection_helpers.rb

@@ -68,8 +68,18 @@ module ActionView
             html_options
           end
 
+          # Sanitize the attribute name used for the label's `for` attribute
+          # in collection helpers. When the value is nil or results in an
+          # empty sanitized string, skip the trailing underscore to match the
+          # id generated by add_default_name_and_id_for_value.
           def sanitize_attribute_name(value)
-            "#{sanitized_method_name}_#{sanitized_value(value)}"
+            sanitized = sanitized_value(value)
+
+            if sanitized.empty?
+              sanitized_method_name.dup
+            else
+              "#{sanitized_method_name}_#{sanitized}"
+            end
           end
 
           def render_collection

data/lib/action_view/helpers/tags/week_field.rb

@@ -6,7 +6,7 @@ module ActionView
       class WeekField < DatetimeField # :nodoc:
         private
           def format_datetime(value)
-            value&.strftime("%Y-W%V")
+            value&.strftime("%G-W%V")
           end
       end
     end

data/lib/action_view/railtie.rb

@@ -78,10 +78,6 @@ module ActionView
     end
 
     config.after_initialize do |app|
-      config.after_initialize do
-        ActionView.render_tracker = config.action_view.render_tracker
-      end
-
       ActiveSupport.on_load(:action_view) do
         app.config.action_view.each do |k, v|
           next if k == :render_tracker
@@ -106,6 +102,10 @@ module ActionView
       end
     end
 
+    initializer "action_view.set_render_tracker" do |app|
+      ActionView.render_tracker = app.config.action_view.render_tracker
+    end
+
     initializer "action_view.setup_action_pack" do |app|
       ActiveSupport.on_load(:action_controller) do
         ActionView::RoutingUrlFor.include(ActionDispatch::Routing::UrlFor)

data/lib/action_view/template.rb

@@ -470,8 +470,9 @@ module ActionView
           end
         end_src
 
-        # Make sure the source is in the encoding of the returned code
-        source.force_encoding(code.encoding)
+        # Make sure the source is in the encoding of the returned code.
+        # ASCII-only code has no encoding worth propagating.
+        source.force_encoding(code.encoding) unless code.ascii_only?
 
         # In case we get back a String from a handler that is not in
         # BINARY or the default_internal, encode it to the default_internal

data/lib/action_view/test_case.rb

@@ -272,7 +272,7 @@ module ActionView
         @request = @controller.request
         @view_flow = ActionView::OutputFlow.new
         @output_buffer = ActionView::OutputBuffer.new
-        @rendered = self.class.content_class.new(+"")
+        _reset_rendered
 
         test_case_instance = self
         controller_class.define_method(:_test_case) { test_case_instance }
@@ -284,8 +284,18 @@ module ActionView
 
       def render(options = {}, local_assigns = {}, &block)
         view.assign(view_assigns)
-        @rendered << output = view.render(options, local_assigns, &block)
-        output
+
+        if @_rendering
+          view.render(options, local_assigns, &block)
+        else
+          _reset_rendered
+          @_rendering = true
+          output = view.render(options, local_assigns, &block)
+          @rendered << output
+          output
+        end
+      ensure
+        @_rendering = false unless @_rendering.nil?
       end
 
       def rendered_views
@@ -383,6 +393,7 @@ module ActionView
         :@method_name,
         :@output_buffer,
         :@_partials,
+        :@_rendering,
         :@passed,
         :@rendered,
         :@request,
@@ -412,6 +423,10 @@ module ActionView
         end]
       end
 
+      def _reset_rendered
+        @rendered = self.class.content_class.new(+"")
+      end
+
       def method_missing(selector, ...)
         begin
           routes = @controller.respond_to?(:_routes) && @controller._routes

data/lib/action_view.rb

@@ -37,6 +37,7 @@ module ActionView
   eager_autoload do
     autoload :Base
     autoload :Context
+    autoload :DependencyTracker
     autoload :Digestor
     autoload :Helpers
     autoload :LookupContext
@@ -91,7 +92,19 @@ module ActionView
   autoload :CacheExpiry
   autoload :TestCase
 
-  singleton_class.attr_accessor :render_tracker
+  singleton_class.attr_reader :render_tracker
+
+  def self.render_tracker=(value)
+    @render_tracker = value
+    case value
+    when :ruby
+      DependencyTracker.register_tracker :erb, DependencyTracker::RubyTracker
+    else
+      DependencyTracker.register_tracker :erb, DependencyTracker::ERBTracker
+    end
+    value
+  end
+
   self.render_tracker = :regex
 
   def self.eager_load!

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: actionview
 version: !ruby/object:Gem::Version
-  version: 8.1.3.1
+  version: 8.1.4
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.3.1
+        version: 8.1.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.3.1
+        version: 8.1.4
 - !ruby/object:Gem::Dependency
   name: builder
   requirement: !ruby/object:Gem::Requirement
@@ -85,28 +85,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.3.1
+        version: 8.1.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.3.1
+        version: 8.1.4
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.3.1
+        version: 8.1.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.3.1
+        version: 8.1.4
 description: Simple, battle-tested conventions and helpers for building web pages.
 email: david@loudthinking.com
 executables: []
@@ -247,10 +247,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v8.1.3.1/actionview/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v8.1.3.1/
+  changelog_uri: https://github.com/rails/rails/blob/v8.1.4/actionview/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v8.1.4/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v8.1.3.1/actionview
+  source_code_uri: https://github.com/rails/rails/tree/v8.1.4/actionview
   rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
@@ -267,7 +267,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements:
 - none
-rubygems_version: 4.0.16
+rubygems_version: 4.0.20
 specification_version: 4
 summary: Rendering framework putting the V in MVC (part of Rails).
 test_files: []