actionview 6.1.5 → 7.0.0.alpha1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fd064a197a833619a7f7946467645cf6814026fc955611621b69bdf46e84999d
-  data.tar.gz: decb0c47e2ddab1aabb45bd2a0e4001296c59d680cedc84f153e4340b4872040
+  metadata.gz: 488edff5bf41873248138efbc0c8ee4ecd1809793a99ebe520870d35e2a6e459
+  data.tar.gz: 429fd7c60ef3fb02df47871d05a7289cfda25e21586928dc1accebaa45678a7d
 SHA512:
-  metadata.gz: 4cce01bf7d01ed74cdeed1e68ecfa02c8bb714e6ae2737ff8b413a2d1dfd28d218dc0652561851ad8753214968ce29ecf0b7aadf7f6cd06e301e3ee975e4b454
-  data.tar.gz: a2103caa32e76b4cdb7f1efb56bf36388374bdaf9acde4874c8578482024a5945329d194d762bdfd6803b53713356284216a9d15795c56ad203ce5ed16410271
+  metadata.gz: 3db204604fb84ce3ab96976aad76fffb4938a2ec6ad7f965b2dc59a785622888867f92df3282ae560d6fb594fecc215a1c18340329ea912bed58c74d457e6824
+  data.tar.gz: 7eb29f984ea723f25728f8ae0c06127b7728501e18e690b0b73972d34a3bd467783760c293d50bc474f1fba9ddc824c02678af7653edcab8a5703766a572b96f

data/CHANGELOG.md

@@ -1,115 +1,109 @@
-## Rails 6.1.5 (March 09, 2022) ##
+## Rails 7.0.0.alpha1 (September 15, 2021) ##
 
-*   `preload_link_tag` properly inserts `as` attributes for files with `image` MIME
-    types, such as JPG or SVG.
+*   Improves the performance of ActionView::Helpers::NumberHelper formatters by avoiding the use of
+    exceptions as flow control.
 
-    *Nate Berkopec*
-
-*   Add `autocomplete="off"` to all generated hidden fields.
-
-    Fixes #42610.
-
-    *Ryan Baumann*
-
-*   Fix `current_page?` when URL has trailing slash.
-
-    This fixes the `current_page?` helper when the given URL has a trailing slash,
-    and is an absolute URL or also has query params.
-
-    Fixes #33956.
-
-    *Jonathan Hefner*
+    *Mike Dalessio*
 
+*   `preload_link_tag` properly inserts `as` attributes for files with `image` MIME types, such as JPG or SVG.
 
-## Rails 6.1.4.7 (March 08, 2022) ##
-
-*   No changes.
-
-
-## Rails 6.1.4.6 (February 11, 2022) ##
-
-*   No changes.
-
+    *Nate Berkopec*
 
-## Rails 6.1.4.5 (February 11, 2022) ##
+*   Add `weekday_options_for_select` and `weekday_select` helper methods. Also adds `weekday_select` to `FormBuilder`.
 
-*   No changes.
+    *Drew Bragg*, *Dana Kashubeck*, *Kasper Timm Hansen*
 
+*   Add `caching?` helper that returns whether the current code path is being cached and `uncacheable!` to denote helper methods that can't participate in fragment caching.
 
-## Rails 6.1.4.4 (December 15, 2021) ##
+    *Ben Toews*, *John Hawthorn*, *Kasper Timm Hansen*, *Joel Hawksley*
 
-*   No changes.
+*   Add `include_seconds` option for `time_field`.
 
+        <%= form.time_field :foo, include_seconds: false %>
+        # => <input value="16:22" type="time" />
 
-## Rails 6.1.4.3 (December 14, 2021) ##
+    Default includes seconds:
 
-*   No changes.
+        <%= form.time_field :foo %>
+        # => <input value="16:22:01.440" type="time" />
 
+    This allows you to take advantage of [different rendering options](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/time#time_value_format) in some browsers.
 
-## Rails 6.1.4.2 (December 14, 2021) ##
+    *Alex Ghiculescu*
 
-*   No changes.
+*   Improve error messages when template file does not exist at absolute filepath.
 
+    *Ted Whang*
 
-## Rails 6.1.4.1 (August 19, 2021) ##
+*   Add `:country_code` option to `sms_to` for consistency with `phone_to`.
 
-*   No changes.
+    *Jonathan Hefner*
 
+*   OpenSSL constants are now used for Digest computations.
 
-## Rails 6.1.4 (June 24, 2021) ##
+    *Dirkjan Bussink*
 
 *   The `translate` helper now passes `default` values that aren't
     translation keys through `I18n.translate` for interpolation.
 
     *Jonathan Hefner*
 
-*   Don't attach UJS form submission handlers to Turbo forms.
-
-    *David Heinemeier Hansson*
-
-*   Allow both `current_page?(url_hash)` and `current_page?(**url_hash)` on Ruby 2.7.
+*   Adds option `extname` to `stylesheet_link_tag` to skip default
+    `.css` extension appended to the stylesheet path.
 
-    *Ryuta Kamizono*
+    Before:
 
+    ```ruby
+    stylesheet_link_tag "style.less"
+    # <link href="/stylesheets/style.less.scss" rel="stylesheet">
+    ```
 
-## Rails 6.1.3.2 (May 05, 2021) ##
-
-*   No changes.
-
-
-## Rails 6.1.3.1 (March 26, 2021) ##
-
-*   No changes.
-
-
-## Rails 6.1.3 (February 17, 2021) ##
-
-*   No changes.
-
+    After:
 
-## Rails 6.1.2.1 (February 10, 2021) ##
+    ```ruby
+    stylesheet_link_tag "style.less", extname: false, skip_pipeline: true, rel: "stylesheet/less"
+    # <link href="/stylesheets/style.less" rel="stylesheet/less">
+    ```
 
-*   No changes.
+    *Abhay Nikam*
 
+*   Deprecate `render` locals to be assigned to instance variables.
 
-## Rails 6.1.2 (February 09, 2021) ##
+    *Petrik de Heus*
 
-*   No changes.
+*   Remove legacy default `media=screen` from `stylesheet_link_tag`.
 
+    *André Luis Leal Cardoso Junior*
 
-## Rails 6.1.1 (January 07, 2021) ##
+*   Change `ActionView::Helpers::FormBuilder#button` to transform `formmethod`
+    attributes into `_method="$VERB"` Form Data to enable varied same-form actions:
 
-*   Fix lazy translation in partial with block.
+        <%= form_with model: post, method: :put do %>
+          <%= form.button "Update" %>
+          <%= form.button "Delete", formmethod: :delete %>
+        <% end %>
+        <%# => <form action="posts/1">
+            =>   <input type="hidden" name="_method" value="put">
+            =>   <button type="submit">Update</button>
+            =>   <button type="submit" formmethod="post" name="_method" value="delete">Delete</button>
+            => </form>
+        %>
 
-    *Marek Kasztelnik*
+    *Sean Doyle*
 
-*   Avoid extra `SELECT COUNT` queries when rendering Active Record collections.
+*   Change `ActionView::Helpers::UrlHelper#button_to` to *always* render a
+    `<button>` element, regardless of whether or not the content is passed as
+    the first argument or as a block.
 
-    *aar0nr*
+        <%= button_to "Delete", post_path(@post), method: :delete %>
+        # => <form action="/posts/1"><input type="hidden" name="_method" value="delete"><button type="submit">Delete</button></form>
 
-*   Link preloading keep integrity hashes in the header.
+        <%= button_to post_path(@post), method: :delete do %>
+          Delete
+        <% end %>
+        # => <form action="/posts/1"><input type="hidden" name="_method" value="delete"><button type="submit">Delete</button></form>
 
-    *Étienne Barrié*
+    *Sean Doyle*, *Dusan Orlovic*
 
 *   Add `config.action_view.preload_links_header` to allow disabling of
     the `Link` header being added by default when using `stylesheet_link_tag`
@@ -122,282 +116,46 @@
 
     *Jonathan Hefner*
 
+*   Add `config.action_view.image_loading` to configure the default value of
+    the `image_tag` `:loading` option.
 
-## Rails 6.1.0 (December 09, 2020) ##
-
-*   SanitizeHelper.sanitized_allowed_attributes and SanitizeHelper.sanitized_allowed_tags
-    call safe_list_sanitizer's class method
-
-    Fixes #39586
+    By setting `config.action_view.image_loading = "lazy"`, an application can opt in to
+    lazy loading images sitewide, without changing view code.
 
-    *Taufiq Muhammadi*
-
-*   Change form_with to generate non-remote forms by default.
-
-    `form_with` would generate a remote form by default. This would confuse
-    users because they were forced to handle remote requests.
-
-    All new 6.1 applications will generate non-remote forms by default.
-    When upgrading a 6.0 application you can enable remote forms by default by
-    setting `config.action_view.form_with_generates_remote_forms` to `true`.
-
-    *Petrik de Heus*
-
-*   Yield translated strings to calls of `ActionView::FormBuilder#button`
-    when a block is given.
-
-    *Sean Doyle*
-
-*   Alias `ActionView::Helpers::Tags::Label::LabelBuilder#translation` to
-    `#to_s` so that `form.label` calls can yield that value to their blocks.
-
-    *Sean Doyle*
-
-*   Rename the new `TagHelper#class_names` method to `TagHelper#token_list`,
-    and make the original available as an alias.
+    *Jonathan Hefner*
 
-        token_list("foo", "foo bar")
-        # => "foo bar"
+*   `ActionView::Helpers::FormBuilder#id` returns the value
+    of the `<form>` element's `id` attribute. With a `method` argument, returns
+    the `id` attribute for a form field with that name.
 
-    *Sean Doyle*
+        <%= form_for @post do |f| %>
+          <%# ... %>
 
-*   ARIA Array and Hash attributes are treated as space separated `DOMTokenList`
-    values. This is useful when declaring lists of label text identifiers in
-    `aria-labelledby` or `aria-describedby`.
-
-        tag.input type: 'checkbox', name: 'published', aria: {
-          invalid: @post.errors[:published].any?,
-          labelledby: ['published_context', 'published_label'],
-          describedby: { published_errors: @post.errors[:published].any? }
-        }
-        #=> <input
-              type="checkbox" name="published" aria-invalid="true"
-              aria-labelledby="published_context published_label"
-              aria-describedby="published_errors"
-            >
+          <% content_for :sticky_footer do %>
+            <%= form.button(form: f.id) %>
+          <% end %>
+        <% end %>
 
     *Sean Doyle*
 
-*   Remove deprecated `escape_whitelist` from `ActionView::Template::Handlers::ERB`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `find_all_anywhere` from `ActionView::Resolver`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `formats` from `ActionView::Template::HTML`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `formats` from `ActionView::Template::RawFile`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `formats` from `ActionView::Template::Text`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `find_file` from `ActionView::PathSet`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `rendered_format` from `ActionView::LookupContext`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `find_file` from `ActionView::ViewPaths`.
-
-    *Rafael Mendonça França*
-
-*   Require that `ActionView::Base` subclasses implement `#compiled_method_container`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated support to pass an object that is not a `ActionView::LookupContext` as the first argument
-    in `ActionView::Base#initialize`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `format` argument `ActionView::Base#initialize`.
+*   `ActionView::Helpers::FormBuilder#field_id` returns the value generated by
+    the FormBuilder for the given attribute name.
 
-    *Rafael Mendonça França*
-
-*   Remove deprecated `ActionView::Template#refresh`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `ActionView::Template#original_encoding`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `ActionView::Template#variants`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `ActionView::Template#formats`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `ActionView::Template#virtual_path=`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `ActionView::Template#updated_at`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `updated_at` argument required on `ActionView::Template#initialize`.
-
-    *Rafael Mendonça França*
-
-*   Make `locals` argument required on `ActionView::Template#initialize`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `ActionView::Template.finalize_compiled_template_methods`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `config.action_view.finalize_compiled_template_methods`
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated support to calling `ActionView::ViewPaths#with_fallback` with a block.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated support to passing absolute paths to `render template:`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated support to passing relative paths to `render file:`.
-
-    *Rafael Mendonça França*
-
-*   Remove support to template handlers that don't accept two arguments.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated pattern argument in `ActionView::Template::PathResolver`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated support to call private methods from object in some view helpers.
-
-    *Rafael Mendonça França*
-
-*   `ActionView::Helpers::TranslationHelper#translate` accepts a block, yielding
-    the translated text and the fully resolved translation key:
-
-        <%= translate(".relative_key") do |translation, resolved_key| %>
-          <span title="<%= resolved_key %>"><%= translation %></span>
+        <%= form_for @post do |f| %>
+          <%= f.label :title %>
+          <%= f.text_field :title, aria: { describedby: f.field_id(:title, :error) } %>
+          <%= tag.span("is blank", id: f.field_id(:title, :error) %>
         <% end %>
 
     *Sean Doyle*
 
-*   Ensure cache fragment digests include all relevant template dependencies when
-    fragments are contained in a block passed to the render helper. Remove the
-    virtual_path keyword arguments found in CacheHelper as they no longer possess
-    any function following 1581cab.
-
-    Fixes #38984.
+*   Add `tag.attributes` to transform a Hash into HTML Attributes, ready to be
+    interpolated into ERB.
 
-    *Aaron Lipman*
+        <input <%= tag.attributes(type: :text, aria: { label: "Search" }) %> >
+        # => <input type="text" aria-label="Search">
 
-*   Deprecate `config.action_view.raise_on_missing_translations` in favor of
-    `config.i18n.raise_on_missing_translations`.
-
-    New generalized configuration option now determines whether an error should be raised
-    for missing translations in controllers and views.
-
-    *fatkodima*
-
-*   Instrument layout rendering in `TemplateRenderer#render_with_layout` as `render_layout.action_view`,
-    and include (when necessary) the layout's virtual path in notification payloads for collection and partial renders.
-
-    *Zach Kemp*
-
-*   `ActionView::Base.annotate_rendered_view_with_filenames` annotates HTML output with template file names.
-
-    *Joel Hawksley*, *Aaron Patterson*
-
-*   `ActionView::Helpers::TranslationHelper#translate` returns nil when
-    passed `default: nil` without a translation matching `I18n#translate`.
-
-    *Stefan Wrobel*
-
-*   `OptimizedFileSystemResolver` prefers template details in order of locale,
-    formats, variants, handlers.
-
-    *Iago Pimenta*
-
-*   Added `class_names` helper to create a CSS class value with conditional classes.
-
-    *Joel Hawksley*, *Aaron Patterson*
-
-*   Add support for conditional values to TagBuilder.
-
-    *Joel Hawksley*
-
-*   `ActionView::Helpers::FormOptionsHelper#select` should mark option for `nil` as selected.
-
-    ```ruby
-    @post = Post.new
-    @post.category = nil
-
-    # Before
-    select("post", "category", none: nil, programming: 1, economics: 2)
-    # =>
-    # <select name="post[category]" id="post_category">
-    #   <option value="">none</option>
-    #  <option value="1">programming</option>
-    #  <option value="2">economics</option>
-    # </select>
-
-    # After
-    select("post", "category", none: nil, programming: 1, economics: 2)
-    # =>
-    # <select name="post[category]" id="post_category">
-    #   <option selected="selected" value="">none</option>
-    #  <option value="1">programming</option>
-    #  <option value="2">economics</option>
-    # </select>
-    ```
-
-    *bogdanvlviv*
-
-*   Log lines for partial renders and started template renders are now
-    emitted at the `DEBUG` level instead of `INFO`.
-
-    Completed template renders are still logged at the `INFO` level.
-
-    *DHH*
-
-*   ActionView::Helpers::SanitizeHelper: support rails-html-sanitizer 1.1.0.
-
-    *Juanito Fatas*
-
-*   Added `phone_to` helper method to create a link from mobile numbers.
-
-    *Pietro Moro*
-
-*   annotated_source_code returns an empty array so TemplateErrors without a
-    template in the backtrace are surfaced properly by DebugExceptions.
-
-    *Guilherme Mansur*, *Kasper Timm Hansen*
-
-*   Add autoload for SyntaxErrorInTemplate so syntax errors are correctly raised by DebugExceptions.
-
-    *Guilherme Mansur*, *Gannon McGibbon*
-
-*   `RenderingHelper` supports rendering objects that `respond_to?` `:render_in`.
-
-    *Joel Hawksley*, *Natasha Umer*, *Aaron Patterson*, *Shawn Allen*, *Emily Plummer*, *Diana Mounter*, *John Hawthorn*, *Nathan Herald*, *Zaid Zawaideh*, *Zach Ahn*
-
-*   Fix `select_tag` so that it doesn't change `options` when `include_blank` is present.
-
-    *Younes SERRAJ*
+    *Sean Doyle*
 
 
-Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/actionview/CHANGELOG.md) for previous changes.
+Please check [6-1-stable](https://github.com/rails/rails/blob/6-1-stable/actionview/CHANGELOG.md) for previous changes.

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2004-2022 David Heinemeier Hansson
+Copyright (c) 2004-2021 David Heinemeier Hansson
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the
@@ -18,3 +18,4 @@ NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
 LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+

data/lib/action_view/base.rb

@@ -9,7 +9,7 @@ require "action_view/context"
 require "action_view/template"
 require "action_view/lookup_context"
 
-module ActionView #:nodoc:
+module ActionView # :nodoc:
   # = Action View Base
   #
   # Action View templates can be written in several ways.
@@ -179,7 +179,7 @@ module ActionView #:nodoc:
         ActionView::Resolver.caching = value
       end
 
-      def xss_safe? #:nodoc:
+      def xss_safe? # :nodoc:
         true
       end
 
@@ -227,7 +227,7 @@ module ActionView #:nodoc:
 
     # :startdoc:
 
-    def initialize(lookup_context, assigns, controller) #:nodoc:
+    def initialize(lookup_context, assigns, controller) # :nodoc:
       @_config = ActiveSupport::InheritableOptions.new
 
       @lookup_context = lookup_context

data/lib/action_view/buffers.rb

@@ -18,7 +18,7 @@ module ActionView
   #   sbuf << 5
   #   puts sbuf # => "hello\u0005"
   #
-  class OutputBuffer < ActiveSupport::SafeBuffer #:nodoc:
+  class OutputBuffer < ActiveSupport::SafeBuffer # :nodoc:
     def initialize(*)
       super
       encode!
@@ -38,7 +38,7 @@ module ActionView
     alias :safe_append= :safe_concat
   end
 
-  class StreamingBuffer #:nodoc:
+  class StreamingBuffer # :nodoc:
     def initialize(block)
       @block = block
     end

data/lib/action_view/cache_expiry.rb

@@ -4,49 +4,63 @@ module ActionView
   class CacheExpiry
     class Executor
       def initialize(watcher:)
-        @cache_expiry = CacheExpiry.new(watcher: watcher)
+        @execution_lock = Concurrent::ReadWriteLock.new
+        @cache_expiry = ViewModificationWatcher.new(watcher: watcher) do
+          clear_cache
+        end
       end
 
-      def before(target)
-        @cache_expiry.clear_cache_if_necessary
+      def run
+        ActiveSupport::Dependencies.interlock.permit_concurrent_loads do
+          @cache_expiry.execute_if_updated
+          @execution_lock.acquire_read_lock
+        end
       end
-    end
-
-    def initialize(watcher:)
-      @watched_dirs = nil
-      @watcher_class = watcher
-      @watcher = nil
-      @mutex = Mutex.new
-    end
 
-    def clear_cache_if_necessary
-      @mutex.synchronize do
-        watched_dirs = dirs_to_watch
-        return if watched_dirs.empty?
+      def complete(_)
+        @execution_lock.release_read_lock
+      end
 
-        if watched_dirs != @watched_dirs
-          @watched_dirs = watched_dirs
-          @watcher = @watcher_class.new([], watched_dirs) do
-            clear_cache
+      private
+        def clear_cache
+          @execution_lock.with_write_lock do
+            ActionView::LookupContext::DetailsKey.clear
           end
-          @watcher.execute
-        else
-          @watcher.execute_if_updated
         end
-      end
-    end
-
-    def clear_cache
-      ActionView::LookupContext::DetailsKey.clear
     end
 
-    private
-      def dirs_to_watch
-        all_view_paths.grep(FileSystemResolver).map!(&:path).tap(&:uniq!).sort!
+    class ViewModificationWatcher
+      def initialize(watcher:, &block)
+        @watched_dirs = nil
+        @watcher_class = watcher
+        @watcher = nil
+        @mutex = Mutex.new
+        @block = block
       end
 
-      def all_view_paths
-        ActionView::ViewPaths.all_view_paths.flat_map(&:paths)
+      def execute_if_updated
+        @mutex.synchronize do
+          watched_dirs = dirs_to_watch
+          return if watched_dirs.empty?
+
+          if watched_dirs != @watched_dirs
+            @watched_dirs = watched_dirs
+            @watcher = @watcher_class.new([], watched_dirs, &@block)
+            @watcher.execute
+          else
+            @watcher.execute_if_updated
+          end
+        end
       end
+
+      private
+        def dirs_to_watch
+          all_view_paths.grep(FileSystemResolver).map!(&:path).tap(&:uniq!).sort!
+        end
+
+        def all_view_paths
+          ActionView::ViewPaths.all_view_paths.flat_map(&:paths)
+        end
+    end
   end
 end